[kudu-CR] WIP [non voter-itest] stress test for the 3-4-3 replacement scheme

2018-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9255 Change subject: WIP [non_voter-itest] stress test for the 3-4-3 replacement scheme .. WIP [non_voter-itest] stress test for the 3-4-3

[kudu-CR] KUDU-1704: add READ YOUR WRITES scan mode

2018-02-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 ) Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode .. Patch Set 11: (13 comments)

[kudu-CR] KUDU-1704: add READ YOUR WRITES scan mode

2018-02-07 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Mike Percy, Dan Burkert, David Ribeiro Alves, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8804 to look at the new patch set (#11). Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode

[kudu-CR] KUDU-2291 (part 1): allow collecting a thread's stack without immediate symbolization

2018-02-07 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9252 to review the following change. Change subject: KUDU-2291 (part 1): allow collecting a thread's stack without immediate symbolization

[kudu-CR] WIP: KUDU-2291 (part 2): Add a /stacks page

2018-02-07 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9253 to review the following change. Change subject: WIP: KUDU-2291 (part 2): Add a /stacks page .. WIP:

[kudu-CR] KUDU-2291 (part 3): use futex to speed up stack collection

2018-02-07 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9254 to review the following change. Change subject: KUDU-2291 (part 3): use futex to speed up stack collection

[kudu-CR] Add back KuduColumnSchema DataTypeToString

2018-02-07 Thread Grant Henke (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9240 to look at the new patch set (#3). Change subject: Add back KuduColumnSchema DataTypeToString

[kudu-CR] Add back KuduColumnSchema DataTypeToString

2018-02-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9240 ) Change subject: Add back KuduColumnSchema DataTypeToString .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2274. consensus: Remove ConsensusMetadata thread safety

2018-02-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9246 ) Change subject: KUDU-2274. consensus: Remove ConsensusMetadata thread safety .. Patch Set 1: (3 comments)

[kudu-CR] KUDU-721: [Spark] Add DECIMAL type support

2018-02-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9213 ) Change subject: KUDU-721: [Spark] Add DECIMAL type support .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2274. consensus: Remove ConsensusMetadata thread safety

2018-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9246 ) Change subject: KUDU-2274. consensus: Remove ConsensusMetadata thread safety .. Patch Set 1: (1 comment)

[kudu-CR] Fix unlocked access to cmeta in RaftConsensus::Start()

2018-02-07 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9245 ) Change subject: Fix unlocked access to cmeta in RaftConsensus::Start() .. Fix unlocked access to cmeta in RaftConsensus::Start()

[kudu-CR] Add back KuduColumnSchema DataTypeToString

2018-02-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9240 ) Change subject: Add back KuduColumnSchema DataTypeToString .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-721: [Spark] Add DECIMAL type support

2018-02-07 Thread Grant Henke (Code Review)
Hello Dan Burkert, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9213 to look at the new patch set (#3). Change subject: KUDU-721: [Spark] Add DECIMAL type support

[kudu-CR] Add previous / current thread to collision warner

2018-02-07 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9237 ) Change subject: Add previous / current thread to collision warner .. Add previous / current thread to collision warner The

[kudu-CR] WIP: Create a rolling-failure endurance test

2018-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9222 ) Change subject: WIP: Create a rolling-failure endurance test .. Patch Set 3: (3 comments) Looks good and this script worked for me,

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

2018-02-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8692 ) Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client .. Patch Set 10: (3 comments)

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

2018-02-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8692 ) Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-2274. WIP: Shut down tombstoned replica when replacing it

2018-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9156 ) Change subject: KUDU-2274. WIP: Shut down tombstoned replica when replacing it .. Patch Set 2: Code-Review+1 I think this looks good

[kudu-CR] KUDU-2274. consensus: Remove ConsensusMetadata thread safety

2018-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9246 ) Change subject: KUDU-2274. consensus: Remove ConsensusMetadata thread safety .. Patch Set 1: (3 comments)

[kudu-CR] KUDU-721: [Spark] Add DECIMAL type support

2018-02-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9213 ) Change subject: KUDU-721: [Spark] Add DECIMAL type support .. Patch Set 2: (1 comment)

[kudu-CR] Fix unlocked access to cmeta in RaftConsensus::Start()

2018-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9245 ) Change subject: Fix unlocked access to cmeta in RaftConsensus::Start() .. Patch Set 1: Code-Review+2 Nice find! -- To view, visit

[kudu-CR] KUDU-721: [Java] Add DECIMAL column type support

2018-02-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8882 ) Change subject: KUDU-721: [Java] Add DECIMAL column type support .. Patch Set 11: (17 comments) Similar concerns from the C++ side, I'm

[kudu-CR] docs: update docs for update dirs tool

2018-02-07 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9110 ) Change subject: docs: update docs for update_dirs tool .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2274. WIP: Shut down tombstoned replica when replacing it

2018-02-07 Thread Mike Percy (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9156 to look at the new patch set (#2). Change subject: KUDU-2274. WIP: Shut down tombstoned replica when replacing it

[kudu-CR] Fix unlocked access to cmeta in RaftConsensus::Start()

2018-02-07 Thread Mike Percy (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9245 to review the following change. Change subject: Fix unlocked access to cmeta in RaftConsensus::Start() .. Fix

[kudu-CR] KUDU-2274. consensus: Remove ConsensusMetadata thread safety

2018-02-07 Thread Mike Percy (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9246 to review the following change. Change subject: KUDU-2274. consensus: Remove ConsensusMetadata thread safety ..

[kudu-CR] Add previous / current thread to collision warner

2018-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9237 ) Change subject: Add previous / current thread to collision warner .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] Add previous / current thread to collision warner

2018-02-07 Thread Mike Percy (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9237 to look at the new patch set (#2). Change subject: Add previous / current thread to collision warner

[kudu-CR] [build] fix on ld's -l:path to file notation on OS X

2018-02-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9242 ) Change subject: [build] fix on ld's -l:path_to_file notation on OS X .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Add previous / current thread to collision warner

2018-02-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9237 ) Change subject: Add previous / current thread to collision warner .. Patch Set 1: (1 comment)

[kudu-CR] [build] fix on ld's -l:path to file notation on OS X

2018-02-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9242 ) Change subject: [build] fix on ld's -l:path_to_file notation on OS X .. [build] fix on ld's -l:path_to_file notation on OS X

[kudu-CR] docs: improvements to transaction semantics

2018-02-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9235 ) Change subject: docs: improvements to transaction semantics .. Patch Set 1: > Which version of Kudu does this apply? The latest release

[kudu-CR] [build] fix on ld's -l:path to file notation on OS X

2018-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9242 Change subject: [build] fix on ld's -l:path_to_file notation on OS X .. [build] fix on ld's -l:path_to_file notation on OS X Fixed the

[kudu-CR] Add back KuduColumnSchema DataTypeToString

2018-02-07 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9240 to look at the new patch set (#2). Change subject: Add back KuduColumnSchema DataTypeToString .. Add back

[kudu-CR] Add back KuduColumnSchema DataTypeToString

2018-02-07 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9240 Change subject: Add back KuduColumnSchema DataTypeToString .. Add back KuduColumnSchema DataTypeToString KuduColumnSchema’s

[kudu-CR] [docs] MacPorts specific build instructions

2018-02-07 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9236 ) Change subject: [docs] MacPorts specific build instructions .. Patch Set 1: Code-Review+1 (1 comment) I didn't test it but it looks

[kudu-CR] docs: improvements to NTP troubleshooting

2018-02-07 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9234 ) Change subject: docs: improvements to NTP troubleshooting .. Patch Set 1: (3 comments)