[kudu-CR] [www] support column sorting on /tables page

2019-09-09 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14187 ) Change subject: [www] support column sorting on /tables page .. Patch Set 3: (1 comment)

[kudu-CR] [kudu-client] KUDU-2910 Add Singleton Class KuduClientCache to kudu client module and can used across different integration like spark, Hive etc..

2019-09-09 Thread Sandish Kumar HN (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14202 to look at the new patch set (#3). Change subject: [kudu-client] KUDU-2910 Add Singleton Class KuduClientCache to kudu client module and can used across different

[kudu-CR] [kudu-client] KUDU-2910 Add Singleton Class KuduClientCache to kudu client module and can used across different integration like spark, Hive etc..

2019-09-09 Thread Sandish Kumar HN (Code Review)
Sandish Kumar HN has posted comments on this change. ( http://gerrit.cloudera.org:8080/14202 ) Change subject: [kudu-client] KUDU-2910 Add Singleton Class KuduClientCache to kudu client module and can used across different integration like spark, Hive etc..

[kudu-CR] [kudu-client] KUDU-2910 Add Singleton Class KuduClientCache to kudu client module and can used across different integration like spark, Hive etc..

2019-09-09 Thread Sandish Kumar HN (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14202 to look at the new patch set (#2). Change subject: [kudu-client] KUDU-2910 Add Singleton Class KuduClientCache to kudu client module and can used across different

[kudu-CR] [examples] Example shell scripts to start and stop Kudu cluster

2019-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14192 ) Change subject: [examples] Example shell scripts to start and stop Kudu cluster .. Patch Set 6: (4 comments)

[kudu-CR] [docs] Kudu source code indexing in Eclipse

2019-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14193 ) Change subject: [docs] Kudu source code indexing in Eclipse .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-2921: Exposing the table statistics to spark relation.

2019-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14107 ) Change subject: KUDU-2921: Exposing the table statistics to spark relation. .. Patch Set 10: Verified+1 Yeah I don't think those

[kudu-CR] KUDU-2921: Exposing the table statistics to spark relation.

2019-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: KUDU-2921: Exposing the table statistics to spark relation. .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14107 To

[kudu-CR] KUDU-2921: Exposing the table statistics to spark relation.

2019-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14107 ) Change subject: KUDU-2921: Exposing the table statistics to spark relation. .. KUDU-2921: Exposing the table statistics to spark

[kudu-CR] [www] support column sorting on /tables page

2019-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14187 ) Change subject: [www] support column sorting on /tables page .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2921: Exposing the table statistics to spark relation.

2019-09-09 Thread ZhangYao (Code Review)
ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14107 ) Change subject: KUDU-2921: Exposing the table statistics to spark relation. .. Patch Set 10: I ran those failure test offline multi times,

[kudu-CR] [utils] Fix a data race when creating EasyCurl objects in multithreads

2019-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14189 ) Change subject: [utils] Fix a data race when creating EasyCurl objects in multithreads .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] [metrics] Add a metric to count merged entities when merge metrics

2019-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14128 ) Change subject: [metrics] Add a metric to count merged entities when merge metrics .. Patch Set 10: > Last time I manually overrode -1

[kudu-CR] KUDU-2921: Exposing the table statistics to spark relation.

2019-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14107 ) Change subject: KUDU-2921: Exposing the table statistics to spark relation. .. Patch Set 10: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2921: Exposing the table statistics to spark relation.

2019-09-09 Thread ZhangYao (Code Review)
ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14107 ) Change subject: KUDU-2921: Exposing the table statistics to spark relation. .. Patch Set 10: (2 comments)

[kudu-CR] KUDU-2921: Exposing the table statistics to spark relation.

2019-09-09 Thread ZhangYao (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14107 to look at the new patch set (#10). Change subject: KUDU-2921: Exposing the table statistics to spark relation.

[kudu-CR] [metrics] Add a metric to count merged entities when merge metrics

2019-09-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14128 ) Change subject: [metrics] Add a metric to count merged entities when merge metrics .. Patch Set 10: > Looks good but IWYU is still

[kudu-CR] [metrics] Add a metric to count merged entities when merge metrics

2019-09-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [metrics] Add a metric to count merged entities when merge metrics .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] [metrics] Add a metric to count merged entities when merge metrics

2019-09-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14128 ) Change subject: [metrics] Add a metric to count merged entities when merge metrics .. Patch Set 10: Verified+1 Overriding strange

[kudu-CR] [docs] Kudu source code indexing in Eclipse

2019-09-09 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/14193 ) Change subject: [docs] Kudu source code indexing in Eclipse .. Patch Set 4: Code-Review+1 -- To view, visit

[kudu-CR] [metrics] Add a metric to count merged entities when merge metrics

2019-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14128 ) Change subject: [metrics] Add a metric to count merged entities when merge metrics .. Patch Set 10: Looks good but IWYU is still

[kudu-CR] [kudu-client] KUDU-2910 Add KuduClientCache to kudu client module and can used across different integration like spark, Hive etc..

2019-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14202 ) Change subject: [kudu-client] KUDU-2910 Add KuduClientCache to kudu client module and can used across different integration like spark, Hive etc..

[kudu-CR] [kudu-client] KUDU-2910 Add KuduClientCache to kudu client module and can used across different integration like spark, Hive etc..

2019-09-09 Thread Sandish Kumar HN (Code Review)
Sandish Kumar HN has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14202 Change subject: [kudu-client] KUDU-2910 Add KuduClientCache to kudu client module and can used across different integration like spark, Hive etc..

[kudu-CR] [hms] Sync external HMS tables with purge property

2019-09-09 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14179 ) Change subject: [hms] Sync external HMS tables with purge property .. Patch Set 4: (1 comment)

[kudu-CR] [docs] fix typo in location-awareness design doc

2019-09-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14196 ) Change subject: [docs] fix typo in location-awareness design doc .. [docs] fix typo in location-awareness design doc Fixed

[kudu-CR] KUDU-2921: Exposing the table statistics to spark relation.

2019-09-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14107 ) Change subject: KUDU-2921: Exposing the table statistics to spark relation. .. Patch Set 9: Code-Review+1 (2 comments)

[kudu-CR] [www] support column sorting on /tables page

2019-09-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14187 ) Change subject: [www] support column sorting on /tables page .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] [hms] Sync external HMS tables with purge property

2019-09-09 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [hms] Sync external HMS tables with purge property .. Removed -Verified by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14179 To

[kudu-CR] [hms] Sync external HMS tables with purge property

2019-09-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14179 ) Change subject: [hms] Sync external HMS tables with purge property .. Patch Set 4: Verified+1 -- To view, visit

[kudu-CR] [hms] Sync external HMS tables with purge property

2019-09-09 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [hms] Sync external HMS tables with purge property .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14179 To

[kudu-CR] [docs] fix typo in location-awareness design doc

2019-09-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14196 ) Change subject: [docs] fix typo in location-awareness design doc .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [hms] Sync external HMS tables with purge property

2019-09-09 Thread Grant Henke (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Greg Solovyev, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14179 to look at the new patch set (#4). Change subject: [hms] Sync external HMS tables with purge property

[kudu-CR] [docs] Kudu source code indexing in Eclipse

2019-09-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14193 ) Change subject: [docs] Kudu source code indexing in Eclipse .. Patch Set 4: Code-Review+1 Looks good to me. It would be great if

[kudu-CR] [docs] fix typo in location-awareness design doc

2019-09-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14196 Change subject: [docs] fix typo in location-awareness design doc .. [docs] fix typo in location-awareness design doc Fixed scan mode

[kudu-CR] [utils] Fix a data race when creating EasyCurl objects in multithreads

2019-09-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14189 ) Change subject: [utils] Fix a data race when creating EasyCurl objects in multithreads .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] [utils] Fix a data race when creating EasyCurl objects in multithreads

2019-09-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14189 ) Change subject: [utils] Fix a data race when creating EasyCurl objects in multithreads .. Patch Set 3: (4 comments)

[kudu-CR] [utils] Fix a data race when creating EasyCurl objects in multithreads

2019-09-09 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14189 to look at the new patch set (#3). Change subject: [utils] Fix a data race when creating EasyCurl objects in multithreads

[kudu-CR] KUDU-2921: Exposing the table statistics to spark relation.

2019-09-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14107 ) Change subject: KUDU-2921: Exposing the table statistics to spark relation. .. Patch Set 9: Code-Review+1 LGTM. I will leave open to

[kudu-CR] [hms] Sync external HMS tables with purge property

2019-09-09 Thread Grant Henke (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Greg Solovyev, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14179 to look at the new patch set (#3). Change subject: [hms] Sync external HMS tables with purge property

[kudu-CR] [hms] Sync external HMS tables with purge property

2019-09-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14179 ) Change subject: [hms] Sync external HMS tables with purge property .. Patch Set 2: (27 comments)