[kudu-CR] KUDU-613: Introduce SLRU cache

2024-05-30 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. Patch Set 19: (12 comments)

[kudu-CR] KUDU-613: Add SLRU Cache metrics

2024-05-30 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Add SLRU Cache metrics .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-613: Integrate SLRU cache into block cache

2024-05-30 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21390 ) Change subject: KUDU-613: Integrate SLRU cache into block cache .. Patch Set 3: (12 comments)

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-05-30 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20607 to look at the new patch set (#19). Change subject: KUDU-613: Introduce SLRU cache

[kudu-CR] KUDU-613: Add SLRU Cache metrics

2024-05-30 Thread Mahesh Reddy (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21389 to look at the new patch set (#5). Change subject: KUDU-613: Add SLRU Cache metrics

[kudu-CR] KUDU-613: Integrate SLRU cache into block cache

2024-05-30 Thread Mahesh Reddy (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21390 to look at the new patch set (#3). Change subject: KUDU-613: Integrate SLRU cache into block cache

[kudu-CR] KUDU-2671: Update upstream docs

2024-05-28 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21108 ) Change subject: KUDU-2671: Update upstream docs .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2671: Update upstream docs

2024-05-28 Thread Mahesh Reddy (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21108 to look at the new patch set (#2). Change subject: KUDU-2671: Update upstream docs .. KUDU-2671:

[kudu-CR] KUDU-613: Introduce new BlockCache metrics

2024-05-16 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Introduce new BlockCache metrics .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-613: Introduce new BlockCache metrics

2024-05-16 Thread Mahesh Reddy (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21389 to look at the new patch set (#4). Change subject: KUDU-613: Introduce new BlockCache metrics

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-05-16 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. Patch Set 18: (29 comments)

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-05-16 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20607 to look at the new patch set (#18). Change subject: KUDU-613: Introduce SLRU cache

[kudu-CR] KUDU-613: Introduce new BlockCache metrics

2024-05-10 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Introduce new BlockCache metrics .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-613: Introduce new BlockCache metrics

2024-05-10 Thread Mahesh Reddy (Code Review)
Hello Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21389 to look at the new patch set (#3). Change subject: KUDU-613: Introduce new BlockCache metrics

[kudu-CR](gh-pages) [blog] Fix typo in blogpost

2024-05-06 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21378 ) Change subject: [blog] Fix typo in blogpost .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/21378 To

[kudu-CR] [security-flags-itest] Fix missing command line flags

2024-05-06 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21399 ) Change subject: [security-flags-itest] Fix missing command line flags .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-613: Integrate SLRU cache into block cache

2024-05-03 Thread Mahesh Reddy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21390 to look at the new patch set (#2). Change subject: KUDU-613: Integrate SLRU cache into block cache .. KUDU-613:

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-05-03 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20607 to look at the new patch set (#16). Change subject: KUDU-613: Introduce SLRU cache

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-05-02 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. Patch Set 15: (6 comments) http://gerrit.cloudera.org:8080/#/c/20607/14//COMMIT_MSG

[kudu-CR] KUDU-613: Cleanup of cache code

2024-05-02 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21018 ) Change subject: KUDU-613: Cleanup of cache code .. Patch Set 8: (1 comment)

[kudu-CR] KUDU-613: Cleanup of cache code

2024-05-02 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21018 to look at the new patch set (#8). Change subject: KUDU-613: Cleanup of cache code

[kudu-CR] KUDU-613: Integrate SLRU cache into block cache

2024-05-02 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21390 Change subject: KUDU-613: Integrate SLRU cache into block cache .. KUDU-613: Integrate SLRU cache into block cache This patch

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-05-02 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20607 to look at the new patch set (#15). Change subject: KUDU-613: Introduce SLRU cache

[kudu-CR] KUDU-613: Introduce new BlockCache metrics

2024-05-02 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21389 Change subject: KUDU-613: Introduce new BlockCache metrics .. KUDU-613: Introduce new BlockCache metrics With the new SLRU cache used

[kudu-CR](gh-pages) [blog] Fix typo in blogpost

2024-04-30 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21378 ) Change subject: [blog] Fix typo in blogpost .. Patch Set 1: (1 comment)

[kudu-CR] [util] fix TidyBot warnings in ScopedTracer

2024-04-24 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21352 ) Change subject: [util] fix TidyBot warnings in ScopedTracer .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [docs] encryption-at-rest is now natively supported

2024-04-22 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21336 ) Change subject: [docs] encryption-at-rest is now natively supported .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] [docs] encryption-at-rest is now natively supported

2024-04-21 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21336 ) Change subject: [docs] encryption-at-rest is now natively supported .. Patch Set 1: Should the second bullet point in the following

[kudu-CR] [rpc-test] make RpcPendingConnectionsMetric more stable

2024-04-10 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21251 ) Change subject: [rpc-test] make RpcPendingConnectionsMetric more stable .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [c++17] address std::move() warnings

2024-04-04 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21241 ) Change subject: [c++17] address std::move() warnings .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [c++17] address std::iterator deprecation warnings

2024-04-04 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21240 ) Change subject: [c++17] address std::iterator deprecation warnings .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [tests] fix a misprint

2024-04-02 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21229 ) Change subject: [tests] fix a misprint .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/21229 To

[kudu-CR] KUDU-3561 skip tablet entities in Prometheus format

2024-04-02 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21226 ) Change subject: KUDU-3561 skip tablet entities in Prometheus format .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-3562 fix integer overflow in available space metrics

2024-04-01 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21227 ) Change subject: KUDU-3562 fix integer overflow in available space metrics .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-3561 skip tablet entities in Prometheus format

2024-04-01 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21226 ) Change subject: KUDU-3561 skip tablet entities in Prometheus format .. Patch Set 1: (2 comments)

[kudu-CR] [rpc] relax settings for MeasureAcceptorDispatchTimes

2024-04-01 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21212 ) Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] [gutil] fix compilation with clang 15

2024-04-01 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21206 ) Change subject: [gutil] fix compilation with clang 15 .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2671: Update upstream docs

2024-03-05 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21108 Change subject: KUDU-2671: Update upstream docs .. KUDU-2671: Update upstream docs This patch updates the upstream docs to include

[kudu-CR] Remove the replace flag if the move fails in auto rebalancing.

2024-03-04 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21073 ) Change subject: Remove the replace flag if the move fails in auto rebalancing. .. Patch Set 7: (2 comments) Can you also add some

[kudu-CR] [compaction] Code cleanup and readability improvement

2024-03-04 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21098 ) Change subject: [compaction] Code cleanup and readability improvement .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-613: Cleanup of cache code

2024-02-29 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21018 ) Change subject: KUDU-613: Cleanup of cache code .. Patch Set 7: (4 comments)

[kudu-CR] KUDU-613: Cleanup of cache code

2024-02-29 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21018 to look at the new patch set (#7). Change subject: KUDU-613: Cleanup of cache code

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-02-28 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. Patch Set 14: (16 comments)

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-02-28 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20607 to look at the new patch set (#14). Change subject: KUDU-613: Introduce SLRU cache

[kudu-CR] KUDU-613: Cleanup of cache code

2024-02-28 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21018 to look at the new patch set (#6). Change subject: KUDU-613: Cleanup of cache code

[kudu-CR] [rpc] a bit of clean-up on LifoServiceQueue

2024-02-22 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21049 ) Change subject: [rpc] a bit of clean-up on LifoServiceQueue .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] [test] make TestRpcHandlerLatencyMetric more robust

2024-02-22 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21055 ) Change subject: [test] make TestRpcHandlerLatencyMetric more robust .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-02-15 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. Patch Set 13: (18 comments) Addressed the first batch of comments, I'll address the

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-02-15 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20607 to look at the new patch set (#13). Change subject: KUDU-613: Introduce SLRU cache

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-02-13 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. Patch Set 12: (4 comments) Fixed the ASAN test error and addressed the comments

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-02-13 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20607 to look at the new patch set (#12). Change subject: KUDU-613: Introduce SLRU cache

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-02-08 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. Patch Set 11: (5 comments) Running into an ASAN error after the latest changes, it

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-02-08 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20607 to look at the new patch set (#11). Change subject: KUDU-613: Introduce SLRU cache

[kudu-CR] KUDU-613: Cleanup of cache code

2024-02-08 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21018 ) Change subject: KUDU-613: Cleanup of cache code .. Patch Set 3: (3 comments)

[kudu-CR] KUDU-613: Cleanup of cache code

2024-02-08 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21018 to look at the new patch set (#3). Change subject: KUDU-613: Cleanup of cache code

[kudu-CR] KUDU-613: Cleanup of cache code

2024-02-07 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21018 to look at the new patch set (#2). Change subject: KUDU-613: Cleanup of cache code .. KUDU-613: Cleanup

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-02-07 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. Patch Set 9: (3 comments)

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-02-07 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20607 to look at the new patch set (#9). Change subject: KUDU-613: Introduce SLRU cache

[kudu-CR] KUDU-613: Cleanup of cache code

2024-02-07 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21018 Change subject: KUDU-613: Cleanup of cache code .. KUDU-613: Cleanup of cache code This patch moves some classes out of the anonymous

[kudu-CR] KUDU-613: Scan Resistant Caching

2024-01-24 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20607 to look at the new patch set (#8). Change subject: KUDU-613: Scan Resistant Caching ..

[kudu-CR] KUDU-613: Scan Resistant Caching

2024-01-18 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Scan Resistant Caching .. Patch Set 7: > Uploaded patch set 7. Moving locking down to shard level. SLRU

[kudu-CR] KUDU-613: Scan Resistant Caching

2024-01-18 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20607 to look at the new patch set (#7). Change subject: KUDU-613: Scan Resistant Caching ..

[kudu-CR] KUDU-3491 Destruct master before creating a new one

2024-01-17 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20913 ) Change subject: KUDU-3491 Destruct master before creating a new one .. Patch Set 7: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-3491 Destruct master before creating a new one

2024-01-17 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20913 ) Change subject: KUDU-3491 Destruct master before creating a new one .. Patch Set 6: Code-Review+1 -- To view, visit

[kudu-CR] [master runner] Destruct server before new one

2024-01-17 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20913 ) Change subject: [master_runner] Destruct server before new one .. Patch Set 2: (1 comment)

[kudu-CR] [log block manager-test] Improve random selection

2024-01-16 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20899 ) Change subject: [log_block_manager-test] Improve random selection .. Patch Set 5: > Patch Set 5: > > (1 comment) Besides this error,

[kudu-CR](branch-1.17.x) KUDU-3532: Follow up to replica placement bug

2024-01-05 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20861 ) Change subject: KUDU-3532: Follow up to replica placement bug .. Patch Set 2: (1 comment)

[kudu-CR](branch-1.17.x) KUDU-3532: Follow up to replica placement bug

2024-01-05 Thread Mahesh Reddy (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20861 to look at the new patch set (#2). Change subject: KUDU-3532: Follow up to replica placement bug

[kudu-CR](branch-1.17.x) KUDU-3252: Follow up to replica placement bug

2024-01-04 Thread Mahesh Reddy (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/20861 to review the following change. Change subject: KUDU-3252: Follow up to replica placement bug .. KUDU-3252: Follow

[kudu-CR] KUDU-3252: Follow up to replica placement bug

2023-12-22 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20827 ) Change subject: KUDU-3252: Follow up to replica placement bug .. Patch Set 2: (4 comments)

[kudu-CR] KUDU-3252: Follow up to replica placement bug

2023-12-22 Thread Mahesh Reddy (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20827 to look at the new patch set (#2). Change subject: KUDU-3252: Follow up to replica placement bug ..

[kudu-CR] KUDU-3532: Fix range aware replica placement bug

2023-12-20 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20781 ) Change subject: KUDU-3532: Fix range aware replica placement bug .. Patch Set 2: (4 comments)

[kudu-CR] KUDU-3252: Follow up to replica placement bug

2023-12-20 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20827 Change subject: KUDU-3252: Follow up to replica placement bug .. KUDU-3252: Follow up to replica placement bug This patch addresses the

[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths

2023-12-20 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 ) Change subject: [compaction/flush] Cleanup of compaction and flush code paths .. Patch Set 7: Code-Review+1 LGTM, looks like there's

[kudu-CR] [rpc] modernize code a bit

2023-12-20 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20815 ) Change subject: [rpc] modernize code a bit .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20815 To

[kudu-CR] KUDU-3532: Fix range aware replica placement bug

2023-12-12 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20781 Change subject: KUDU-3532: Fix range aware replica placement bug .. KUDU-3532: Fix range aware replica placement bug An implicit

[kudu-CR] [util] make Socket::SetTcpKeepAlive() available on macOS

2023-12-10 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20765 ) Change subject: [util] make Socket::SetTcpKeepAlive() available on macOS .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR](branch-1.17.x) [compaction] Fix the incorrect memory budgeting condition

2023-12-10 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20764 ) Change subject: [compaction] Fix the incorrect memory budgeting condition .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [compaction] Fix the incorrect memory budgeting condition

2023-12-06 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20758 ) Change subject: [compaction] Fix the incorrect memory budgeting condition .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [security] a small style-related code cleanup

2023-12-04 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20745 ) Change subject: [security] a small style-related code cleanup .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] [rpc] micro-optimizations on RpczStore::LogTrace

2023-12-04 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20748 ) Change subject: [rpc] micro-optimizations on RpczStore::LogTrace .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] more strict check for [un]setenv() return code

2023-12-04 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20744 ) Change subject: more strict check for [un]setenv() return code .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-3527 Fix block manager test on 64k filesystems

2023-11-29 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test on 64k filesystems .. Patch Set 5: (1 comment)

[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths

2023-11-27 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 ) Change subject: [compaction/flush] Cleanup of compaction and flush code paths .. Patch Set 4: Code-Review+1 -- To view, visit

[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths

2023-11-22 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 ) Change subject: [compaction/flush] Cleanup of compaction and flush code paths .. Patch Set 4: (2 comments)

[kudu-CR] [thirdparty] update lz4 up to 1.9.4 version

2023-11-21 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20722 ) Change subject: [thirdparty] update lz4 up to 1.9.4 version .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [tablet] NewReplicaOpDriver() --> NewFollowerOpDriver()

2023-11-16 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20713 ) Change subject: [tablet] NewReplicaOpDriver() --> NewFollowerOpDriver() .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-613: Scan Resistant Caching

2023-11-14 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Scan Resistant Caching .. Patch Set 6: > Uploaded patch set 6. Added metrics. Added another unit test and

[kudu-CR] KUDU-613: Scan Resistant Caching

2023-11-14 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20607 to look at the new patch set (#6). Change subject: KUDU-613: Scan Resistant Caching ..

[kudu-CR] KUDU-613: Scan Resistant Caching

2023-11-09 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Scan Resistant Caching .. Patch Set 5: > Patch Set 4: > > (9 comments) > > It's very important to add

[kudu-CR] KUDU-613: Scan Resistant Caching

2023-11-09 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Scan Resistant Caching .. Patch Set 5: (9 comments)

[kudu-CR] KUDU-613: Scan Resistant Caching

2023-11-09 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20607 to look at the new patch set (#5). Change subject: KUDU-613: Scan Resistant Caching ..

[kudu-CR] [util] fix compilation warning

2023-11-06 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20671 ) Change subject: [util] fix compilation warning .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20671

[kudu-CR] [master] fix typo in MasterAddrsToCsv()

2023-11-06 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20670 ) Change subject: [master] fix typo in MasterAddrsToCsv() .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] WIP KUDU-613: Scan Resistant Caching

2023-11-01 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20607 to look at the new patch set (#4). Change subject: WIP KUDU-613: Scan Resistant Caching ..

[kudu-CR] [util] check if EVP CIPHER CTX new() returns null

2023-11-01 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20642 ) Change subject: [util] check if EVP_CIPHER_CTX_new() returns null .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] WIP KUDU-613: Scan Resistant Caching

2023-10-26 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20607 to look at the new patch set (#3). Change subject: WIP KUDU-613: Scan Resistant Caching ..

[kudu-CR] WIP KUDU-613: Scan Resistant Caching

2023-10-25 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: WIP KUDU-613: Scan Resistant Caching .. Patch Set 2: (7 comments) Thanks for your feedback! I left comments

[kudu-CR] WIP KUDU-613: Scan Resistant Caching

2023-10-25 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20607 to look at the new patch set (#2). Change subject: WIP KUDU-613: Scan Resistant Caching ..

[kudu-CR] [fs] fix compilation on macOS

2023-10-24 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20618 ) Change subject: [fs] fix compilation on macOS .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20618

  1   2   3   4   5   6   >