[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-21 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. [cpp] KUDU-2971: protobuf-based wrapper for

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 12: (1 comment)

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 12: Code-Review+2 (1 comment)

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 12: (1 comment) > Patch Set 11: > > (1 comment)

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-21 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15185 to look at the new patch set (#12). Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 11: (1 comment) I'd rather we didn't merge a

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-21 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 11: Verified+1 Code-Review+1 I am also Ok with

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 11: Code-Review+2 Looks good to me! Maybe Adar

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 11: (1 comment)

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-21 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15185 to look at the new patch set (#11). Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 10: (1 comment)

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-21 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15185 to look at the new patch set (#10). Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 9: (25 comments)

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 9: (1 comment)

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 9: (13 comments) few nits

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 9: (13 comments)

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-20 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 9: Code-Review+2 (1 comment) Looks good to me,

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 9: (1 comment)

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-20 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 9: Code-Review+1 (1 comment)

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 9: Verified+1 Failure seems to be from a

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-20 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15185 To

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 9: (15 comments)

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15185 to look at the new patch set (#9). Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 8: (7 comments) some nits

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-19 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 8: (11 comments) Overall looks good to me, thanks a

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-19 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15185 to look at the new patch set (#8). Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-19 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15185 to look at the new patch set (#7). Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-19 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15185 to look at the new patch set (#6). Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 5: (16 comments)

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-19 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15185 to look at the new patch set (#5). Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 4: (1 comment)

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 4: (18 comments) Addressed partial comments and push

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-18 Thread Hao Hao (Code Review)
Hao Hao has uploaded a new patch set (#4) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. [cpp] KUDU-2971:

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 3: (3 comments)

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 2: (5 comments) I think Hao might be working on

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 1: (24 comments) May need to modify the dist-test

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-07 Thread Andrew Wong (Code Review)
Hello Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15185 to review the following change. Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. [cpp]