Andrew Wong has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
[cpp] KUDU-2971: protobuf-based wrapper for
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 12:
(1 comment)
Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 12: Code-Review+2
(1 comment)
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 12:
(1 comment)
> Patch Set 11:
>
> (1 comment)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15185
to look at the new patch set (#12).
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 11:
(1 comment)
I'd rather we didn't merge a
Hao Hao has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 11: Verified+1 Code-Review+1
I am also Ok with
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 11: Code-Review+2
Looks good to me! Maybe Adar
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 11:
(1 comment)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15185
to look at the new patch set (#11).
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 10:
(1 comment)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15185
to look at the new patch set (#10).
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 9:
(25 comments)
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 9:
(1 comment)
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 9:
(13 comments)
few nits
Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 9:
(13 comments)
Hao Hao has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 9: Code-Review+2
(1 comment)
Looks good to me,
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 9:
(1 comment)
Hao Hao has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 9: Code-Review+1
(1 comment)
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 9: Verified+1
Failure seems to be from a
Andrew Wong has removed a vote on this change.
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15185
To
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 9:
(15 comments)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15185
to look at the new patch set (#9).
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 8:
(7 comments)
some nits
Hao Hao has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 8:
(11 comments)
Overall looks good to me, thanks a
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15185
to look at the new patch set (#8).
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15185
to look at the new patch set (#7).
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15185
to look at the new patch set (#6).
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 5:
(16 comments)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15185
to look at the new patch set (#5).
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 4:
(1 comment)
Hao Hao has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 4:
(18 comments)
Addressed partial comments and push
Hao Hao has uploaded a new patch set (#4) to the change originally created by
Andrew Wong. ( http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
[cpp] KUDU-2971:
Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 3:
(3 comments)
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 2:
(5 comments)
I think Hao might be working on
Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
Patch Set 1:
(24 comments)
May need to modify the dist-test
Hello Hao Hao,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15185
to review the following change.
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses
..
[cpp]
37 matches
Mail list logo