[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. KUDU-1711: ColumnSchema supports storing column

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 9: Code-Review+2 (1 comment)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-28 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 9: (1 comment)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-28 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#9). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 8: (1 comment)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-28 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#8). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#7). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#6). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 5: (2 comments)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 5: (2 comments)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#5). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#4). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 3: (9 comments) yes, the impala catalog uses kudu java

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 3: (9 comments) > @adar,the table will be created

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 3: BTW, if you want Impala to pick up support for

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-26 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#3). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-26 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 2: (1 comment) ok, let me try again.

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-26 Thread helifu (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#2). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-26 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 1: (10 comments) @adar,the table will be created

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 1: (4 comments)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 1: (6 comments) What happens if you try to add a

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-25 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12849 Change subject: KUDU-1711: ColumnSchema supports storing column comment .. KUDU-1711: ColumnSchema supports storing column comment This patch