[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 34: BTW the source for dist-test is open if you want to run

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 33: Code-Review+2 > I found the root cause of this problem.

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 33: Verified+1 Overriding Jenkins, the one failure here was

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-23 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken by KeyRange When reading

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-23 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12323 To unsubscribe,

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-23 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 33: > > The reason for the problem should be that KeyRange is

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-23 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#33) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 32: > The reason for the problem should be that KeyRange is

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-22 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 32: (1 comment) Thanks Adar for the test result. I added the

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-22 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#32) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-22 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#31) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 30: (2 comments)

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 30: This patch looks good to me, I think we just need to

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 29: (1 comment)

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-17 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 30: Sorry, the problem has not been reproduced in local. The

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-17 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#30) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-17 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#29) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-17 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 28: I found that DefaultSourceTest.testScanWithKeyRange has a

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-16 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#28) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-16 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#27) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-16 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 26: (6 comments) Thanks for review.

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 26: (1 comment)

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-16 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#25) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-16 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 24: (7 comments) Thanks for all the updates. It's looking

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 24: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-14 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 24: (1 comment) Add tablet not null check in KeyRanage's

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-14 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#24) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 23: Code-Review+1 (1 comment) Grant, could you take another

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-14 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 23: (18 comments)

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-14 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#23) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-14 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#22) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-14 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#21) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 20: (18 comments)

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-12 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 20: (12 comments) Apologize for updating the patch late. I have

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-12 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#20) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-12 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#19) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-12 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#18) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-11 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#17) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-11 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#16) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-11 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#15) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-11 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#14) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-11 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#13) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-11 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#12) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-10 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#11) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-03-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 10: (15 comments)

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-03-23 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 10: (22 comments) Hi, guys. I refactored part of the code for

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-03-23 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#10) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-03-23 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#9) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-03-23 Thread Yao Xu (Code Review)
Yao Xu has uploaded a new patch set (#8) to the change originally created by yangz. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. KUDU-2670: Part 1: Build ScanToken