[kudu-CR] iwyu: standardize on libc++

2020-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. iwyu: standardize on libc++ A common IWYU pain point is that the set of

[kudu-CR] iwyu: standardize on libc++

2020-03-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15492

[kudu-CR] iwyu: standardize on libc++

2020-03-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. Patch Set 10: > Looks good to me and I verified it works fine on CentOS8. > >

[kudu-CR] iwyu: standardize on libc++

2020-03-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. Patch Set 10: Code-Review+2 Looks good to me and I verified it works fine on CentOS8.

[kudu-CR] iwyu: standardize on libc++

2020-03-24 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, Grant Henke, Bankim Bhavsar, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15492 to look at the new patch set (#9). Change subject: iwyu: standardize on libc++

[kudu-CR] iwyu: standardize on libc++

2020-03-24 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu

[kudu-CR] iwyu: standardize on libc++

2020-03-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. Patch Set 8: Verified+1 Overriding Jenkins, flaky Java test. -- To view, visit

[kudu-CR] iwyu: standardize on libc++

2020-03-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/15492/5//COMMIT_MSG

[kudu-CR] iwyu: standardize on libc++

2020-03-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/15492/7//COMMIT_MSG Commit

[kudu-CR] iwyu: standardize on libc++

2020-03-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/15492/7//COMMIT_MSG Commit

[kudu-CR] iwyu: standardize on libc++

2020-03-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/15492/5//COMMIT_MSG Commit

[kudu-CR] iwyu: standardize on libc++

2020-03-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. Patch Set 7: Code-Review+2 (3 comments)

[kudu-CR] iwyu: standardize on libc++

2020-03-24 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15492 to look at the new patch set (#7). Change subject: iwyu: standardize on libc++

[kudu-CR] iwyu: standardize on libc++

2020-03-24 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15492 to look at the new patch set (#6). Change subject: iwyu: standardize on libc++

[kudu-CR] iwyu: standardize on libc++

2020-03-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. Patch Set 5: Verified+1 Overriding Jenkins, filed KUDU-3092 for the flaky test. -- To

[kudu-CR] iwyu: standardize on libc++

2020-03-24 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu

[kudu-CR] iwyu: standardize on libc++

2020-03-23 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15492 to look at the new patch set (#5). Change subject: iwyu: standardize on libc++

[kudu-CR] iwyu: standardize on libc++

2020-03-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. Patch Set 4: (3 comments) New IWYU run on all files: https://pastebin.com/Mcyd3pfF

[kudu-CR] iwyu: standardize on libc++

2020-03-23 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15492 to look at the new patch set (#4). Change subject: iwyu: standardize on libc++