[kudu-CR] compaction policy: fix bound calculation

2016-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: compaction_policy: fix bound calculation .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4152 To unsubscribe, visit

[kudu-CR](gh-pages) kudu flume sink blog post

2016-08-30 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: kudu flume sink blog post .. Abandoned Squashed into https://gerrit.cloudera.org/3510 -- To view, visit http://gerrit.cloudera.org:8080/4149 To unsubscribe, visit

[kudu-CR](gh-pages) kudu flume sink blog post

2016-08-30 Thread Ara Ebrahimi (Code Review)
Ara Ebrahimi has uploaded a new patch set (#3). Change subject: kudu flume sink blog post .. kudu flume sink blog post Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed --- A _posts/2016-07-06-flume.md 1 file changed, 255

[kudu-CR] [docs] added Kudu version into the doxygen footer

2016-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [docs] added Kudu version into the doxygen footer .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4165/1/CMakeLists.txt File CMakeLists.txt:

[kudu-CR] [docs] added Kudu version into the doxygen footer

2016-08-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [docs] added Kudu version into the doxygen footer .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3147/ -- To view, visit

[kudu-CR] [docs] added Kudu version into the doxygen footer

2016-08-30 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4165 to look at the new patch set (#3). Change subject: [docs] added Kudu version into the doxygen footer .. [docs]

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 6: Subprocess::Call has optional out-parameters for stdout/stderr so you can capture it and

[kudu-CR] KUDU-1586. consensus: always send at least one op

2016-08-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1586. consensus: always send at least one op .. KUDU-1586. consensus: always send at least one op This fixes a bug in which the LogCache would not

[kudu-CR] compaction policy: fix bound calculation

2016-08-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: compaction_policy: fix bound calculation .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3148/ -- To view, visit

[kudu-CR] compaction policy: fix bound calculation

2016-08-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: compaction_policy: fix bound calculation .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4152/1/src/kudu/tablet/compaction_policy.cc File

[kudu-CR] KUDU-1586. consensus: always send at least one op

2016-08-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1586. consensus: always send at least one op .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4168 To unsubscribe, visit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 6: Code-Review+1 Code LGTM, but I agree that a test would be nice. -- To view, visit

[kudu-CR] docs: update installation with new OS support

2016-08-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: update installation with new OS support .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4128 To unsubscribe, visit

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 15: (1 comment)

[kudu-CR] docs: updates to kudu impala integration.adoc

2016-08-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: updates to kudu_impala_integration.adoc .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4138 To unsubscribe, visit

[kudu-CR] KUDU-1582. Optimize budgeted compaction policy with an approximation

2016-08-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1582. Optimize budgeted compaction policy with an approximation .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3149/ -- To view,

[kudu-CR] compaction policy: fix bound calculation

2016-08-30 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4152 to look at the new patch set (#2). Change subject: compaction_policy: fix bound calculation ..

[kudu-CR] docs: updates to kudu impala integration.adoc

2016-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: docs: updates to kudu_impala_integration.adoc .. Patch Set 1: Code-Review+1 (1 comment) Just one nice-to-know question regarding CentOS. Otherwise lgtm.

[kudu-CR](gh-pages) kudu flume sink blog post

2016-08-30 Thread Ara Ebrahimi (Code Review)
Ara Ebrahimi has uploaded a new patch set (#2). Change subject: kudu flume sink blog post .. kudu flume sink blog post Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed --- A _posts/2016-07-06-flume.md 1 file changed, 182

[kudu-CR] make election timeout jitter more aggressive

2016-08-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: make election timeout jitter more aggressive .. Patch Set 1: Let's try and close this one out soon? Not sure where the conversation got left. -- To view, visit

[kudu-CR] [docs] added Kudu version into the doxygen footer

2016-08-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: [docs] added Kudu version into the doxygen footer .. [docs] added Kudu version into the doxygen footer Added information on the Kudu source version into

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 23: (16 comments) Nice. This is much more understandable than previously.

[kudu-CR] tool: port log-dump

2016-08-30 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4167 to look at the new patch set (#2). Change subject: tool: port log-dump .. tool: port log-dump This one was more

[kudu-CR] tool: port log-dump

2016-08-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port log-dump .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3151/ -- To view, visit http://gerrit.cloudera.org:8080/4167 To

[kudu-CR] Add trace metrics for maintenance ops, LBM writes

2016-08-30 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4172 to review the following change. Change subject: Add trace metrics for maintenance ops, LBM writes .. Add trace

[kudu-CR] Add trace metrics for maintenance ops, LBM writes

2016-08-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add trace metrics for maintenance ops, LBM writes .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3150/ -- To view, visit

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 17: Build Started http://104.196.14.100/job/kudu-gerrit/3152/ -- To view,

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-30 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3823 to look at the new patch set (#17). Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] docs: updates to kudu impala integration.adoc

2016-08-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: updates to kudu_impala_integration.adoc .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4138/1/docs/kudu_impala_integration.adoc File

[kudu-CR] [docs] added Kudu version into the doxygen footer

2016-08-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [docs] added Kudu version into the doxygen footer .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4165 To unsubscribe, visit

[kudu-CR] [java-client] Add ScanToken.stringifySerializedToken

2016-08-30 Thread Dan Burkert (Code Review)
Hello Matthew Jacobs, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4173 to review the following change. Change subject: [java-client] Add ScanToken.stringifySerializedToken

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Patch Set 4: (7 comments)

[kudu-CR] [java-client] Add ScanToken.stringifySerializedToken

2016-08-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java-client] Add ScanToken.stringifySerializedToken .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3155/ -- To view, visit

[kudu-CR] docs: updates to kudu impala integration.adoc

2016-08-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: docs: updates to kudu_impala_integration.adoc .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3154/ -- To view, visit

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-30 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 17: (2 comments) TFTRs Mike/Dan/Adar, updated the patch to reflect the

[kudu-CR] Inlined dispatch for predicate evaluation

2016-08-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4164/2/src/kudu/common/column_predicate.h File

[kudu-CR] client-test: remove an unnecessary manual leader election

2016-08-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: client-test: remove an unnecessary manual leader election .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4141 To unsubscribe,

[kudu-CR] raft consensus-itest: workaround flakiness due to KUDU-1580

2016-08-30 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: raft_consensus-itest: workaround flakiness due to KUDU-1580 .. raft_consensus-itest: workaround flakiness due to KUDU-1580 KUDU-1580 is a bug in which the

[kudu-CR] raft consensus-itest: inserter thread should FATAL instead of FAIL

2016-08-30 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: raft_consensus-itest: inserter thread should FATAL instead of FAIL .. raft_consensus-itest: inserter thread should FATAL instead of FAIL This test has a

[kudu-CR](gh-pages) kudu flume sink blog post

2016-08-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: kudu flume sink blog post .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/3510/6/_posts/2016-08-31-intro-flume-kudu-sink.md File

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-08-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 4: (4 comments) I am still working my way through this patch. There are several TODOs, not sure if

[kudu-CR](gh-pages) kudu flume sink blog post

2016-08-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: kudu flume sink blog post .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3510 To unsubscribe, visit

[kudu-CR] docs: updates to kudu impala integration.adoc

2016-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: docs: updates to kudu_impala_integration.adoc .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4138 To unsubscribe, visit

[kudu-CR] Add trace metrics for maintenance ops, LBM writes

2016-08-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add trace metrics for maintenance ops, LBM writes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4172/1/src/kudu/util/maintenance_manager.cc

[kudu-CR](gh-pages) kudu flume sink blog post

2016-08-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: kudu flume sink blog post .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/3510/6/_posts/2016-08-31-intro-flume-kudu-sink.md File

[kudu-CR] KUDU-668. log block manager should tolerate empty metadata

2016-08-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-668. log block manager should tolerate empty metadata .. Patch Set 1: fwiw I also just tried this patch on a test cluster which had hit this issue, and some

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Patch Set 5: > Build Failed > > http://104.196.14.100/job/kudu-gerrit/3158/ : FAILURE All the

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 23: (2 comments)

[kudu-CR] Add trace metrics for maintenance ops, LBM writes

2016-08-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Add trace metrics for maintenance ops, LBM writes .. Add trace metrics for maintenance ops, LBM writes This adds a trace-scoped counter for

[kudu-CR](gh-pages) kudu flume sink blog post

2016-08-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: kudu flume sink blog post .. Patch Set 6: Code-Review+2 Verified+1 Thanks Ara! I'll push this live tomorrow morning. -- To view, visit

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 23: (27 comments) Dan & Adar, thank you for the review. I'll post updated version as soon as

[kudu-CR] KUDU-668. log block manager should tolerate empty metadata

2016-08-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-668. log block manager should tolerate empty metadata .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3157/ -- To view, visit

[kudu-CR] KUDU-668. log block manager should tolerate empty metadata

2016-08-30 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4178 to review the following change. Change subject: KUDU-668. log block manager should tolerate empty metadata ..

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-30 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4034 to look at the new patch set (#5). Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Add

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/3158/ -- To view, visit

[kudu-CR](gh-pages) kudu flume sink blog post

2016-08-30 Thread Ara Ebrahimi (Code Review)
Hello Mike Percy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3510 to look at the new patch set (#7). Change subject: kudu flume sink blog post .. kudu flume sink blog post

[kudu-CR](gh-pages) kudu flume sink blog post

2016-08-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: kudu flume sink blog post .. Patch Set 5: (1 comment) We need to rename the file to the date it will get posted. Let me collect some opinions and get back to you

[kudu-CR] tool: port log-dump

2016-08-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tool: port log-dump .. tool: port log-dump This one was more complicated, because log-dump can run against a single file or an entire tablet. So I put

[kudu-CR] tool: port log-dump

2016-08-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: port log-dump .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4167 To unsubscribe, visit

[kudu-CR] c++ client: expose private GetTablet API

2016-08-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: c++ client: expose private GetTablet API .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3159/ -- To view, visit

[kudu-CR] c++ client: expose private GetTablet API

2016-08-30 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4179 to review the following change. Change subject: c++ client: expose private GetTablet API .. c++ client:

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/3161/ -- To view, visit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-30 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#7). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] c++ client: expose private GetTablet API

2016-08-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: c++ client: expose private GetTablet API .. Patch Set 1: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/3162/ -- To view, visit

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-08-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' .. Patch Set 1: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/3163/ -- To view, visit

[kudu-CR](gh-pages) kudu flume sink blog post

2016-08-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: kudu flume sink blog post .. Patch Set 5: > Let's publish tomorrow. > > Please rename the file to 2016-08-07-intro-flume-kudu-sink.md Oops, my mistake. Please

[kudu-CR](gh-pages) kudu flume sink blog post

2016-08-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: kudu flume sink blog post .. Patch Set 5: Let's publish tomorrow. Please rename the file to 2016-08-07-intro-flume-kudu-sink.md -- To view, visit

[kudu-CR](gh-pages) kudu flume sink blog post

2016-08-30 Thread Ara Ebrahimi (Code Review)
Ara Ebrahimi has uploaded a new patch set (#6). Change subject: kudu flume sink blog post .. kudu flume sink blog post Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed --- A _posts/2016-08-31-intro-flume-kudu-sink.md 1 file

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Patch Set 4: (7 comments) Did a significant rewrite to make it more similar to the DataSet Sink

[kudu-CR] Add trace metrics for maintenance ops, LBM writes

2016-08-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add trace metrics for maintenance ops, LBM writes .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] WIP: tie log retention to consensus watermarks

2016-08-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: tie log retention to consensus watermarks .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3156/ -- To view, visit

[kudu-CR] WIP: tie log retention to consensus watermarks

2016-08-30 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4177 to review the following change. Change subject: WIP: tie log retention to consensus watermarks .. WIP: tie log

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 23: (3 comments) http://gerrit.cloudera.org:8080/#/c/3952/23/src/kudu/client/batcher.cc File

[kudu-CR](gh-pages) kudu flume sink blog post

2016-08-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: kudu flume sink blog post .. Patch Set 1: Thanks for posting this update! Please squash this into the previous commit and re-push to Gerrit:

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-30 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 6: > Code change looks good, but how about a test in kudu-ts-cli-test? Yess, thought about