[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3389/ -- To view, visit http://gerrit.clo

[kudu-CR] tool: port ts-cli

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port ts-cli .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/3390/ -- To view, visit http://gerrit.cloudera.org:8080/4373 To unsubscrib

[kudu-CR] tool: port ts-cli

2016-09-12 Thread Todd Lipcon (Code Review)
Hello Dinesh Bhat, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4373 to look at the new patch set (#5). Change subject: tool: port ts-cli .. tool: port ts-cli I chose to

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4305 to look at the new patch set (#14). Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool ..

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. Patch Set 14: Build Started http://104.196.14.100/job/kudu-gerrit/3391/ -- To view, visit http://gerrit

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. Patch Set 8: Just rebased and put this in a series with Dinesh's patch. Will commit if it passes -- To

[kudu-CR] tool: port ts-cli

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: port ts-cli .. Patch Set 5: Just rebased -- To view, visit http://gerrit.cloudera.org:8080/4373 To unsubscribe, visit http://gerrit.cloudera.org:8080/setti

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 1: How sure are we that this won't negatively affect the non-auto-flush code path? i.e is this ris

[kudu-CR] KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

2016-09-12 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4392 to look at the new patch set (#2). Change subject: KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

[kudu-CR] KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3392/ -- To view, visit

[kudu-CR] Remove a spurious warning left in raft consensus state.cc

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Remove a spurious warning left in raft_consensus_state.cc .. Remove a spurious warning left in raft_consensus_state.cc Change-Id: I0bcada22bc31e1640e5e047

[kudu-CR] KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

2016-09-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy .. Patch Set 2: (5 comments) looks good, just a few nits http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3393/ -- To view, visit

[kudu-CR] KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

2016-09-12 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4392 to look at the new patch set (#3). Change subject: KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

[kudu-CR] KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy .. Patch Set 3: took care of all the nits -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

2016-09-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4392 To unsubs

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4395/1/src/kudu/client/session-internal.cc Fil

[kudu-CR] Add two RAT excludes

2016-09-12 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4396 to review the following change. Change subject: Add two RAT excludes .. Add two RAT excludes - .avsc fi

[kudu-CR] Add two RAT excludes

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add two RAT excludes .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3394/ -- To view, visit http://gerrit.cloudera.org:8080/4396 To unsubsc

[kudu-CR] Add two RAT excludes

2016-09-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add two RAT excludes .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4396 To unsubscribe, visit http://gerrit.cloudera.org:8080/set

[kudu-CR] [docs/doxygen] removed auto-generated comments

2016-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4397 Change subject: [docs/doxygen] removed auto-generated comments .. [docs/doxygen] removed auto-generated comments The template auto-gener

[kudu-CR] [docs/doxygen] removed auto-generated comments

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [docs/doxygen] removed auto-generated comments .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3395/ -- To view, visit http://gerrit.clouder

[kudu-CR] [docs/doxygen] removed auto-generated comments

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [docs/doxygen] removed auto-generated comments .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4397 To unsubscribe, visit http://g

[kudu-CR] tool: port ts-cli

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tool: port ts-cli .. tool: port ts-cli I chose to expose common server functionality in new 'master' and 'tserver' modes rather than consolidating them in

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4305 To unsubscribe, visit

[kudu-CR] tool: port ts-cli

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: port ts-cli .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4373 To unsubscribe, visit http://gerrit.cloudera.org:8080/setti

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool This change ports fs_dump actions under 'ku

[kudu-CR] [docs/doxygen] removed auto-generated comments

2016-09-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [docs/doxygen] removed auto-generated comments .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4397 To unsubscribe, visit http://ge

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4395/1/src/kudu/client/session-internal.cc F

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4395/1/src/kudu/client/session-internal.cc File

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4395 to look at the new patch set (#2). Change subject: [client] avoid circular deps in time-based flusher .. [client] a

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3396/ -- To view, visit http://gerrit.clo

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 2: (1 comment) I left you some comments just as you revved PS2. Not sure if you saw them. http://g

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 2: > How sure are we that this won't negatively affect the > non-auto-flush code path? i.e is th

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4395/1/src/kudu/client/session-internal.cc F

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4395/1/src/kudu/client/session-internal.h File s

[kudu-CR] [docs/doxygen] removed auto-generated comments

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [docs/doxygen] removed auto-generated comments .. [docs/doxygen] removed auto-generated comments The template auto-generated comments for doxygen directiv

[kudu-CR] KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy .. Patch Set 3: Verified+1 Known-flaky java test -- To view, visit http://gerrit.cloudera.or

[kudu-CR] KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy .. KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy This fixes a b

[kudu-CR] Add two RAT excludes

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Add two RAT excludes .. Add two RAT excludes - .avsc files can't have a comment header - The HTML template used for the doxygen footer seems small enough

[kudu-CR](branch-1.0.x) Revert "java: fix leak of TabletClient objects in client2tablets map"

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/4398 Change subject: Revert "java: fix leak of TabletClient objects in client2tablets map" .. Revert "java: fix leak of TabletClient objects in

[kudu-CR](branch-1.0.x) Change version to non-SNAPSHOT in branch

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Change version to non-SNAPSHOT in branch .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3398/ -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] Bump version to 1.1.0-SNAPSHOT

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/4400 Change subject: Bump version to 1.1.0-SNAPSHOT .. Bump version to 1.1.0-SNAPSHOT Change-Id: Ifd9db10a73fecbb73cebe66c16d16e9d11a98750 ---

[kudu-CR] Bump version to 1.1.0-SNAPSHOT

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Bump version to 1.1.0-SNAPSHOT .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3399/ -- To view, visit http://gerrit.cloudera.org:8080/4400

[kudu-CR](branch-1.0.x) Revert "java: fix leak of TabletClient objects in client2tablets map"

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Revert "java: fix leak of TabletClient objects in client2tablets map" .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3397/ -- To view, vis

[kudu-CR](branch-1.0.x) Change version to non-SNAPSHOT in branch

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/4399 Change subject: Change version to non-SNAPSHOT in branch .. Change version to non-SNAPSHOT in branch Change-Id: Ibc73006692673591a78c1bf3a

[kudu-CR] debug-util-test: address flakiness

2016-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: debug-util-test: address flakiness .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4346 To unsubscribe, visit http://gerrit.clouder

[kudu-CR] debug-util-test: address flakiness

2016-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: debug-util-test: address flakiness .. debug-util-test: address flakiness In TSAN builds, this test seems to fail sometimes due to not starting the 'Sleeper

[kudu-CR] build-and-test: only run cmake once

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: build-and-test: only run cmake once .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3400/ -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] build-and-test: only run cmake once

2016-09-12 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4401 to review the following change. Change subject: build-and-test: only run cmake once .. build-and-test: only run cmake

[kudu-CR](branch-1.0.x) Revert "java: fix leak of TabletClient objects in client2tablets map"

2016-09-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Revert "java: fix leak of TabletClient objects in client2tablets map" .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/439

[kudu-CR](branch-1.0.x) Revert "java: fix leak of TabletClient objects in client2tablets map"

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Revert "java: fix leak of TabletClient objects in client2tablets map" .. Revert "java: fix leak of TabletClient objects in client2tablets map" This rever

[kudu-CR](branch-1.0.x) Change version to non-SNAPSHOT in branch

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Change version to non-SNAPSHOT in branch .. Change version to non-SNAPSHOT in branch Change-Id: Ibc73006692673591a78c1bf3a101058ad62fc014 Reviewed-on: htt

[kudu-CR](branch-1.0.x) Change version to non-SNAPSHOT in branch

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Change version to non-SNAPSHOT in branch .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4399 To unsubscribe, visit http://gerrit.

[kudu-CR] Bump version to 1.1.0-SNAPSHOT

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Bump version to 1.1.0-SNAPSHOT .. Bump version to 1.1.0-SNAPSHOT Change-Id: Ifd9db10a73fecbb73cebe66c16d16e9d11a98750 Reviewed-on: http://gerrit.cloudera.

[kudu-CR] Bump version to 1.1.0-SNAPSHOT

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Bump version to 1.1.0-SNAPSHOT .. Patch Set 1: Code-Review+2 Verified+1 Flaky java tests, self-reviewing since it's just build-related -- To view, visit http://g

[kudu-CR] KUDU-1301 - [python] Tests leak tmp directory

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1301 - [python] Tests leak tmp directory .. KUDU-1301 - [python] Tests leak tmp directory In the past the python tests have been leaking tmp director

[kudu-CR] KUDU-1301 - [python] Tests leak tmp directory

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1301 - [python] Tests leak tmp directory .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4372 To unsubscribe, visit http://ge

[kudu-CR] [c++ client] AUTO FLUSH BACKGROUND optimizations

2016-09-12 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4308 to look at the new patch set (#3). Change subject: [c++ client] AUTO_FLUSH_BACKGROUND optimizations .. [c++ client]

[kudu-CR] [c++ client] AUTO FLUSH BACKGROUND optimizations

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [c++ client] AUTO_FLUSH_BACKGROUND optimizations .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3401/ -- To view, visit http://gerrit.cloud

[kudu-CR] [c++ client] AUTO FLUSH BACKGROUND optimizations

2016-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [c++ client] AUTO_FLUSH_BACKGROUND optimizations .. Patch Set 2: (2 comments) Thank you for the review! I posted the updated version. http://gerrit.cloudera.o

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 1: > (1 comment) > > I left you some comments just as you revved PS2. Not sure if you > saw t

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4395/2/src/kudu/client/session-internal.cc Fi

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4395 to look at the new patch set (#3). Change subject: [client] avoid circular deps in time-based flusher .. [client] a

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3402/ -- To view, visit http://gerrit.clo

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4395 To unsubscribe, visit http:

[kudu-CR] [client] performance optimizations

2016-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [client] performance optimizations .. Patch Set 2: (1 comment) Thank you for the review! Will address the rest of the comments after addressing the tests flak

[kudu-CR] KUDU-1090: relax MemTracker uniqueness constraint

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1090: relax MemTracker uniqueness constraint .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/4394/2/src/kudu/integration-tests/external_mini

[kudu-CR] build-and-test: only run cmake once

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: build-and-test: only run cmake once .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4401 To unsubscribe, visit http://gerrit.cloud

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 3: Verified+1 I managed to write a test which reliably leaks without this patch: https://gist.githu

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [client] avoid circular deps in time-based flusher .. [client] avoid circular deps in time-based flusher The boost::bind() makes cast of parameters during

[kudu-CR](branch-1.0.x) [client] avoid circular deps in time-based flusher

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/4403 Change subject: [client] avoid circular deps in time-based flusher .. [client] avoid circular deps in time-based flusher The boost::bind()

[kudu-CR](branch-1.0.x) [client] avoid circular deps in time-based flusher

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3403/ -- To view, visit http://gerrit.clo

<    1   2