[kudu-CR] clock: refactor interaction with NTP into a new interface

Todd Lipcon has posted comments on this change. Change subject: clock: refactor interaction with NTP into a new interface .. Patch Set 3: (2 comments) fixed new tidy issues

[kudu-CR] KUDU-2088: Synchronizer may not go out of scope with outstanding references

Todd Lipcon has posted comments on this change. Change subject: KUDU-2088: Synchronizer may not go out of scope with outstanding references .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7562

[kudu-CR] clock: refactor interaction with NTP into a new interface

Adar Dembo has posted comments on this change. Change subject: clock: refactor interaction with NTP into a new interface .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/7520/4/src/kudu/clock/mock_ntp.h File

[kudu-CR] raft consensus-itest: another fix for asynchronous SIGSTOP

Adar Dembo has posted comments on this change. Change subject: raft_consensus-itest: another fix for asynchronous SIGSTOP .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2088: Synchronizer may not go out of scope with outstanding references

Adar Dembo has submitted this change and it was merged. Change subject: KUDU-2088: Synchronizer may not go out of scope with outstanding references .. KUDU-2088: Synchronizer may not go out of scope with outstanding references

[kudu-CR] KUDU-2088: Synchronizer may not go out of scope with outstanding references

Adar Dembo has posted comments on this change. Change subject: KUDU-2088: Synchronizer may not go out of scope with outstanding references .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7562/1//COMMIT_MSG

[kudu-CR] tool: print usage information when arguments fail to parse

Todd Lipcon has submitted this change and it was merged. Change subject: tool: print usage information when arguments fail to parse .. tool: print usage information when arguments fail to parse This changes the output when the

[kudu-CR] Move clock-related classes to src/kudu/clock

Todd Lipcon has posted comments on this change. Change subject: Move clock-related classes to src/kudu/clock .. Patch Set 3: (3 comments) fixed tidy issues in modified code (some pre-existing that are getting re-flagged due

[kudu-CR] Expose running maintenance op info

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7537 to look at the new patch set (#4). Change subject: Expose running maintenance op info .. Expose running

[kudu-CR] KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

Hello Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7545 to look at the new patch set (#2). Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

[kudu-CR] disk failure: add persistent disk states

Adar Dembo has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 6: (29 comments) http://gerrit.cloudera.org:8080/#/c/7270/6/src/kudu/fs/block_manager_util-test.cc File

[kudu-CR] Move clock-related classes to src/kudu/clock

Adar Dembo has posted comments on this change. Change subject: Move clock-related classes to src/kudu/clock .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/7519/4/src/kudu/clock/CMakeLists.txt File

[kudu-CR] KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

Todd Lipcon has posted comments on this change. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. Patch Set 1: (1 comment)

[kudu-CR] Expose running maintenance op info

Sam Okrent has posted comments on this change. Change subject: Expose running maintenance op info .. Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/7537/3/src/kudu/tserver/tserver-path-handlers.cc File

[kudu-CR] clock: refactor interaction with NTP into a new interface

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7520 to look at the new patch set (#4). Change subject: clock: refactor interaction with NTP into a new interface ..

[kudu-CR] Move clock-related classes to src/kudu/clock

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7519 to look at the new patch set (#4). Change subject: Move clock-related classes to src/kudu/clock .. Move

[kudu-CR] KUDU-2060: Show primary keys in the master's table web UI page

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7555 to look at the new patch set (#6). Change subject: KUDU-2060: Show primary keys in the master's table web UI page

[kudu-CR] KUDU-2088: Synchronizer may not go out of scope with outstanding references

Adar Dembo has posted comments on this change. Change subject: KUDU-2088: Synchronizer may not go out of scope with outstanding references .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7562/1//COMMIT_MSG

[kudu-CR](branch-1.3.x) KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA

Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [docs] guide on assertions in the Java code

Todd Lipcon has posted comments on this change. Change subject: [docs] guide on assertions in the Java code .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7549 To unsubscribe, visit

[kudu-CR] [docs] guide on assertions in the Java code

Todd Lipcon has submitted this change and it was merged. Change subject: [docs] guide on assertions in the Java code .. [docs] guide on assertions in the Java code Added guide on using assert and Guava Preconditions in the

[kudu-CR] KUDU-2060. Show primary keys in the master's table web UI page

Todd Lipcon has posted comments on this change. Change subject: KUDU-2060. Show primary keys in the master's table web UI page .. Patch Set 2: (1 comment)

[kudu-CR] Expose running maintenance op info

Todd Lipcon has posted comments on this change. Change subject: Expose running maintenance op info .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7537/2/src/kudu/util/maintenance_manager.h File

[kudu-CR] KUDU-2060. Show primary keys in the master's table web UI page

srisaikumarravip...@inspur.com has posted comments on this change. Change subject: KUDU-2060. Show primary keys in the master's table web UI page .. Patch Set 4: The issues should be resolved now - Sri Sai Kumar -- To view,

[kudu-CR] KUDU-2060. Show primary keys in the master's table web UI page

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7555 to look at the new patch set (#4). Change subject: KUDU-2060. Show primary keys in the master's table web UI page

[kudu-CR] KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA

Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA .. KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA

[kudu-CR] Add metrics for tablet state and tablet copy

Adar Dembo has posted comments on this change. Change subject: Add metrics for tablet state and tablet copy .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7540/1//COMMIT_MSG Commit Message: PS1, Line 9:

[kudu-CR](branch-1.4.x) KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA

Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Expose running maintenance op info

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7537 to look at the new patch set (#3). Change subject: Expose running maintenance op info .. Expose running

[kudu-CR](branch-1.3.x) KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA

Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA .. KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA

[kudu-CR] KUDU-2060. Show primary keys in the master's table web UI page

srisaikumarravip...@inspur.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/7555 Change subject: KUDU-2060. Show primary keys in the master's table web UI page .. KUDU-2060. Show primary keys in the

[kudu-CR] tool: print usage information when arguments fail to parse

Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7301 to look at the new patch set (#3). Change subject: tool: print usage information when arguments fail to parse

[kudu-CR] raft consensus-itest: don't assume SIGSTOP is synchronous

Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7557 to review the following change. Change subject: raft_consensus-itest: don't assume SIGSTOP is synchronous ..

[kudu-CR] KUDU-2060. Show primary keys in the master's table web UI page

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7555 to look at the new patch set (#3). Change subject: KUDU-2060. Show primary keys in the master's table web UI page

[kudu-CR] disk failure: add persistent disk states

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#6). Change subject: disk failure: add persistent disk states .. disk failure: add

[kudu-CR] log block manager: mark container as read-only after syncing error

Adar Dembo has submitted this change and it was merged. Change subject: log block manager: mark container as read-only after syncing error .. log block manager: mark container as read-only after syncing error Currently,

[kudu-CR] [docs] fixed typos in raft-config-change.md

Todd Lipcon has submitted this change and it was merged. Change subject: [docs] fixed typos in raft-config-change.md .. [docs] fixed typos in raft-config-change.md Change-Id: Ie1f43915b5f2a393957bc0d6b9e120f7419c72b1

[kudu-CR] [docs] fixed typos in raft-config-change.md

Todd Lipcon has posted comments on this change. Change subject: [docs] fixed typos in raft-config-change.md .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7548 To unsubscribe, visit

[kudu-CR](branch-1.4.x) KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA

Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA .. KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA

[kudu-CR] KUDU-2060. Show primary keys in the master's table web UI page

Todd Lipcon has posted comments on this change. Change subject: KUDU-2060. Show primary keys in the master's table web UI page .. Patch Set 1: (1 comment)

[kudu-CR] tool: print usage information when arguments fail to parse

Adar Dembo has posted comments on this change. Change subject: tool: print usage information when arguments fail to parse .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7301 To unsubscribe,

[kudu-CR] [tools] Address potential flakiness of TestMoveTablet

Todd Lipcon has submitted this change and it was merged. Change subject: [tools] Address potential flakiness of TestMoveTablet .. [tools] Address potential flakiness of TestMoveTablet There's a few potential sources of

[kudu-CR] Expose running maintenance op info

Sam Okrent has posted comments on this change. Change subject: Expose running maintenance op info .. Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/7537/2/src/kudu/tserver/tserver-path-handlers.h File

[kudu-CR] consensus peers: capture weak refs in functors submitted to thread pools

Adar Dembo has posted comments on this change. Change subject: consensus_peers: capture weak refs in functors submitted to thread pools .. Patch Set 3: > Maybe worth looping raft_consensus-itest a bunch before committing >

[kudu-CR] consensus peers: capture weak refs in functors submitted to thread pools

Adar Dembo has submitted this change and it was merged. Change subject: consensus_peers: capture weak refs in functors submitted to thread pools .. consensus_peers: capture weak refs in functors submitted to thread pools By

[kudu-CR] raft consensus-itest: don't assume SIGSTOP is synchronous

Todd Lipcon has posted comments on this change. Change subject: raft_consensus-itest: don't assume SIGSTOP is synchronous .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7557 To unsubscribe,

[kudu-CR] KUDU-2060. Show primary keys in the master's table web UI page

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7555 to look at the new patch set (#2). Change subject: KUDU-2060. Show primary keys in the master's table web UI page

[kudu-CR](branch-1.3.x) KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA

Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/7554 Change subject: KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA .. KUDU-2087. Fix failure to map Kerberos

[kudu-CR](branch-1.4.x) KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA

Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/7553 Change subject: KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA .. KUDU-2087. Fix failure to map Kerberos

[kudu-CR] KUDU-2060. Show primary keys in the master's table web UI page

Todd Lipcon has posted comments on this change. Change subject: KUDU-2060. Show primary keys in the master's table web UI page .. Patch Set 1: (3 comments)

[kudu-CR] KUDU-2060. Show primary keys in the master's table web UI page

Todd Lipcon has posted comments on this change. Change subject: KUDU-2060. Show primary keys in the master's table web UI page .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7555/4//COMMIT_MSG Commit Message:

[kudu-CR] Add metrics for tablet state and tablet copy

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7540 to look at the new patch set (#3). Change subject: Add metrics for tablet state and tablet copy .. Add metrics for

[kudu-CR] Add metrics for tablet state and tablet copy

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7540 to look at the new patch set (#4). Change subject: Add metrics for tablet state and tablet copy .. Add metrics for

[kudu-CR] Add metrics for tablet state and tablet copy

Will Berkeley has posted comments on this change. Change subject: Add metrics for tablet state and tablet copy .. Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/7540/1//COMMIT_MSG Commit Message: PS1, Line 9:

[kudu-CR] [docs] guide on assertions in the Java code

Alexey Serbin has posted comments on this change. Change subject: [docs] guide on assertions in the Java code .. Patch Set 2: Verified+1 Unrelated flakes in: RaftConsensusITest.TestReplicaBehaviorViaRPC

[kudu-CR] [docs] guide on assertions in the Java code

Alexey Serbin has uploaded a new patch set (#2). Change subject: [docs] guide on assertions in the Java code .. [docs] guide on assertions in the Java code Added guide on using assert and Guava Preconditions in the Kudu Java

[kudu-CR] Add metrics for tablet state and tablet copy

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7540 to look at the new patch set (#2). Change subject: Add metrics for tablet state and tablet copy .. Add metrics for

[kudu-CR] KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA

Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7551 to review the following change. Change subject: KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA

[kudu-CR] disk failure: add persistent disk states

Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 5: (44 comments) I know there are already comments on some of these, but I've moved some of the changes to

[kudu-CR] disk failure: add persistent disk states

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#5). Change subject: disk failure: add persistent disk states .. disk failure: add

[kudu-CR] KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA

Alexey Serbin has posted comments on this change. Change subject: KUDU-2087. Fix failure to map Kerberos principal to username with FreeIPA .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7551

[kudu-CR] KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

Andrew Wong has posted comments on this change. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. Patch Set 1: Code-Review+1 (1 comment) Comment nit, otherwise lgtm