[kudu-CR] WIP [raft consensus-itest] proper fix for Test KUDU 1735

2018-01-09 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8989 to look at the new patch set (#2). Change subject: WIP [raft_consensus-itest] proper fix for Test_KUDU_1735

[kudu-CR] [raft consensus-itest] proper fix for Test KUDU 1735

2018-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Adar Dembo from this change. ( http://gerrit.cloudera.org:8080/8989 ) Change subject: [raft_consensus-itest] proper fix for Test_KUDU_1735 .. Removed reviewer Adar Dembo. -- To view, visit

[kudu-CR] KUDU-2202: support for removing data directories (take two)

2018-01-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8978 ) Change subject: KUDU-2202: support for removing data directories (take two) .. Patch Set 1: (8 comments)

[kudu-CR] [raft consensus-itest] proper fix for Test KUDU 1735

2018-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8989 Change subject: [raft_consensus-itest] proper fix for Test_KUDU_1735 .. [raft_consensus-itest] proper fix for Test_KUDU_1735 Adapted

[kudu-CR] Adding a subsection to NTP troubleshooting section to cover frequent cases of NTP crashes when the Kudu cluster is deployed on Microsoft Azure

2018-01-09 Thread Mahdi Askari (Code Review)
Hello Alex Rodoni, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8960 to look at the new patch set (#3). Change subject: Adding a subsection to NTP troubleshooting section to cover frequent cases of NTP crashes when the Kudu

[kudu-CR] Adding a subsection to NTP troubleshooting section to cover frequent cases of NTP crashes when the Kudu cluster is deployed on Microsoft Azure

2018-01-09 Thread Mahdi Askari (Code Review)
Hello Alex Rodoni, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8960 to look at the new patch set (#2). Change subject: Adding a subsection to NTP troubleshooting section to cover frequent cases of NTP crashes when the Kudu

[kudu-CR] Adding a subsection to NTP troubleshooting section to cover frequent cases of NTP crashes when the Kudu cluster is deployed on Microsoft Azure

2018-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8960 ) Change subject: Adding a subsection to NTP troubleshooting section to cover frequent cases of NTP crashes when the Kudu cluster is deployed on Microsoft Azure

[kudu-CR] KUDU-2115: avoid compacting already-compacted rowsets

2018-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8859 ) Change subject: KUDU-2115: avoid compacting already-compacted rowsets .. KUDU-2115: avoid compacting already-compacted rowsets

[kudu-CR] KUDU-2115: avoid compacting already-compacted rowsets

2018-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8859 ) Change subject: KUDU-2115: avoid compacting already-compacted rowsets .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] Fixup DeltaStats::ToString

2018-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8988 ) Change subject: Fixup DeltaStats::ToString .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8988 To

[kudu-CR] Fixup DeltaStats::ToString

2018-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8988 ) Change subject: Fixup DeltaStats::ToString .. Fixup DeltaStats::ToString Simplifies the implementation and fixes the mismatched

[kudu-CR] [webui] Make tombstone tablet info less confusing

2018-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8981 ) Change subject: [webui] Make tombstone tablet info less confusing .. Patch Set 2: (2 comments)

[kudu-CR] [webui] Make tombstone tablet info less confusing

2018-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8981 ) Change subject: [webui] Make tombstone tablet info less confusing .. Patch Set 1: > > Build Failed > > Alexey is fixing the last few

[kudu-CR] KUDU-2202: support for removing data directories (take two)

2018-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8978 ) Change subject: KUDU-2202: support for removing data directories (take two) .. Patch Set 2: Verified+1 The test failures were a batch of

[kudu-CR] KUDU-2202: support for removing data directories (take two)

2018-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8978 ) Change subject: KUDU-2202: support for removing data directories (take two) .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] Fixup DeltaStats::ToString

2018-01-09 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8988 to review the following change. Change subject: Fixup DeltaStats::ToString .. Fixup DeltaStats::ToString Simplifies

[kudu-CR] [raft consensus-itest] fix for Test KUDU 1735

2018-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8987 ) Change subject: [raft_consensus-itest] fix for Test_KUDU_1735 .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR] [raft consensus-itest] fix for Test KUDU 1735

2018-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8987 ) Change subject: [raft_consensus-itest] fix for Test_KUDU_1735 .. [raft_consensus-itest] fix for Test_KUDU_1735 Quick fir for

[kudu-CR] [raft consensus-itest] fix for Test KUDU 1735

2018-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8987 ) Change subject: [raft_consensus-itest] fix for Test_KUDU_1735 .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [raft consensus-itest] fix for Test KUDU 1735

2018-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8987 Change subject: [raft_consensus-itest] fix for Test_KUDU_1735 .. [raft_consensus-itest] fix for Test_KUDU_1735 Quick fir for

[kudu-CR] KUDU-2253 Deltafile on-disk size is 3x larger than expected

2018-01-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8982 ) Change subject: KUDU-2253 Deltafile on-disk size is 3x larger than expected .. Patch Set 1: The failures are known issues from another

[kudu-CR] [webui] Make tombstone tablet info less confusing

2018-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8981 ) Change subject: [webui] Make tombstone tablet info less confusing .. Patch Set 1: > Build Failed Alexey is fixing the last few tests

[kudu-CR] [tests] update tests for replication scheme consistency

2018-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8979 ) Change subject: [tests] update tests for replication scheme consistency .. [tests] update tests for replication scheme

[kudu-CR] [tests] update tests for replication scheme consistency

2018-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8979 ) Change subject: [tests] update tests for replication scheme consistency .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] [tests] update tests for replication scheme consistency

2018-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8979 ) Change subject: [tests] update tests for replication scheme consistency .. Patch Set 2: Verified+1 Will fix

[kudu-CR] WIP: move fake xml file generation to run-test.sh

2018-01-09 Thread Mike Percy (Code Review)
Hello Edward Fancher, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8984 to review the following change. Change subject: WIP: move fake xml file generation to run-test.sh .. WIP: move

[kudu-CR] KUDU-2233 Add a test case for compactions in the past

2018-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8885 ) Change subject: KUDU-2233 Add a test case for compactions in the past .. Patch Set 7: (4 comments)

[kudu-CR] KUDU-2253 Deltafile on-disk size is 3x larger than expected

2018-01-09 Thread Dan Burkert (Code Review)
Hello Will Berkeley, Grant Henke, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8982 to review the following change. Change subject: KUDU-2253 Deltafile on-disk size is 3x larger than expected

[kudu-CR] [webui] Make tombstone tablet info less confusing

2018-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8981 Change subject: [webui] Make tombstone tablet info less confusing .. [webui] Make tombstone tablet info less confusing Previously, when

[kudu-CR] [mvcc] Fix watermark advancement in the absence of committed transactions

2018-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8964 ) Change subject: [mvcc] Fix watermark advancement in the absence of committed transactions .. [mvcc] Fix watermark advancement in

[kudu-CR] Add some DVLOG statements to help in debugging compaction issues

2018-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8886 ) Change subject: Add some DVLOG statements to help in debugging compaction issues .. Add some DVLOG statements to help in

[kudu-CR] [tests] update tests for replication scheme consistency

2018-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8979 ) Change subject: [tests] update tests for replication scheme consistency .. Patch Set 1: > What about the raft_consensus-itest failure?

[kudu-CR] [tests] update tests for replication scheme consistency

2018-01-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8979 to look at the new patch set (#2). Change subject: [tests] update tests for replication scheme consistency

[kudu-CR] [tests] update tests for replication scheme consistency

2018-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8979 ) Change subject: [tests] update tests for replication scheme consistency .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [tests] update tests for replication scheme consistency

2018-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8979 ) Change subject: [tests] update tests for replication scheme consistency .. Patch Set 1: Code-Review+2 What about the raft_consensus-itest

[kudu-CR](branch-1.5.x) Add 'kudu fs list' tool

2018-01-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8970 ) Change subject: Add 'kudu fs list' tool .. Patch Set 1: Yep, only issue here was the change of Arena's ctor from 2 args to 1. I just

[kudu-CR](branch-1.6.x) Add 'kudu fs list' tool

2018-01-09 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8967 ) Change subject: Add 'kudu fs list' tool .. Add 'kudu fs list' tool This tool aims to replace exploratory usages of 'kudu fs

[kudu-CR](branch-1.5.x) Add 'kudu fs list' tool

2018-01-09 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8970 ) Change subject: Add 'kudu fs list' tool .. Add 'kudu fs list' tool This tool aims to replace exploratory usages of 'kudu fs

[kudu-CR] Add some DVLOG statements to help in debugging compaction issues

2018-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8886 ) Change subject: Add some DVLOG statements to help in debugging compaction issues .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [mvcc] Fix watermark advancement in the absence of committed transactions

2018-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8964 ) Change subject: [mvcc] Fix watermark advancement in the absence of committed transactions .. Patch Set 2: Code-Review+2 -- To view,

[kudu-CR] fs: defer failure from metadata load to bootstrap when data dir is missing

2018-01-09 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8376 to look at the new patch set (#3). Change subject: fs: defer failure from metadata load to bootstrap when data dir is missing

[kudu-CR] KUDU-2202: support for removing data directories (take two)

2018-01-09 Thread Adar Dembo (Code Review)
Hello Andrew Wong, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8978 to review the following change. Change subject: KUDU-2202: support for removing data directories (take two)

[kudu-CR](branch-1.6.x) Add 'kudu fs list' tool

2018-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8967 ) Change subject: Add 'kudu fs list' tool .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8967 To

[kudu-CR](branch-1.5.x) Add 'kudu fs list' tool

2018-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8970 ) Change subject: Add 'kudu fs list' tool .. Patch Set 1: Code-Review+2 Looks like a faithful backport -- To view, visit

[kudu-CR] fs: defer failure from metadata load to bootstrap when data dir is missing

2018-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8376 ) Change subject: fs: defer failure from metadata load to bootstrap when data dir is missing .. Patch Set 2: (6 comments)

[kudu-CR] fs: defer failure from metadata load to bootstrap when data dir is missing

2018-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has restored this change. ( http://gerrit.cloudera.org:8080/8376 ) Change subject: fs: defer failure from metadata load to bootstrap when data dir is missing .. Restored -- To view, visit

[kudu-CR](gh-pages) docs refresh

2018-01-09 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8974 Change subject: docs refresh .. docs refresh Change-Id: I07d899da6ea7107f1e01c82d88b1a32583b57a54 --- M docs/administration.html M

[kudu-CR] KUDU-2233 Add a test case for compactions in the past

2018-01-09 Thread David Ribeiro Alves (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8885 to look at the new patch set (#7). Change subject: KUDU-2233 Add a test case for compactions in the past

[kudu-CR] KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

2018-01-09 Thread Edward Fancher (Code Review)
Hello Mike Percy, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8757 to look at the new patch set (#14). Change subject: KUDU-2216. Post process gtest generated xml to include the output from the

[kudu-CR] KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client)

2018-01-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8830 ) Change subject: KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client) .. Patch Set 1: (25 comments) I need to tweak the

[kudu-CR] KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client)

2018-01-09 Thread Grant Henke (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8830 to look at the new patch set (#7). Change subject: KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client)

[kudu-CR] [mvcc] Fix watermark advancement in the absence of committed transactions

2018-01-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8964 ) Change subject: [mvcc] Fix watermark advancement in the absence of committed transactions .. Patch Set 2: Verified+1 Unrelated

[kudu-CR] [mvcc] Fix watermark advancement in the absence of committed transactions

2018-01-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has removed a vote on this change. Change subject: [mvcc] Fix watermark advancement in the absence of committed transactions .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit