[kudu-CR] [java client] Make row errors more readable

2023-08-01 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20163 ) Change subject: [java client] Make row errors more readable .. Patch Set 6: Verified+1 Code-Review+2 Unrelated test failure in

[kudu-CR] [java client] Make row errors more readable

2023-08-01 Thread Yifan Zhang (Code Review)
Yifan Zhang has removed a vote on this change. Change subject: [java client] Make row errors more readable .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20163 To unsubscribe,

[kudu-CR] [java client] Make row errors more readable

2023-08-01 Thread Yifan Zhang (Code Review)
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20163 ) Change subject: [java client] Make row errors more readable .. [java client] Make row errors more readable Flushing data in

[kudu-CR] [java client] Make row errors more readable

2023-08-01 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20163 ) Change subject: [java client] Make row errors more readable .. Patch Set 6: > Patch Set 5: Code-Review+1 > > The lint failure report by

[kudu-CR] [duplication] KUDU-3290 Support write ops to kafka with kafka client

2023-08-01 Thread Yuqi Du (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19909 to look at the new patch set (#7). Change subject: [duplication] KUDU-3290 Support write ops to kafka with kafka client

[kudu-CR] [common] minor optimization on ComputeHashBuckets

2023-08-01 Thread Yuqi Du (Code Review)
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/20288 ) Change subject: [common] minor optimization on ComputeHashBuckets .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] [java client] Make row errors more readable

2023-08-01 Thread Wang Xixu (Code Review)
Hello Alexey Serbin, Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20163 to look at the new patch set (#6). Change subject: [java client] Make row errors more readable

[kudu-CR](branch-1.17.x) [docs] Update 1.17.0 release notes

2023-08-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20293 Change subject: [docs] Update 1.17.0 release notes .. [docs] Update 1.17.0 release notes Change-Id:

[kudu-CR] logging.cc: Call GetLoggingDirectories before first write

2023-08-01 Thread Marton Greber (Code Review)
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20292 ) Change subject: logging.cc: Call GetLoggingDirectories before first write .. Patch Set 2: (2 comments)

[kudu-CR](branch-1.17.x) [docs] Update 1.17.0 release notes

2023-08-01 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20293 to look at the new patch set (#3). Change subject: [docs] Update 1.17.0 release notes .. [docs] Update 1.17.0

[kudu-CR](branch-1.17.x) [docs] Update 1.17.0 release notes

2023-08-01 Thread Yingchun Lai (Code Review)
Hello Zoltan Martonka, Kudu Jenkins, Song Jiacheng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20293 to look at the new patch set (#4). Change subject: [docs] Update 1.17.0 release notes

[kudu-CR](branch-1.17.x) [docs] Update 1.17.0 release notes

2023-08-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20293 ) Change subject: [docs] Update 1.17.0 release notes .. [docs] Update 1.17.0 release notes Change-Id:

[kudu-CR] [common] minor optimization on ComputeHashBuckets

2023-08-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20288 ) Change subject: [common] minor optimization on ComputeHashBuckets .. Patch Set 1: Code-Review+2 > Patch Set 1: Code-Review+1 > > (1

[kudu-CR] [common] minor optimization on ComputeHashBuckets

2023-08-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20288 ) Change subject: [common] minor optimization on ComputeHashBuckets .. [common] minor optimization on ComputeHashBuckets It's

[kudu-CR] [client] Avoid impala crash by returning error if invalid tablet id found

2023-08-01 Thread Ashwani Raina (Code Review)
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20270 ) Change subject: [client] Avoid impala crash by returning error if invalid tablet id found .. Patch Set 3: (7 comments)

[kudu-CR] [client] Avoid impala crash by returning error if invalid tablet id found

2023-08-01 Thread Ashwani Raina (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20270 to look at the new patch set (#4). Change subject: [client] Avoid impala crash by returning error if invalid tablet id found

[kudu-CR](branch-1.17.x) [compile] fix a compile warning

2023-08-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20290 ) Change subject: [compile] fix a compile warning .. [compile] fix a compile warning I noticed that there is a warning during

[kudu-CR](branch-1.17.x) [java client] Make row errors more readable

2023-08-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [java client] Make row errors more readable .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20291 To unsubscribe,

[kudu-CR](branch-1.17.x) [compile] fix a compile warning

2023-08-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [compile] fix a compile warning .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20290 To unsubscribe, visit

[kudu-CR](branch-1.17.x) [compile] fix a compile warning

2023-08-01 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/20290 to review the following change. Change subject: [compile] fix a compile warning .. [compile] fix a

[kudu-CR](branch-1.17.x) [java client] Make row errors more readable

2023-08-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20291 ) Change subject: [java client] Make row errors more readable .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR](branch-1.17.x) [java client] Make row errors more readable

2023-08-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20291 ) Change subject: [java client] Make row errors more readable .. [java client] Make row errors more readable Flushing data in

[kudu-CR](branch-1.17.x) [java client] Make row errors more readable

2023-08-01 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20291 ) Change subject: [java client] Make row errors more readable .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR](branch-1.17.x) [docs] Update 1.17.0 release notes

2023-08-01 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20293 to look at the new patch set (#2). Change subject: [docs] Update 1.17.0 release notes .. [docs] Update 1.17.0

[kudu-CR] logging.cc: Call GetLoggingDirectories before first write

2023-08-01 Thread Code Review
Ádám Bakai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20292 Change subject: logging.cc: Call GetLoggingDirectories before first write .. logging.cc: Call GetLoggingDirectories before first write

[kudu-CR] logging.cc: Call GetLoggingDirectories before first write

2023-08-01 Thread Code Review
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20292 to look at the new patch set (#2). Change subject: logging.cc: Call GetLoggingDirectories before first write ..

[kudu-CR](branch-1.17.x) [java client] Make row errors more readable

2023-08-01 Thread Yingchun Lai (Code Review)
Hello Yifan Zhang, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/20291 to review the following change. Change subject: [java client] Make row errors more readable .. [java client] Make

[kudu-CR](branch-1.17.x) [compile] fix a compile warning

2023-08-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20290 ) Change subject: [compile] fix a compile warning .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit

[kudu-CR](branch-1.17.x) [java client] Make row errors more readable

2023-08-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20291 ) Change subject: [java client] Make row errors more readable .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] logging.cc: Call GetLoggingDirectories before first write

2023-08-01 Thread Code Review
Ádám Bakai has abandoned this change. ( http://gerrit.cloudera.org:8080/20016 ) Change subject: logging.cc: Call GetLoggingDirectories before first write .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/20016 To

[kudu-CR] a

2023-08-01 Thread Code Review
Ádám Bakai has abandoned this change. ( http://gerrit.cloudera.org:8080/20161 ) Change subject: a .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/20161 To unsubscribe, visit

[kudu-CR](branch-1.17.x) [docs] Update 1.17.0 release notes

2023-08-01 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20293 ) Change subject: [docs] Update 1.17.0 release notes .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] Change order of operations during InitCatalogManagerTask

2023-08-01 Thread Code Review
Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19639 ) Change subject: Change order of operations during InitCatalogManagerTask .. Patch Set 5: > > Patch Set 4: > > > > > Thanks for

[kudu-CR] [docs] Add 1.16.0 release notes to previous release notes

2023-08-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20296 Change subject: [docs] Add 1.16.0 release notes to previous release notes .. [docs] Add 1.16.0 release notes to previous release notes

[kudu-CR] [client] Avoid impala crash by returning error if invalid tablet id found

2023-08-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20270 ) Change subject: [client] Avoid impala crash by returning error if invalid tablet id found .. Patch Set 3: (1 comment)

[kudu-CR] [docs] Add 1.16.0 release notes to previous release notes

2023-08-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20296 ) Change subject: [docs] Add 1.16.0 release notes to previous release notes .. Patch Set 2: The newly added doc can be previewed in

[kudu-CR] [common] minor optimization on ComputeHashBuckets

2023-08-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20288 ) Change subject: [common] minor optimization on ComputeHashBuckets .. Patch Set 1: (1 comment)

[kudu-CR] [docs] Add 1.16.0 release notes to previous release notes

2023-08-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20296 ) Change subject: [docs] Add 1.16.0 release notes to previous release notes .. Patch Set 2: The master branch lack of the 1.16.0 release

[kudu-CR] [docs] Add 1.16.0 release notes to previous release notes

2023-08-01 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20296 to look at the new patch set (#2). Change subject: [docs] Add 1.16.0 release notes to previous release notes ..

[kudu-CR] [client] Avoid impala crash by returning error if invalid tablet id found

2023-08-01 Thread Ashwani Raina (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20270 to look at the new patch set (#5). Change subject: [client] Avoid impala crash by returning error if invalid tablet id found

[kudu-CR] [docs] Add 1.16.0 release notes to previous release notes

2023-08-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20296 ) Change subject: [docs] Add 1.16.0 release notes to previous release notes .. [docs] Add 1.16.0 release notes to previous

[kudu-CR] [docs] Add 1.16.0 release notes to previous release notes

2023-08-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20296 ) Change subject: [docs] Add 1.16.0 release notes to previous release notes .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.17.x) [docs] Add 1.16.0 release notes to previous release notes

2023-08-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20298 ) Change subject: [docs] Add 1.16.0 release notes to previous release notes .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.17.x) [docs] Add 1.16.0 release notes to previous release notes

2023-08-01 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/20298 to review the following change. Change subject: [docs] Add 1.16.0 release notes to previous release notes

[kudu-CR] [docker] fix docker buildx error

2023-08-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20299 Change subject: [docker] fix docker buildx error .. [docker] fix docker buildx error Fix the failure of build docker images, the error

[kudu-CR](branch-1.17.x) [docs] Add 1.16.0 release notes to previous release notes

2023-08-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20298 ) Change subject: [docs] Add 1.16.0 release notes to previous release notes .. [docs] Add 1.16.0 release notes to previous