[kudu-CR] [log] use THROTTLE MSG for KLOG EVERY N SECS when necessary

2024-01-04 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20855 ) Change subject: [log] use THROTTLE_MSG for KLOG_EVERY_N_SECS when necessary .. [log] use THROTTLE_MSG for

[kudu-CR] [WIP] Increase AssertEventually timeout to 60 seconds

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20846 ) Change subject: [WIP] Increase AssertEventually timeout to 60 seconds .. Patch Set 3: (2 comments)

[kudu-CR] Do not enter ALTERING state just for replication factor changed.

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20830 ) Change subject: Do not enter ALTERING state just for replication factor changed. .. Do not enter ALTERING state just for

[kudu-CR] Do not enter ALTERING state just for replication factor changed.

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20830 ) Change subject: Do not enter ALTERING state just for replication factor changed. .. Patch Set 10: Code-Review+2 (1 comment) Thank

[kudu-CR] [java] add sequenceId into the tracked RPCs' trace

2024-01-04 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20857 ) Change subject: [java] add sequenceId into the tracked RPCs' trace .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [java] fix NPE in Connection::exceptionCaught()

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20858 Change subject: [java] fix NPE in Connection::exceptionCaught() .. [java] fix NPE in Connection::exceptionCaught() Before this patch,

[kudu-CR] [log] use THROTTLE MSG for KLOG EVERY N SECS when necessary

2024-01-04 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20855 ) Change subject: [log] use THROTTLE_MSG for KLOG_EVERY_N_SECS when necessary .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [log] use THROTTLE MSG for KLOG EVERY N SECS when necessary

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20855 Change subject: [log] use THROTTLE_MSG for KLOG_EVERY_N_SECS when necessary .. [log] use THROTTLE_MSG for KLOG_EVERY_N_SECS when

[kudu-CR] [java] add sequenceId into the tracked RPCs' trace

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20857 Change subject: [java] add sequenceId into the tracked RPCs' trace .. [java] add sequenceId into the tracked RPCs' trace This patch

[kudu-CR] [java] add sequenceId into the tracked RPCs' trace

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20857 ) Change subject: [java] add sequenceId into the tracked RPCs' trace .. [java] add sequenceId into the tracked RPCs' trace This

[kudu-CR] [docs] updated info on the C++ standard used in Kudu code

2024-01-04 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20859 ) Change subject: [docs] updated info on the C++ standard used in Kudu code .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [docs] updated info on the C++ standard used in Kudu code

2024-01-04 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20859 ) Change subject: [docs] updated info on the C++ standard used in Kudu code .. [docs] updated info on the C++ standard used

[kudu-CR] [fs] Simplify the data directory inheritance hierarchy

2024-01-04 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20833 ) Change subject: [fs] Simplify the data directory inheritance hierarchy .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3252: Follow up to replica placement bug

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20827 ) Change subject: KUDU-3252: Follow up to replica placement bug .. KUDU-3252: Follow up to replica placement bug This patch

[kudu-CR] [docs] updated info on the C++ standard used in Kudu code

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20859 Change subject: [docs] updated info on the C++ standard used in Kudu code .. [docs] updated info on the C++ standard used in Kudu code

[kudu-CR] [java] fix NPE in Connection::exceptionCaught()

2024-01-04 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20858 ) Change subject: [java] fix NPE in Connection::exceptionCaught() .. [java] fix NPE in Connection::exceptionCaught() Before

[kudu-CR] [java] fix NPE in Connection::exceptionCaught()

2024-01-04 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20858 ) Change subject: [java] fix NPE in Connection::exceptionCaught() .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3252: Follow up to replica placement bug

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20827 ) Change subject: KUDU-3252: Follow up to replica placement bug .. Patch Set 2: Verified+1 unrelated test failures -- To view, visit

[kudu-CR] KUDU-3252: Follow up to replica placement bug

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20827 ) Change subject: KUDU-3252: Follow up to replica placement bug .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.17.x) KUDU-3252: Follow up to replica placement bug

2024-01-04 Thread Mahesh Reddy (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/20861 to review the following change. Change subject: KUDU-3252: Follow up to replica placement bug .. KUDU-3252: Follow

[kudu-CR] [fs] Simplify the data directory inheritance hierarchy

2024-01-04 Thread Yifan Zhang (Code Review)
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20833 ) Change subject: [fs] Simplify the data directory inheritance hierarchy .. [fs] Simplify the data directory inheritance hierarchy

[kudu-CR] Do not enter ALTERING state just for replication factor changed.

2024-01-04 Thread Song Jiacheng (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20830 to look at the new patch set (#9). Change subject: Do not enter ALTERING state just for replication factor changed.

[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2024-01-04 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Alexey Serbin, Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20715 to look at the new patch set (#20). Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client.

[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2024-01-04 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Alexey Serbin, Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20715 to look at the new patch set (#21). Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client.

[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2024-01-04 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Alexey Serbin, Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20715 to look at the new patch set (#23). Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client.

[kudu-CR] Do not enter ALTERING state just for replication factor changed.

2024-01-04 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20830 ) Change subject: Do not enter ALTERING state just for replication factor changed. .. Patch Set 9: (2 comments)

[kudu-CR] [WIP] Increase AssertEventually timeout to 60 seconds

2024-01-04 Thread Code Review
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20846 to look at the new patch set (#2). Change subject: [WIP] Increase AssertEventually timeout to 60 seconds .. [WIP]

[kudu-CR] Do not enter ALTERING state just for replication factor changed.

2024-01-04 Thread Song Jiacheng (Code Review)
Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20830 ) Change subject: Do not enter ALTERING state just for replication factor changed. .. Patch Set 9: (2 comments) > Patch Set 9: > > (2

[kudu-CR] Do not enter ALTERING state just for replication factor changed.

2024-01-04 Thread Song Jiacheng (Code Review)
Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20830 ) Change subject: Do not enter ALTERING state just for replication factor changed. .. Patch Set 9: (3 comments) > Patch Set 6: > > (2

[kudu-CR] Do not enter ALTERING state just for replication factor changed.

2024-01-04 Thread Song Jiacheng (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20830 to look at the new patch set (#10). Change subject: Do not enter ALTERING state just for replication factor changed.

[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2024-01-04 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Alexey Serbin, Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20715 to look at the new patch set (#22). Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client.

[kudu-CR] [WIP] Increase AssertEventually timeout to 60 seconds

2024-01-04 Thread Code Review
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20846 to look at the new patch set (#3). Change subject: [WIP] Increase AssertEventually timeout to 60 seconds .. [WIP]

[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2024-01-04 Thread Song Jiacheng (Code Review)
Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20715 ) Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. .. Patch Set 23: (13 comments) Thanks for the