[kudu-CR] KUDU-1834 Don't redact KuduRowResult::ToString()

2017-03-01 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6222 Change subject: KUDU-1834 Don't redact KuduRowResult::ToString() .. KUDU-1834 Don't redact KuduRowResult::ToString() A user on the client

[kudu-CR] [rpc] removed unused deadline member in RetriableRpc

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [rpc] removed unused deadline_ member in RetriableRpc .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6221 To unsubscribe, visit

[kudu-CR] [rpc] removed unused deadline member in RetriableRpc

2017-03-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6221 Change subject: [rpc] removed unused deadline_ member in RetriableRpc .. [rpc] removed unused deadline_ member in RetriableRpc

[kudu-CR] [security] Add per-connection nonce for Kerberos replay resistance

2017-03-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] Add per-connection nonce for Kerberos replay resistance .. Patch Set 7: (10 comments) http://gerrit.cloudera.org:8080/#/c/6137/7//COMMIT_MSG Commit

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-03-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/6129/8//COMMIT_MSG Commit Message: PS8, Line 20:

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-03-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/6129/8//COMMIT_MSG Commit Message: PS8,

[kudu-CR] WIP/test: enable kerberos by default for all tests

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/6217 Change subject: WIP/test: enable kerberos by default for all tests .. WIP/test: enable kerberos by default for all tests Curious to see

[kudu-CR] mini kdc: log when MiniKDC operations are slow

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: mini_kdc: log when MiniKDC operations are slow .. mini_kdc: log when MiniKDC operations are slow ExternalMiniClusterTest seems to occasionally fail due

[kudu-CR] webserver: add X-Frame-Options header

2017-03-01 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6215 to look at the new patch set (#2). Change subject: webserver: add X-Frame-Options header .. webserver: add

[kudu-CR] webserver: add X-Frame-Options header

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: webserver: add X-Frame-Options header .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6215/1/src/kudu/server/webserver.cc File

[kudu-CR] server: offer a flag to completely disable the web server

2017-03-01 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6216 to review the following change. Change subject: server: offer a flag to completely disable the web server ..

[kudu-CR] [security] Add per-connection nonce for Kerberos replay resistance

2017-03-01 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6137 to look at the new patch set (#7). Change subject: [security] Add per-connection nonce for Kerberos replay resistance

[kudu-CR] webserver: add X-Frame-Options header

2017-03-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: webserver: add X-Frame-Options header .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6215/1/src/kudu/server/webserver.cc File

[kudu-CR] mini kdc: log when MiniKDC operations are slow

2017-03-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: mini_kdc: log when MiniKDC operations are slow .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6214 To unsubscribe, visit

[kudu-CR] KUDU-1887: Add RpcContext::DiscardTransfer()

2017-03-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: KUDU-1887: Add RpcContext::DiscardTransfer() .. Patch Set 3: Test failure seems unrelated:

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-03-01 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6129 to look at the new patch set (#8). Change subject: KUDU-1893 Ensure evaluation of added columns .. KUDU-1893

[kudu-CR] mini kdc: log when MiniKDC operations are slow

2017-03-01 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6214 to review the following change. Change subject: mini_kdc: log when MiniKDC operations are slow .. mini_kdc: log when

[kudu-CR] webserver: add X-Frame-Options header

2017-03-01 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6215 to review the following change. Change subject: webserver: add X-Frame-Options header .. webserver: add

[kudu-CR] KUDU-1887: Add RpcContext::DiscardTransfer()

2017-03-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: KUDU-1887: Add RpcContext::DiscardTransfer() .. Patch Set 3: I will note, respectfully, that this will conflict with a trunk that doesn't include

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-03-01 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6129 to look at the new patch set (#7). Change subject: KUDU-1893 Ensure evaluation of added columns .. KUDU-1893

[kudu-CR] KUDU-1887: Add RpcContext::DiscardTransfer()

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1887: Add RpcContext::DiscardTransfer() .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6212 To unsubscribe, visit

[kudu-CR] KUDU-1887: Add RpcContext::DiscardTransfer()

2017-03-01 Thread Henry Robinson (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6212 to look at the new patch set (#3). Change subject: KUDU-1887: Add RpcContext::DiscardTransfer() .. KUDU-1887: Add

[kudu-CR] KUDU-1887: Add RpcContext::DiscardTransfer()

2017-03-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: KUDU-1887: Add RpcContext::DiscardTransfer() .. Patch Set 1: Sorry, just saw the test comment. Coming up. -- To view, visit

[kudu-CR] KUDU-1887: Add RpcContext::DiscardTransfer()

2017-03-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: KUDU-1887: Add RpcContext::DiscardTransfer() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6212/1/src/kudu/rpc/rpc_context.h File

[kudu-CR] KUDU-1887: Add RpcContext::DiscardTransfer()

2017-03-01 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: KUDU-1887: Add RpcContext::DiscardTransfer() .. KUDU-1887: Add RpcContext::DiscardTransfer() DiscardTransfer() allows RPC handlers to release the memory backing

[kudu-CR] KUDU-1887: Add RpcContext::DiscardTransfer()

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1887: Add RpcContext::DiscardTransfer() .. Patch Set 1: (1 comment) Implementation looks fine, but please add some basic test coverage (eg to

[kudu-CR] KUDU-1887: Add RpcContext::DiscardTransfer()

2017-03-01 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6212 Change subject: KUDU-1887: Add RpcContext::DiscardTransfer() .. KUDU-1887: Add RpcContext::DiscardTransfer() DiscardTransfer() allows

[kudu-CR] WIP: Make ExternalDaemon::StartProcess() handle fault injection

2017-03-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/6211 Change subject: WIP: Make ExternalDaemon::StartProcess() handle fault injection .. WIP: Make ExternalDaemon::StartProcess() handle

[kudu-CR] Java Client: authenticate with login username when using SASL PLAIN

2017-03-01 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Java Client: authenticate with login username when using SASL PLAIN .. Java Client: authenticate with login username when using SASL PLAIN Also tweaks

[kudu-CR] [security] Add per-connection nonce for Kerberos replay resistance

2017-03-01 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6137 to look at the new patch set (#6). Change subject: [security] Add per-connection nonce for Kerberos replay resistance

[kudu-CR] [security] Add per-connection nonce for Kerberos replay resistance

2017-03-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] Add per-connection nonce for Kerberos replay resistance .. Patch Set 5: (3 comments)

[kudu-CR] Destabilize rpc authentication and rpc encryption flags

2017-03-01 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Destabilize rpc_authentication and rpc_encryption flags .. Destabilize rpc_authentication and rpc_encryption flags These flags are not yet ready to be

[kudu-CR] Java Client: authenticate with login username when using SASL PLAIN

2017-03-01 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Java Client: authenticate with login username when using SASL PLAIN .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6209

[kudu-CR] Java Client: authenticate with login username when using SASL PLAIN

2017-03-01 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6209 to review the following change. Change subject: Java Client: authenticate with login username when using SASL PLAIN

[kudu-CR] Bump gflags to 2.2.0

2017-03-01 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Bump gflags to 2.2.0 .. Bump gflags to 2.2.0 Flags can now be specified with dashes instead of underscores‼️️ Change-Id:

[kudu-CR] Destabilize rpc authentication and rpc encryption flags

2017-03-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Destabilize rpc_authentication and rpc_encryption flags .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6208 To unsubscribe, visit

[kudu-CR] Destabilize rpc authentication and rpc encryption flags

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Destabilize rpc_authentication and rpc_encryption flags .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6208 To unsubscribe,

[kudu-CR] Destabilize rpc authentication and rpc encryption flags

2017-03-01 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6208 to review the following change. Change subject: Destabilize rpc_authentication and rpc_encryption flags ..

[kudu-CR] KUDU-1898: /varz page doesn't HTML-escape flag values

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1898: /varz page doesn't HTML-escape flag values .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6173 To unsubscribe, visit

[kudu-CR] KUDU-1898: /varz page doesn't HTML-escape flag values

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1898: /varz page doesn't HTML-escape flag values .. KUDU-1898: /varz page doesn't HTML-escape flag values This fixes the flag values are not

[kudu-CR] [security] use shorter RSA keys in tests

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [security] use shorter RSA keys in tests .. [security] use shorter RSA keys in tests When running tests, use the following RSA private keys: * TSK: 512

[kudu-CR] spark: send authentication credentials to tasks

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: spark: send authentication credentials to tasks .. spark: send authentication credentials to tasks This changes KuduContext to eagerly connect to the

[kudu-CR](branch-1.2.x) KUDU-1904 Don't seek on empty RLE blocks

2017-03-01 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1904 Don't seek on empty RLE blocks .. Patch Set 2: Code-Review+2 Verified+1 Test failure isn't related, although it's an odd one. -- To view, visit

[kudu-CR](branch-1.2.x) KUDU-1904 Don't seek on empty RLE blocks

2017-03-01 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1904 Don't seek on empty RLE blocks .. KUDU-1904 Don't seek on empty RLE blocks Seeking in RLE blocks enforces that the seek position is less

[kudu-CR] Reserve 512 MB of disk space by default

2017-03-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Reserve 512 MB of disk space by default .. Patch Set 1: OK, thanks for reviewing, I'll update this patch with that change. -- To view, visit

[kudu-CR](branch-1.2.x) KUDU-1821. Noisy warning from catalog manager

2017-03-01 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1821. Noisy warning from catalog manager .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6205 To unsubscribe, visit

[kudu-CR](branch-1.2.x) KUDU-1821. Noisy warning from catalog manager

2017-03-01 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1821. Noisy warning from catalog manager .. KUDU-1821. Noisy warning from catalog manager This commit changes the LOG if the catalog manager

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-03-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 6: (9 comments) http://gerrit.cloudera.org:8080/#/c/6129/6/src/kudu/common/column_predicate.cc

[kudu-CR] Bump gflags to 2.2.0

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Bump gflags to 2.2.0 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6207/1//COMMIT_MSG Commit Message: Line 9: Flags can now be specified with

[kudu-CR] Bump gflags to 2.2.0

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Bump gflags to 2.2.0 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6207 To unsubscribe, visit

[kudu-CR] Bump gflags to 2.2.0

2017-03-01 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6207 to review the following change. Change subject: Bump gflags to 2.2.0 .. Bump gflags to 2.2.0 Flags can now be

[kudu-CR](branch-1.2.x) KUDU-1852. KuduTableAlterer should not crash with nullptr arguments

2017-03-01 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1852. KuduTableAlterer should not crash with nullptr arguments .. KUDU-1852. KuduTableAlterer should not crash with nullptr arguments

[kudu-CR](branch-1.2.x) KUDU-1852. KuduTableAlterer should not crash with nullptr arguments

2017-03-01 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1852. KuduTableAlterer should not crash with nullptr arguments .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6204

[kudu-CR] [security] use shorter RSA keys in tests

2017-03-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] use shorter RSA keys in tests .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6194 To unsubscribe, visit

[kudu-CR] [security] use shorter RSA keys in tests

2017-03-01 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6194 to look at the new patch set (#8). Change subject: [security] use shorter RSA keys in tests .. [security] use

[kudu-CR](branch-1.2.x) KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV

2017-03-01 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has submitted this change and it was merged. Change subject: KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV .. KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV The

[kudu-CR] Reserve 512 MB of disk space by default

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Reserve 512 MB of disk space by default .. Patch Set 1: To me, the description you wrote sounds pretty reasonable/understandable. Agreed that at some point

[kudu-CR](branch-1.2.x) KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV

2017-03-01 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6203

[kudu-CR] Workaround a leak in OpenSSL 1.0.0

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Workaround a leak in OpenSSL 1.0.0 .. Workaround a leak in OpenSSL 1.0.0 This fixes another leak seen occasionally as a flaky test on RHEL 6: Direct

[kudu-CR] KUDU-1901. Fix crash in concurrent OpenSSL usage

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1901. Fix crash in concurrent OpenSSL usage .. KUDU-1901. Fix crash in concurrent OpenSSL usage This fixes a crash in which a TLSContext's SSL_CTX

[kudu-CR](branch-1.2.x) KUDU-1880 Prevent eager ignoring of NULLs

2017-03-01 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Abandoned This patch hinges on the presence of IsNull predicates, which are not in 1.2.x. -- To view, visit

[kudu-CR] KUDU-1901. Fix crash in concurrent OpenSSL usage

2017-03-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1901. Fix crash in concurrent OpenSSL usage .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6187 To unsubscribe, visit

[kudu-CR] spark: send authentication credentials to tasks

2017-03-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: spark: send authentication credentials to tasks .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6081 To unsubscribe, visit

[kudu-CR] [security] use shorter RSA keys in tests

2017-03-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] use shorter RSA keys in tests .. Patch Set 7: > Yah I think it's probably simpler to just go back to 1024 on the > JVM. I didn't forsee this

[kudu-CR] Combine redaction flag for log and flags into one.

2017-03-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 17: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6112 To unsubscribe, visit

[kudu-CR] Combine redaction flag for log and flags into one.

2017-03-01 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Combine redaction flag for log and flags into one. .. Combine redaction flag for log and flags into one. This adds a new flag --redact to replace

[kudu-CR] [security] use shorter RSA keys in tests

2017-03-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] use shorter RSA keys in tests .. Patch Set 7: Yah I think it's probably simpler to just go back to 1024 on the JVM. I didn't forsee this complication

[kudu-CR](branch-1.2.x) KUDU-1899. Fix support for empty string keys

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1899. Fix support for empty string keys .. KUDU-1899. Fix support for empty string keys We've never prevented users from inserting a row with "" as

[kudu-CR] [security] use shorter RSA keys in tests

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] use shorter RSA keys in tests .. Patch Set 7: Would like to see Dan's opinion. Just thinking any case we can avoid complexity in our build/test stuff,

[kudu-CR](branch-1.2.x) KUDU-1821. Noisy warning from catalog manager

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/6205 Change subject: KUDU-1821. Noisy warning from catalog manager .. KUDU-1821. Noisy warning from catalog manager This commit changes the

[kudu-CR](branch-1.2.x) KUDU-1852. KuduTableAlterer should not crash with nullptr arguments

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/6204 Change subject: KUDU-1852. KuduTableAlterer should not crash with nullptr arguments .. KUDU-1852. KuduTableAlterer should not crash with

[kudu-CR](branch-1.2.x) KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/6203 Change subject: KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV .. KUDU-1851 - [python] TableAlterer direct

[kudu-CR] [security] use shorter RSA keys in tests

2017-03-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] use shorter RSA keys in tests .. Patch Set 7: > is all of this extra security properties stuff "worth it" to go > from 1024-bit to 768-bit? Well,

[kudu-CR](branch-1.2.x) KUDU-1880 Prevent eager ignoring of NULLs

2017-03-01 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6202 Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. KUDU-1880 Prevent eager ignoring of NULLs During a nullable block scan, if a

[kudu-CR] [security] use shorter RSA keys in tests

2017-03-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] use shorter RSA keys in tests .. Patch Set 7: is all of this extra security properties stuff "worth it" to go from 1024-bit to 768-bit? -- To view,

[kudu-CR](branch-1.2.x) KUDU-1904 Don't seek on empty RLE blocks

2017-03-01 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6201 Change subject: KUDU-1904 Don't seek on empty RLE blocks .. KUDU-1904 Don't seek on empty RLE blocks Seeking in RLE blocks enforces that

[kudu-CR] [security] use shorter RSA keys in tests

2017-03-01 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6194 to look at the new patch set (#6). Change subject: [security] use shorter RSA keys in tests .. [security] use