[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/6066/11/src/kudu/consens

[kudu-CR] KUDU-1607. Unpin tablet flush after failed bootstrap

2017-03-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/6422/3/src/kudu/integration-tests/tablet_dele

[kudu-CR] KUDU-1607. Unpin tablet flush after failed bootstrap

2017-03-20 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6422 to look at the new patch set (#5). Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap .. KUDU-160

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6066/7/src/kudu/consensus

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/6066/12/src/kudu/consens

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 12: (5 comments) http://gerrit.cloudera.org:8080/#/c/6066/11/src/kudu/consen

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 11: (7 comments) http://gerrit.cloudera.org:8080/#/c/6066/11/src/kudu/consen

[kudu-CR] cfile-test: add a 100M-string file with low cardinality

2017-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: cfile-test: add a 100M-string file with low cardinality .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6432/1/src/kudu/cfile/cfile-test-base.h Fi

[kudu-CR] cfile-test: add a 100M-string file with low cardinality

2017-03-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: cfile-test: add a 100M-string file with low cardinality .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6432/1/src/kudu/cfile/cfile-test-b

[kudu-CR] Optimize BinaryDictBlock to use dense hash map, smaller hot path

2017-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Optimize BinaryDictBlock to use dense_hash_map, smaller hot path .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6433/2/src/kudu/cfile/binary_dict

[kudu-CR] KUDU-1607. Unpin tablet flush after failed bootstrap

2017-03-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap .. Patch Set 4: (6 comments) sorry had some comments on an old rev. I checked and most still seem rel

[kudu-CR] compaction-test: use default bloom sizing

2017-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: compaction-test: use default bloom sizing .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6429/2/src/kudu/tablet/compaction-test.cc File src/kudu/

[kudu-CR] cfile writer: inline written size() method

2017-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: cfile_writer: inline written_size() method .. Patch Set 2: Curious whether or not you saw any improvement after making this change (even if not, the change makes

[kudu-CR](gh-pages) Update docs, add 1.3 release

2017-03-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Update docs, add 1.3 release .. Patch Set 1: Code-Review+2 Verified+1 Clicked around and seems to wor. -- To view, visit http://gerrit.cloudera.org:8080/6445 To

[kudu-CR](gh-pages) Update docs, add 1.3 release

2017-03-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Update docs, add 1.3 release .. Update docs, add 1.3 release Change-Id: I17689bb788bd1a8edf5b1374e3cf685d8c8dc2af Reviewed-on: http://gerrit.cloudera.org:

[kudu-CR] key encoder: avoid unordered map for looking up encoders

2017-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: key_encoder: avoid unordered_map for looking up encoders .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6431/2/src/kudu/common/key_encoder.cc Fil

[kudu-CR](gh-pages) Update docs, add 1.3 release

2017-03-20 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6445 to review the following change. Change subject: Update docs, add 1.3 release .. Update docs, add 1.3 release C

[kudu-CR] compaction: fix rowblock size in compaction output

2017-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: compaction: fix rowblock size in compaction output .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6430 To unsubscribe, visit http

[kudu-CR] WIP: client timeout repro test

2017-03-20 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6444 to review the following change. Change subject: WIP: client timeout repro test .. WIP: client timeout repro tes

[kudu-CR] Spark ITBLL

2017-03-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Spark ITBLL .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6419/1/java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/Bi

[kudu-CR] cfile-test: add a 100M-string file with low cardinality

2017-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: cfile-test: add a 100M-string file with low cardinality .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6432/1/src/kudu/cfile/cfile-test-base.h Fi

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-20 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has abandoned this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Abandoned Uploaded to new link by mistake, original patch is in http://gerrit.cloudera.org:808

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-20 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6066 to look at the new patch set (#12). Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-20 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6443 to review the following change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-20 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 11: (22 comments) http://gerrit.cloudera.org:8080/#/c/6066/11//COMMIT_MSG C

[kudu-CR] KUDU-1607. Unpin tablet flush after failed bootstrap

2017-03-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6422/3/src/kudu/tablet/tablet_bootstrap.cc Fil

[kudu-CR] kudu-mapreduce: tweak poms

2017-03-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: kudu-mapreduce: tweak poms .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6418/1//COMMIT_MSG Commit Message: Line 22: fat jar containing kudu-cli

[kudu-CR] KUDU-1607. Unpin tablet flush after failed bootstrap

2017-03-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6422/3/src/kudu/tablet/tablet_bootstrap.cc Fil

[kudu-CR] KUDU-1607. Unpin tablet flush after failed bootstrap

2017-03-20 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6422 to look at the new patch set (#4). Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap .. KUDU-160

[kudu-CR] KUDU-1607. Unpin tablet flush after failed bootstrap

2017-03-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6422/3/src/kudu/tablet/tablet_bootstrap.cc Fi

[kudu-CR] compaction: fix rowblock size in compaction output

2017-03-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: compaction: fix rowblock size in compaction output .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6430 To unsubscribe, vi

[kudu-CR] key encoder: avoid unordered map for looking up encoders

2017-03-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: key_encoder: avoid unordered_map for looking up encoders .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6431 To unsubscri

[kudu-CR] compaction-test: use default bloom sizing

2017-03-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: compaction-test: use default bloom sizing .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6429/2/src/kudu/tablet/compaction-test.cc File

[kudu-CR] cfile writer: inline written size() method

2017-03-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: cfile_writer: inline written_size() method .. Patch Set 2: Code-Review+2 isolate failed for the release build. given the contents of the patch likely not

[kudu-CR] Optimize BinaryDictBlock to use dense hash map, smaller hot path

2017-03-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Optimize BinaryDictBlock to use dense_hash_map, smaller hot path .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6433/2/src/kudu/cfile/bi

[kudu-CR] WIP [java client] fixed NPE in master RPC error handler

2017-03-20 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: WIP [java client] fixed NPE in master RPC error handler .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6401 To unsubscribe, visit

[kudu-CR] Optimize BinaryDictBlock to use dense hash map, smaller hot path

2017-03-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Optimize BinaryDictBlock to use dense_hash_map, smaller hot path .. Patch Set 2: Code-Review+1 Thirdparty change looks good. I also reviewed the dictionary encoding

[kudu-CR] kudu-mapreduce: tweak poms

2017-03-20 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: kudu-mapreduce: tweak poms .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6418/1//COMMIT_MSG Commit Message: Line 22: fat jar containing kudu-cl

[kudu-CR] KUDU-1607. Unpin tablet flush after failed bootstrap

2017-03-20 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6422 to look at the new patch set (#3). Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap .. KUDU-160

[kudu-CR] KUDU-1607. Unpin tablet flush after failed bootstrap

2017-03-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6422/3/src/kudu/tablet/tablet_bootstrap.cc Fi

[kudu-CR] KUDU-1607. Unpin tablet flush after failed bootstrap

2017-03-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap .. Patch Set 2: (10 comments) http://gerrit.cloudera.org:8080/#/c/6422/2//COMMIT_MSG Commit Message: PS2, Lin

[kudu-CR] kudu-spark: switch default profile from spark1/2.10 to spark2/2.11

2017-03-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: kudu-spark: switch default profile from spark1/2.10 to spark2/2.11 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6420 To

[kudu-CR] kudu-mapreduce: tweak poms

2017-03-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: kudu-mapreduce: tweak poms .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6418/1//COMMIT_MSG Commit Message: Line 22: fat jar containing