[kudu-CR] KUDU-2141. master: Remove DCHECK when tablet report has no opid index

2017-09-08 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: KUDU-2141. master: Remove DCHECK when tablet report has no opid_index .. KUDU-2141. master: Remove DCHECK when tablet report has no opid_index Commit

[kudu-CR] KUDU-2141. master: Remove DCHECK when tablet report has no opid index

2017-09-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-2141. master: Remove DCHECK when tablet report has no opid_index .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8019 To

[kudu-CR] KUDU-2141. master: Remove DCHECK when tablet report has no opid index

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2141. master: Remove DCHECK when tablet report has no opid_index .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8019 To

[kudu-CR] [tests] de-flaking catalog manager tsk-itest

2017-09-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [tests] de-flaking catalog_manager_tsk-itest .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2141. master: Remove DCHECK when tablet report has no opid index

2017-09-08 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/8019 Change subject: KUDU-2141. master: Remove DCHECK when tablet report has no opid_index .. KUDU-2141. master: Remove DCHECK when tablet

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7985 To

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-08 Thread Dan Burkert (Code Review)
Hello Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7985 to look at the new patch set (#7). Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new patch set (#3). Change subject: KUDU-2125: Tablet copy client does not retry on failures .. KUDU-2125: Tablet copy client does not retry on failures Change-Id:

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 2: (3 comments)

[kudu-CR] [tests] de-flaking catalog manager tsk-itest

2017-09-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [tests] de-flaking catalog_manager_tsk-itest .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 2: (3 comments)

[kudu-CR] [tests] de-flaking catalog manager tsk-itest

2017-09-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [tests] de-flaking catalog_manager_tsk-itest .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8017/1//COMMIT_MSG Commit Message: > Did you try

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7985 To

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 2: Verified+1 bogus iwyu -- To view, visit http://gerrit.cloudera.org:8080/8016 To

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. Patch Set 6: Verified+1 ignore bogus iwyu -- To view, visit

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-08 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8016 to look at the new patch set (#2). Change subject: KUDU-2125: Tablet copy client does not retry on failures ..

[kudu-CR] [tests] de-flaking catalog manager tsk-itest

2017-09-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/8017 Change subject: [tests] de-flaking catalog_manager_tsk-itest .. [tests] de-flaking catalog_manager_tsk-itest After recent updates the

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-08 Thread Dan Burkert (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8016 to review the following change. Change subject: KUDU-2125: Tablet copy client does not retry on failures

[kudu-CR] KUDU-2137: protect against concurrent schema version change and tablet drop

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-2137: protect against concurrent schema version change and tablet drop .. KUDU-2137: protect against concurrent schema version change and tablet drop

[kudu-CR] catalog manager: fix unprotected data access in TableInfo::AddRemoveTablets

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: catalog_manager: fix unprotected data access in TableInfo::AddRemoveTablets .. catalog_manager: fix unprotected data access in TableInfo::AddRemoveTablets

[kudu-CR] catalog manager: fix unprotected data access in TableInfo::AddRemoveTablets

2017-09-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: catalog_manager: fix unprotected data access in TableInfo::AddRemoveTablets .. Patch Set 4: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2137: protect against concurrent schema version change and tablet drop

2017-09-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2137: protect against concurrent schema version change and tablet drop .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] catalog manager: fix unprotected data access in TableInfo::AddRemoveTablets

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: catalog_manager: fix unprotected data access in TableInfo::AddRemoveTablets .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7995

[kudu-CR] KUDU-2137: protect against concurrent schema version change and tablet drop

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2137: protect against concurrent schema version change and tablet drop .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7996

[kudu-CR](gh-pages) Update website for 1.5.0 release

2017-09-08 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8013 to review the following change. Change subject: Update website for 1.5.0 release .. Update

[kudu-CR] catalog manager: fix unprotected data access in TableInfo::AddRemoveTablets

2017-09-08 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7995 to look at the new patch set (#4). Change subject: catalog_manager: fix unprotected data access in TableInfo::AddRemoveTablets

[kudu-CR] catalog manager: fix unprotected data access in TableInfo::AddRemoveTablets

2017-09-08 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7995 to look at the new patch set (#3). Change subject: catalog_manager: fix unprotected data access in TableInfo::AddRemoveTablets

[kudu-CR] catalog manager: various boring cleanup

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: catalog_manager: various boring cleanup .. catalog_manager: various boring cleanup Change-Id: I028611361ae7d5ce2818707c203c045dbce294c6 Reviewed-on:

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. Patch Set 5: Verified+1 ignoring iwyu failure; looks wrong to me. -- To view,

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7985 To

[kudu-CR] catalog manager: fix unprotected data access in TableInfo::AddRemoveTablets

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: catalog_manager: fix unprotected data access in TableInfo::AddRemoveTablets .. Patch Set 2: (2 comments)

[kudu-CR] catalog manager: fix unprotected data access in TableInfo::AddRemoveTablets

2017-09-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: catalog_manager: fix unprotected data access in TableInfo::AddRemoveTablets .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-08 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7985 to look at the new patch set (#5). Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession

[kudu-CR] catalog manager: fix unprotected data access in TableInfo::AddRemoveTablets

2017-09-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: catalog_manager: fix unprotected data access in TableInfo::AddRemoveTablets .. Patch Set 2: (1 comment)

[kudu-CR] catalog manager: various boring cleanup

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: catalog_manager: various boring cleanup .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7990/3/src/kudu/master/catalog_manager.cc

[kudu-CR] catalog manager: fix unprotected data access in TableInfo::AddRemoveTablets

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: catalog_manager: fix unprotected data access in TableInfo::AddRemoveTablets .. Patch Set 2: gotcha; sounds good. -- To view, visit

[kudu-CR] KUDU-2137: protect against concurrent schema version change and tablet drop

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2137: protect against concurrent schema version change and tablet drop .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7996

[kudu-CR] catalog manager: fix unprotected data access in TableInfo::AddRemoveTablets

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: catalog_manager: fix unprotected data access in TableInfo::AddRemoveTablets .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7995

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2137: protect against concurrent schema version change and tablet drop

2017-09-08 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7996 to look at the new patch set (#3). Change subject: KUDU-2137: protect against concurrent schema version change and tablet drop

[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 1: gsl::span : std::vector as Slice (or gsl::string_span) : std::string -- To view, visit

[kudu-CR] catalog manager: various boring cleanup

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: catalog_manager: various boring cleanup .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7990/3/src/kudu/master/catalog_manager.cc File

[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 1: I don't want to block merging this, but we might want to think about this is a bigger context.

[kudu-CR] KUDU-2137: protect against concurrent schema version change and tablet drop

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2137: protect against concurrent schema version change and tablet drop .. Patch Set 2: (1 comment)

[kudu-CR] catalog manager: fix unprotected data access in TableInfo::AddRemoveTablets

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: catalog_manager: fix unprotected data access in TableInfo::AddRemoveTablets .. Patch Set 2: > yikes. does this indicate a lack of test coverage around >

[kudu-CR] ref counted: fix move constructors to actually move

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: ref_counted: fix move constructors to actually move .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8002 To unsubscribe, visit

[kudu-CR] KUDU-2137: protect against concurrent schema version change and tablet drop

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2137: protect against concurrent schema version change and tablet drop .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2137: protect against concurrent schema version change and tablet drop

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2137: protect against concurrent schema version change and tablet drop .. Patch Set 2: (1 comment)

[kudu-CR] catalog manager: various boring cleanup

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: catalog_manager: various boring cleanup .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7990/3/src/kudu/master/catalog_manager.cc File

[kudu-CR] catalog manager: fix unprotected data access in TableInfo::AddRemoveTablets

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: catalog_manager: fix unprotected data access in TableInfo::AddRemoveTablets .. Patch Set 1: Code looks good. -- To view, visit

[kudu-CR] catalog manager: fix unprotected data access in TableInfo::AddRemoveTablets

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: catalog_manager: fix unprotected data access in TableInfo::AddRemoveTablets .. Patch Set 1: yikes. does this indicate a lack of test coverage around concurrent

[kudu-CR] catalog manager: various boring cleanup

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: catalog_manager: various boring cleanup .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7990/2/src/kudu/master/catalog_manager.cc File

[kudu-CR] catalog manager: various boring cleanup

2017-09-08 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7990 to look at the new patch set (#3). Change subject: catalog_manager: various boring cleanup .. catalog_manager:

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. Patch Set 4: Code-Review+1 (1 comment)

[kudu-CR] catalog manager: various boring cleanup

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: catalog_manager: various boring cleanup .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7990/2/src/kudu/master/catalog_manager.cc File

[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/env_posix.cc File

[kudu-CR] WIP: pb util: avoid repeated stat() calls reading files

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP: pb_util: avoid repeated stat() calls reading files .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8010/1/src/kudu/util/pb_util.cc File

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. Patch Set 3: (8 comments)

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-08 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7985 to look at the new patch set (#4). Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession

[kudu-CR] Avoid a few allocations while reading PBC files

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/env_posix.cc File

[kudu-CR] log block manager: use move semantics to fill in the block map

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log_block_manager: use move semantics to fill in the block map .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] log block manager: switch from google::sparse hash map to sparsepp

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log_block_manager: switch from google::sparse_hash_map to sparsepp .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8007/1//COMMIT_MSG Commit

[kudu-CR] log block manager: switch from google::sparse hash map to sparsepp

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log_block_manager: switch from google::sparse_hash_map to sparsepp .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8007/1//COMMIT_MSG Commit

[kudu-CR] ref counted: fix move constructors to actually move

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: ref_counted: fix move constructors to actually move .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] Add a simple benchmark to create 1M blocks and reopen LBM

2017-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add a simple benchmark to create 1M blocks and reopen LBM .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/6968/16/src/kudu/consensus/log-test.cc

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 15: (2 comments)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-08 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#16). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric