[kudu-CR] KUDU-2193 (part 1): switch to a waiting mutex in TSTabletManager

2017-10-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8345 ) Change subject: KUDU-2193 (part 1): switch to a waiting mutex in TSTabletManager .. KUDU-2193 (part 1): switch to a waiting mutex

[kudu-CR] KUDU-2193 (part 2): avoid holding TSTabletManager::lock for a long time

2017-10-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8346 ) Change subject: KUDU-2193 (part 2): avoid holding TSTabletManager::lock_ for a long time .. KUDU-2193 (part 2): avoid holding

[kudu-CR] KUDU-2193 (part 2): avoid holding TSTabletManager::lock for a long time

2017-10-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8346 ) Change subject: KUDU-2193 (part 2): avoid holding TSTabletManager::lock_ for a long time .. Patch Set 2: Code-Review+2 -- To view,

[kudu-CR] [mini-cluster] allow 18-bit PID in LOOPBACK bind mode

2017-10-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8422 ) Change subject: [mini-cluster] allow 18-bit PID in LOOPBACK bind mode .. [mini-cluster] allow 18-bit PID in LOOPBACK bind mode

[kudu-CR] [mini-cluster] allow 18-bit PID in LOOPBACK bind mode

2017-10-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8422 ) Change subject: [mini-cluster] allow 18-bit PID in LOOPBACK bind mode .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] fs: store opts at construction time

2017-10-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8437 ) Change subject: fs: store opts at construction time .. Patch Set 2: (1 comment)

[kudu-CR] fs: store opts at construction time

2017-10-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8437 ) Change subject: fs: store opts at construction time .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] fs: store opts at construction time

2017-10-31 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8437 to look at the new patch set (#2). Change subject: fs: store opts at construction time

[kudu-CR] fs: store opts at construction time

2017-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8437 ) Change subject: fs: store opts at construction time .. Patch Set 1: (3 comments)

[kudu-CR] fs: store opts at construction time

2017-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8437 ) Change subject: fs: store opts at construction time .. Patch Set 1: (1 comment)

[kudu-CR](branch-1.2.x) [client-test] Reduce flakyness of TestWriteWithDeadTabletServer

2017-10-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8429 ) Change subject: [client-test] Reduce flakyness of TestWriteWithDeadTabletServer .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] fs: store opts at construction time

2017-10-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8437 ) Change subject: fs: store opts at construction time .. Patch Set 1: (3 comments) Some nits

[kudu-CR] fs: store opts at construction time

2017-10-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8437 ) Change subject: fs: store opts at construction time .. Patch Set 1: (1 comment)

[kudu-CR] fs: store opts at construction time

2017-10-31 Thread Adar Dembo (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8437 to review the following change. Change subject: fs: store opts at construction time .. fs: store opts at construction

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-10-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 21: (13 comments)

[kudu-CR] KUDU-1809: Add batch size configuration for ScanToken API

2017-10-31 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8435 Change subject: KUDU-1809: Add batch size configuration for ScanToken API .. KUDU-1809: Add batch size configuration for ScanToken API Both

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 ) Change subject: KUDU-2191 (2/n): Hive Metastore client .. Patch Set 36: (2 comments)

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-10-31 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 21: (10 comments)

[kudu-CR] cfile set: make FindRow more robust to errors

2017-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8423 ) Change subject: cfile_set: make FindRow more robust to errors .. cfile_set: make FindRow more robust to errors Previously,

[kudu-CR] cfile set: make FindRow more robust to errors

2017-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8423 ) Change subject: cfile_set: make FindRow more robust to errors .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Add log parser script

2017-10-31 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8229 ) Change subject: Add log parser script .. Patch Set 1: (3 comments) Thanks for taking a look at this, Andrew!

[kudu-CR](branch-1.2.x) [client-test] Reduce flakyness of TestWriteWithDeadTabletServer

2017-10-31 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8429 to review the following change. Change subject: [client-test] Reduce flakyness of TestWriteWithDeadTabletServer

[kudu-CR] Add log parser script

2017-10-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8229 ) Change subject: Add log parser script .. Patch Set 1: (3 comments) Overall looks pretty good.

[kudu-CR] Update auth token validity seconds description

2017-10-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8413 ) Change subject: Update auth_token_validity_seconds description .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Update auth token validity seconds description

2017-10-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8413 ) Change subject: Update auth_token_validity_seconds description .. Update auth_token_validity_seconds description The caveats

[kudu-CR] [mini-cluster] allow 18-bit PID in LOOPBACK bind mode

2017-10-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8422 ) Change subject: [mini-cluster] allow 18-bit PID in LOOPBACK bind mode .. Patch Set 1: (1 comment)

[kudu-CR] Update auth token validity seconds description

2017-10-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8413 ) Change subject: Update auth_token_validity_seconds description .. Patch Set 2: (1 comment)

[kudu-CR] Update auth token validity seconds description

2017-10-31 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8413 to look at the new patch set (#2). Change subject: Update auth_token_validity_seconds description ..

[kudu-CR] [java client] improve AsyncKuduScanner logging

2017-10-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8382 ) Change subject: [java client] improve AsyncKuduScanner logging .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] Update auth token validity seconds description

2017-10-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8413 ) Change subject: Update auth_token_validity_seconds description .. Patch Set 1: (1 comment) Thank you for taking care of this. I

[kudu-CR] KUDU-2200: provide better diagnostics when connecting to a subset of masters

2017-10-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8393 ) Change subject: KUDU-2200: provide better diagnostics when connecting to a subset of masters .. Patch Set 2: (4 comments)