[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: tablet: introduce closed mvcc and stopped tablets .. Patch Set 34: (13 comments)

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#34). Change subject: tablet: introduce closed mvcc and stopped tablets

[kudu-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8595 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 2: Code-Review+2 Looks good to me. Perhaps,

[kudu-CR] tablet: make various update paths atomic

2017-11-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 ) Change subject: tablet: make various update paths atomic .. Patch Set 11: > Patch Set 11: > > Any idea what the coverage of these code

[kudu-CR] WIP [catalog manager] added 3-4-3 behavior

2017-11-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8619 Change subject: WIP [catalog_manager] added 3-4-3 behavior .. WIP [catalog_manager] added 3-4-3 behavior Updated the catalog_manager to

[kudu-CR] error manager: synchronize/serialize handling

2017-11-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 ) Change subject: error_manager: synchronize/serialize handling .. Patch Set 9: (7 comments)

[kudu-CR] KUDU-2165 workaround: avoid TSAN warnings on CacheMetrics

2017-11-20 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8617 to review the following change. Change subject: KUDU-2165 workaround: avoid TSAN warnings on CacheMetrics

[kudu-CR] maintenance manager: fix a deadlock on shutdown

2017-11-20 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8616 to review the following change. Change subject: maintenance_manager: fix a deadlock on shutdown ..

[kudu-CR] Add a test for data consistency after stopping tablets

2017-11-20 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8618 to review the following change. Change subject: Add a test for data consistency after stopping tablets ..

[kudu-CR] tablet: make various update paths atomic

2017-11-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 ) Change subject: tablet: make various update paths atomic .. Patch Set 11: Any idea what the coverage of these code paths look like? eg

[kudu-CR] handle disk failures during tablet copies

2017-11-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7654 ) Change subject: handle disk failures during tablet copies .. Patch Set 6: (4 comments) Some of these changes make sense but see my

[kudu-CR] tablet: mark delta tracker read-only on error

2017-11-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8605 ) Change subject: tablet: mark delta tracker read-only on error .. Patch Set 5: (3 comments)

[kudu-CR] tablet: add early returns to maintenance functions

2017-11-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8606 ) Change subject: tablet: add early returns to maintenance functions .. Patch Set 5: (4 comments)

[kudu-CR] consensus: fix reporting of errors in CANNOT PREPARE case

2017-11-20 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8615 to review the following change. Change subject: consensus: fix reporting of errors in CANNOT_PREPARE case ..

[kudu-CR] tablet: mark delta tracker read-only on error

2017-11-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8605 ) Change subject: tablet: mark delta tracker read-only on error .. Patch Set 5: (1 comment) lgtm, could use a test

[kudu-CR] tablet: make various update paths atomic

2017-11-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 ) Change subject: tablet: make various update paths atomic .. Patch Set 11: Code-Review+2 This looks pretty good to me. Todd may also want

[kudu-CR] Mark hms client-test as RUN SERIAL to avoid timeouts

2017-11-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8566 ) Change subject: Mark hms_client-test as RUN_SERIAL to avoid timeouts .. Mark hms_client-test as RUN_SERIAL to avoid timeouts It

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: tablet: introduce closed mvcc and stopped tablets .. Patch Set 33: (1 comment)

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: tablet: introduce closed mvcc and stopped tablets .. Patch Set 33: (2 comments)

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: tablet: introduce closed mvcc and stopped tablets .. Patch Set 33: (9 comments)

[kudu-CR] shutdown tablets on disk failure at runtime

2017-11-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7442 to look at the new patch set (#10). Change subject: shutdown tablets on disk failure at runtime

[kudu-CR] handle disk failures during tablet copies

2017-11-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7654 to look at the new patch set (#6). Change subject: handle disk failures during tablet copies

[kudu-CR] error manager: synchronize/serialize handling

2017-11-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8395 to look at the new patch set (#9). Change subject: error_manager: synchronize/serialize handling

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#33). Change subject: tablet: introduce closed mvcc and stopped tablets

[kudu-CR] tablet copy service: fix Status message with misplaced $0

2017-11-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8598 ) Change subject: tablet_copy_service: fix Status message with misplaced $0 .. tablet_copy_service: fix Status message with

[kudu-CR](branch-1.5.x) KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2017-11-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8604 ) Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev .. Removed reviewer Kudu Jenkins with

[kudu-CR](branch-1.5.x) KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2017-11-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8604 ) Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev .. Patch Set 2: Verified+1 unrelated flake

[kudu-CR](branch-1.4.x) KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2017-11-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8602 ) Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev .. Patch Set 2: > Known bug in encoder:

[kudu-CR](branch-1.4.x) [security] test and fixes for TLS socket EINTR issues

2017-11-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8601 ) Change subject: [security] test and fixes for TLS socket EINTR issues .. Patch Set 2: Verified+1 Known bug in the encoder:

[kudu-CR](branch-1.4.x) [security] test and fixes for TLS socket EINTR issues

2017-11-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8601 ) Change subject: [security] test and fixes for TLS socket EINTR issues .. Removed reviewer Kudu Jenkins with the following

[kudu-CR](branch-1.4.x) KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2017-11-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8602 ) Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev .. Patch Set 2: Verified+1 Known bug in

[kudu-CR](branch-1.4.x) KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2017-11-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8602 ) Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev .. Removed reviewer Kudu Jenkins with

[kudu-CR] KUDU-1737 : Submit column characteristics via KuduContext

2017-11-20 Thread Anonymous Coward (Code Review)
saketa.chalamch...@gmail.com has abandoned this change. ( http://gerrit.cloudera.org:8080/6010 ) Change subject: KUDU-1737 : Submit column characteristics via KuduContext .. Abandoned Created another review at

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#32). Change subject: tablet: introduce closed mvcc and stopped tablets

[kudu-CR] tablet: add early returns to maintenance functions

2017-11-20 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8606 to look at the new patch set (#4). Change subject: tablet: add early returns to maintenance functions

[kudu-CR] tablet: mark delta tracker read-only on error

2017-11-20 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8605 to look at the new patch set (#4). Change subject: tablet: mark delta tracker read-only on error .. tablet: mark

[kudu-CR] error manager: synchronize/serialize handling

2017-11-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8395 to look at the new patch set (#8). Change subject: error_manager: synchronize/serialize handling

[kudu-CR] tablet: make various update paths atomic

2017-11-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Mike Percy, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8441 to look at the new patch set (#10). Change subject: tablet: make various update paths atomic

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#31). Change subject: tablet: introduce closed mvcc and stopped tablets

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#29). Change subject: tablet: introduce closed mvcc and stopped tablets

[kudu-CR] tablet: mark delta tracker read-only on error

2017-11-20 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8605 to look at the new patch set (#2). Change subject: tablet: mark delta tracker read-only on error .. tablet: mark

[kudu-CR] tablet: make various update paths atomic

2017-11-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Mike Percy, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8441 to look at the new patch set (#8). Change subject: tablet: make various update paths atomic

[kudu-CR] tablet: add early returns to maintenance functions

2017-11-20 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8606 to look at the new patch set (#2). Change subject: tablet: add early returns to maintenance functions

[kudu-CR] handle disk failures during tablet copies

2017-11-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7654 to look at the new patch set (#3). Change subject: handle disk failures during tablet copies

[kudu-CR] shutdown tablets on disk failure at runtime

2017-11-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7442 to look at the new patch set (#7). Change subject: shutdown tablets on disk failure at runtime

[kudu-CR](branch-1.5.x) KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2017-11-20 Thread Alexey Serbin (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8604 to look at the new patch set (#2). Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev

[kudu-CR](branch-1.5.x) [security] test and fixes for TLS socket EINTR issues

2017-11-20 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8603 to look at the new patch set (#2). Change subject: [security] test and fixes for TLS socket EINTR issues

[kudu-CR](branch-1.4.x) [security] test and fixes for TLS socket EINTR issues

2017-11-20 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8601 to look at the new patch set (#2). Change subject: [security] test and fixes for TLS socket EINTR issues

[kudu-CR](branch-1.4.x) KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2017-11-20 Thread Alexey Serbin (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8602 to look at the new patch set (#2). Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev

[kudu-CR](branch-1.3.x) [security] test and fixes for TLS socket EINTR issues

2017-11-20 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8599 to look at the new patch set (#2). Change subject: [security] test and fixes for TLS socket EINTR issues

[kudu-CR](branch-1.3.x) KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2017-11-20 Thread Alexey Serbin (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8600 to look at the new patch set (#2). Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev

[kudu-CR] [Java] Add public INT128 column type support

2017-11-20 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8608 Change subject: [Java] Add public INT128 column type support .. [Java] Add public INT128 column type support This patch adds basic

[kudu-CR] wire protocol: optimize RewriteRowBlockPointers

2017-11-20 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8554 ) Change subject: wire_protocol: optimize RewriteRowBlockPointers .. wire_protocol: optimize RewriteRowBlockPointers I was looking

[kudu-CR] wire protocol: optimize RewriteRowBlockPointers

2017-11-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8554 ) Change subject: wire_protocol: optimize RewriteRowBlockPointers .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] tablet: make various update paths atomic

2017-11-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 ) Change subject: tablet: make various update paths atomic .. Patch Set 7: (1 comment)

[kudu-CR] handle disk failures during tablet copies

2017-11-20 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/8607 ) Change subject: handle disk failures during tablet copies .. Abandoned This is a duplicate -- To view, visit http://gerrit.cloudera.org:8080/8607

[kudu-CR] handle disk failures during tablet copies

2017-11-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7654 to look at the new patch set (#2). Change subject: handle disk failures during tablet copies

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#28). Change subject: tablet: introduce closed mvcc and stopped tablets

[kudu-CR] tablet: mark delta tracker read-only on error

2017-11-20 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8605 Change subject: tablet: mark delta tracker read-only on error .. tablet: mark delta tracker read-only on error When DeltaTracker::Flush()

[kudu-CR] handle disk failures during tablet copies

2017-11-20 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8607 Change subject: handle disk failures during tablet copies .. handle disk failures during tablet copies There are two components in a

[kudu-CR] tablet: add early returns to maintenance functions

2017-11-20 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8606 Change subject: tablet: add early returns to maintenance functions .. tablet: add early returns to maintenance functions When a Tablet is

[kudu-CR] tablet: make various update paths atomic

2017-11-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Mike Percy, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8441 to look at the new patch set (#7). Change subject: tablet: make various update paths atomic

[kudu-CR](branch-1.5.x) [security] test and fixes for TLS socket EINTR issues

2017-11-20 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8603 to review the following change. Change subject: [security] test and fixes for TLS socket EINTR issues ..

[kudu-CR](branch-1.5.x) KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2017-11-20 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8604 to review the following change. Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev

[kudu-CR](branch-1.4.x) KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2017-11-20 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8602 to review the following change. Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev

[kudu-CR](branch-1.4.x) [security] test and fixes for TLS socket EINTR issues

2017-11-20 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8601 to review the following change. Change subject: [security] test and fixes for TLS socket EINTR issues ..

[kudu-CR](branch-1.3.x) [security] test and fixes for TLS socket EINTR issues

2017-11-20 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8599 to review the following change. Change subject: [security] test and fixes for TLS socket EINTR issues ..

[kudu-CR](branch-1.3.x) KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2017-11-20 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8600 to review the following change. Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev

[kudu-CR] tablet copy service: fix Status message with misplaced $0

2017-11-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8598 ) Change subject: tablet_copy_service: fix Status message with misplaced $0 .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8595 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 2: (1 comment)

[kudu-CR] tablet copy service: fix Status message with misplaced $0

2017-11-20 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8598 to review the following change. Change subject: tablet_copy_service: fix Status message with misplaced $0 ..

[kudu-CR] schema: micro-optimize num columns()

2017-11-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8587 ) Change subject: schema: micro-optimize num_columns() .. schema: micro-optimize num_columns() Looking at some profile earlier

[kudu-CR] Bug: KUDU-1737

2017-11-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8591 ) Change subject: Bug: KUDU-1737 .. Patch Set 1: It looks like you've split this change across two gerrits. Does this one obsolete the

[kudu-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8595 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 2: (1 comment)

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: tablet: introduce closed mvcc and stopped tablets .. Patch Set 27: Verified+1 Failure was caused by a seeming flake in

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-20 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: tablet: introduce closed mvcc and stopped tablets .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/7439 To unsubscribe,

[kudu-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8595 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8595 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2215. kernel stack watchdog: avoid blocking thread exit

2017-11-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8536 ) Change subject: KUDU-2215. kernel_stack_watchdog: avoid blocking thread exit .. KUDU-2215. kernel_stack_watchdog: avoid blocking

[kudu-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8595 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8595 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 2: > > Would it make more sense to just call

[kudu-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8595 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 2: > Would it make more sense to just call it

[kudu-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8595 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 2: Would it make more sense to just call it