[kudu-CR] KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any

2018-06-08 Thread Anupama Gupta (Code Review)
Anupama Gupta has posted comments on this change. ( http://gerrit.cloudera.org:8080/10591 ) Change subject: KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any .. Patch Set 14: (10 comments) Ple

[kudu-CR] KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any

2018-06-08 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10591 to look at the new patch set (#14). Change subject: KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any ...

[kudu-CR] KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any

2018-06-08 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10591 to look at the new patch set (#13). Change subject: KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any ...

[kudu-CR] Increase --tablet copy begin session timeout ms to 30 sec

2018-06-08 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10651 ) Change subject: Increase --tablet_copy_begin_session_timeout_ms to 30 sec .. Increase --tablet_copy_begin_session_timeout_ms to 30

[kudu-CR] [tools] ksck: fix some output spacing and printing of GetFlags warnings

2018-06-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10667 ) Change subject: [tools] ksck: fix some output spacing and printing of GetFlags warnings .. Patch Set 1: Code-Review+1 (1 comment) http

[kudu-CR] WIP consensus: remove env usage from ConsensusMetadata

2018-06-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10649 ) Change subject: WIP consensus: remove env usage from ConsensusMetadata .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:

[kudu-CR] wip tablet: add tmeta manager

2018-06-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10650 ) Change subject: wip tablet: add tmeta manager .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/10650/1/src/kudu

[kudu-CR] [tools] ksck: fix some output spacing and printing of GetFlags warnings

2018-06-08 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: [tools] ksck: fix some output spacing and printing of GetFlags warnings .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] [tools] ksck: fix some output spacing and printing of GetFlags warnings

2018-06-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10667 ) Change subject: [tools] ksck: fix some output spacing and printing of GetFlags warnings .. Patch Set 1: Verified+1 Unrealted flake in

[kudu-CR] [tools] add 'kudu tablet set attributes' sub-command

2018-06-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10536 ) Change subject: [tools] add 'kudu tablet set_attributes' sub-command .. Patch Set 2: (1 comment) I'll take over revving this since Al

[kudu-CR] [tools] ksck: fix some output spacing and printing of GetFlags warnings

2018-06-08 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10667 Change subject: [tools] ksck: fix some output spacing and printing of GetFlags warnings .. [tools] ksck: fix some output spacing and pr

[kudu-CR] Code update for KUDU-2459

2018-06-08 Thread Shriya Gupta (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10656 to look at the new patch set (#4). Change subject: Code update for KUDU-2459 .. Code update for KUDU-2459 Change-I

[kudu-CR] Code update for KUDU-2459

2018-06-08 Thread Shriya Gupta (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10656 to look at the new patch set (#3). Change subject: Code update for KUDU-2459 .. Code update for KUDU-2459 Change-I

[kudu-CR] Code update for KUDU-2459, also made fixes to correct last LINT-build failure (whitespaces,line length etc)

2018-06-08 Thread Shriya Gupta (Code Review)
Shriya Gupta has abandoned this change. ( http://gerrit.cloudera.org:8080/10662 ) Change subject: Code update for KUDU-2459, also made fixes to correct last LINT-build failure (whitespaces,line length etc) .. Abandoned Made

[kudu-CR] Code update for KUDU-2459

2018-06-08 Thread Shriya Gupta (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10656 to look at the new patch set (#2). Change subject: Code update for KUDU-2459 .. Code update for KUDU-2459 Change-I

[kudu-CR] Code update for KUDU-2459, also made fixes to correct last LINT-build failure (whitespaces,line length etc)

2018-06-08 Thread Shriya Gupta (Code Review)
Shriya Gupta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10662 Change subject: Code update for KUDU-2459, also made fixes to correct last LINT-build failure (whitespaces,line length etc) .. Code upd

[kudu-CR] KUDU-1861: add range-partitions to loadgen tables

2018-06-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10633 ) Change subject: KUDU-1861: add range-partitions to loadgen tables .. Patch Set 4: Code-Review+2 (1 comment) I'd like Alexey to take anot

[kudu-CR] KUDU-1861: add range-partitions to loadgen tables

2018-06-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10633 ) Change subject: KUDU-1861: add range-partitions to loadgen tables .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/1063

[kudu-CR] KUDU-1861: add range-partitions to loadgen tables

2018-06-08 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10633 to look at the new patch set (#4). Change subject: KUDU-1861: add range-partitions to loadgen tables ..

[kudu-CR] Code update for KUDU-2459

2018-06-08 Thread Shriya Gupta (Code Review)
Shriya Gupta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10656 Change subject: Code update for KUDU-2459 .. Code update for KUDU-2459 Change-Id: If9e5242318589452a0507d3973b9be3e6a186a69 --- M src/ku

[kudu-CR] KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any

2018-06-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10591 ) Change subject: KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any .. Patch Set 12: (11 comments) http:/

[kudu-CR] Increase --tablet copy begin session timeout ms to 30 sec

2018-06-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10651 ) Change subject: Increase --tablet_copy_begin_session_timeout_ms to 30 sec .. Patch Set 2: Code-Review+2 -- To view, visit http://gerr

[kudu-CR] [tools] add 'kudu tablet set attributes' sub-command

2018-06-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10536 ) Change subject: [tools] add 'kudu tablet set_attributes' sub-command .. Patch Set 2: (5 comments) Needs to be covered in the tool tes

[kudu-CR] Log idle time when expiring tablet copy sessions

2018-06-08 Thread Mike Percy (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10652 to look at the new patch set (#2). Change subject: Log idle time when expiring tablet copy sessions .

[kudu-CR] Increase --tablet copy begin session timeout ms to 30 sec

2018-06-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10651 ) Change subject: Increase --tablet_copy_begin_session_timeout_ms to 30 sec .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/

[kudu-CR] Increase --tablet copy begin session timeout ms to 30 sec

2018-06-08 Thread Mike Percy (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10651 to look at the new patch set (#2). Change subject: Increase --tablet_copy_begin_session_timeout_ms to 30 sec

[kudu-CR] Increase --tablet copy begin session timeout ms to 30 sec

2018-06-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10651 ) Change subject: Increase --tablet_copy_begin_session_timeout_ms to 30 sec .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.clo

[kudu-CR] KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any

2018-06-08 Thread Anupama Gupta (Code Review)
Anupama Gupta has posted comments on this change. ( http://gerrit.cloudera.org:8080/10591 ) Change subject: KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any .. Patch Set 12: (23 comments) Tha

[kudu-CR] KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any

2018-06-08 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10591 to look at the new patch set (#12). Change subject: KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any ...

[kudu-CR] KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any

2018-06-08 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10591 to look at the new patch set (#11). Change subject: KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any ...

[kudu-CR] KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any

2018-06-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10591 ) Change subject: KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any .. Patch Set 10: (1 comment) Not sure