[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 ) Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13908/3/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: PS3: > Doesn't this change mean that old servers (those that don't support > this interning) won't be able to communicate with new clients? We'd > like to preserve that backwards compatibility. I'm not sure if the new client is compatible with the old server. Maybe we can upgrade server first and then upgrade the client? -- To view, visit http://gerrit.cloudera.org:8080/13908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18272274f07d5ae8e9f6b9572f9900aa8df27bef Gerrit-Change-Number: 13908 Gerrit-PatchSet: 3 Gerrit-Owner: Yao Xu Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Yao Xu Gerrit-Comment-Date: Thu, 25 Jul 2019 04:09:15 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2881 Support create/drop range partition by command line
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13833 ) Change subject: KUDU-2881 Support create/drop range partition by command line .. Patch Set 12: Verified+1 Unrelated test failure of ksck_remote-test -- To view, visit http://gerrit.cloudera.org:8080/13833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I647d9c3cf01807bd8ae9f8cf4091568ea6f1161c Gerrit-Change-Number: 13833 Gerrit-PatchSet: 12 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yao Xu Gerrit-Reviewer: honeyhexin Gerrit-Comment-Date: Thu, 25 Jul 2019 03:57:31 + Gerrit-HasComments: No
[kudu-CR] KUDU-2881 Support create/drop range partition by command line
Andrew Wong has removed a vote on this change. Change subject: KUDU-2881 Support create/drop range partition by command line .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I647d9c3cf01807bd8ae9f8cf4091568ea6f1161c Gerrit-Change-Number: 13833 Gerrit-PatchSet: 12 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yao Xu Gerrit-Reviewer: honeyhexin
[kudu-CR] KUDU-2881 Support create/drop range partition by command line
Andrew Wong has removed a vote on this change. Change subject: KUDU-2881 Support create/drop range partition by command line .. Removed -Verified by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I647d9c3cf01807bd8ae9f8cf4091568ea6f1161c Gerrit-Change-Number: 13833 Gerrit-PatchSet: 12 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yao Xu Gerrit-Reviewer: honeyhexin
[kudu-CR] KUDU-2881 Support create/drop range partition by command line
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Yao Xu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13833 to look at the new patch set (#12). Change subject: KUDU-2881 Support create/drop range partition by command line .. KUDU-2881 Support create/drop range partition by command line Sometimes we need to drop the range partition and then recreate it in order to rewrite in case that the partition was written wrongly. This patch supports to add/drop range partition by command line. The command can be used as: 1. kudu table add_range_partition [-lower_bound_type] [-upper_bound_type] 2. kudu table drop_range_partition [-lower_bound_type] [-upper_bound_type] The parameters of lower_bound and upper_bound can be empty, which means we will use the default value. If both these two parameters are empty, it means the range partition is unbounded. The parameters of lower_bound_type and upper_bound_type is optional. If these two parameters are not specified, the default value are INCLUSIVE_BOUND and EXCLUSIVE_BOUND respectively. These two parameters are both case-insensitive. Change-Id: I647d9c3cf01807bd8ae9f8cf4091568ea6f1161c --- M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_table.cc 4 files changed, 889 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/13833/12 -- To view, visit http://gerrit.cloudera.org:8080/13833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I647d9c3cf01807bd8ae9f8cf4091568ea6f1161c Gerrit-Change-Number: 13833 Gerrit-PatchSet: 12 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yao Xu Gerrit-Reviewer: honeyhexin
[kudu-CR] [clock] introduce mini chronyd
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13916 to look at the new patch set (#2). Change subject: [clock] introduce mini_chronyd .. [clock] introduce mini_chronyd This patch introduces a wrapper around chronyd, so it's possible to run multiple instances of chronyd reference NTP servers as part of Kudu mini-cluster, providing reference for NTP clients. WIP: * add more tests * add more useful functionality to use for follow-up tests running built-in NTP client Change-Id: Id9d06d218828240f2a2980ef5ec30428f86277f7 --- M src/kudu/clock/CMakeLists.txt A src/kudu/clock/test/mini_chronyd-test.cc A src/kudu/clock/test/mini_chronyd.cc A src/kudu/clock/test/mini_chronyd.h 4 files changed, 537 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/13916/2 -- To view, visit http://gerrit.cloudera.org:8080/13916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id9d06d218828240f2a2980ef5ec30428f86277f7 Gerrit-Change-Number: 13916 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] WIP [clock] introduce mini chronyd
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13916 to look at the new patch set (#3). Change subject: WIP [clock] introduce mini_chronyd .. WIP [clock] introduce mini_chronyd This patch introduces a wrapper around chronyd, so it's possible to run multiple instances of chronyd reference NTP servers as part of Kudu mini-cluster, providing reference for NTP clients. WIP: * add more tests * add more useful functionality to use for follow-up tests running built-in NTP client Change-Id: Id9d06d218828240f2a2980ef5ec30428f86277f7 --- M src/kudu/clock/CMakeLists.txt A src/kudu/clock/test/mini_chronyd-test.cc A src/kudu/clock/test/mini_chronyd.cc A src/kudu/clock/test/mini_chronyd.h 4 files changed, 537 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/13916/3 -- To view, visit http://gerrit.cloudera.org:8080/13916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id9d06d218828240f2a2980ef5ec30428f86277f7 Gerrit-Change-Number: 13916 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [clock] introduce mini chronyd
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13916 Change subject: [clock] introduce mini_chronyd .. [clock] introduce mini_chronyd This patch introduces a wrapper around chronyd, so it's possible to run multiple instances of chronyd reference NTP servers as part of Kudu mini-cluster, providing reference for NTP clients. One nice feature that chronyd has is its ability to run in server-only mode, i.e. not driving the system clock: see '-x' option 'man chronyd'. Also, it's possible to run using the system clock as a source instead of a physical device (GPS, oscillator, etc.). In addition, it's possible to manually set the reference time for chrony NTP server running in server-only local mode. The chrony suite has 'chronyc' CLI tool to send control commands to chronyd NTP daemon. WIP: * add more tests * add more useful functionality to use for follow-up tests running built-in NTP client Change-Id: Id9d06d218828240f2a2980ef5ec30428f86277f7 --- M src/kudu/clock/CMakeLists.txt A src/kudu/clock/test/mini_chronyd-test.cc A src/kudu/clock/test/mini_chronyd.cc A src/kudu/clock/test/mini_chronyd.h 4 files changed, 537 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/13916/1 -- To view, visit http://gerrit.cloudera.org:8080/13916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id9d06d218828240f2a2980ef5ec30428f86277f7 Gerrit-Change-Number: 13916 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] [thirdparty] introduce chrony
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13915 Change subject: [thirdparty] introduce chrony .. [thirdparty] introduce chrony Added chrony into the thirdparty: a set of follow-up patches use the chronyd NTP implementation and its chronyc CLI to provide the functionality of reference NTP servers for test scenarios involving Kudu built-in NTP client. One nice feature that chronyd has is the ability to run in server-only mode, i.e. not driving the system clock: 'man chronyd', the '-x' option. Also, it's possible to chronyd NTP server using the system clock as a source instead of a physical device (GPS, oscillator, etc.). In addition, it's possible to manually set the reference time for chrony NTP server running in server-only local mode. The chrony suite has 'chronyc' CLI tool to send control commands to chronyd NTP daemon. As of now, the latest version 3.5 is used with not-yet-upstream patch to drop the requirements of being run under superuser UID when driving the system clock is not required (e.g., when running in server-only mode, see '-x' command-line flag). Change-Id: I71ed12311b10979af8a12094881b6b8b47ef8008 --- M thirdparty/build-definitions.sh M thirdparty/build-thirdparty.sh M thirdparty/download-thirdparty.sh A thirdparty/patches/chrony-no-superuser.patch M thirdparty/vars.sh 5 files changed, 72 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/13915/1 -- To view, visit http://gerrit.cloudera.org:8080/13915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I71ed12311b10979af8a12094881b6b8b47ef8008 Gerrit-Change-Number: 13915 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] [master] Change the timeout threshold for unit test case
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13909 ) Change subject: [master] Change the timeout threshold for unit test case .. Patch Set 1: > I actually haven't been able to reproduce the reported test failure > looping the test hundreds of times in various build modes. I trust > you've seen the failure rate go down in your environment? I haven't seen that in my environment, but I assume that might happen when clock is a bit off or in the process of synchronization. I think you can find the stack trace as it's reported in https://issues.apache.org/jira/browse/KUDU-2882 -- To view, visit http://gerrit.cloudera.org:8080/13909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief5ec23c83022c2c5dbcc65a110ad8fe1f91f1a7 Gerrit-Change-Number: 13909 Gerrit-PatchSet: 1 Gerrit-Owner: helifu Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 24 Jul 2019 22:06:14 + Gerrit-HasComments: No
[kudu-CR] [master] Change the timeout threshold for unit test case
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13909 ) Change subject: [master] Change the timeout threshold for unit test case .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief5ec23c83022c2c5dbcc65a110ad8fe1f91f1a7 Gerrit-Change-Number: 13909 Gerrit-PatchSet: 1 Gerrit-Owner: helifu Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 24 Jul 2019 22:06:37 + Gerrit-HasComments: No
[kudu-CR] [master] Change the timeout threshold for unit test case
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13909 ) Change subject: [master] Change the timeout threshold for unit test case .. Patch Set 1: I actually haven't been able to reproduce the reported test failure looping the test hundreds of times in various build modes. I trust you've seen the failure rate go down in your environment? -- To view, visit http://gerrit.cloudera.org:8080/13909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief5ec23c83022c2c5dbcc65a110ad8fe1f91f1a7 Gerrit-Change-Number: 13909 Gerrit-PatchSet: 1 Gerrit-Owner: helifu Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 24 Jul 2019 21:58:15 + Gerrit-HasComments: No
[kudu-CR] KUDU-2881 Support create/drop range partition by command line
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Yao Xu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13833 to look at the new patch set (#11). Change subject: KUDU-2881 Support create/drop range partition by command line .. KUDU-2881 Support create/drop range partition by command line Sometimes we need to drop the range partition and then recreate it in order to rewrite in case that the partition was written wrongly. This patch supports to add/drop range partition by command line. The command can be used as: 1. kudu table add_range_partition [-lower_bound_type] [-upper_bound_type] 2. kudu table drop_range_partition [-lower_bound_type] [-upper_bound_type] The parameters of lower_bound and upper_bound can be empty, which means we will use the default value. If both these two parameters are empty, it means the range partition is unbounded. The parameters of lower_bound_type and upper_bound_type is optional. If these two parameters are not specified, the default value are INCLUSIVE_BOUND and EXCLUSIVE_BOUND respectively. These two parameters are both case-insensitive. Change-Id: I647d9c3cf01807bd8ae9f8cf4091568ea6f1161c --- M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_table.cc 4 files changed, 889 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/13833/11 -- To view, visit http://gerrit.cloudera.org:8080/13833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I647d9c3cf01807bd8ae9f8cf4091568ea6f1161c Gerrit-Change-Number: 13833 Gerrit-PatchSet: 11 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yao Xu Gerrit-Reviewer: honeyhexin
[kudu-CR] version util: track extra delimiter too
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13911 ) Change subject: version_util: track extra delimiter too .. version_util: track extra delimiter too One of the version_util tests verifies that the current version's canonical representation matches its raw version. The test fails when the delimiter between the maintenance and extra components is a period, because the canonical representation builder (i.e. ToString()) assumes that the delimiter is always a dash. Rather than weaken the invariant enforced by the unit test, let's track the parsed delimiter faithfully. I chose to store it separately from the extra component itself since it didn't logically seem like part of it. Change-Id: I0fe983e55ae9f83d075297016ccc5d50c208c549 Reviewed-on: http://gerrit.cloudera.org:8080/13911 Tested-by: Adar Dembo Reviewed-by: Alexey Serbin --- M src/kudu/util/version_util-test.cc M src/kudu/util/version_util.cc M src/kudu/util/version_util.h 3 files changed, 31 insertions(+), 17 deletions(-) Approvals: Adar Dembo: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0fe983e55ae9f83d075297016ccc5d50c208c549 Gerrit-Change-Number: 13911 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong
[kudu-CR] version util: track extra delimiter too
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13911 ) Change subject: version_util: track extra delimiter too .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13911/2/src/kudu/util/version_util.cc File src/kudu/util/version_util.cc: http://gerrit.cloudera.org:8080/#/c/13911/2/src/kudu/util/version_util.cc@44 PS2, Line 44: this->extra_delimiter == other.extra_delimiter && > I don't view this as a "semantic" version comparison; I view it as a canoni Ah, indeed. It seems we semantically compare versions as tuples, doing something like make_tuple(v.major, v.minor, v.maintenance) >= make_tuple(1, 7, 1); -- To view, visit http://gerrit.cloudera.org:8080/13911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fe983e55ae9f83d075297016ccc5d50c208c549 Gerrit-Change-Number: 13911 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Comment-Date: Wed, 24 Jul 2019 18:06:06 + Gerrit-HasComments: Yes
[kudu-CR] version util: track extra delimiter too
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13911 ) Change subject: version_util: track extra delimiter too .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I0fe983e55ae9f83d075297016ccc5d50c208c549 Gerrit-Change-Number: 13911 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong
[kudu-CR] version util: track extra delimiter too
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13911 ) Change subject: version_util: track extra delimiter too .. Patch Set 2: Verified+1 Overriding Jenkins, failures were in NTP. -- To view, visit http://gerrit.cloudera.org:8080/13911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fe983e55ae9f83d075297016ccc5d50c208c549 Gerrit-Change-Number: 13911 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 24 Jul 2019 17:52:57 + Gerrit-HasComments: No
[kudu-CR] version util: track extra delimiter too
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13911 ) Change subject: version_util: track extra delimiter too .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13911/2/src/kudu/util/version_util.cc File src/kudu/util/version_util.cc: http://gerrit.cloudera.org:8080/#/c/13911/2/src/kudu/util/version_util.cc@44 PS2, Line 44: this->extra_delimiter == other.extra_delimiter && > Do we really want to include the delimiter into the criteria while performi I don't view this as a "semantic" version comparison; I view it as a canonical version comparison. And since the ToString() changes alter the canonical representation to include the delimiter, equality should too. Put another way, I think equality should behave as if we're comparing raw versions. -- To view, visit http://gerrit.cloudera.org:8080/13911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fe983e55ae9f83d075297016ccc5d50c208c549 Gerrit-Change-Number: 13911 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 24 Jul 2019 17:50:37 + Gerrit-HasComments: Yes
[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 ) Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client .. Patch Set 3: (4 comments) Echoing Todd's comments, we don't want to break backwards or forwards compatibility, and I think the changes in meta_cache.cc break compat between old servers and new clients. You might consider splitting up the patch too; there are a number of related but not tightly coupled concerns here (i.e. using ReplicaPB internally, using it on the wire, interning replicas in GetTabletLocationsResponse, etc.) http://gerrit.cloudera.org:8080/#/c/13908/3/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: PS3: Doesn't this change mean that old servers (those that don't support this interning) won't be able to communicate with new clients? We'd like to preserve that backwards compatibility. http://gerrit.cloudera.org:8080/#/c/13908/3/src/kudu/integration-tests/table_locations-itest.cc File src/kudu/integration-tests/table_locations-itest.cc: http://gerrit.cloudera.org:8080/#/c/13908/3/src/kudu/integration-tests/table_locations-itest.cc@250 PS3, Line 250: string tablet_id Capture by cref if you're not using std::move. http://gerrit.cloudera.org:8080/#/c/13908/3/src/kudu/integration-tests/table_locations-itest.cc@275 PS3, Line 275: get_tablet_location(proxy_.get(), loc.tablet_id()); Need to wrap in NO_FATALS. http://gerrit.cloudera.org:8080/#/c/13908/3/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/13908/3/src/kudu/master/master.proto@a565 PS3, Line 565: I think this comment was useful; could you restore it, and duplicate it into GetTabletLocationsResponsePB? -- To view, visit http://gerrit.cloudera.org:8080/13908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18272274f07d5ae8e9f6b9572f9900aa8df27bef Gerrit-Change-Number: 13908 Gerrit-PatchSet: 3 Gerrit-Owner: Yao Xu Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Yao Xu Gerrit-Comment-Date: Wed, 24 Jul 2019 17:49:02 + Gerrit-HasComments: Yes
[kudu-CR] docs: add the required config for Sentry
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13902 ) Change subject: docs: add the required config for Sentry .. docs: add the required config for Sentry This commit adds the required config for fine-grained authz in Sentry. Thirdparty cluster management software like Cloudera Manager may configure these automatically. If not using such software, it's necessary to set these configurations manually. Staged version here: https://github.com/haohaoc/kudu/blob/master/docs/security.adoc Change-Id: If208579405c11fc25aefbedd3f63ac21afecbddf Reviewed-on: http://gerrit.cloudera.org:8080/13902 Reviewed-by: Alexey Serbin Tested-by: Hao Hao --- M docs/security.adoc 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Hao Hao: Verified -- To view, visit http://gerrit.cloudera.org:8080/13902 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If208579405c11fc25aefbedd3f63ac21afecbddf Gerrit-Change-Number: 13902 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] docs: add the required config for Sentry
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13902 ) Change subject: docs: add the required config for Sentry .. Patch Set 3: Verified+1 Unrelated flaky test -- To view, visit http://gerrit.cloudera.org:8080/13902 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If208579405c11fc25aefbedd3f63ac21afecbddf Gerrit-Change-Number: 13902 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 24 Jul 2019 17:47:51 + Gerrit-HasComments: No
[kudu-CR] docs: add the required config for Sentry
Hao Hao has removed a vote on this change. Change subject: docs: add the required config for Sentry .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13902 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: If208579405c11fc25aefbedd3f63ac21afecbddf Gerrit-Change-Number: 13902 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] version util: track extra delimiter too
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13911 ) Change subject: version_util: track extra delimiter too .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13911/2/src/kudu/util/version_util.cc File src/kudu/util/version_util.cc: http://gerrit.cloudera.org:8080/#/c/13911/2/src/kudu/util/version_util.cc@44 PS2, Line 44: this->extra_delimiter == other.extra_delimiter && Do we really want to include the delimiter into the criteria while performing semantic version comparison? I think my question is: why to bother about the representation details why semantically comparing versions? Or this method is not considered to be semantic comparison at all? -- To view, visit http://gerrit.cloudera.org:8080/13911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fe983e55ae9f83d075297016ccc5d50c208c549 Gerrit-Change-Number: 13911 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 24 Jul 2019 17:32:46 + Gerrit-HasComments: Yes
[kudu-CR] version util: track extra delimiter too
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13911 to look at the new patch set (#2). Change subject: version_util: track extra delimiter too .. version_util: track extra delimiter too One of the version_util tests verifies that the current version's canonical representation matches its raw version. The test fails when the delimiter between the maintenance and extra components is a period, because the canonical representation builder (i.e. ToString()) assumes that the delimiter is always a dash. Rather than weaken the invariant enforced by the unit test, let's track the parsed delimiter faithfully. I chose to store it separately from the extra component itself since it didn't logically seem like part of it. Change-Id: I0fe983e55ae9f83d075297016ccc5d50c208c549 --- M src/kudu/util/version_util-test.cc M src/kudu/util/version_util.cc M src/kudu/util/version_util.h 3 files changed, 31 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/13911/2 -- To view, visit http://gerrit.cloudera.org:8080/13911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0fe983e55ae9f83d075297016ccc5d50c208c549 Gerrit-Change-Number: 13911 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] version util: track extra delimiter too
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13911 to review the following change. Change subject: version_util: track extra delimiter too .. version_util: track extra delimiter too One of the version_util tests verifies that the current version's canonical representation matches its raw version. The test fails when the delimiter between the maintenance and extra components is a period, because the canonical representation builder (i.e. ToString()) assumes that the delimiter is always a dash. Rather than weaken the invariant enforced by the unit test, let's track the parsed delimiter faithfully. I chose to store it separately from the extra component itself since it didn't logically seem like part of it. Change-Id: I0fe983e55ae9f83d075297016ccc5d50c208c549 --- M src/kudu/util/version_util-test.cc M src/kudu/util/version_util.cc M src/kudu/util/version_util.h 3 files changed, 30 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/13911/1 -- To view, visit http://gerrit.cloudera.org:8080/13911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0fe983e55ae9f83d075297016ccc5d50c208c549 Gerrit-Change-Number: 13911 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong
[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 ) Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13908/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13908/1//COMMIT_MSG@9 PS1, Line 9: According to the comments of https://gerrit.cloudera.org/#/c/13875/, the > hrm, in those comments, it claimed that ReplicaPB was deprecated as of 0.5. Whoops, it seems that was my mistake claiming that ReplicaPB was deprecated as of 0.5.0. It seems I confused the version of the line with DEPRECATED comment with one of the lines of 'message ReplicaPB' definition. Sorry. -- To view, visit http://gerrit.cloudera.org:8080/13908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18272274f07d5ae8e9f6b9572f9900aa8df27bef Gerrit-Change-Number: 13908 Gerrit-PatchSet: 1 Gerrit-Owner: Yao Xu Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Yao Xu Gerrit-Comment-Date: Wed, 24 Jul 2019 16:50:29 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2881 Support create/drop range partition by command line
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Yao Xu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13833 to look at the new patch set (#10). Change subject: KUDU-2881 Support create/drop range partition by command line .. KUDU-2881 Support create/drop range partition by command line Sometimes we need to drop the range partition and then recreate it in order to rewrite in case that the partition was written wrongly. This patch supports to add/drop range partition by command line. The command can be used as: 1. kudu table add_range_partition [-lower_bound_type] [-upper_bound_type] 2. kudu table drop_range_partition [-lower_bound_type] [-upper_bound_type] The parameters of lower_bound and upper_bound can be empty, which means we will use the default value. If both these two parameters are empty, it means the range partition is unbounded. The parameters of lower_bound_type and upper_bound_type is optional. If these two parameters are not specified, the default value are INCLUSIVE_BOUND and EXCLUSIVE_BOUND respectively. These two parameters are both case-insensitive. Change-Id: I647d9c3cf01807bd8ae9f8cf4091568ea6f1161c --- M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_table.cc 4 files changed, 889 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/13833/10 -- To view, visit http://gerrit.cloudera.org:8080/13833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I647d9c3cf01807bd8ae9f8cf4091568ea6f1161c Gerrit-Change-Number: 13833 Gerrit-PatchSet: 10 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yao Xu Gerrit-Reviewer: honeyhexin
[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13908 to look at the new patch set (#3). Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client .. [client] Deprecated TabletLocationsPB.ReplicaPB message in client According to the comments of https://gerrit.cloudera.org/#/c/13875/, the TabletLocationsPB.ReplicaPB message has been deprecated a long time ago. In this patch, I removed the dependency on it from the client. The server-side is compatible with both old and new client. Change-Id: I18272274f07d5ae8e9f6b9572f9900aa8df27bef --- M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToClusterResponse.java M java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java M java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ProtobufUtils.java M src/kudu/client/client.cc M src/kudu/client/meta_cache.cc M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/delete_table-itest.cc M src/kudu/integration-tests/linked_list-test.cc M src/kudu/integration-tests/master_sentry-itest.cc M src/kudu/integration-tests/raft_config_change-itest.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/integration-tests/registration-test.cc M src/kudu/integration-tests/table_locations-itest.cc M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/integration-tests/tombstoned_voting-itest.cc M src/kudu/integration-tests/ts_itest-base.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/master/master_service.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/rebalancer_tool-test.cc 27 files changed, 266 insertions(+), 232 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/13908/3 -- To view, visit http://gerrit.cloudera.org:8080/13908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I18272274f07d5ae8e9f6b9572f9900aa8df27bef Gerrit-Change-Number: 13908 Gerrit-PatchSet: 3 Gerrit-Owner: Yao Xu Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Yao Xu
[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13908 to look at the new patch set (#2). Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client .. [client] Deprecated TabletLocationsPB.ReplicaPB message in client According to the comments of https://gerrit.cloudera.org/#/c/13875/, the TabletLocationsPB.ReplicaPB message has been deprecated a long time ago. In this patch, I removed the dependency on it from the client. The server-side is compatible with both old and new client. Change-Id: I18272274f07d5ae8e9f6b9572f9900aa8df27bef --- M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToClusterResponse.java M java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java M java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ProtobufUtils.java M src/kudu/client/client.cc M src/kudu/client/meta_cache.cc M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/delete_table-itest.cc M src/kudu/integration-tests/linked_list-test.cc M src/kudu/integration-tests/master_sentry-itest.cc M src/kudu/integration-tests/raft_config_change-itest.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/integration-tests/registration-test.cc M src/kudu/integration-tests/table_locations-itest.cc M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/integration-tests/tombstoned_voting-itest.cc M src/kudu/integration-tests/ts_itest-base.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/master/master_service.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/rebalancer_tool-test.cc 27 files changed, 266 insertions(+), 232 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/13908/2 -- To view, visit http://gerrit.cloudera.org:8080/13908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I18272274f07d5ae8e9f6b9572f9900aa8df27bef Gerrit-Change-Number: 13908 Gerrit-PatchSet: 2 Gerrit-Owner: Yao Xu Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Yao Xu
[kudu-CR] KUDU-2881 Support create/drop range partition by command line
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Yao Xu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13833 to look at the new patch set (#9). Change subject: KUDU-2881 Support create/drop range partition by command line .. KUDU-2881 Support create/drop range partition by command line Sometimes we need to drop the range partition and then recreate it in order to rewrite in case that the partition was written wrongly. This patch supports to add/drop range partition by command line. The command can be used as: 1. kudu table add_range_partition [-lower_bound_type] [-upper_bound_type] 2. kudu table drop_range_partition [-lower_bound_type] [-upper_bound_type] The parameters of lower_bound and upper_bound can be empty, which means we will use the default value. If both these two parameters are empty, it means the range partition is unbounded. The parameters of lower_bound_type and upper_bound_type is optional. If these two parameters are not specified, the default value are INCLUSIVE_BOUND and EXCLUSIVE_BOUND respectively. These two parameters are both case-insensitive. Change-Id: I647d9c3cf01807bd8ae9f8cf4091568ea6f1161c --- M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_table.cc 4 files changed, 888 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/13833/9 -- To view, visit http://gerrit.cloudera.org:8080/13833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I647d9c3cf01807bd8ae9f8cf4091568ea6f1161c Gerrit-Change-Number: 13833 Gerrit-PatchSet: 9 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yao Xu Gerrit-Reviewer: honeyhexin
[kudu-CR] KUDU-2881 Support create/drop range partition by command line
honeyhexin has posted comments on this change. (
http://gerrit.cloudera.org:8080/13833 )
Change subject: KUDU-2881 Support create/drop range partition by command line
..
Patch Set 8:
(11 comments)
http://gerrit.cloudera.org:8080/#/c/13833/7/src/kudu/common/partition.h
File src/kudu/common/partition.h:
http://gerrit.cloudera.org:8080/#/c/13833/7/src/kudu/common/partition.h@260
PS7, Line 260: Gets the vector containin
> nit: reword this as "Returns a vector containing the column indexes of the
Done
http://gerrit.cloudera.org:8080/#/c/13833/7/src/kudu/common/partition.h@263
PS7, Line 263: Status GetRangeSchemaColumnIndexes(const Schema& schema,
: std::vector*
range_column_idxs) const;
:
> Is this used anywhere?
This function is useless now. I have delete it.
http://gerrit.cloudera.org:8080/#/c/13833/7/src/kudu/common/partition.cc
File src/kudu/common/partition.cc:
http://gerrit.cloudera.org:8080/#/c/13833/7/src/kudu/common/partition.cc@1245
PS7, Line 1245: if (idx == Schema::kColumnNotFound) {
> Do we need to worry about what happens if the column ID isn't in the schema
I have add the process in the newest patch: if any of the columns is not in the
key range columns then an InvalidArgument status is returned.
http://gerrit.cloudera.org:8080/#/c/13833/7/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:
http://gerrit.cloudera.org:8080/#/c/13833/7/src/kudu/tools/kudu-admin-test.cc@2346
PS7, Line 2346: TEST_F(AdminCliTest, TestAddAndDropUnboundedPartition) {
> Could you split this test into multiple test cases that test the following:
Done
http://gerrit.cloudera.org:8080/#/c/13833/7/src/kudu/tools/kudu-admin-test.cc@2354
PS7, Line 2354:
> nit: maybe call this kTestTableName so it's clear this is a table name inst
Done
http://gerrit.cloudera.org:8080/#/c/13833/7/src/kudu/tools/kudu-admin-test.cc@2370
PS7, Line 2370: turn Status::OK();
: };
:
: // At first, the range partition is unbounded, we can insert
any data into it.
: // We insert 100 row
> nit: for multi-line function calls, we generally use four spaces, per the C
Done
http://gerrit.cloudera.org:8080/#/c/13833/7/src/kudu/tools/kudu-admin-test.cc@2404
PS7, Line 2404: master_addr,
> nit: maybe pull this out into its own variable and reuse it everywhere
Done
http://gerrit.cloudera.org:8080/#/c/13833/7/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:
http://gerrit.cloudera.org:8080/#/c/13833/7/src/kudu/tools/tool_action_table.cc@489
PS7, Line 489: values;
> nit: how about, "an empty row will be used"?
Done
http://gerrit.cloudera.org:8080/#/c/13833/7/src/kudu/tools/tool_action_table.cc@653
PS7, Line 653: "'EXCLUSIVE_BOUND' can be received");
: }
: if (!boost::iequals(FLAGS_upper_bo
> nit: We don't need the Substitute() here. Could just be, "wrong type of ran
Done
http://gerrit.cloudera.org:8080/#/c/13833/7/src/kudu/tools/tool_action_table.cc@694
PS7, Line 694: per_b
> nit: for readability, rather than passing boolean arguments, we generally t
Done
http://gerrit.cloudera.org:8080/#/c/13833/7/src/kudu/tools/tool_action_table.cc@837
PS7, Line 837: kTableRangeLowerBoundArg,
: "String representation of lower
bound of "
> Could you also add that if the parameter is an empty array, the partition w
Done
--
To view, visit http://gerrit.cloudera.org:8080/13833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I647d9c3cf01807bd8ae9f8cf4091568ea6f1161c
Gerrit-Change-Number: 13833
Gerrit-PatchSet: 8
Gerrit-Owner: honeyhexin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yao Xu
Gerrit-Reviewer: honeyhexin
Gerrit-Comment-Date: Wed, 24 Jul 2019 14:23:02 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2881 Support create/drop range partition by command line
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Yao Xu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13833 to look at the new patch set (#8). Change subject: KUDU-2881 Support create/drop range partition by command line .. KUDU-2881 Support create/drop range partition by command line Sometimes we need to drop the range partition and then recreate it in order to rewrite in case that the partition was written wrongly. This patch supports to add/drop range partition by command line. The command can be used as: 1. kudu table add_range_partition [-lower_bound_type] [-upper_bound_type] 2. kudu table drop_range_partition [-lower_bound_type] [-upper_bound_type] The parameters of lower_bound and upper_bound can be empty, which means we will use the default value. If both these two parameters are empty, it means the range partition is unbounded. The parameters of lower_bound_type and upper_bound_type is optional. If these two parameters are not specified, the default value are INCLUSIVE_BOUND and EXCLUSIVE_BOUND respectively. These two parameters are both case-insensitive. Change-Id: I647d9c3cf01807bd8ae9f8cf4091568ea6f1161c --- M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_table.cc 4 files changed, 889 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/13833/8 -- To view, visit http://gerrit.cloudera.org:8080/13833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I647d9c3cf01807bd8ae9f8cf4091568ea6f1161c Gerrit-Change-Number: 13833 Gerrit-PatchSet: 8 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yao Xu Gerrit-Reviewer: honeyhexin
[kudu-CR] [master] Change the timeout threshold for unit test case
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13909 Change subject: [master] Change the timeout threshold for unit test case .. [master] Change the timeout threshold for unit test case In the previous patch, we use KUDU_ALLOW_SLOW_TEST to avoid failure in some environments. Now, another solution is proposed. It changes the timeout threshold to meet the assertion conditions. Change-Id: Ief5ec23c83022c2c5dbcc65a110ad8fe1f91f1a7 --- M src/kudu/master/sentry_authz_provider-test.cc 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/13909/1 -- To view, visit http://gerrit.cloudera.org:8080/13909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ief5ec23c83022c2c5dbcc65a110ad8fe1f91f1a7 Gerrit-Change-Number: 13909 Gerrit-PatchSet: 1 Gerrit-Owner: helifu
[kudu-CR] Deprecated TabletLocationsPB.ReplicaPB message
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 ) Change subject: Deprecated TabletLocationsPB.ReplicaPB message .. Patch Set 1: > (1 comment) It seems like this. :( I think I can make some changes to make the server-side compatible with the old client. -- To view, visit http://gerrit.cloudera.org:8080/13908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18272274f07d5ae8e9f6b9572f9900aa8df27bef Gerrit-Change-Number: 13908 Gerrit-PatchSet: 1 Gerrit-Owner: Yao Xu Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Yao Xu Gerrit-Comment-Date: Wed, 24 Jul 2019 07:31:43 + Gerrit-HasComments: No
[kudu-CR] Deprecated TabletLocationsPB.ReplicaPB message
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 ) Change subject: Deprecated TabletLocationsPB.ReplicaPB message .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13908/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13908/1//COMMIT_MSG@9 PS1, Line 9: According to the comments of https://gerrit.cloudera.org/#/c/13875/, the hrm, in those comments, it claimed that ReplicaPB was deprecated as of 0.5.0, but I'm not sure where that came from. The new InternedReplicaPB was added in 586e957f76a547340f2ab93a7eebc3f116ff825e which was only a few months ago. I think removing ReplicaPB would break wire compatibility with 1.9 and below? -- To view, visit http://gerrit.cloudera.org:8080/13908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18272274f07d5ae8e9f6b9572f9900aa8df27bef Gerrit-Change-Number: 13908 Gerrit-PatchSet: 1 Gerrit-Owner: Yao Xu Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 24 Jul 2019 07:19:38 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock
Todd Lipcon has uploaded a new patch set (#6) to the change originally created by ZhangYao. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock .. KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock This improves the performance of serializing RowBlocks to the wire by amortiznig the cost of iterating over the set bits of the selection bitmap. Instead of using the bitmap once per column, we convert the bitmap to a list of set indices up front, and then use those indices for conversion. This changes the benchmarks to report cycles/cell instead of raw times, making it easier to see the effects of column count or sparsity. Benchmark results: column count 3 and row select rate 1: 5.12520529 -> 5.44280228 cycles/cell column count 3 and row select rate 0.8: 12.74473127 -> 7.04588262 cycles/cell column count 3 and row select rate 0.5: 23.98607461 -> 7.51201477 cycles/cell column count 3 and row select rate 0.2: 40.66053179 -> 8.30233998 cycles/cell column count 30 and row select rate 1:15.43040511 -> 15.97765642 cycles/cell column count 30 and row select rate 0.8: 23.7480557 -> 17.84433817 cycles/cell column count 30 and row select rate 0.5: 40.08323337 -> 17.67888749 cycles/cell column count 30 and row select rate 0.2: 48.62210244 -> 16.56884988 cycles/cell column count 300 and row select rate 1: 18.9223316 -> 20.90426976 cycles/cell column count 300 and row select rate 0.8: 27.50793008 -> 21.92481189 cycles/cell column count 300 and row select rate 0.5: 40.34367716 -> 21.32180024 cycles/cell column count 300 and row select rate 0.2: 52.7446843 -> 20.92634437 cycles/cell Patch co-authored by Zhang Yao. Change-Id: I19917d1875c46fd4cf98ef8a471b0340a76161e7 --- M src/kudu/common/rowblock-test.cc M src/kudu/common/rowblock.cc M src/kudu/common/rowblock.h M src/kudu/common/wire_protocol-test.cc M src/kudu/common/wire_protocol.cc 5 files changed, 105 insertions(+), 53 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/13721/6 -- To view, visit http://gerrit.cloudera.org:8080/13721 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I19917d1875c46fd4cf98ef8a471b0340a76161e7 Gerrit-Change-Number: 13721 Gerrit-PatchSet: 6 Gerrit-Owner: ZhangYao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Yao Xu Gerrit-Reviewer: ZhangYao
[kudu-CR] Deprecated TabletLocationsPB.ReplicaPB message
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13908 Change subject: Deprecated TabletLocationsPB.ReplicaPB message .. Deprecated TabletLocationsPB.ReplicaPB message According to the comments of https://gerrit.cloudera.org/#/c/13875/, the TabletLocationsPB.ReplicaPB message has been deprecated a long time ago. In this patch, I removed the dependency on it from the code. Change-Id: I18272274f07d5ae8e9f6b9572f9900aa8df27bef --- M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToClusterResponse.java M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableLocationsRequest.java M java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java M java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ProtobufUtils.java M src/kudu/client/client.cc M src/kudu/client/meta_cache.cc M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/delete_table-itest.cc M src/kudu/integration-tests/linked_list-test.cc M src/kudu/integration-tests/master_sentry-itest.cc M src/kudu/integration-tests/raft_config_change-itest.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/integration-tests/registration-test.cc M src/kudu/integration-tests/table_locations-itest.cc M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/integration-tests/tombstoned_voting-itest.cc M src/kudu/integration-tests/ts_itest-base.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/master/master_service.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/rebalancer_tool-test.cc 28 files changed, 247 insertions(+), 290 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/13908/1 -- To view, visit http://gerrit.cloudera.org:8080/13908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I18272274f07d5ae8e9f6b9572f9900aa8df27bef Gerrit-Change-Number: 13908 Gerrit-PatchSet: 1 Gerrit-Owner: Yao Xu
[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock .. Patch Set 4: Talked to ZhangYao offline and he suggested I upload my change as a patch. Here it is, with up-to-date perf results in the commit message -- To view, visit http://gerrit.cloudera.org:8080/13721 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19917d1875c46fd4cf98ef8a471b0340a76161e7 Gerrit-Change-Number: 13721 Gerrit-PatchSet: 4 Gerrit-Owner: ZhangYao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Yao Xu Gerrit-Reviewer: ZhangYao Gerrit-Comment-Date: Wed, 24 Jul 2019 06:01:42 + Gerrit-HasComments: No
[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock
Todd Lipcon has uploaded a new patch set (#5) to the change originally created by ZhangYao. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock .. KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock This improves the performance of serializing RowBlocks to the wire by amortiznig the cost of iterating over the set bits of the selection bitmap. Instead of using the bitmap once per column, we convert the bitmap to a list of set indices up front, and then use those indices for conversion. This changes the benchmarks to report cycles/cell instead of raw times, making it easier to see the effects of column count or sparsity. Benchmark results: column count 3 and row select rate 1: 5.12520529 -> 5.44280228 cycles/cell column count 3 and row select rate 0.8: 12.74473127 -> 7.04588262 cycles/cell column count 3 and row select rate 0.5: 23.98607461 -> 7.51201477 cycles/cell column count 3 and row select rate 0.2: 40.66053179 -> 8.30233998 cycles/cell column count 30 and row select rate 1:15.43040511 -> 15.97765642 cycles/cell column count 30 and row select rate 0.8: 23.7480557 -> 17.84433817 cycles/cell column count 30 and row select rate 0.5: 40.08323337 -> 17.67888749 cycles/cell column count 30 and row select rate 0.2: 48.62210244 -> 16.56884988 cycles/cell column count 300 and row select rate 1: 18.9223316 -> 20.90426976 cycles/cell column count 300 and row select rate 0.8: 27.50793008 -> 21.92481189 cycles/cell column count 300 and row select rate 0.5: 40.34367716 -> 21.32180024 cycles/cell column count 300 and row select rate 0.2: 52.7446843 -> 20.92634437 cycles/cell Patch co-authored by Zhang Yao. Change-Id: I19917d1875c46fd4cf98ef8a471b0340a76161e7 --- M src/kudu/common/rowblock-test.cc M src/kudu/common/rowblock.cc M src/kudu/common/rowblock.h M src/kudu/common/wire_protocol-test.cc M src/kudu/common/wire_protocol.cc 5 files changed, 104 insertions(+), 53 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/13721/5 -- To view, visit http://gerrit.cloudera.org:8080/13721 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I19917d1875c46fd4cf98ef8a471b0340a76161e7 Gerrit-Change-Number: 13721 Gerrit-PatchSet: 5 Gerrit-Owner: ZhangYao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Yao Xu Gerrit-Reviewer: ZhangYao
