[kudu-CR] KUDU-2612 Java client transaction implementation

2021-01-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16929 ) Change subject: KUDU-2612 Java client transaction implementation .. Patch Set 9: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2612 keep-alive txn heartbeating for Java client

2021-01-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16967 ) Change subject: KUDU-2612 keep-alive txn heartbeating for Java client .. Patch Set 4: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2612 keep-alive txn heartbeating for Java client

2021-01-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-2612 keep-alive txn heartbeating for Java client .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16967 To

[kudu-CR] KUDU-2612 keep-alive txn heartbeating for Java client

2021-01-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16967 ) Change subject: KUDU-2612 keep-alive txn heartbeating for Java client .. Patch Set 4: Verified+1 unrelated test failure in

[kudu-CR] KUDU-2612 Java client transaction implementation

2021-01-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-2612 Java client transaction implementation .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16929 To

[kudu-CR] KUDU-2612 Java client transaction implementation

2021-01-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16929 ) Change subject: KUDU-2612 Java client transaction implementation .. Patch Set 9: Verified+1 Unrelated test failure in TSAN build:

[kudu-CR] KUDU-2612: add a TxnSystemClient to the tservers

2021-01-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16974 ) Change subject: KUDU-2612: add a TxnSystemClient to the tservers .. Patch Set 4: Code-Review+1 (5 comments) Looks good overall, just

[kudu-CR] KUDU-3230: Fix the issue of hardcode sasl proto name

2021-01-26 Thread Hongjiang Zhang (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16956 to look at the new patch set (#16). Change subject: KUDU-3230: Fix the issue of hardcode sasl_proto_name

[kudu-CR] KUDU-3230: Fix the issue of hardcode sasl proto name

2021-01-26 Thread Hongjiang Zhang (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16956 to look at the new patch set (#15). Change subject: KUDU-3230: Fix the issue of hardcode sasl_proto_name

[kudu-CR] KUDU-2612 keep-alive txn heartbeating for Java client

2021-01-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16967 ) Change subject: KUDU-2612 keep-alive txn heartbeating for Java client .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-2612 keep-alive txn heartbeating for Java client

2021-01-26 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16967 to look at the new patch set (#4). Change subject: KUDU-2612 keep-alive txn heartbeating for Java client

[kudu-CR] KUDU-2612 Java client transaction implementation

2021-01-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16929 ) Change subject: KUDU-2612 Java client transaction implementation .. Patch Set 5: (2 comments)

[kudu-CR] KUDU-2612 Java client transaction implementation

2021-01-26 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16929 to look at the new patch set (#9). Change subject: KUDU-2612 Java client transaction implementation

[kudu-CR] KUDU-2612: add a TxnSystemClient to the tservers

2021-01-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16974 ) Change subject: KUDU-2612: add a TxnSystemClient to the tservers .. Patch Set 4: (7 comments) Overall looks good to me, just some nits.

[kudu-CR] [java] address warnings from the SonarLint tool

2021-01-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16969 ) Change subject: [java] address warnings from the SonarLint tool .. Patch Set 1: (3 comments)

[kudu-CR] KUDU-3239: [build] Disable errorprone on Java 11

2021-01-26 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16983 ) Change subject: KUDU-3239: [build] Disable errorprone on Java 11 .. KUDU-3239: [build] Disable errorprone on Java 11 It turns

[kudu-CR](branch-1.14.x) Add release notes for 1.14.0

2021-01-26 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16980 ) Change subject: Add release notes for 1.14.0 .. Add release notes for 1.14.0 Change-Id:

[kudu-CR] KUDU-2612 keep-alive txn heartbeating for Java client

2021-01-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16967 ) Change subject: KUDU-2612 keep-alive txn heartbeating for Java client .. Patch Set 3: Code-Review+1 (2 comments)

[kudu-CR] KUDU-3239: [build] Disable errorprone on Java 11

2021-01-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16983 ) Change subject: KUDU-3239: [build] Disable errorprone on Java 11 .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3239: [build] Disable errorprone on Java 11

2021-01-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16983 ) Change subject: KUDU-3239: [build] Disable errorprone on Java 11 .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3239: [build] Disable errorprone on Java 11

2021-01-26 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16983 ) Change subject: KUDU-3239: [build] Disable errorprone on Java 11 .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3239: [build] Disable errorprone on Java 11

2021-01-26 Thread Grant Henke (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16983 to look at the new patch set (#2). Change subject: KUDU-3239: [build] Disable errorprone on Java 11

[kudu-CR] KUDU-2612: add a TxnSystemClient to the tservers

2021-01-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16974 ) Change subject: KUDU-2612: add a TxnSystemClient to the tservers .. Patch Set 4: Verified+1 Unrelated flaky test

[kudu-CR] KUDU-2612: add a TxnSystemClient to the tservers

2021-01-26 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2612: add a TxnSystemClient to the tservers .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16974 To unsubscribe,

[kudu-CR] KUDU-2612: add a TxnSystemClient to the tservers

2021-01-26 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2612: add a TxnSystemClient to the tservers .. Removed -Verified by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16974 To unsubscribe,

[kudu-CR] KUDU-2612 Java client transaction implementation

2021-01-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16929 ) Change subject: KUDU-2612 Java client transaction implementation .. Patch Set 8: Code-Review+1 (2 comments) Overall looks good to me,

[kudu-CR] [build] Disable errorprone on Java 11

2021-01-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16983 ) Change subject: [build] Disable errorprone on Java 11 .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [build] Disable errorprone on Java 11

2021-01-26 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16983 ) Change subject: [build] Disable errorprone on Java 11 .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [build] Disable errorprone on Java 11

2021-01-26 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16983 ) Change subject: [build] Disable errorprone on Java 11 .. Patch Set 1: Code-Review+2 Could you mention the JIRA in the commit

[kudu-CR] [build] Disable errorprone on Java 11

2021-01-26 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16983 Change subject: [build] Disable errorprone on Java 11 .. [build] Disable errorprone on Java 11 It turns out that errorprone is not

[kudu-CR](branch-1.14.x) Add release notes for 1.14.0

2021-01-26 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16980 ) Change subject: Add release notes for 1.14.0 .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/16980

[kudu-CR] KUDU-2612 Java client transaction implementation

2021-01-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16929 ) Change subject: KUDU-2612 Java client transaction implementation .. Patch Set 8: Verified+1 Unrelated build issue in TSAN build:

[kudu-CR] KUDU-2612 Java client transaction implementation

2021-01-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-2612 Java client transaction implementation .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16929 To

[kudu-CR] KUDU-2612 Java client transaction implementation

2021-01-26 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16929 to look at the new patch set (#8). Change subject: KUDU-2612 Java client transaction implementation

[kudu-CR] [build] Fix occasional Gradle build failures

2021-01-26 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16968 ) Change subject: [build] Fix occasional Gradle build failures .. [build] Fix occasional Gradle build failures Occasionally, on a

[kudu-CR] KUDU-3230: Fix the issue of hardcode sasl proto name

2021-01-26 Thread Hongjiang Zhang (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16956 to look at the new patch set (#14). Change subject: KUDU-3230: Fix the issue of hardcode sasl_proto_name