[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. KUDU-2353 (part 1): add a tool to parse

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 9: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-06-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 9: Code-Review+2 New unit test looks

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-06-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 9: (1 comment)

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-06-01 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new patch set (#9) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log ..

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-06-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 8: (1 comment)

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-06-01 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-06-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 8: Verified+1 Java flake. Unrelated.

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-06-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-06-01 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new patch set (#8) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log ..

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-06-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 7: Had to rework quite a bit to fit

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-06-01 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new patch set (#7) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log ..

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-06-01 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new patch set (#6) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log ..

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-05-31 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new patch set (#5) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log ..

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-05-31 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 4: Code-Review+1 (2 comments) Looks

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-05-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 4: Ah, I forgot about that. Thanks

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-05-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 4: Looks good though I'd still like to

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-05-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-05-30 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new patch set (#4) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log ..

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-05-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 3: (3 comments)

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-05-23 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 2: (11 comments) Didn't add any

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-05-23 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new patch set (#3) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log ..

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-05-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 2: One other comment I forgot to make

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-05-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 2: (11 comments)

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-05-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 1: (10 comments)

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-03-27 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 ) Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log .. Patch Set 1: (2 comments) Just small nits.

[kudu-CR] KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log

2018-03-22 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9773 to review the following change. Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log