Grant Henke has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 15:
(14 comments)
http://gerrit.cloudera.org:8080/#/c/6630/15/docs/design-docs/cfile.md
File
Todd Lipcon has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 15:
(13 comments)
http://gerrit.cloudera.org:8080/#/c/6630/15/docs/design-docs/cfile.md
File
Adar Dembo has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 15:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6630/15//COMMIT_MSG
Commit Message:
Line 7: WIP:
Adar Dembo has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 13:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6630/14/docs/design-docs/cfile.md
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6630
to look at the new patch set (#15).
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
WIP: KUDU-463. Add
Grant Henke has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 13:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6630/14/docs/design-docs/cfile.md
File
Adar Dembo has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 14:
(1 comment)
Looks good, just two other things:
1. What was your conclusion re: bit flipping in the test?
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6630
to look at the new patch set (#14).
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
WIP: KUDU-463. Add
Grant Henke has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 13:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/6630/13/src/kudu/cfile/cfile_writer.cc
File
Jean-Daniel Cryans has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6630/13/src/kudu/cfile/cfile_reader.cc
File
Adar Dembo has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 13:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/6630/13/src/kudu/cfile/cfile_reader.cc
File
Grant Henke has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 13:
(25 comments)
http://gerrit.cloudera.org:8080/#/c/6630/13/src/kudu/cfile/cfile-test.cc
File
Adar Dembo has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6630/13/src/kudu/cfile/cfile_reader.cc
File
Adar Dembo has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 13:
(28 comments)
http://gerrit.cloudera.org:8080/#/c/6630/13/src/kudu/cfile/cfile-test.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6630
to look at the new patch set (#13).
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
WIP: KUDU-463. Add
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6630
to look at the new patch set (#12).
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
WIP: KUDU-463. Add
Adar Dembo has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6630/11/src/kudu/util/env.h
File src/kudu/util/env.h:
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6630
to look at the new patch set (#11).
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
WIP: KUDU-463. Add
Adar Dembo has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 10:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6630/10/src/kudu/util/env_posix.cc
File
Grant Henke has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 10:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6630/10/src/kudu/util/env_posix.cc
File
Adar Dembo has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 10:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6630/10/src/kudu/fs/block_manager-test.cc
File
Grant Henke has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 10:
(23 comments)
http://gerrit.cloudera.org:8080/#/c/6630/10/src/kudu/cfile/cfile_reader.cc
File
Mike Percy has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 10:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/6630/10/src/kudu/cfile/cfile_reader.cc
File
Adar Dembo has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 10:
(21 comments)
I didn't review the checksumming stuff yet, just looked at the rest and the
plumbing.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6630
to look at the new patch set (#10).
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
WIP: KUDU-463. Add
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6630
to look at the new patch set (#9).
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
WIP: KUDU-463. Add
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6630
to look at the new patch set (#8).
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
WIP: KUDU-463. Add
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6630
to look at the new patch set (#7).
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
WIP: KUDU-463. Add
Grant Henke has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 6:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/6630/6/src/kudu/cfile/cfile_reader.cc
File
Adar Dembo has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6630/6/src/kudu/util/env.h
File src/kudu/util/env.h:
Todd Lipcon has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 6:
(2 comments)
Just did a quick look at the approach using readv, it seems like a good
direction to me. I
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6630
to look at the new patch set (#6).
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
WIP: KUDU-463. Add
Todd Lipcon has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6630/3/src/kudu/cfile/cfile-test.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6630
to look at the new patch set (#5).
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
WIP: KUDU-463. Add
Grant Henke has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 3:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/6630/3//COMMIT_MSG
Commit Message:
Line 19: immeditaly
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6630
to look at the new patch set (#4).
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
WIP: KUDU-463. Add
Todd Lipcon has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 3:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/6630/3//COMMIT_MSG
Commit Message:
PS3, Line 19:
Grant Henke has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 3:
I need to handle the header and footer yet, which may require a change in how
to handle backwards
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6630
to look at the new patch set (#3).
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
WIP: KUDU-463. Add
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6630
to look at the new patch set (#2).
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
WIP: KUDU-463. Add
Grant Henke has posted comments on this change.
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
Patch Set 1:
This is just a quick push to sanity check my approach.
--
To view, visit
Grant Henke has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6630
Change subject: WIP: KUDU-463. Add checksumming to cfile
..
WIP: KUDU-463. Add checksumming to cfile
Adds optional checksumming and
42 matches
Mail list logo
