[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-10-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: Bump! I want this like every day :) -- To view,

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: agreed we'd use pair or tuple for multi-out-param use

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: In Rust, where this pattern is pervasive, it's common

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: At first I thought this was supposed to be a

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: (1 comment)

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: (2 comments)

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: (1 comment)

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: btw looks like a newer (C++11-y) version is available

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: (2 comments)

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: (1 comment)

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: (9 comments)

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8127 Change subject: WIP: Pull StatusOr and related tests from protobuf .. WIP: Pull StatusOr and related tests from protobuf Needs