[kudu-CR] Doxygen for C++ client API

2016-07-21 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#13). Change subject: Doxygen for C++ client API .. Doxygen for C++

[kudu-CR] Doxygen for C++ client API

2016-07-21 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Doxygen for C++ client API .. Patch Set 13: Build Started http://104.196.14.100/job/kudu-gerrit/2614/ -- To view, visit http://gerrit.cloudera.org:8080/3619 To

[kudu-CR] Doxygen for C++ client API

2016-07-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Doxygen for C++ client API .. Patch Set 12: (42 comments) http://gerrit.cloudera.org:8080/#/c/3619/12/src/kudu/client/client.h File src/kudu/client/client.h:

[kudu-CR] Doxygen for C++ client API

2016-07-20 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Doxygen for C++ client API .. Patch Set 12: OK that's all my feedback. Thanks again for taking this on! -- To view, visit http://gerrit.cloudera.org:8080/3619

[kudu-CR] Doxygen for C++ client API

2016-07-20 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Doxygen for C++ client API .. Patch Set 12: (19 comments) http://gerrit.cloudera.org:8080/#/c/3619/12/src/kudu/client/client.h File src/kudu/client/client.h:

[kudu-CR] Doxygen for C++ client API

2016-07-19 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Doxygen for C++ client API .. Patch Set 12: Build Started http://104.196.14.100/job/kudu-gerrit/2566/ -- To view, visit http://gerrit.cloudera.org:8080/3619 To

[kudu-CR] Doxygen for C++ client API

2016-07-19 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#12). Change subject: Doxygen for C++ client API .. Doxygen for C++ client API If

[kudu-CR] Doxygen for C++ client API

2016-07-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Doxygen for C++ client API .. Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/3619/9/src/kudu/client/client.h File src/kudu/client/client.h: >

[kudu-CR] Doxygen for C++ client API

2016-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Doxygen for C++ client API .. Patch Set 11: (5 comments) http://gerrit.cloudera.org:8080/#/c/3619/9/src/kudu/client/client.h File src/kudu/client/client.h: > 1.

[kudu-CR] Doxygen for C++ client API

2016-07-19 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Doxygen for C++ client API .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/2551/ -- To view, visit http://gerrit.cloudera.org:8080/3619 To

[kudu-CR] Doxygen for C++ client API

2016-07-19 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#11). Change subject: Doxygen for C++ client API .. Doxygen for C++ client API If

[kudu-CR] doxygen for C++ client API

2016-07-19 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/2550/ -- To view, visit http://gerrit.cloudera.org:8080/3619 To

[kudu-CR] doxygen for C++ client API

2016-07-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 9: (64 comments) http://gerrit.cloudera.org:8080/#/c/3619/9/src/kudu/client/client.h File src/kudu/client/client.h:

[kudu-CR] doxygen for C++ client API

2016-07-19 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#10). Change subject: doxygen for C++ client API .. doxygen for C++ client API If

[kudu-CR] doxygen for C++ client API

2016-07-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 9: (1 comment) > One thing we should add to this (it can be a follow-up commit). > > It needs to be integrated into

[kudu-CR] doxygen for C++ client API

2016-07-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 9: (65 comments) http://gerrit.cloudera.org:8080/#/c/3619/9/src/kudu/client/client.h File src/kudu/client/client.h: High

[kudu-CR] doxygen for C++ client API

2016-07-18 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 9: One thing we should add to this (it can be a follow-up commit). It needs to be integrated into make_site.sh and the web

[kudu-CR] doxygen for C++ client API

2016-07-15 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#9). Change subject: doxygen for C++ client API .. doxygen for C++ client API If

[kudu-CR] doxygen for C++ client API

2016-07-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 8: (2 comments) Will send an update shortly. http://gerrit.cloudera.org:8080/#/c/3619/8/CMakeLists.txt File

[kudu-CR] doxygen for C++ client API

2016-07-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/2509/ -- To view, visit http://gerrit.cloudera.org:8080/3619 To

[kudu-CR] doxygen for C++ client API

2016-07-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/3619/8/CMakeLists.txt File CMakeLists.txt: Line 989:

[kudu-CR] doxygen for C++ client API

2016-07-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 8: (4 comments) Please see the responses in-line. Once the questions are cleared, I'll post the next version.

[kudu-CR] doxygen for C++ client API

2016-07-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 8: (6 comments) Thank you for review! http://gerrit.cloudera.org:8080/#/c/3619/8/CMakeLists.txt File CMakeLists.txt:

[kudu-CR] doxygen for C++ client API

2016-07-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/3619/8/CMakeLists.txt File CMakeLists.txt: Line 983:

[kudu-CR] doxygen for C++ client API

2016-07-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#8). Change subject: doxygen for C++ client API .. doxygen for C++ client API If

[kudu-CR] doxygen for C++ client API

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2504/ -- To view, visit http://gerrit.cloudera.org:8080/3619 To

[kudu-CR] doxygen for C++ client API

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2503/ -- To view, visit http://gerrit.cloudera.org:8080/3619 To