[kudu-CR] WIP: Integration test for replay cache

2016-06-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: Integration test for replay cache .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2112/ -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] WIP: Integration test for replay cache

2016-06-29 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3519 to look at the new patch set (#6). Change subject: WIP: Integration test for replay cache .. WIP: Integration test

[kudu-CR] WIP: Integration test for replay cache

2016-06-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: Integration test for replay cache .. Patch Set 5: thanks for taking a look. I can certainly spend some time elaborating on the invariants. Regarding

[kudu-CR] WIP: Integration test for replay cache

2016-06-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: Integration test for replay cache .. Patch Set 5: Been looking at the new test and the code for the last couple hours. A couple concerns I have from running

[kudu-CR] Update docs on how to run gcovr

2016-06-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Update docs on how to run gcovr .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3508/1/README.adoc File README.adoc: PS1, Line 221: gcc (not clan

[kudu-CR] WIP: Integration test for replay cache

2016-06-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: Integration test for replay cache .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2111/ -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] WIP: Integration test for replay cache

2016-06-29 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3519 to look at the new patch set (#5). Change subject: WIP: Integration test for replay cache .. WIP: Integration test

[kudu-CR] master failover-itest: eliminate some flakiness

2016-06-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: master_failover-itest: eliminate some flakiness .. Patch Set 1: Because, upon election and subsequent rebuild of master state, the new leader master must

[kudu-CR] WIP: Integration test for replay cache

2016-06-29 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3519 to look at the new patch set (#4). Change subject: WIP: Integration test for replay cache .. WIP: Integration test

[kudu-CR] WIP: Integration test for replay cache

2016-06-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: Integration test for replay cache .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2110/ -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] [java client] RPCs can get lost in a TabletClient race

2016-06-29 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3541 to look at the new patch set (#3). Change subject: [java client] RPCs can get lost in a TabletClient race .. [java

[kudu-CR] [java client] RPCs can get lost in a TabletClient race

2016-06-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java client] RPCs can get lost in a TabletClient race .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2109/ -- To view, visit http://gerrit

[kudu-CR] [java client] RPCs can get lost in a TabletClient race

2016-06-29 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] RPCs can get lost in a TabletClient race .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3541/1/java/kudu-client/src/main/ja

[kudu-CR] master failover-itest: eliminate some flakiness

2016-06-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: master_failover-itest: eliminate some flakiness .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3521/1//COMMIT_MSG Commit Message: Line 17: 1. Bey

[kudu-CR] master failover-itest: eliminate some flakiness

2016-06-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: master_failover-itest: eliminate some flakiness .. Patch Set 1: (1 comment) +2 with the commit message comment caveat http://gerrit.cloudera.org:8080/#/c

[kudu-CR] [java client] RPCs can get lost in a TabletClient race

2016-06-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java client] RPCs can get lost in a TabletClient race .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2108/ -- To view, visit http://gerrit

[kudu-CR] [java client] RPCs can get lost in a TabletClient race

2016-06-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] RPCs can get lost in a TabletClient race .. Patch Set 1: (4 comments) What releases (if any) are affected by this? We've been applying bandaid after

[kudu-CR] [java client] RPCs can get lost in a TabletClient race

2016-06-29 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3541 to look at the new patch set (#2). Change subject: [java client] RPCs can get lost in a TabletClient race .. [java

[kudu-CR] WIP: Integration test for replay cache

2016-06-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: Integration test for replay cache .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2107/ -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] WIP: Integration test for replay cache

2016-06-29 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3519 to look at the new patch set (#3). Change subject: WIP: Integration test for replay cache .. WIP: Integration test

[kudu-CR] [java client] RPCs can get lost in a TabletClient race

2016-06-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] RPCs can get lost in a TabletClient race .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3541/1/java/kudu-client/src/main/java/org/k

[kudu-CR] [java client] RPCs can get lost in a TabletClient race

2016-06-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java client] RPCs can get lost in a TabletClient race .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2106/ -- To view, visit http://gerrit

[kudu-CR] [java client] RPCs can get lost in a TabletClient race

2016-06-29 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3541 Change subject: [java client] RPCs can get lost in a TabletClient race .. [java client] RPCs can get lost in a TabletClient race We

[kudu-CR] Add missing include to rwlock-perf.cc

2016-06-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. Change subject: Add missing include to rwlock-perf.cc .. Abandoned got merged elsewise -- To view, visit http://gerrit.cloudera.org:8080/3527 To unsubscribe, visit http://gerrit.cloudera

[kudu-CR] KUDU-1490: Show software version of tablet servers

2016-06-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1490: Show software version of tablet servers .. KUDU-1490: Show software version of tablet servers In the web UI, it could be helpful to know what v

[kudu-CR] Disable core dumping in integration tests which crash

2016-06-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Disable core dumping in integration tests which crash .. Disable core dumping in integration tests which crash In TSAN builds, core dumps can take minutes

[kudu-CR] KUDU-1490: Show software version of tablet servers

2016-06-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1490: Show software version of tablet servers .. Patch Set 5: Code-Review+2 Looks good! -- To view, visit http://gerrit.cloudera.org:8080/3535 To unsubscribe

[kudu-CR] KUDU-1490: Show software version of tablet servers

2016-06-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1490: Show software version of tablet servers .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2105/ -- To view, visit http://gerrit.clo

[kudu-CR] KUDU-1490: Show software version of tablet servers

2016-06-29 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3535 to look at the new patch set (#5). Change subject: KUDU-1490: Show software version of tablet servers .. KUDU-1490:

[kudu-CR] Show software version of tablet servers

2016-06-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Show software version of tablet servers .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3535/4//COMMIT_MSG Commit Message: PS4, Line 7: Show softw

[kudu-CR] Show software version of tablet servers

2016-06-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Show software version of tablet servers .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2104/ -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] Show software version of tablet servers

2016-06-29 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3535 to look at the new patch set (#4). Change subject: Show software version of tablet servers .. Show software version

[kudu-CR] [java-client] refactor AsyncKuduSession

2016-06-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java-client] refactor AsyncKuduSession .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/3477/3/java/kudu-client/src/main/java/org/kududb/client/As

[kudu-CR] [java-client] refactor AsyncKuduSession

2016-06-29 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] refactor AsyncKuduSession .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3477 To unsubscribe, visit http://g

[kudu-CR] [java-client] refactor AsyncKuduSession

2016-06-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java-client] refactor AsyncKuduSession .. Patch Set 4: (11 comments) http://gerrit.cloudera.org:8080/#/c/3477/3/java/kudu-client/src/main/java/org/kududb/client/

[kudu-CR] Show software version of tablet servers

2016-06-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Show software version of tablet servers .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3535/2//COMMIT_MSG Commit Message: PS2, Line 7: software v

[kudu-CR] Show software version of tablet servers

2016-06-29 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Show software version of tablet servers .. Patch Set 3: (3 comments) > (2 comments) > > please also add a new assertion in registration-test.cc to check > tha

[kudu-CR] Show software version of tablet servers

2016-06-29 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3535 to look at the new patch set (#3). Change subject: Show software version of tablet servers .. Show software version

[kudu-CR] Show software version of tablet servers

2016-06-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Show software version of tablet servers .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2103/ -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] Show software vers to tablets in master web server

2016-06-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Show software vers to tablets in master web server .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3535/2/src/kudu/tserver/heartbeater.cc File src/

[kudu-CR] Disable core dumping in integration tests which crash

2016-06-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Disable core dumping in integration tests which crash .. Patch Set 2: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2102/ -- To view, visit http

[kudu-CR] Remove unused RunShellProcess() function

2016-06-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Remove unused RunShellProcess() function .. Remove unused RunShellProcess() function Change-Id: I881410660a360d2c6f75046dc95d61453b562bd2 Reviewed-on: htt

[kudu-CR] Show software vers to tablets in master web server

2016-06-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Show software vers to tablets in master web server .. Patch Set 2: (2 comments) please also add a new assertion in registration-test.cc to check that the version

[kudu-CR] Show software vers to tablets in master web server

2016-06-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Show software vers to tablets in master web server .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2101/ -- To view, visit http://gerrit.clo

[kudu-CR] Show software vers to tablets in master web server

2016-06-29 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#2). Change subject: Show software vers to tablets in master web server .. Show software vers to tablets in master web server In the web UI, it could be helpful to know what version of t

[kudu-CR] Disable core dumping in integration tests which crash

2016-06-29 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Disable core dumping in integration tests which crash .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3534 To unsubscribe, visit ht

[kudu-CR] Remove unused RunShellProcess() function

2016-06-29 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Remove unused RunShellProcess() function .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3533 To unsubscribe, visit http://gerrit.c

[kudu-CR] Remove unused RunShellProcess() function

2016-06-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Remove unused RunShellProcess() function .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2100/ -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] Remove unused RunShellProcess() function

2016-06-29 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3533 to look at the new patch set (#2). Change subject: Remove unused RunShellProcess() function .. Remove unused RunShell

[kudu-CR] Remove unused RunShellCommand() function

2016-06-29 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Remove unused RunShellCommand() function .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3533/1//COMMIT_MSG Commit Message: Line 7:

[kudu-CR] Show software vers to tablets in master web server

2016-06-29 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3535 Change subject: Show software vers to tablets in master web server .. Show software vers to tablets in master web server In the web UI, it

[kudu-CR] Show software vers to tablets in master web server

2016-06-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Show software vers to tablets in master web server .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2099/ -- To view, visit http://gerrit.clo

[kudu-CR] Remove unused RunShellCommand() function

2016-06-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Remove unused RunShellCommand() function .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2097/ -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] Disable core dumping in integration tests which crash

2016-06-29 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3534 to review the following change. Change subject: Disable core dumping in integration tests which crash .. Disable core d

[kudu-CR] Disable core dumping in integration tests which crash

2016-06-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Disable core dumping in integration tests which crash .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2098/ -- To view, visit http://gerrit.

[kudu-CR] Remove unused RunShellCommand() function

2016-06-29 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3533 to review the following change. Change subject: Remove unused RunShellCommand() function .. Remove unused RunShellComma

[kudu-CR] [java-client] refactor AsyncKuduSession

2016-06-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java-client] refactor AsyncKuduSession .. Patch Set 4: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2096/ -- To view, visit http://gerrit.clou

[kudu-CR] Implement SchemaRelationProvider

2016-06-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Implement SchemaRelationProvider .. Patch Set 1: (1 comment) LGTM except for the style nit. http://gerrit.cloudera.org:8080/#/c/3529/1/java/kudu-spark/src/main/s

[kudu-CR] build: adjust boost location check slightly

2016-06-29 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: build: adjust boost location check slightly .. build: adjust boost location check slightly Commit 5b83695 broke the Cloudera packaging builds because the b

[kudu-CR] build: adjust boost location check slightly

2016-06-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: build: adjust boost location check slightly .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3530 To unsubscribe, visit http://gerr

[kudu-CR] build: adjust boost location check slightly

2016-06-29 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: build: adjust boost location check slightly .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3530 To unsubscribe, visit http

[kudu-CR] build: adjust boost location check slightly

2016-06-29 Thread Adar Dembo (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3530 to review the following change. Change subject: build: adjust boost location check slightly .. build: adjust boost loc

[kudu-CR] build: adjust boost location check slightly

2016-06-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: build: adjust boost location check slightly .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2095/ -- To view, visit http://gerrit.cloudera.o

[kudu-CR] [java-client] refactor AsyncKuduSession

2016-06-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java-client] refactor AsyncKuduSession .. Patch Set 4: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2094/ -- To view, visit http://gerrit.clou