Re: Review Request 44379: Correctly parse perf stat format for non-vanilla 3.10 kernel.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/#review122894 --- Patch looks great! Reviews applied: [44379] Passed command:

Re: Review Request 44584: Improved docs for dynamic weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44584/#review122893 --- docs/weights.md (lines 39 - 44)

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/ --- (Updated March 10, 2016, 8:34 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44584: Improved docs for dynamic weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44584/#review122891 --- Fix it, then Ship it! Fix it, then Ship it docs/roles.md

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

> On March 9, 2016, 10:18 a.m., Adam B wrote: > > src/master/master.cpp, line 2837 > > > > > > When would this ever be empty? Shouldn't we have validated somewhere > > prior that the Reserve operation is reserving

Re: Review Request 44583: Reran `generate-endpoint-help.py` script for `/weights` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44583/#review122889 --- src/master/http.cpp (lines 1166 - 1167)

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

> On 三月 10, 2016, 5:21 a.m., Neil Conway wrote: > > src/tests/persistent_volume_endpoints_tests.cpp, line 60 > > > > > > "using" directives should be sorted alphabetically. Thanks for the review, has updated the

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44606/ --- (Updated 三月 10, 2016, 7:11 a.m.) Review request for mesos, Guangya Liu, Neil

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review122887 --- We may need to do some discovery on whether an executor could

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/#review122886 --- Can you add some tests for these endpoints that show that hitting

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review122881 --- Patch looks great! Reviews applied: [44255] Passed command:

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44606/#review122879 --- Can you also update the documentation? In particular,

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/#review122874 --- I just did a grep and I found this: ```sh $ ag --cpp

Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44606/ --- Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod Kone.

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review122873 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Re: Review Request 44379: Correctly parse perf stat format for non-vanilla 3.10 kernel.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/ --- (Updated 三月 10, 2016, 3:24 a.m.) Review request for mesos. Changes ---

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

> On 三月 7, 2016, 10:43 p.m., Jie Yu wrote: > > src/master/master.cpp, line 2846 > > > > > > I looked weird to me that we increase the metrics for reserve resources > > in 'authorizeXXX' function. Can you do that

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/ --- (Updated 三月 10, 2016, 2:42 a.m.) Review request for mesos, Greg Mann, Guangya

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On 三月 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue` would

Re: Review Request 44026: Moved future tests into future_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44026/#review122869 --- Patch looks great! Reviews applied: [44026] Passed command:

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

> On March 9, 2016, 6:46 p.m., Michael Park wrote: > > src/tests/cluster.hpp, line 88 > > > > > > Why do we need to return `Try` as opposed to > > `Try`? > > Joseph Wu wrote: > We return an

Re: Review Request 44531: Fixed parsing network ip address with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/#review122860 --- Ship it! Ship It! - Travis Hegner On March 8, 2016, 10:54

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On March 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue`

Re: Review Request 42516: Add support for user-defined networks.

> On 二月 18, 2016, 10:44 p.m., Jie Yu wrote: > > include/mesos/v1/mesos.proto, lines 1543-1544 > > > > > > We're going to introduce a ContainerInfo.NetworkInfo.name to allow > > frameworks to specify the network

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On March 9, 2016, 9:03 p.m., Ezra Silvera wrote: > > src/docker/docker.cpp, lines 304-305 > > > > > > Please note that a container can be attached to more then one network! > > In that case HostConfig.NetworkMode

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On 三月 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue` would

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On 三月 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue` would

Re: Review Request 44475: Improve master slave metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44475/#review122848 --- Patch looks great! Reviews applied: [44473, 44474, 44475]

Re: Review Request 41049: New python lib with only the executor driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41049/#review122835 --- Patch looks great! Reviews applied: [41049] Passed command:

Re: Review Request 44470: Implemented runtime isoaltor default entrypoint test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44470/#review122833 --- src/tests/containerizer/runtime_isolator_tests.cpp (lines 173 -

Re: Review Request 44469: Implemented runtime isolator default cmd test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44469/#review122830 --- Fix it, then Ship it!

Re: Review Request 44467: Implemented local puller shell command test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44467/#review122829 --- src/tests/containerizer/provisioner_docker_tests.cpp (line 31)

Re: Review Request 44467: Implemented local puller shell command test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44467/#review122826 --- Fix it, then Ship it!

Re: Review Request 44584: Improved docs for dynamic weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44584/#review122822 --- Patch looks great! Reviews applied: [44583, 44584] Passed

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On March 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue`

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On March 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue`

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated March 9, 2016, 1:23 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 9, 2016, 9:20 p.m.) Review request for mesos and Benjamin

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review122802 --- src/docker/docker.cpp (lines 304 - 305)

Re: Review Request 44342: XFS disk resource isolator.

> On March 9, 2016, 6:03 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.hpp, line 87 > > > > > > Ditto about uint32_t vs prid_t. We don't use ``prid_t`` in the header so that the XFS

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On March 9, 2016, 8:48 p.m., Ezra Silvera wrote: > > Please note that a container can be attached to more then one network! In > > that case HostConfig.NetworkMode will contain the first NW the container > > was attached two. The desired IP, however, might be the one on a different > > NW

Re: Review Request 44554: Added agent HTTP authentication to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44554/ --- (Updated March 9, 2016, 9 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44554: Added agent HTTP authentication to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44554/ --- (Updated March 9, 2016, 8:58 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review122796 --- Please note that a container can be attached to more then one

Review Request 44554: Added agent HTTP authentication to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44554/ --- Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff. Bugs:

Re: Review Request 44515: Added agent flags for HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 9, 2016, 8:47 p.m.) Review request for mesos, Adam B, Alexander

Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff. Bugs:

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/ --- (Updated March 9, 2016, 8:42 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44515: Added agent flags for HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 9, 2016, 8:42 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44515: Added agent flags for HTTP authentication.

> On March 9, 2016, 4:56 a.m., Alexander Rojas wrote: > > src/slave/constants.cpp, line 58 > > > > > > Can you create a JIRA issue so we make the naming of the realm symetric > > in the master to _mesos-master_. I

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/ --- (Updated March 9, 2016, 12:10 p.m.) Review request for mesos, Benjamin

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

> On March 9, 2016, 10:46 a.m., Michael Park wrote: > > src/tests/cluster.hpp, line 88 > > > > > > Why do we need to return `Try` as opposed to > > `Try`? We return an `Owned` so that the tests can

Re: Review Request 44580: Made changes to the executor library around managing connections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44580/#review122785 --- Patch looks great! Reviews applied: [44578, 44579, 44580]

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On March 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue`

Re: Review Request 44026: Moved future tests into future_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44026/ --- (Updated March 9, 2016, 7:25 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 44026: Moved future tests into future_tests.cpp.

> On Feb. 26, 2016, 1:45 a.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp, lines 1764-1776 > > > > > > Should this be moved to `future_tests.cpp` too? > > Cong Wang wrote: > Yes,

Re: Review Request 44474: Improve master tasks metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44474/ --- (Updated March 9, 2016, 7:08 p.m.) Review request for mesos, Ben Mahler, Ian

Re: Review Request 44475: Improve master slave metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44475/ --- (Updated March 9, 2016, 7:08 p.m.) Review request for mesos, Ben Mahler, Ian

Re: Review Request 44473: Added decrement operator to Counter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44473/ --- (Updated March 9, 2016, 7:07 p.m.) Review request for mesos, Ben Mahler, Ian

Re: Review Request 44026: Moved future tests into future_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44026/ --- (Updated March 9, 2016, 7:01 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 44515: Added agent flags for HTTP authentication.

> On March 9, 2016, 3:56 a.m., Alexander Rojas wrote: > > src/slave/constants.cpp, line 58 > > > > > > Can you create a JIRA issue so we make the naming of the realm symetric > > in the master to _mesos-master_. I

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On March 8, 2016, 11:51 p.m., Dan Osborne wrote: > > Ship It! I ran a test cluster and found no regression for launching containers networked with bridge and host. - Dan --- This is an automatically generated e-mail. To reply,

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review122760 --- Pass over the header file for questions + review of the API.

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- (Updated March 9, 2016, 6:37 p.m.) Review request for mesos and Benjamin

Re: Review Request 44289: Added support for contender and detector modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated March 9, 2016, 6:39 p.m.) Review request for mesos and Benjamin

Re: Review Request 44547: Added functions in promises to the collect header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated March 9, 2016, 6:39 p.m.) Review request for mesos and Benjamin

Re: Review Request 44546: Moved functions in promises to a common header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated March 9, 2016, 6:38 p.m.) Review request for mesos and Benjamin

Re: Review Request 44545: Separated standalone and zookeeper classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated March 9, 2016, 6:38 p.m.) Review request for mesos and Benjamin

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated March 9, 2016, 6:37 p.m.) Review request for mesos and Benjamin

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

> On March 8, 2016, 11:37 p.m., Adam B wrote: > > src/master/constants.cpp, lines 52-53 > > > > > > Would the same hold true for any machine that runs both a master and an > > agent process? > > Or is it only

Re: Review Request 41049: New python lib with only the executor driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41049/ --- (Updated March 9, 2016, 6:24 p.m.) Review request for mesos, Till Toenshoff

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 18, 2016, 10:44 p.m., Jie Yu wrote: > > include/mesos/v1/mesos.proto, lines 1543-1544 > > > > > > We're going to introduce a ContainerInfo.NetworkInfo.name to allow > > frameworks to specify the network

Review Request 44584: Improved docs for dynamic weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44584/ --- Review request for mesos and Adam B. Repository: mesos Description ---

Review Request 44583: Reran `generate-endpoint-help.py` script for `/weights` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44583/ --- Review request for mesos and Adam B. Repository: mesos Description ---

Re: Review Request 44342: XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44342/#review122156 --- Partial review. Continuing on the latest revision. It would be

Review Request 44579: Minor fix to output state during a `CHECK` failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44579/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 44580: Made changes to the executor library around managing connections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44580/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4858

Review Request 44578: Pass `received` argument by const ref in the executor library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44578/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4858

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

> On March 7, 2016, 10:43 p.m., Jie Yu wrote: > > src/master/master.cpp, line 2846 > > > > > > I looked weird to me that we increase the metrics for reserve resources > > in 'authorizeXXX' function. Can you do

Re: Review Request 44469: Implemented runtime isolator default cmd test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44469/ --- (Updated March 9, 2016, 9:55 a.m.) Review request for mesos, Artem

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review122743 --- Patch looks great! Reviews applied: [44570] Passed command:

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review122740 --- Ship it! Ship It! - Gilbert Song On March 7, 2016, 9:17

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/#review122729 --- Patch looks great! Reviews applied: [44318, 44319, 44320, 44322]

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

> On March 9, 2016, 4:33 p.m., James DeFelice wrote: > > include/mesos/mesos.proto, line 442 > > > > > > what if it's specified in both places, two different ways? I think > > there's room for a little more

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/ --- (Updated March 9, 2016, 4:48 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review122725 --- include/mesos/mesos.proto (line 442)

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/ --- (Updated March 9, 2016, 4 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/ --- (Updated March 9, 2016, 3:51 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review122721 --- Does it a typo in Description? s/archived/achieved

Re: Review Request 44511: Add registry tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/#review122722 --- Patch looks great! Reviews applied: [41681, 43863, 44512, 41790,

Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/ --- Review request for mesos, Adam B and Joerg Schad. Bugs: MESOS-4772

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/ --- (Updated March 9, 2016, 3:10 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/ --- (Updated March 9, 2016, 3:07 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44531: Fixed parsing network ip address with docker.

> On March 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue`

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/#review122714 --- Patch looks great! Reviews applied: [44004, 44200, 44549, 44555]

Re: Review Request 43758: Made signal escalation timeout configurable in command executor.

> On Feb. 19, 2016, 1:23 p.m., Guangya Liu wrote: > > src/launcher/executor.cpp, lines 173-174 > > > > > > Add some checking here if the `escalationTimeout < Duration::zero()`? Good point. Indeed, we theoretically

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/#review122711 --- Patch looks great! Reviews applied: [41681, 43863, 44450]

Re: Review Request 44439: Added device support in cgroups abstraction.

> On March 9, 2016, 1:58 a.m., Ben Mahler wrote: > > src/linux/cgroups.hpp, lines 635-654 > > > > > > The naming convention in this file is to mirror the cgroups controls, > > so these would be: > > > >

Re: Review Request 44511: Add registry tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/ --- (Updated March 9, 2016, 10:03 a.m.) Review request for mesos and Adam B.

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated March 9, 2016, 9:47 a.m.) Review request for mesos, Adam B, Neil

  1   2   >