Re: Review Request 45314: Updated `network::connect` to use the typeful `Try` error state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45314/#review125387 --- Patch looks great! Reviews applied: [45310, 45311, 45312, 45313,

Re: Review Request 45327: Drop HTTP Status `404` and `307` in the scheduler library.

> On March 25, 2016, 1:53 a.m., Anand Mazumdar wrote: > > LGTM, just some minor code comments. Thanks a lot for the review Anand. I just updated the review request with the fixes. Let me know if there are other issues. - Yong --- This

Re: Review Request 45327: Drop HTTP Status `404` and `307` in the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45327/ --- (Updated March 25, 2016, 2:28 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 43935: Allow setting role in mesos-execute.

> On 三月 24, 2016, 7:57 p.m., Greg Mann wrote: > > src/cli/execute.cpp, line 215 > > > > > > s/sepcified/specified/ Sorry for the typo... please review again. - Jian

Re: Review Request 43935: Allow setting role in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/ --- (Updated 三月 25, 2016, 1:54 a.m.) Review request for mesos, Greg Mann, Shuai

Re: Review Request 45327: Drop HTTP Status `404` and `307` in the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45327/#review125378 --- Fix it, then Ship it! LGTM, just some minor code comments.

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/#review125377 --- Patch looks great! Reviews applied: [45304] Passed command:

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review125367 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 45290: Added a test for the '/files/debug' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45290/ --- (Updated March 25, 2016, midnight) Review request for mesos, Adam B, Ben

Re: Review Request 45249: Added a new '/files' endpoints test using authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45249/ --- (Updated March 24, 2016, 11:59 p.m.) Review request for mesos, Adam B, Ben

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review125362 --- Ship it! Ship It! - Jie Yu On March 24, 2016, 2:34 a.m.,

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On March 16, 2016, 11:08 p.m., Jie Yu wrote: > > This patch breaks all the ROOT DOCKER tests in our internal CI. I've > > reverted it for now. Can you do a sudo make check with docker? > > Steve Niemitz wrote: > ok, I see what the problem is here. The issue is with the >

Re: Review Request 44834: Documented task, executor, and volume IDs reuse is discouraged.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44834/#review125348 --- Ship it! Ship It! - Jie Yu On March 15, 2016, 5:54 a.m.,

Re: Review Request 44500: Implemented passing image and user env var to command task.

> On March 16, 2016, 4:22 a.m., Benjamin Bannier wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, line 160 > > > > > > Does it makes sense to distinguish the sources of overwriting here and >

Re: Review Request 44500: Implemented passing image and user env var to command task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44500/ --- (Updated March 24, 2016, 3:01 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 45320: Made libprocess return "Accepted" for all libprocess requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45320/ --- (Updated March 24, 2016, 9:58 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45320: Made libprocess return "Accepted" for all libprocess requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45320/ --- (Updated March 24, 2016, 9:57 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44499: Added task_environment flag/used execvpe for command executor.

> On March 16, 2016, 4:22 a.m., Benjamin Bannier wrote: > > src/launcher/executor.cpp, lines 470-471 > > > > > > Any reason we cannot use the `CHECK` condition for the `if`? Thanks, Benjamin! We do not always have

Review Request 45320: Made libprocess return "Accepted" for all libprocess requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45320/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 45319: Cleaned up various code in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45319/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 45318: Added a comment to a utility function in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45318/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 44499: Added task_environment flag/used execvpe for command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44499/ --- (Updated March 24, 2016, 2:53 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 44498: Forbid the executor to inherit from slave environment.

> On March 8, 2016, 10:02 p.m., Guangya Liu wrote: > > The configuration.md should also be updated. > > Gilbert Song wrote: > Thanks, Guangya! Will do. > > Note that this patch will be commited until 0.30 :) Fixed. Thanks, Guangya! - Gilbert

Re: Review Request 44498: Forbid the executor to inherit from slave environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44498/ --- (Updated March 24, 2016, 2:51 p.m.) Review request for mesos and Jie Yu.

Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5014

Re: Review Request 45249: Added new '/files' endpoints tests using authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45249/ --- (Updated March 24, 2016, 8:33 p.m.) Review request for mesos, Adam B, Ben

Re: Review Request 45248: Added authentication to the '/files' endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45248/ --- (Updated March 24, 2016, 8:30 p.m.) Review request for mesos, Adam B, Ben

Re: Review Request 43911: Updated `/state` agent endpoint to use jsonify.

> On March 10, 2016, 7 p.m., Michael Park wrote: > > src/slave/http.cpp, line 105 > > > > > > If we were using `model` before, we need to maintain that. > > > > We have a `json` defined for `CommandInfo` in

Review Request 45313: Introduced `WindowsSocketError` and factored out `WindowsErrorBase`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45313/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Repository:

Review Request 45314: Updated `network::connect` to use the typeful `Try` error state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45314/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Repository:

Review Request 45312: Captured the error code in `ErrnoError` and `WindowsError`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45312/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Repository:

Review Request 45310: Removed unnecessary constructors in `Try`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45310/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Repository:

Re: Review Request 43935: Allow setting role in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review125329 --- Fix it, then Ship it! src/cli/execute.cpp (line 214)

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On March 16, 2016, 11:08 p.m., Jie Yu wrote: > > This patch breaks all the ROOT DOCKER tests in our internal CI. I've > > reverted it for now. Can you do a sudo make check with docker? > > Steve Niemitz wrote: > ok, I see what the problem is here. The issue is with the >

Re: Review Request 45280: Test upload binary file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45280/#review125324 --- Patch looks great! Reviews applied: [45280] Passed command:

Review Request 45304: Change Call and Event Type enums in executor.proto optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5015

Re: Review Request 45186: Implemented user specified system config files support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45186/#review125311 --- I am discarding these patches because they should be supported by

Re: Review Request 45278: Replace remain zookeeper version number.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45278/#review125308 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review125297 --- Patch looks great! Reviews applied: [37168] Passed command:

Re: Review Request 44993: Updated `TestContainerizer` to support default actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44993/ --- (Updated March 24, 2016, 5:30 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review125072 --- src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp (line

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/#review124983 --- src/slave/containerizer/mesos/containerizer.cpp (line 217)

Re: Review Request 45185: Introduced an agent flag 'system_config_files'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45185/#review125289 --- src/slave/flags.cpp (line 108)

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

> On March 23, 2016, 8:21 a.m., Deshi Xiao wrote: > > can we ignore .md scan? the .md possible container non-ascii characters. Are non-ASCII characters in .md files actually required? We should be able to use HTML character entities instead (e.g., ``) instead. - Neil

Re: Review Request 45186: Implemented user specified system config files support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45186/#review125287 --- src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line

Re: Review Request 43911: Updated `/state` agent endpoint to use jsonify.

> On March 24, 2016, 4:38 p.m., Michael Park wrote: > > src/slave/http.cpp, line 96 > > > > > > This should be marked `static`, right? This is addressed in https://reviews.apache.org/r/44981/. - Michael

Re: Review Request 44981: Marked some private `json` functions as `static`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44981/#review125283 --- Ship it! Ship It! - Michael Park On March 17, 2016, 9:33

Re: Review Request 44658: Removed unused signal escalation constant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44658/ --- (Updated March 24, 2016, 4:15 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/ --- (Updated March 24, 2016, 4:18 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 44707: Added validation for task's kill policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/ --- (Updated March 24, 2016, 4:15 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44854: Added validation for executor's shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/ --- (Updated March 24, 2016, 4:14 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44657: Used `KillPolicy` and shutdown grace period in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44657/ --- (Updated March 24, 2016, 4:15 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44656: Introduced `KillPolicy` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44656/ --- (Updated March 24, 2016, 4:15 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44994: Added a test for executor shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/ --- (Updated March 24, 2016, 4:15 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44991: Enabled mocking on `TestContainerizer::destroy`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44991/ --- (Updated March 24, 2016, 4:14 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/ --- (Updated March 24, 2016, 4:14 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/ --- (Updated March 24, 2016, 4:13 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review125266 --- Patch looks great! Reviews applied: [45214, 45217, 45265, 45270]

Re: Review Request 44084: Windows: Forked os::rename().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44084/ --- (Updated March 24, 2016, 2:59 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 42551: Porting mesos on ppc64le.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42551/#review125251 --- Patch looks great! Reviews applied: [42551] Passed command:

Re: Review Request 43883: Added a metric for querying the number offer filters for a role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated March 24, 2016, 2:36 p.m.) Review request for mesos, Alexander

Re: Review Request 45082: Implemented cleanup() method of "network/cni" isolator.

> On March 22, 2016, 11:37 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 151 > > > > > > I guess if we are going to use `attach` for connecting to networks, >

Re: Review Request 45280: Test upload binary file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45280/ --- (Updated March 24, 2016, 11:08 a.m.) Review request for mesos and Zhiwei Chen.

Re: Review Request 45280: Test upload binary file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45280/ --- (Updated March 24, 2016, 11:03 a.m.) Review request for mesos and Zhiwei Chen.

Re: Review Request 44846: Deprecated the plain text credential format.

> On March 17, 2016, 6:21 p.m., Joerg Schad wrote: > > src/master/flags.cpp, line 227 > > > > > > We now mention deprecated twice here. > > The 'Note that' also seems to be out of sync with the configuration.md.

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review125237 --- Patch looks great! Reviews applied: [44255] Passed command:

Re: Review Request 45280: Test upload binary file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45280/ --- (Updated March 24, 2016, 10:23 a.m.) Review request for mesos and Zhiwei Chen.

Re: Review Request 45280: Test upload binary file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45280/ --- (Updated March 24, 2016, 10:21 a.m.) Review request for mesos and Zhiwei Chen.

Re: Review Request 45280: Test upload binary file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45280/ --- (Updated March 24, 2016, 10:19 a.m.) Review request for mesos and Zhiwei Chen.

Re: Review Request 44448: Replaced EXIT(1) with EXIT(EXIT_FAILURE).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8/ --- (Updated March 24, 2016, 10:19 a.m.) Review request for mesos and Bernd

Re: Review Request 44447: Replaced EXIT(1) with EXIT(EXIT_FAILURE) in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7/ --- (Updated March 24, 2016, 10:18 a.m.) Review request for mesos and Bernd

Re: Review Request 44446: Replaced EXIT(1) with EXIT(EXIT_FAILURE) in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/ --- (Updated March 24, 2016, 10:18 a.m.) Review request for mesos and Bernd

Review Request 45280: Test upload binary file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45280/ --- Review request for mesos and Zhiwei Chen. Repository: mesos Description

Review Request 45278: Replace remain zookeeper version number.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45278/ --- Review request for mesos. Repository: mesos Description --- Replace

Review Request 45277: Add zookeeper-3.4.8.tar.gz.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45277/ --- Review request for mesos and Zhiwei Chen. Repository: mesos Description

Review Request 45276: Remove zookeeper-3.4.5.tar.gz.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45276/ --- Review request for mesos and Zhiwei Chen. Repository: mesos Description

Re: Review Request 45037: Regenerated agent endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45037/#review125235 --- Ship it! Ship It! - Adam B On March 24, 2016, 2:07 a.m.,

Re: Review Request 45037: Regenerated agent endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45037/ --- (Updated March 24, 2016, 9:07 a.m.) Review request for mesos, Adam B and Greg

Re: Review Request 45037: Regenerated agent endpoint documentation.

> On March 21, 2016, 10:30 a.m., Adam B wrote: > > docs/endpoints/slave/health.md, lines 17-18 > > > > > > Why the double-blank line here (and elsewhere)? This is caused by the way the Description help is generated.

Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44376/ --- (Updated March 24, 2016, 4:58 p.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 45269: Test upload zookeeper tar.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45269/ --- (Updated March 24, 2016, 8:52 a.m.) Review request for mesos and Zhiwei Chen.

Re: Review Request 45269: Test upload zookeeper tar.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45269/ --- (Updated March 24, 2016, 8:46 a.m.) Review request for mesos and Zhiwei Chen.

Re: Review Request 45269: Test upload zookeeper tar.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45269/ --- (Updated March 24, 2016, 8:44 a.m.) Review request for mesos and Zhiwei Chen.

Re: Review Request 45269: Test upload zookeeper tar.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45269/ --- (Updated March 24, 2016, 8:40 a.m.) Review request for mesos and Zhiwei Chen.

Re: Review Request 45272: Test update zookeeper version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45272/ --- (Updated March 24, 2016, 8:39 a.m.) Review request for mesos and Zhiwei Chen.

Re: Review Request 44511: Add registry tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/ --- (Updated March 24, 2016, 8:35 a.m.) Review request for mesos and Adam B.

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review125230 --- ping @mcypark, would you help to review it again? - Klaus Ma

Re: Review Request 45015: Windows: Fixed bug causing `os::exists` to report invalid paths exist.

> On March 21, 2016, 9:13 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, lines > > 146-166 > > > > > > Which of these are setting up the test and therefore remain

Re: Review Request 45015: Windows: Fixed bug causing `os::exists` to report invalid paths exist.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45015/ --- (Updated March 24, 2016, 7:58 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44511: Add registry tests for /weights endpoint.

> On March 21, 2016, 1:35 a.m., Adam B wrote: > > Need to get rid of the unnecessary stringify/atof translation, but I like > > the new low-level registry Operation test. > > Yongqiao Wang wrote: > Adam, cloud you help to review and commit this patch firstly, then I will > update the all

Re: Review Request 44511: Add registry tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/#review125225 --- Fix it, then Ship it! Looks great! I'd move the weightInfo

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review125224 --- Bad patch! Reviews applied: [44372] Failed command:

Re: Review Request 45217: Implemented docker volume driver isolator interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45217/ --- (Updated 三月 24, 2016, 7:04 a.m.) Review request for mesos and Jie Yu. Bugs:

Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5013

Re: Review Request 45265: Plugged in dvd isolator into agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45265/ --- (Updated 三月 24, 2016, 7:04 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 21, 2016, 11:57 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 328-336 > > > > > > why do we need this dispatch ? The dispatch is to itself, so seems

Re: Review Request 45166: Fixed flaky `MasterTest.SlavesEndpointTwoSlaves`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45166/#review125222 --- Ship it! Ship It! - Adam B On March 23, 2016, 8:14 a.m.,

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On March 16, 2016, 11:08 p.m., Jie Yu wrote: > > This patch breaks all the ROOT DOCKER tests in our internal CI. I've > > reverted it for now. Can you do a sudo make check with docker? > > Steve Niemitz wrote: > ok, I see what the problem is here. The issue is with the >

Re: Review Request 45265: Plugged in dvd isolator into agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45265/ --- (Updated 三月 24, 2016, 6:13 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 45259: Added Appc provisioner integration test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45259/#review125219 --- Patch looks great! Reviews applied: [45259] Passed command:

  1   2   >