Re: Review Request 45854: Updated the default JSON representation of a Resource to include GPUs.

2016-04-07 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45854/ --- (Updated April 8, 2016, 5:54 a.m.) Review request for mesos, Ben Mahler, Rob

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review127733 --- Patch looks great! Reviews applied: [37168] Passed command:

Re: Review Request 44832: Validate string when convert `Flags` to `hashmap<string, string>`.

2016-04-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44832/#review127727 --- Ship it! Ship It! - Ben Mahler On April 2, 2016, 8:07 a.m.,

Re: Review Request 45534: Added per-role and quota share metrics to the DRFSorter.

2016-04-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45534/#review127721 --- High level thought is that we should start with just the shares

Re: Review Request 44853: Added benchmark test for the allocator metrics endpoint.

2016-04-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44853/#review127698 --- Fix it, then Ship it!

Re: Review Request 45533: Explicitly typed quota role sorter in Mesos allocator.

2016-04-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45533/#review127705 --- Fix it, then Ship it!

Re: Review Request 45910: Move metrics code into the scheduler body.

2016-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45910/#review127722 --- Bad patch! Reviews applied: [45910, 45800, 45799, 45440, 45067]

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-04-07 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated April 8, 2016, 10:33 a.m.) Review request for mesos, Greg Mann, Joerg

Re: Review Request 45852: Added standard metrics for GPU resources.

2016-04-07 Thread haosdent huang
> On April 8, 2016, 2:24 a.m., haosdent huang wrote: > > Do you forgot to update > > ``` > > diff --git a/src/common/http.cpp b/src/common/http.cpp > > index 3748c71..d2f75b0 100644 > > --- a/src/common/http.cpp > > +++ b/src/common/http.cpp > > @@ -105,6 +105,7 @@ JSON::Object model(const

Re: Review Request 45905: Added metrics to the balloon framework.

2016-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/#review127719 --- Bad patch! Reviews applied: [45905, 45604] Failed command:

Re: Review Request 45852: Added standard metrics for GPU resources.

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45852/#review127718 --- Do you forgot to update ``` diff --git a/src/common/http.cpp

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/#review127714 --- How about `fetcher_cache_dir`, `appc_store_dir` and

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-04-07 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review127711 --- Fix it, then Ship it!

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-07 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/#review127688 --- Thanks for the update! Doing a quick `git-grep` after applying

Review Request 45910: Move metrics code into the scheduler body.

2016-04-07 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45910/ --- Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Vinod Kone.

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review127696 --- src/slave/containerizer/mesos/provisioner/paths.hpp (lines 43 -

Re: Review Request 45898: CMake: Place master files that moved into the correct directories.

2016-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45898/#review127699 --- Patch looks great! Reviews applied: [45898] Passed command:

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

2016-04-07 Thread Joseph Wu
> On April 6, 2016, 11:55 a.m., Vinod Kone wrote: > > src/examples/long_lived_framework.cpp, line 272 > > > > > > s/counter/metrics/ > > > > I'm assuming you might want to add gauge type metrics to this

Review Request 45604: Updated the balloon framework and executor.

2016-04-07 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45604/ --- Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod

Review Request 45905: Added metrics to the balloon framework.

2016-04-07 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/ --- Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod

Re: Review Request 44571: Added timeout for destroying Docker containers.

2016-04-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44571/#review127685 --- Fix it, then Ship it! src/slave/containerizer/docker.cpp

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45800/#review127684 --- Bad patch! Reviews applied: [45800, 45799, 45440, 45067] Failed

Review Request 45900: Removed stale contender/detector files.

2016-04-07 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45900/ --- Review request for mesos, Anurag Singh and James Peach. Repository: mesos

Review Request 45901: Removed unsed headers from master contender/detector files.

2016-04-07 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45901/ --- Review request for mesos and Anurag Singh. Repository: mesos Description

Re: Review Request 45200: Duplicate flags with keywork 'slave' on master side.

2016-04-07 Thread Vinod Kone
> On April 1, 2016, 10:49 p.m., Vinod Kone wrote: > > Can you call this out in the CHANGELOG too please? > > > > Also, all of the old flags should print a deprecation warning (when a user > > does --help on the binary or starts the binary with a deprecated flag) and > > direct users to the

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-07 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review127677 --- support/docker_build.sh (line 10)

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-07 Thread Vinod Kone
> On April 7, 2016, 10:13 p.m., Vinod Kone wrote: > > Also can you create an issue on ASF JIRA (if there isn't one already) and attach it to "bugs" in this review? - Vinod --- This is an automatically generated e-mail. To reply,

Re: Review Request 44950: Add XFS disk isolator documentation.

2016-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/#review127679 --- Bad patch! Reviews applied: [44950, 44949, 44948, 44947, 45689,

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-04-07 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44606/#review127678 --- Fix it, then Ship it! docs/persistent-volume.md (line 296)

Re: Review Request 45803: Add PowerPC LE CI for support/docker_build.sh.

2016-04-07 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45803/#review127676 --- support/docker_build.sh (lines 71 - 92)

Review Request 45898: CMake: Place master files that moved into the correct directories.

2016-04-07 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45898/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-07 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45800/ --- (Updated April 7, 2016, 9:50 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

2016-04-07 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated April 7, 2016, 9:50 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44949: Add XFS disk isolator tests.

2016-04-07 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated April 7, 2016, 9:50 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

2016-04-07 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated April 7, 2016, 9:50 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44947: Add tests for XFS project quota utilities.

2016-04-07 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated April 7, 2016, 9:49 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

2016-04-07 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated April 7, 2016, 9:49 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45800/#review127670 --- Bad patch! Reviews applied: [45800, 45799, 45440, 45067] Failed

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

2016-04-07 Thread Vinod Kone
> On April 6, 2016, 6:55 p.m., Vinod Kone wrote: > > src/examples/long_lived_framework.cpp, line 272 > > > > > > s/counter/metrics/ > > > > I'm assuming you might want to add gauge type metrics to this

Re: Review Request 45799: Cleaned up the virtual overloads in long lived framework.

2016-04-07 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45799/#review127663 --- Ship it! Ship It! - Vinod Kone On April 6, 2016, 3:43 a.m.,

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-07 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45800/#review127665 --- Fix it, then Ship it! src/examples/long_lived_framework.cpp

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-07 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45800/ --- (Updated April 7, 2016, 9:24 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45799: Cleaned up the virtual overloads in long lived framework.

2016-04-07 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45799/ --- (Updated April 7, 2016, 9:24 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

2016-04-07 Thread Vinod Kone
> On April 6, 2016, 6:55 p.m., Vinod Kone wrote: > > As discussed offline, lets add TODOs for metrics to defer the gauges to scheduler process. - Vinod --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

2016-04-07 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44081/ --- (Updated April 7, 2016, 7:35 p.m.) Review request for mesos, Alex Naparu,

Review Request 45888: Stout: Implemented `os::setenv` on Windows.

2016-04-07 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45888/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

2016-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45022/#review127638 --- Bad patch! Reviews applied: [45022, 45015, 45009, 44084, 44978,

Re: Review Request 45494: Removed clone option from subprocess [4/5].

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45494/#review127637 --- 3rdparty/libprocess/src/subprocess.cpp (line 561)

Re: Review Request 45491: Refactored subprocess options [1/5].

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45491/#review127636 --- 3rdparty/libprocess/src/subprocess.cpp (line 67)

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

2016-04-07 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45022/ --- (Updated April 7, 2016, 6:23 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

2016-04-07 Thread Michael Park
> On March 22, 2016, 8:35 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp, lines > > 41-43 > > > > > > `RemoveDirectory` only works on empty directories, right? This

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

2016-04-07 Thread Michael Park
> On March 22, 2016, 8:30 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 200 > > > > > > Why do we need this? I would much prefer to remove this. > > Alex

Re: Review Request 42516: Add support for user-defined networks.

2016-04-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review127624 --- Ship it! Ship It! - Jie Yu On March 31, 2016, 11:17 a.m.,

Re: Review Request 45495: Removed custom clone functions from Mesos [5/5].

2016-04-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45495/ --- (Updated April 7, 2016, 5:09 p.m.) Review request for mesos and Joris Van

Re: Review Request 45494: Removed clone option from subprocess [4/5].

2016-04-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45494/ --- (Updated April 7, 2016, 5:07 p.m.) Review request for mesos and Joris Van

Re: Review Request 45493: Added cloneFlags option to subprocess [3/5].

2016-04-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45493/ --- (Updated April 7, 2016, 5:02 p.m.) Review request for mesos and Joris Van

Re: Review Request 45493: Added namespace option to subprocess [3/5].

2016-04-07 Thread Joerg Schad
> On April 5, 2016, 6:53 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 338-355 > > > > > > Can you add a `TODO` here to consider making this `clone_flags` as > >

Re: Review Request 45491: Refactored subprocess options [1/5].

2016-04-07 Thread Joerg Schad
> On April 5, 2016, 6:40 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 219 > > > > > > Do we use this `operator() ()` style elsewhere? If you mean `operator()()` (vs

Re: Review Request 45491: Refactored subprocess options [1/5].

2016-04-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45491/ --- (Updated April 7, 2016, 4:55 p.m.) Review request for mesos and Joris Van

Re: Review Request 45876: Fixed library lookup for Master detector/contender modules.

2016-04-07 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45876/#review127609 --- Ship it! Ship It! - James Peach On April 7, 2016, 4:40

Review Request 45876: Fixed library lookup for Master detector/contender modules.

2016-04-07 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45876/ --- Review request for mesos, Jie Yu and James Peach. Repository: mesos

Re: Review Request 45874: Fixed typo in subprocess.hpp.

2016-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45874/#review127608 --- Patch looks great! Reviews applied: [45874] Passed command:

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-07 Thread Tim Anderegg
> On April 4, 2016, 6:13 p.m., Gilbert Song wrote: > > src/cli/execute.cpp, line 287 > > > > > > This is incorrect. We handle this merging operation in runtime isolator. I was testing out a similar implementation

Review Request 45874: Fixed typo in subprocess.hpp.

2016-04-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45874/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-04-07 Thread Neil Conway
> On March 18, 2016, 6:51 p.m., Vinod Kone wrote: > > Looks good to me. Couple of things before this can get committed. > > > > --> Have you sent an email to dev/user list about this backwards > > incompatible change? If not, you should. > > > > --> If users are depending on the return code

Re: Review Request 45670: Added tests for HTTP command executor.

2016-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45670/#review127599 --- Bad patch! Reviews applied: [45670, 44427, 44424, 44423] Failed

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

2016-04-07 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44424/ --- (Updated April 7, 2016, 10:13 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

2016-04-07 Thread Qian Zhang
> On April 6, 2016, 11:14 p.m., Anand Mazumdar wrote: > > Thanks for bearing with me. Most of the new comments are from the previous > > version itself. My bad, should have been caught by me earlier. Thanks Anand for all the comments, you are really rigorous and all your review comments are

Re: Review Request 45492: Used ChildHooks in Mesos [2/5].

2016-04-07 Thread Joerg Schad
> On April 5, 2016, 6:48 p.m., Joris Van Remoortere wrote: > > src/slave/containerizer/external_containerizer.cpp, lines 1091-1092 > > > > > > why not inline this? I couldn't find a nice/readable way to inline the

Re: Review Request 45670: Added tests for HTTP command executor.

2016-04-07 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45670/ --- (Updated April 7, 2016, 9:49 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 45670: Added tests for HTTP command executor.

2016-04-07 Thread Qian Zhang
> On April 5, 2016, 3:07 a.m., Anand Mazumdar wrote: > > hmm.. Would it be possible to not create a new file just for these two > > tests? IIUC, the existing tests in `src/tests/command_executor_tests.cpp` > > can be easily parameterized by value. The parameterization argument can be > > a

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

2016-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45022/#review127583 --- Bad patch! Reviews applied: [45022, 45015, 45009, 44084, 44978,

Re: Review Request 45863: Updated error messages in weights handler.

2016-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45863/#review127581 --- Bad patch! Reviews applied: [45863] Failed command:

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

2016-04-07 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45022/ --- (Updated April 7, 2016, 11:08 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 45863: Updated error messages in weights handler.

2016-04-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45863/#review127580 --- Fix it, then Ship it! src/master/weights_handler.cpp (line

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

2016-04-07 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45022/ --- (Updated April 7, 2016, 11:02 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

2016-04-07 Thread Alex Clemmer
> On March 22, 2016, 8:35 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp, lines > > 41-43 > > > > > > `RemoveDirectory` only works on empty directories, right? This

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

2016-04-07 Thread Alex Clemmer
> On March 22, 2016, 8:30 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 200 > > > > > > Why do we need this? I would much prefer to remove this. What would you

Review Request 45863: Updated error messages in weights handler.

2016-04-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45863/ --- Review request for mesos, Yongqiao Wang and Joerg Schad. Repository: mesos

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44606/#review127578 --- Patch looks great! Reviews applied: [42705, 44606] Passed

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45350/ --- (Updated April 7, 2016, 10:40 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45473: Migrate test cases for `net_cls` subsystem to cgroups unified isolator.

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45473/ --- (Updated April 7, 2016, 10:37 a.m.) Review request for mesos, Avinash

Re: Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45362/ --- (Updated April 7, 2016, 10:37 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45086/ --- (Updated April 7, 2016, 10:38 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45364: Migrate test cases for `memory` subsystem to cgroups unified isolator.

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45364/ --- (Updated April 7, 2016, 10:37 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45354: Migrate `UserCgroupIsolatorTest` to cgroups unified isolator.

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45354/ --- (Updated April 7, 2016, 10:37 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45353: Migrate test cases for `cpuacct` subsystem to cgroups unified isolator.

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45353/ --- (Updated April 7, 2016, 10:37 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43283/ --- (Updated April 7, 2016, 10:37 a.m.) Review request for mesos, Ian Downes, Jan

Re: Review Request 45085: Add cgroups unified isolator.

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45085/ --- (Updated April 7, 2016, 10:37 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45472: Add `NetClsSubsystem` for cgroups unified isolator.

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45472/ --- (Updated April 7, 2016, 10:37 a.m.) Review request for mesos, Avinash

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- (Updated April 7, 2016, 10:37 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45087: Add `CpuSubsystem` for cgroups unified isolator.

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45087/ --- (Updated April 7, 2016, 10:37 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45351: Migrate test cases for `cpu` subsystem to cgroups unified isolator.

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45351/ --- (Updated April 7, 2016, 10:37 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45352: Add `CpuacctSubsystem` for cgroups unified isolator.

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45352/ --- (Updated April 7, 2016, 10:37 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45083: Added ANY mode to futures collect mechanism.

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45083/ --- (Updated April 7, 2016, 10:36 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 44084: Windows: Forked os::rename().

2016-04-07 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44084/ --- (Updated April 7, 2016, 10:15 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44978: Windows: Fixed `fs::list` to be more compliant with POSIX version.

2016-04-07 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44978/ --- (Updated April 7, 2016, 9:36 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 45861: Windows: Fixed non-blocking connect.

2016-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45861/#review127575 --- Patch looks great! Reviews applied: [45861] Passed command:

Re: Review Request 44082: Stout: Un-commented out functions and marked them as deleted instead.

2016-04-07 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44082/ --- (Updated April 7, 2016, 9:12 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

2016-04-07 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44081/ --- (Updated April 7, 2016, 9:11 a.m.) Review request for mesos, Alex Naparu,

  1   2   >