Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49137/#review139479 --- Patch looks great! Reviews applied: [49136, 49137] Passed

Re: Review Request 49234: Removed DockerRuntimeIsolatorProcess::recover from docker/runtime.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49234/#review139475 --- Patch looks great! Reviews applied: [49234] Passed command:

Re: Review Request 49184: Implemented file volume support in mesos containerizer.

> On 六月 24, 2016, 8:43 a.m., Guangya Liu wrote: > > @Gilbert, I saw that there is no test case for containers without rootfs > > against your code change, are you planning to add those cases in this patch > > chain? > > Gilbert Song wrote: > Thanks for pointing that out. > > I

Re: Review Request 49184: Implemented file volume support in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49184/#review139473 --- src/slave/containerizer/mesos/isolators/filesystem/linux.cpp

Re: Review Request 49184: Implemented file volume support in mesos containerizer.

> On 六月 24, 2016, 8:11 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, lines 404-420 > > > > > > Can you please add some comments here for why not handling the case for >

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

> On 六月 26, 2016, 2:52 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/appc/store.cpp, lines 211-212 > > > > > > VLOG(1) << "Failed to get manifest for image '" > > <<

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review139469 --- src/slave/containerizer/mesos/containerizer.cpp (lines 78 - 83)

Re: Review Request 49207: Added proto message definitions to support appc runtime.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/#review139465 --- include/mesos/appc/spec.proto (line 44)

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49137/ --- (Updated June 26, 2016, 1:56 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49136: Add Framework protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49136/ --- (Updated June 26, 2016, 1:53 a.m.) Review request for mesos, Anand Mazumdar,

Review Request 49234: Removed DockerRuntimeIsolatorProcess::recover from docker/runtime.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49234/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos

Re: Review Request 48910: Group frameworks by state in the webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/#review139460 --- Patch looks great! Reviews applied: [48910] Passed command:

Re: Review Request 49219: Added runtime isolator interface to run appc containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49219/#review139459 --- src/Makefile.am (line 1028)

Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4778

Re: Review Request 49207: Added proto message definitions to support appc runtime.

> On 六月 25, 2016, 9:16 a.m., Guangya Liu wrote: > > include/mesos/appc/spec.proto, lines 44-46 > > > > > > Can you please put the link of > > https://github.com/appc/spec/blob/master/spec/aci.md here for reference?

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/#review139456 --- Patch looks great! Reviews applied: [49228] Passed command:

Re: Review Request 49063: Updating formatting of some lambda calls for readability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49063/#review139455 --- Patch looks great! Reviews applied: [49060, 49061, 49062, 49088,

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 12, 2016, 2:51 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 351-363 > > > > > > Why do we prepare hierarchy here? I think preparing hierarchy for a > >

Re: Review Request 49157: Added missing comments for operator API protos.

> On June 24, 2016, 9:25 p.m., Anand Mazumdar wrote: > > include/mesos/master/master.proto, line 307 > > > > > > hmmm.. we should consider doing a sweep to kill: > > > > `The response for 'Call::GET_X`. > >

Re: Review Request 49157: Added missing comments for operator API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/ --- (Updated June 25, 2016, 6:44 p.m.) Review request for mesos, Abhishek

Re: Review Request 49157: Added missing comments for operator API protos.

> On June 24, 2016, 9:25 p.m., Anand Mazumdar wrote: > > include/mesos/master/master.proto, line 307 > > > > > > hmmm.. we should consider doing a sweep to kill: > > > > `The response for 'Call::GET_X`. > >

Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49206/#review139450 --- Patch looks great! Reviews applied: [49206] Passed command:

Re: Review Request 49208: Modified tests to check is appc spec with app object is properly parsed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/ --- (Updated June 25, 2016, 5:21 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49219: Added runtime isolator interface to run appc containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49219/ --- (Updated June 25, 2016, 5:21 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49227: Updated proto files with comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49227/#review139449 --- Patch looks great! Reviews applied: [49225, 49226, 49227]

Re: Review Request 49207: Added proto message definitions to support appc runtime.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/ --- (Updated June 25, 2016, 4:08 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 48910: Group frameworks by state in the webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/ --- (Updated June 25, 2016, 3:48 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 48911: Show orphan tasks in WebUI.

> On June 21, 2016, 9:39 p.m., Benjamin Mahler wrote: > > src/webui/master/static/js/controllers.js, lines 151-154 > > > > > > This still looks incorrect, we need to set the stopped time only if the > > last state

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/#review139446 --- src/webui/master/static/js/controllers.js (line 161)

Review Request 49228: Fixed wrong stopped time in webui for live tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/ --- Review request for mesos, Benjamin Mahler, haosdent huang, Ross Allen, and

Re: Review Request 49223: WIP: enhance value parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/#review139445 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 48908: Added test case for exclude scarce resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48908/#review139444 --- Patch looks great! Reviews applied: [49181, 48895, 48904, 49190,

Re: Review Request 49219: Added runtime isolator interface to run appc containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49219/#review139441 --- Patch looks great! Reviews applied: [49207, 49208, 49219]

Re: Review Request 49060: Removed unused approver from tasks authorization continuation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49060/ --- (Updated June 25, 2016, 12:35 p.m.) Review request for mesos, Joerg Schad and

Re: Review Request 49063: Updating formatting of some lambda calls for readability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49063/ --- (Updated June 25, 2016, 12:33 p.m.) Review request for mesos, Joerg Schad and

Re: Review Request 49088: Replaced default capture by value by explicit capture by value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49088/ --- (Updated June 25, 2016, 12:33 p.m.) Review request for mesos, Jay Guo, Joris

Re: Review Request 49062: Fixed lambda capture list for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49062/ --- (Updated June 25, 2016, 12:32 p.m.) Review request for mesos, Adam B,

Re: Review Request 49061: Removed the unused copy of an `ObjectApprover` in a lambda.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49061/ --- (Updated June 25, 2016, 12:31 p.m.) Review request for mesos, Joerg Schad and

Re: Review Request 49060: Removed unused approver from tasks authorization continuation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49060/ --- (Updated June 25, 2016, 12:31 p.m.) Review request for mesos, Joerg Schad and

Re: Review Request 49059: Fixed the test suite build for Apple clang-600.0.54.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49059/ --- (Updated June 25, 2016, 12:30 p.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 49214: Added `FileInfo` protobuf for describing a File.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49214/#review139439 --- Patch looks great! Reviews applied: [49214] Passed command:

Re: Review Request 49208: Modified tests to check is appc spec with app object is properly parsed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/#review139436 --- src/tests/containerizer/provisioner_appc_tests.cpp (line 318)

Re: Review Request 49207: Added proto message definitions to support appc runtime.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/#review139431 --- include/mesos/appc/spec.proto (lines 44 - 46)

Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49206/ --- (Updated June 25, 2016, 9:03 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49206/ --- (Updated June 25, 2016, 9:03 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49206: Implemented Get_Quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49206/ --- (Updated June 25, 2016, 9:02 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49178: Configured single output binary folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49178/#review139435 --- Patch looks great! Reviews applied: [49178] Passed command:

Review Request 49227: Updated proto files with comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49227/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-5500

Review Request 49226: Implemented UNRESERVE_RESOURCES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49226/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-5500

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49225/ --- (Updated June 25, 2016, 6:52 a.m.) Review request for mesos, Anand Mazumdar

Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49225/ --- Review request for mesos. Repository: mesos Description --- Implemented