Re: Review Request 50081: Refactored docker/docker.cpp to use path::absolute().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50081/#review142475 --- Patch looks great! Reviews applied: [50081] Passed command:

Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

> On July 12, 2016, 2:24 a.m., Jay Guo wrote: > > src/tests/mesos.hpp, line 582 > > > > > > why `role1` but not `role`? > > Abhishek Dasgupta wrote: > There are three reasons for this: > > 1. Renaming

Review Request 50103: Fixed the incomplete `TaskStatus` message of docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50103/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Bugs:

Re: Review Request 50064: Added setns and active user test binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50064/#review142473 --- Patch looks great! Reviews applied: [50064] Passed command:

Re: Review Request 50062: Updated makePortRanges for variable types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50062/ --- (Updated 七月 16, 2016, 3:15 a.m.) Review request for mesos, Benjamin Mahler and

Review Request 50062: Updated makePortRanges for variable types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50062/ --- Review request for mesos, Benjamin Mahler and Jiang Yan Xu. Repository: mesos

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/ --- (Updated July 16, 2016, 10:39 a.m.) Review request for mesos and Benjamin

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/ --- (Updated July 16, 2016, 2:14 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 50102: Ignored /etc/* mounts to host filesystems if host network is used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50102/#review142472 --- Fix it, then Ship it!

Re: Review Request 43475: Sped up MasterDetectorExpireSlaveZKSessionNewMaster by advance Clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43475/ --- (Updated July 16, 2016, 2:11 a.m.) Review request for mesos, Alexander

Re: Review Request 43477: Sped up GroupTest.* test cases by advance clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43477/ --- (Updated July 16, 2016, 2:11 a.m.) Review request for mesos, Alexander

Re: Review Request 43474: Sped up MasterDetectorExpireSlaveZKSession by advance Clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43474/ --- (Updated July 16, 2016, 2:10 a.m.) Review request for mesos, Alexander

Re: Review Request 43471: Added the zookeeper patch for the slow add_auth calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43471/ --- (Updated July 16, 2016, 2:09 a.m.) Review request for mesos, Alexander

Re: Review Request 43472: Sped up ZooKeeperTest.LeaderContender by advance Clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43472/ --- (Updated July 16, 2016, 2:09 a.m.) Review request for mesos, Alexander

Re: Review Request 43473: Sped up ContenderDetectorShutdownNetwork by advance Clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43473/ --- (Updated July 16, 2016, 2:09 a.m.) Review request for mesos, Alexander

Re: Review Request 43471: Add the zookeeper patch for the allow add_auth calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43471/ --- (Updated July 16, 2016, 2:02 a.m.) Review request for mesos, Alexander

Review Request 50102: Ignored /etc/* mounts to host filesystems if host network is used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50102/ --- Review request for mesos, Avinash sridharan and Qian Zhang. Bugs: MESOS-5806

Re: Review Request 50088: Added mesos-protobuf target to build protobuf libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50088/#review142471 --- Bad patch! Reviews applied: [50088] Failed command:

Re: Review Request 50081: Refactored docker/docker.cpp to use path::absolute().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50081/#review142469 --- Ship it! Ship It! - Timothy Chen On July 15, 2016, 7:07

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142468 --- Bad patch! Reviews applied: [50003, 50002] Failed command:

Re: Review Request 50080: Updated Windows build instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50080/#review142465 --- Patch looks great! Reviews applied: [50080] Passed command:

Re: Review Request 49784: Increase framework numbers to allocator benchmarks.

> On 七月 12, 2016, 4:32 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3196 > > > > > > Two issues for this patch: > > > > 1) The new added framework number will introduce

Re: Review Request 50064: Added setns and active user test binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50064/ --- (Updated July 15, 2016, 10:18 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

> On 七月 15, 2016, 1:42 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/appc/store.cpp, line 199 > > > > > > I recalled Gilbert asked why returning `Future` here but you dropped > > the

Re: Review Request 50088: Added mesos-protobuf target to build protobuf libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50088/#review142454 --- src/CMakeLists.txt (line 415)

Re: Review Request 42441: Speeded up the `ExamplesTest.*` test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42441/#review142452 --- Ship it! Very clean patch! Thanks for writing a good summary

Re: Review Request 50026: Made the scheduler authentication timeout configurable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50026/#review142451 --- Ship it! Beautiful, thanks for splitting them apart! -

Re: Review Request 50081: Refactored docker/docker.cpp to use path::absolute().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50081/#review142450 --- Ship it! Thanks Gilbert for the follow up patch. - Guangya

Re: Review Request 50064: Added setns and active user test binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50064/ --- (Updated July 15, 2016, 9:56 p.m.) Review request for mesos, Alex Clemmer and

Review Request 50088: Added mesos-protobuf target to build protobuf libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50088/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5852

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

> On July 15, 2016, 5:41 p.m., Greg Mann wrote: > > src/local/flags.hpp, line 33 > > > > > > I was originally put off by the duplication of the `work_dir` flag > > here, since it makes `work_dir` the only normal

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

> On July 15, 2016, 5:41 p.m., Greg Mann wrote: > > Regarding the regression test: several of our tests use this "local mode" > > to test example frameworks (see 'src/tests/examples_tests.cpp'), but they > > all set the MESOS_WORK_DIR env var before running. I also noticed that we > > don't

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/ --- (Updated July 15, 2016, 9:01 p.m.) Review request for mesos, Greg Mann and

Review Request 50064: Added setns and active user test binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50064/ --- Review request for mesos. Repository: mesos Description --- Added setns

Re: Review Request 49939: Updated Agent::GET_METRICS call to return metrics grouped by types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49939/#review142440 --- Patch looks great! Reviews applied: [49936, 49937, 49938, 49939]

Re: Review Request 49990: Added cmake scripts to build slave component libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49990/#review142436 --- Ship it! LGTM! Verified the build on OSX and Windows. -

Re: Review Request 49178: Configured single output binary folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49178/#review142429 --- Fix it, then Ship it! As this is a small change, I'll make the

Re: Review Request 50080: Updated Windows build instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50080/ --- (Updated July 15, 2016, 12:29 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 50065: Enhancement for containers which have image and join host network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50065/#review142394 --- Fix it, then Ship it! LGTM! Thanks for fixing it and being

Re: Review Request 49955: Disabled the `--registry_strict` master flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49955/#review142433 --- Could we clarify the description a bit? I'm having a hard time

Re: Review Request 50080: Updated Windows build instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50080/#review142432 --- Patch looks great! Reviews applied: [50080] Passed command:

Review Request 50081: Refactored docker/docker.cpp to use path::absolute().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50081/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review142431 --- src/slave/containerizer/mesos/provisioner/appc/store.cpp (lines

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

> On July 15, 2016, 6:42 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/appc/store.cpp, line 199 > > > > > > I recalled Gilbert asked why returning `Future` here but you dropped > > the

Re: Review Request 49961: Supported relative container path in docker containerizer.

> On July 13, 2016, 12:08 a.m., Guangya Liu wrote: > > Thansk Guangya:) - Gilbert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49961/#review142022

Re: Review Request 49939: Updated Agent::GET_METRICS call to return metrics grouped by types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49939/ --- (Updated July 15, 2016, 11:30 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 50080: Updated Windows build instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50080/#review142424 --- Ship it! Ship It! - Vinod Kone On July 15, 2016, 5:55 p.m.,

Re: Review Request 49938: Updated Master::GET_METRICS call to return metrics grouped by types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49938/ --- (Updated July 15, 2016, 11:13 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 50044: Updated Sorter::sort to return a vector rather than list.

> On July 15, 2016, 12:15 a.m., Guangya Liu wrote: > > Thanks! > On July 15, 2016, 12:15 a.m., Guangya Liu wrote: > > src/master/allocator/sorter/sorter.hpp, line 132 > > > > > > s/list/vector I'll adjust to:

Re: Review Request 50044: Updated Sorter::sort to return a vector rather than list.

> On July 14, 2016, 11:49 p.m., Klaus Ma wrote: > > src/master/allocator/sorter/drf/sorter.hpp, line 22 > > > > > > This's not necessary, `sorter/sorter.hpp` had included it. > > Guangya Liu wrote: > I think the

Review Request 50080: Updated Windows build instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50080/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, and

Re: Review Request 50044: Updated Sorter::sort to return a vector rather than list.

> On July 15, 2016, 3:35 p.m., Jiang Yan Xu wrote: > > Modulo Gaungya's comments. > > Jiang Yan Xu wrote: > In the testing done section: 72 us reduction from how much time > originally? :) The timing was from a no-op sort. Took 155us for 1000 clients with a list, 83us or so with a

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142393 --- Regarding the regression test: several of our tests use this

Re: Review Request 48313: Consistency in persistent volumes between master and agent on failure.

> On July 13, 2016, 4:04 a.m., Neil Conway wrote: > > BTW, one thought: rather than writing out a new checkpoint and then > > deleting the target checkpoint file, what about renaming target -> current > > checkpoint? Rename is typically atomic (within a single filesystem), which > > is nice,

Re: Review Request 48313: Consistency in persistent volumes between master and agent on failure.

> On July 13, 2016, 11:04 a.m., Neil Conway wrote: > > BTW, one thought: rather than writing out a new checkpoint and then > > deleting the target checkpoint file, what about renaming target -> current > > checkpoint? Rename is typically atomic (within a single filesystem), which > > is nice,

Re: Review Request 49602: Fixed log message to avoid spanning multiple lines.

> On July 15, 2016, 4:26 p.m., Greg Mann wrote: > > Neil I agree - not useful logging information :-) Shall we just remove it > > instead? +1 to killing the log message. - Anand --- This is an automatically generated e-mail. To reply,

Re: Review Request 49604: Fixed incorrect clock time in log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49604/#review142399 --- Ship it! Ship It! - Anand Mazumdar On July 4, 2016, 6:21

Re: Review Request 50002: Allow all flags load methods to specify a prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50002/ --- (Updated July 15, 2016, 4:45 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 49602: Fixed log message to avoid spanning multiple lines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49602/#review142391 --- Neil I agree - not useful logging information :-) Shall we just

Re: Review Request 50002: Allow all flags load methods to specify a prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50002/#review142385 --- Looks good - just some style stuff below.

Re: Review Request 49784: Increase framework numbers to allocator benchmarks.

> On July 11, 2016, 9:32 p.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3196 > > > > > > Two issues for this patch: > > > > 1) The new added framework number will introduce

Re: Review Request 50044: Updated Sorter::sort to return a vector rather than list.

> On July 15, 2016, 8:35 a.m., Jiang Yan Xu wrote: > > Modulo Gaungya's comments. In the testing done section: 72 us reduction from how much time originally? :) - Jiang Yan --- This is an automatically generated e-mail. To reply,

Re: Review Request 50044: Updated Sorter::sort to return a vector rather than list.

> On July 14, 2016, 4:49 p.m., Klaus Ma wrote: > > src/master/allocator/sorter/drf/sorter.hpp, line 22 > > > > > > This's not necessary, `sorter/sorter.hpp` had included it. > > Guangya Liu wrote: > I think the

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

> On July 13, 2016, 10:09 a.m., Neil Conway wrote: > > src/tests/api_tests.cpp, line 95 > > > > > > Rather than changing this for all tests implicitly, I'd prefer creating > > a `master::Flags` and changing the

Re: Review Request 50044: Updated Sorter::sort to return a vector rather than list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50044/#review142383 --- Ship it! Modulo Gaungya's comments. - Jiang Yan Xu On July

Re: Review Request 50072: Moved CreateMasterFlags() function definintion to 'tests/mesos.hpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50072/ --- (Updated July 15, 2016, 3:33 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49914/ --- (Updated July 15, 2016, 3:33 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 50078: Cleaned the arguments passed to health checker in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50078/#review142381 --- Patch looks great! Reviews applied: [50078] Passed command:

Re: Review Request 50078: Cleaned the arguments passed to health checker in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50078/ --- (Updated July 15, 2016, 2:52 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 50078: Cleaned the arguments passed to health checker in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50078/#review142378 --- Ship it! Ship It! - Benjamin Bannier On July 15, 2016, 4:56

Re: Review Request 50078: Cleaned the arguments passed to health checker in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50078/ --- (Updated July 15, 2016, 2:56 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 50078: Cleaned the arguments passed to health checker in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50078/#review142377 --- Ship it! Ship It! - Gastón Kleiman On July 15, 2016, 2:13

Re: Review Request 50078: Cleaned the arguments passed to health checker in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50078/#review142376 --- src/docker/executor.cpp (line 496)

Review Request 50078: Cleaned the arguments passed to health checker in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50078/ --- Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Till Toenshoff.

Re: Review Request 50017: WIP: Validated the resources when parsing it.

> On 七月 14, 2016, 5:56 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 135-147 > > > > > > This suggests a change of semantics to `Resources`. > > > > Currently: `Resources` always

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review142350 --- src/slave/containerizer/mesos/provisioner/appc/store.cpp (line

Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49913/ --- (Updated July 15, 2016, 11:08 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49913/ --- (Updated July 15, 2016, 11:07 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49913/ --- (Updated July 15, 2016, 10:47 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 50065: Enhancement for containers which have image and join host network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50065/#review142353 --- Patch looks great! Reviews applied: [50065] Passed command:

Re: Review Request 50017: WIP: Validated the resources when parsing it.

> On 七月 14, 2016, 5:56 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 135-147 > > > > > > This suggests a change of semantics to `Resources`. > > > > Currently: `Resources` always

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/#review142345 --- Patch looks great! Reviews applied: [50038, 49814, 49817, 49819,

Re: Review Request 49843: Added benchmark test for sorter.

> On 七月 14, 2016, 7:14 p.m., Benjamin Mahler wrote: > > src/tests/sorter_tests.cpp, lines 504-542 > > > > > > It looks like we can simplify these two functions down to the following > > single function? > > >

Re: Review Request 49938: Updated Master::GET_METRICS call to return metrics grouped by types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49938/#review142341 --- src/master/http.cpp (lines 1943 - 1945)

Re: Review Request 49938: Updated Master::GET_METRICS call to return metrics grouped by types.

> On July 15, 2016, 6:55 a.m., Abhishek Dasgupta wrote: > > src/master/http.cpp, lines 1917-1928 > > > > > > You may do it this way: > > // TODO(tuananh): I don't know why I cannot use foreachpair instead. > >

Re: Review Request 49938: Updated Master::GET_METRICS call to return metrics grouped by types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49938/#review142339 --- src/master/http.cpp (lines 1917 - 1928)

Re: Review Request 49938: Updated Master::GET_METRICS call to return metrics grouped by types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49938/#review142338 --- src/tests/api_tests.cpp (line 335)

Re: Review Request 49943: Made vector reserve some spaces for allocator benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49943/#review142336 --- Ship it! Ship It! - Jiang Yan Xu On July 14, 2016, 8:14

Review Request 50065: Enhancement for containers which have image and join host network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50065/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-5806