Re: Review Request 52486: Decoupled QueuedTasks and QueuedTaskGroups on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52486/ --- (Updated Oct. 4, 2016, 5:44 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

> On Oct. 3, 2016, 10:28 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 4339 > > > > > > Mutating TaskInfo should be avoided as much as possible. > > > > I don't follow why we need this. > >

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

> On Oct. 3, 2016, 10:35 p.m., Vinod Kone wrote: > > src/webui/master/static/js/app.js, line 42 > > > > > > Is this backwards compatible? What if some one is depending on this > > path to exist? Morever, I think

Re: Review Request 52499: Removed a redundant space from Appc fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52499/#review151287 --- Ship it! Ship It! - Gilbert Song On Oct. 3, 2016, 6:26

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/#review151278 --- src/slave/slave.cpp (line 4219)

Re: Review Request 52475: Cleanups to make code more consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52475/ --- (Updated Oct. 4, 2016, 1:27 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 52473: Added nested MesosContainerizer tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52473/ --- (Updated Oct. 4, 2016, 1:27 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 52473: Added nested MesosContainerizer tests.

> On Oct. 3, 2016, 9:30 p.m., Jie Yu wrote: > > src/tests/containerizer/nested_mesos_containerizer_tests.cpp, line 426 > > > > > > dash (default shell on ubuntu) does not support double digit file > > descriptor.

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/#review151274 --- src/slave/container_loggers/logrotate.cpp (lines 39 - 41)

Review Request 52499: Removed a redundant space from Appc fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52499/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 52309: Pass the user variable from library to binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/#review151271 --- Looks like you've mastered the ReviewBoard tools :) This patch

Re: Review Request 49874: Added logrotate_container_logger for running mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49874/#review151270 --- Can you also move the companion binary into this new file? See:

Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/#review151269 --- src/examples/CMakeLists.txt (lines 142 - 154)

Re: Review Request 49862: Changed libraies to shared on OSX and UNIX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/#review151266 --- 3rdparty/cmake/Mesos3rdpartyConfigure.cmake (line 50)

Re: Review Request 52002: Added helper methods to determine types of disk resources.

> On 十月 2, 2016, 3:14 a.m., Guangya Liu wrote: > > src/tests/resources_tests.cpp, line 2182 > > > > > > Here we should keep 4 space start from the `(` above or else you can: > > > > ``` > >

Re: Review Request 52185: Do not need to erase task if it not in pendingTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52185/#review151258 --- src/master/master.cpp (line 4111)

Re: Review Request 52185: Do not need to erase task if it not in pendingTasks.

> On Oct. 3, 2016, 11:50 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 4112 > > > > > > Dont think this change is necessary. I would rather have all the > > removals related to pending (framework map and

Re: Review Request 51880: Added unit tests to determine disk size for MOUNT disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51880/ --- (Updated Oct. 3, 2016, 11:46 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52071: Updated docs to handle resources with no size in agent flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52071/ --- (Updated Oct. 3, 2016, 11:46 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ --- (Updated Oct. 3, 2016, 11:46 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52002: Added helper methods to determine types of disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated Oct. 3, 2016, 11:46 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52002: Added helper methods to determine types of disk resources.

> On Oct. 2, 2016, 3:14 a.m., Guangya Liu wrote: > > src/tests/resources_tests.cpp, line 2182 > > > > > > Here we should keep 4 space start from the `(` above or else you can: > > > > ``` > >

Re: Review Request 51999: Refactor parsing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/ --- (Updated Oct. 3, 2016, 11:46 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51999: Refactor parsing of resources.

> On Oct. 2, 2016, 1:56 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 587 > > > > > > I think it is not good to update here in this patch as I cannot see the > > reason why do we want to update here

Re: Review Request 52498: Removed `memory_test_helper_main.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52498/#review151257 --- Ship it! Ship It! - Jie Yu On Oct. 3, 2016, 11:33 p.m.,

Re: Review Request 49688: Added cmake build variables for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/#review151254 --- This patch is probably not needed anymore. We already build the

Review Request 52498: Removed `memory_test_helper_main.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52498/ --- Review request for mesos, Benjamin Bannier, Artem Harutyunyan, and Jie Yu.

Re: Review Request 52462: Ported ReviewBot script to Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52462/#review151252 --- Fix it, then Ship it! support/verify_reviews.py (line 178)

Re: Review Request 52461: Ported apply-reviews.py script to Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52461/#review151250 --- Fix it, then Ship it! support/apply-reviews.py (line 166)

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

> On April 27, 2016, 9:17 p.m., Benjamin Mahler wrote: > > The `messages_*` metrics were originally added to track the number of each > > message type received by the master in the old libprocess message-passing > > API: > >

Re: Review Request 50327: Added scripts to build sample framework executables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50327/#review151244 --- src/examples/CMakeLists.txt (lines 84 - 92)

Re: Review Request 50326: Added script to build mesos-resolve.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50326/#review151241 --- LGTM, but this is a somewhat under-utilized utility. I'd

Re: Review Request 50325: Added script to build mesos-log tool.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50325/#review151237 --- Ship it! LGTM. - Joseph Wu On Sept. 6, 2016, 3:06 p.m.,

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52471/#review151245 --- Patch looks great! Reviews applied: [52470, 52471] Passed

Re: Review Request 52480: Fixed provisioner recovering with nested containers existed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52480/#review151239 --- Ship it! Ship It! - Jie Yu On Oct. 3, 2016, 10:17 p.m.,

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/#review151238 --- src/master/master.cpp (line 4339)

Re: Review Request 52480: Fixed provisioner recovering with nested containers existed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52480/ --- (Updated Oct. 3, 2016, 3:17 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 52480: Fixed provisioner recovering with nested containers existed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52480/ --- (Updated Oct. 3, 2016, 3:16 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 51946: Updated test for BadACLNoPrincipal and BadACLDropCreateAndDestroy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51946/ --- (Updated 十月 3, 2016, 9:53 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52475: Cleanups to make code more consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52475/#review151232 --- src/tests/containerizer/mesos_containerizer_tests.cpp (line 206)

Re: Review Request 52475: Cleanups to make code more consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52475/#review151233 --- Ship it! Ship It! - Jie Yu On Oct. 3, 2016, 3:28 a.m.,

Re: Review Request 52474: Merged TestIsolator and MockIsolator and added a comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52474/#review151231 --- Ship it! Ship It! - Jie Yu On Oct. 3, 2016, 3:28 a.m.,

Re: Review Request 52473: Added nested MesosContainerizer tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52473/#review151184 --- src/tests/containerizer/mesos_containerizer_tests.cpp (line 111)

Re: Review Request 52486: Decoupled QueuedTasks and QueuedTaskGroups on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52486/ --- (Updated Oct. 3, 2016, 9:02 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 51299: Fixed memory leak in master during framework teardown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51299/ --- (Updated Oct. 3, 2016, 1:54 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 51946: Updated test for BadACLNoPrincipal and BadACLDropCreateAndDestroy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51946/#review151222 --- src/tests/persistent_volume_tests.cpp

Re: Review Request 42860: Added paths::overlapping to check whether paths are overlapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42860/#review151195 --- Code looks great! Just some suggestions for the comments.

Re: Review Request 42861: Ensured two Mount Disk resources do not have the same root path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/#review151208 --- src/slave/slave.cpp

Re: Review Request 52473: Added nested MesosContainerizer tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52473/#review151204 --- I would split the moving of the file and the addition of new

Re: Review Request 42861: Ensured two Mount Disk resources do not have the same root path.

> On Sept. 6, 2016, 10:38 p.m., Greg Mann wrote: > > Thanks Haosdent! Looks good. Could you also add a test for this? > > haosdent huang wrote: > Hi, @greggomann Thanks a lot for your reviews and helps! For test cases, > I think we have covered it in https://reviews.apache.org/r/42860/. So

Re: Review Request 52475: Cleanups to make code more consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52475/#review151202 --- Ship it! Ship It! - Gilbert Song On Oct. 2, 2016, 8:28

Re: Review Request 52473: Added nested MesosContainerizer tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52473/#review151201 --- Ship it! Ship It! - Gilbert Song On Oct. 2, 2016, 8:28

Re: Review Request 52417: Implement catchup process for replicated log's read replica.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52417/ --- (Updated Oct. 3, 2016, 6:12 p.m.) Review request for Igor Morozov.

Re: Review Request 52480: Fixed provisioner recovering with nested containers existed.

> On Oct. 3, 2016, 10:47 a.m., Greg Mann wrote: > > src/slave/containerizer/mesos/provisioner/paths.cpp, lines 186-193 > > > > > > Suggestion: > > "It is possible that the 'backends' directory does not exist for

Re: Review Request 51299: Fixed memory leak in master during framework teardown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51299/#review151193 --- Fix it, then Ship it! Modify the header i.e., we are not ==

Re: Review Request 52480: Fixed provisioner recovering with nested containers existed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52480/#review151190 --- src/slave/containerizer/mesos/provisioner/paths.cpp (lines 186 -

Re: Review Request 52486: Decoupled QueuedTasks and QueuedTaskGroups on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52486/ --- (Updated Oct. 3, 2016, 5:09 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 52472: Refactored some test create* functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52472/#review151183 --- Ship it! Ship It! - Gilbert Song On Oct. 2, 2016, 8:28

Re: Review Request 52472: Refactored some test create* functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52472/#review151181 --- Ship it! Ship It! - Jie Yu On Oct. 3, 2016, 3:28 a.m.,

Review Request 52486: Decoupled QueuedTasks and QueuedTaskGroups on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52486/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-6298

Re: Review Request 52417: Implement catchup process for replicated log's read replica.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52417/#review151143 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Review Request 52480: Fixed provisioner recovering with nested containers existed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52480/ --- Review request for mesos, Greg Mann, Artem Harutyunyan, Jie Yu, Timothy Chen,