Re: Review Request 57269: Added a test to ensure allocation roles are exposed in master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57269/ --- (Updated March 10, 2017, 10:18 a.m.) Review request for mesos and Benjamin

Re: Review Request 57360: Replace `.get().` in favor of `->` in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57360/ --- (Updated March 10, 2017, 10:18 a.m.) Review request for mesos and Benjamin

Review Request 57491: Windows: Update libprocess CMake setup for Glog patch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57491/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-6815

Review Request 57490: Windows: Add Glog patch for enabling stack trace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57490/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-6815

Re: Review Request 57254: Updated DRFSorter to support hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/#review168554 --- bmahler and I went through this together for a bit. We didn't get

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54449/ --- (Updated March 10, 2017, 1:16 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

> On March 9, 2017, 11:17 p.m., Jiang Yan Xu wrote: > > src/tests/containerizer/xfs_quota_tests.cpp > > Lines 229 (patched) > > > > > > IMO `ROOT_XFS_NoQuota` reads better: it's literally the mount option > > and

Re: Review Request 56028: Consistently add the FollowSymlink stat argument on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56028/ --- (Updated March 10, 2017, 12:41 a.m.) Review request for mesos, Alex Clemmer,

Re: Review Request 56475: Added a test for the 'CombinedAuthenticator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56475/ --- (Updated March 10, 2017, 12:35 a.m.) Review request for mesos, Alexander

Re: Review Request 56474: Added the 'CombinedAuthenticator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56474/ --- (Updated March 10, 2017, 12:33 a.m.) Review request for mesos, Alexander

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/#review168562 --- src/authentication/executor/jwt_secret_generator.cpp Lines 39

Re: Review Request 56757: Added the SecretGenerator module interface.

> On March 10, 2017, 12:16 a.m., Vinod Kone wrote: > > include/mesos/authentication/secret_generator.hpp > > Lines 30 (patched) > > > > > > s/represent/represents/ Can you rephrase the last sentence as well? It's a

Re: Review Request 56757: Added the SecretGenerator module interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56757/#review168557 --- Fix it, then Ship it!

Re: Review Request 57442: Update website for Mesos 1.2.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57442/#review168558 --- site/source/blog/2017-03-08-mesos-1-2-0-released.md Lines 37

Re: Review Request 56753: Implemented the JWT authenticator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56753/#review168549 --- Fix it, then Ship it!

Re: Review Request 57442: Update website for Mesos 1.2.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57442/#review168555 --- Ship it! Ship It! - Vinod Kone On March 9, 2017, 2:44 a.m.,

Re: Review Request 56475: Added a test for the 'CombinedAuthenticator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56475/ --- (Updated March 9, 2017, 11:45 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 56474: Added the 'CombinedAuthenticator'.

> On Feb. 13, 2017, 11:41 a.m., Alexander Rojas wrote: > > 3rdparty/libprocess/src/authenticator_manager.cpp > > Lines 102-128 (patched) > > > > > > Not so sure about all the continues and the handling of different

Re: Review Request 56474: Added the 'CombinedAuthenticator'.

> On Feb. 13, 2017, 11:41 a.m., Alexander Rojas wrote: > > 3rdparty/libprocess/src/authenticator_manager.cpp > > Lines 77-81 (patched) > > > > > > I'm my C++ knowledge is correct, you don't need this block, doing: >

Re: Review Request 56475: Added a test for the 'CombinedAuthenticator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56475/ --- (Updated March 9, 2017, 11:47 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 56475: Added a test for the 'CombinedAuthenticator'.

> On Feb. 13, 2017, 2:31 p.m., Alexander Rojas wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp > > Lines 1860-1863 (patched) > > > > > > Probably create the expected value in a variable outside of the > >

Re: Review Request 56478: Renamed 'unsetAuthenticator' to 'unsetAuthenticators' in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56478/ --- (Updated March 9, 2017, 11:44 p.m.) Review request for mesos, Jan Schlicht and

Re: Review Request 56474: Added the 'CombinedAuthenticator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56474/ --- (Updated March 9, 2017, 11:43 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 56667: Added support for JSON Web Tokens.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56667/#review168547 --- Ship it! Ship It! - Vinod Kone On March 9, 2017, 2:47 p.m.,

Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56476/ --- (Updated March 9, 2017, 11:41 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 56474: Added support for multiple authenticators to libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56474/ --- (Updated March 9, 2017, 11:40 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 56475: Added libprocess tests for multiple authenticators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56475/ --- (Updated March 9, 2017, 11:41 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 56666: Added a HMAC SHA256 generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review168546 --- Ship it! Ship It! - Vinod Kone On March 8, 2017, 2:11 p.m.,

Re: Review Request 56665: Added a URL-safe base64 implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56665/#review168545 --- Ship it! Ship It! - Vinod Kone On March 8, 2017, 2:10 p.m.,

Re: Review Request 57190: Updated agent for hierarchical roles.

> On März 2, 2017, 11:12 nachm., Neil Conway wrote: > > src/tests/role_tests.cpp > > Lines 887 (patched) > > > > > > We can't depend on `ls` and `grep` being available on Windows. > > > > We could write the

Re: Review Request 57479: Clarified a comment for 'Principal' in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57479/#review168544 --- Ship it! Ship It! - Vinod Kone On March 9, 2017, 10 p.m.,

Re: Review Request 57341: Made the usage of C++ namespaces in 'slave/http.cpp' consistent.

> On March 9, 2017, 9:20 p.m., Jie Yu wrote: > > What's the reason for this change? Can I get some context? I think Gaston wanted calls in slave/http.cpp to look similar to how they were defined in master/http.cpp. The original inconsistency is because in master/http.cpp, we needed the fully

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54449/#review168207 --- Fix it, then Ship it! The test refactor looks great!

Re: Review Request 57190: Updated agent for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57190/ --- (Updated March 10, 2017, 12:14 a.m.) Review request for mesos, Benjamin

Re: Review Request 56028: Consistently add the FollowSymlink stat argument on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56028/#review168535 --- 3rdparty/stout/include/stout/os/windows/stat.hpp Lines 41-43

Re: Review Request 57481: Replaced most instances of `/dev/null` with `os::DEV_NULL`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57481/#review168537 --- Ship it! Ship It! - Andrew Schwartzmeyer On March 9, 2017,

Re: Review Request 56753: Implemented the JWT authenticator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56753/#review168533 --- 3rdparty/libprocess/include/process/authenticator.hpp Lines 151

Re: Review Request 56730: Kill stray tasks when tearing down test cgroups.

> On March 9, 2017, 1:32 p.m., Jiang Yan Xu wrote: > > It could be a follow up patch or a TODO but given the possibility of > > uninterruptable processes etc. We can further reduce the chance of destroy > > failure by starting the cleanup with the freezer subsystem first if it's in > > the

Re: Review Request 57481: Replaced most instances of `/dev/null` with `os::DEV_NULL`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57481/ --- (Updated March 9, 2017, 2:24 p.m.) Review request for mesos, Andrew

Review Request 57481: Replaced most instances of `/dev/null` with `os::DEV_NULL`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57481/ --- Review request for mesos, Andrew Schwartzmeyer and Alex Clemmer. Repository:

Review Request 57480: Replaced an instance of `/dev/null` with `os::DEV_NULL`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57480/ --- Review request for mesos, Andrew Schwartzmeyer and Alex Clemmer. Repository:

Re: Review Request 57166: Updated role validation for hierarchical roles.

> On March 6, 2017, 9:26 p.m., Michael Park wrote: > > src/common/roles.cpp > > Lines 72 (patched) > > > > > > For these error messages, how about we say something like this? > > > > ```cpp > > "A role

Re: Review Request 56028: Consistently add the FollowSymlink stat argument on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56028/#review168532 --- Ship it! Ship It! - Michael Park On March 8, 2017, 4:42

Re: Review Request 56730: Kill stray tasks when tearing down test cgroups.

> On March 9, 2017, 9:32 p.m., Jiang Yan Xu wrote: > > It could be a follow up patch or a TODO but given the possibility of > > uninterruptable processes etc. We can further reduce the chance of destroy > > failure by starting the cleanup with the freezer subsystem first if it's in > > the

Re: Review Request 57354: Added `initializer_list` constructors for `JSON::(Object|Array)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57354/ --- (Updated March 9, 2017, 2 p.m.) Review request for mesos and Benjamin Mahler.

Review Request 57479: Clarified a comment for 'Principal' in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57479/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 57336: Updated `MultiRoleSchedulerUpgrade` to test framework updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57336/ --- (Updated March 9, 2017, 2 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 57335: Migrated `MultiRoleSchedulerUpgrade` from `MasterTest` to `UpgradeTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57335/ --- (Updated March 9, 2017, 1:59 p.m.) Review request for mesos and Benjamin

Re: Review Request 56027: Consistently add the FollowSymlink stat argument on POSIX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56027/ --- (Updated March 9, 2017, 9:49 p.m.) Review request for mesos, Alex Clemmer,

Re: Review Request 56730: Kill stray tasks when tearing down test cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56730/#review168417 --- Ship it! It could be a follow up patch or a TODO but given the

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/#review168525 --- Fix it, then Ship it! src/master/quota_handler.cpp Lines

Re: Review Request 57387: Implemented the Agent API call `DeleteNestedContainer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57387/#review168524 --- src/slave/http.cpp Lines 2455-2457 (patched)

Re: Review Request 57341: Made the usage of C++ namespaces in 'slave/http.cpp' consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57341/#review168523 --- What's the reason for this change? Can I get some context? - Jie

Re: Review Request 57385: Introduced proto changes needed for the DeleteNestedContainer API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57385/#review168522 --- Ship it! Ship It! - Jie Yu On March 8, 2017, 11:07 a.m.,

Re: Review Request 57384: Added `Containerizer::cleanupArtifacts`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57384/#review168515 --- src/slave/containerizer/mesos/containerizer.cpp Lines 2386

Re: Review Request 53264: Added test for CNI port-mapper plugin.

> On Feb. 28, 2017, 4:42 a.m., Jie Yu wrote: > > src/tests/containerizer/cni_isolator_tests.cpp > > Lines 1093-1097 (patched) > > > > > > Instead of that, can we use `__MESOS_TEST__2`? > > Avinash sridharan wrote:

Re: Review Request 57442: Update website for Mesos 1.2.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57442/#review168517 --- Patch looks great! Reviews applied: [57442] Passed command:

Re: Review Request 56027: Consistently add the FollowSymlink stat argument on POSIX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56027/#review168513 --- Fix it, then Ship it! Looks good! Just a few nit-picks below.

Re: Review Request 53264: Added test for CNI port-mapper plugin.

> On Feb. 28, 2017, 4:42 a.m., Jie Yu wrote: > > src/tests/containerizer/cni_isolator_tests.cpp > > Lines 1093-1097 (patched) > > > > > > Instead of that, can we use `__MESOS_TEST__2`? > > Avinash sridharan wrote:

Re: Review Request 57403: Added unit test for verifying user in command task with image specified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57403/#review168512 --- Ship it! Ship It! - Jie Yu On March 8, 2017, 1:27 a.m.,

Re: Review Request 57402: Fixed command task with container image 'root' user issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57402/#review168510 --- Ship it! Ship It! - Jie Yu On March 8, 2017, 1:27 a.m.,

Re: Review Request 56689: Windows: Prevented crash if sandbox `stdout` file already exists.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56689/#review168509 --- Ship it! Ship It! - Joseph Wu On Feb. 14, 2017, 3:40 p.m.,

Re: Review Request 57262: CMake: Added support for SSL-enabled builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57262/ --- (Updated March 9, 2017, 12:12 p.m.) Review request for mesos, Andrew

Re: Review Request 57354: Added `initializer_list` constructors for `JSON::(Object|Array)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57354/#review168504 --- Ship it! Ship It! - Benjamin Mahler On March 7, 2017, 1:33

Re: Review Request 57260: CMake: Refactored FindApr.cmake and FindSvn.cmake.

> On March 9, 2017, 2:06 a.m., Benjamin Bannier wrote: > > Upstream since some time provides find modules for openssl, subversion and > > CURL, so I wonder whether we currently even need to generalize this. Are > > the upstream modules broken in certain cmake versions (if yes, we should > >

Review Request 57473: Added support for authorization of Hierachical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/ --- Review request for mesos, Adam B and Benjamin Bannier. Repository: mesos

Review Request 57474: Added test for authorization of hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57474/ --- Review request for mesos, Adam B and Benjamin Bannier. Repository: mesos

Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57472/ --- Review request for mesos, Adam B and Benjamin Bannier. Repository: mesos

Re: Review Request 57254: Updated DRFSorter to support hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/#review168476 --- src/master/allocator/mesos/hierarchical.hpp Line 259 (original)

Review Request 57469: Made the default executor populate volume mappings for disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57469/ --- Review request for mesos, Gilbert Song and Vinod Kone. Bugs: MESOS-7225

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/ --- (Updated March 9, 2017, 4:44 p.m.) Review request for mesos and Michael Park.

Re: Review Request 57162: Minor cleanup for slave tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57162/ --- (Updated March 9, 2017, 4:46 p.m.) Review request for mesos and Michael Park.

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

> On March 8, 2017, 6:38 p.m., Michael Park wrote: > > src/master/quota_handler.cpp > > Lines 70 (patched) > > > > > > What do you think of introducing a `QuotaTree` with which we can > > encapsulate all this stuff?

Re: Review Request 57254: Updated DRFSorter to support hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/ --- (Updated March 9, 2017, 4:44 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 57165: Minor cleanup for quota validation code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57165/ --- (Updated March 9, 2017, 4:36 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 56757: Added the SecretGenerator module interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56757/ --- (Updated March 9, 2017, 3:52 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 56753: Implemented the JWT authenticator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56753/ --- (Updated March 9, 2017, 3:51 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 56667: Added support for JSON Web Tokens.

> On March 8, 2017, 8:43 p.m., Greg Mann wrote: > > 3rdparty/libprocess/src/jwt.cpp > > Lines 37 (patched) > > > > > > Should the 3 helpers here be either enclosed in an anonymous namespace > > or decorated with

Re: Review Request 56667: Added support for JSON Web Tokens.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56667/ --- (Updated March 9, 2017, 3:47 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 57388: Added documentation for the 'DeleteNestedContainer' Agent API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57388/#review168452 --- Ship it! Ship It! - Alexander Rojas On March 8, 2017, 9:17

Re: Review Request 57387: Implemented the Agent API call `DeleteNestedContainer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57387/#review168450 --- Ship it! src/slave/http.cpp Lines 2464-2471 (patched)

Re: Review Request 57386: Introduced changes to the authz protos needed for DeleteNestedContainer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57386/ --- (Updated March 9, 2017, 2:33 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 57341: Made the usage of C++ namespaces in 'slave/http.cpp' consistent.

> On March 9, 2017, 2:20 p.m., Alexander Rojas wrote: > > I just wonder if there are any rules for when to use the namespace or when > > it can be omit it? I don't know if we have any rules for that. It just irked me that the usage of namespaces in this file wasn't consistent - neither with

Re: Review Request 57341: Made the usage of C++ namespaces in 'slave/http.cpp' consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57341/#review168448 --- Ship it! I just wonder if there are any rules for when to use

Re: Review Request 57386: Introduced changes to the auth protos needed for DeleteNestedContainer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57386/#review168447 --- In summary and description, change /auth/authz/. Using just auth

Re: Review Request 57386: Introduced changes to the auth protos needed for DeleteNestedContainer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57386/ --- (Updated March 9, 2017, 1:54 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 57384: Added `Containerizer::cleanupArtifacts`.

> On March 9, 2017, 1:01 a.m., Vinod Kone wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 2496 (patched) > > > > > > Does a parent container's destruction imply removal of sandbox and > >

Re: Review Request 57384: Added `Containerizer::cleanupArtifacts`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57384/ --- (Updated March 9, 2017, 1:46 p.m.) Review request for mesos, Alexander

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/#review168433 --- Patch looks great! Reviews applied: [55887, 55888] Passed

Re: Review Request 57260: CMake: Refactored FindApr.cmake and FindSvn.cmake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57260/#review168425 --- Upstream since some time provides find modules for openssl,

Re: Review Request 57360: Replace `.get().` in favor of `->` in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57360/ --- (Updated March 9, 2017, 5:31 p.m.) Review request for mesos and Benjamin

Re: Review Request 57269: Added a test to ensure allocation roles are exposed in master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57269/ --- (Updated March 9, 2017, 5:28 p.m.) Review request for mesos and Benjamin

Re: Review Request 56753: Implemented the JWT authenticator.

> On March 8, 2017, 11:50 p.m., Greg Mann wrote: > > 3rdparty/libprocess/src/jwt_authenticator.cpp > > Lines 97 (patched) > > > > > > I'm guessing you have to use `error().message` here because it isn't a > > simple

Re: Review Request 56753: Implemented the JWT authenticator.

> On March 8, 2017, 11:15 p.m., Greg Mann wrote: > > 3rdparty/libprocess/src/jwt_authenticator.cpp > > Lines 75-97 (patched) > > > > > > Strictly speaking, each element of the vector passed to the > >