Re: Review Request 58059: Changed libprocess SocketManager to refer to HttpProxy by PID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58059/#review170523 --- Patch looks great! Reviews applied: [58056, 58057, 58058, 58059]

Review Request 58065: Added initial code for the python mesoshttp package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58065/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Re: Review Request 58055: Documentation updates to reflect multi-role framework support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58055/#review170512 --- Patch looks great! Reviews applied: [58055] Passed command:

Re: Review Request 57513: Cleaned up `strings::tokenize` and `strings::split`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57513/ --- (Updated March 30, 2017, 2:10 a.m.) Review request for mesos and Michael Park.

Re: Review Request 56155: Implemented the 'moveImage()' method of OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56155/ --- (Updated March 30, 2017, 10:08 a.m.) Review request for mesos, Gilbert Song

Re: Review Request 56154: Implemented the 'fetchLayers()' method of prefix puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56154/ --- (Updated March 30, 2017, 10:07 a.m.) Review request for mesos, Gilbert Song

Re: Review Request 56153: Implemented the 'fetchConfig()' method of prefix puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56153/ --- (Updated March 30, 2017, 10:07 a.m.) Review request for mesos, Gilbert Song

Re: Review Request 56152: Implemented the 'fetchManifest()' method of prefix puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56152/ --- (Updated March 30, 2017, 10:06 a.m.) Review request for mesos, Gilbert Song

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/ --- (Updated March 30, 2017, 2:06 a.m.) Review request for mesos and Michael Park.

Re: Review Request 56150: Implemented the 'fetchIndex()' method of prefix puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56150/ --- (Updated March 30, 2017, 10:05 a.m.) Review request for mesos, Gilbert Song

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

> On March 28, 2017, 11:06 p.m., Michael Park wrote: > > src/master/quota_handler.cpp > > Lines 469-487 (original), 605-618 (patched) > > > > > > Couldn't this be just: > > > > ```cpp > > vector

Re: Review Request 56149: Implemented the 'pull()' method of prefix puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56149/ --- (Updated March 30, 2017, 10:04 a.m.) Review request for mesos, Gilbert Song

Re: Review Request 56148: Implemented the '_get()' method of OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56148/ --- (Updated March 30, 2017, 10:03 a.m.) Review request for mesos, Gilbert Song

Re: Review Request 55333: Implemented the 'get()' and '__get()' methods of OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55333/ --- (Updated March 30, 2017, 10:02 a.m.) Review request for mesos, Gilbert Song

Re: Review Request 56147: Implemented metadata manager for OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56147/ --- (Updated March 30, 2017, 10:01 a.m.) Review request for mesos, Gilbert Song

Re: Review Request 55332: Added 'message.proto' for OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55332/ --- (Updated March 30, 2017, 9:59 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 54639: Implemented the 'create()' method of OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54639/ --- (Updated March 30, 2017, 9:56 a.m.) Review request for mesos, Gilbert Song and

Review Request 58064: Implemented the 'create()' method of puller interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58064/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-6681

Re: Review Request 58062: Added puller interface for OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58062/ --- (Updated March 30, 2017, 9:53 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 58063: Added stubs for prefix puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58063/ --- (Updated March 30, 2017, 9:53 a.m.) Review request for mesos, Gilbert Song and

Review Request 58063: Added stubs for prefix puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58063/ --- Review request for mesos. Repository: mesos Description --- Added stubs

Review Request 58062: Added puller interface for OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58062/ --- Review request for mesos. Repository: mesos Description --- Added

Re: Review Request 52382: Added stubs for OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52382/ --- (Updated March 30, 2017, 9:42 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 54638: Added agent flag '--oci_default_locator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54638/ --- (Updated March 30, 2017, 9:40 a.m.) Review request for mesos, Gilbert Song and

Review Request 58061: Added MULTI_ROLE support to the upgrades documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58061/ --- Review request for mesos and Michael Park. Bugs: MESOS-6762

Re: Review Request 52379: Added agent flag '--oci_store_dir'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52379/ --- (Updated March 30, 2017, 9:37 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 57358: Implemented discard behavior in process::Queue.

> On March 24, 2017, 9:09 a.m., Greg Mann wrote: > > 3rdparty/libprocess/include/process/queue.hpp > > Line 58 (original), 58 (patched) > > > > > > I was just testing this patch locally, and noticed that after

Review Request 58059: Changed libprocess SocketManager to refer to HttpProxy by PID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58059/ --- Review request for mesos, Benjamin Mahler and Greg Mann. Bugs: MESOS-6919

Review Request 58057: Changed SSL Socket destruction into a synchronous operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58057/ --- Review request for mesos, Benjamin Mahler and Greg Mann. Bugs: MESOS-6919

Review Request 58058: Moved libprocess initialization of worker threads later.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58058/ --- Review request for mesos, Benjamin Mahler and Greg Mann. Bugs: MESOS-6919

Review Request 58056: Temp: Added rapid-fire socket test for reinitialization testing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58056/ --- Review request for mesos, Benjamin Mahler and Greg Mann. Bugs: MESOS-6919

Re: Review Request 55331: Added 'OCI' message into 'Image' message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55331/ --- (Updated March 30, 2017, 9:19 a.m.) Review request for mesos, Gilbert Song and

Review Request 58060: Added a check to default clang-tidy check list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58060/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 55331: Added 'OCI' message into 'Image' message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55331/ --- (Updated March 30, 2017, 9:16 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 58039: Avoid redundant copies when using `std::get` on a tuple.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58039/ --- (Updated March 30, 2017, 1:15 a.m.) Review request for mesos and Benjamin

Re: Review Request 58037: Removed redundant call to `std::string::c_str()` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58037/ --- (Updated March 30, 2017, 1:14 a.m.) Review request for mesos and Benjamin

Re: Review Request 58040: Avoid various redundant copies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58040/ --- (Updated March 30, 2017, 1:15 a.m.) Review request for mesos and Benjamin

Re: Review Request 58038: Removed redundant call to `std::string::c_str()` in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58038/ --- (Updated March 30, 2017, 1:15 a.m.) Review request for mesos and Benjamin

Re: Review Request 58041: Don't mark a value parameter `const`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58041/ --- (Updated March 30, 2017, 1:15 a.m.) Review request for mesos and Benjamin

Review Request 58055: Documentation updates to reflect multi-role framework support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58055/ --- Review request for mesos and Michael Park. Bugs: MESOS-7324

Re: Review Request 57994: Fixed a regression hiding previously exposed master and agent flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57994/#review170502 --- Fix it, then Ship it! src/master/flags.hpp Line 98

Re: Review Request 57788: Changed allocator to skip allocation on weight and quota changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57788/#review170501 --- Ship it! Ship It! - Michael Park On March 22, 2017, 11:36

Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57564/#review170491 --- src/master/allocator/sorter/drf/sorter.hpp Lines 214-216

Re: Review Request 57975: Windows: Use Subprocess in default executor.

> On March 29, 2017, 9:40 p.m., Joseph Wu wrote: > > src/launcher/CMakeLists.txt > > Lines 29-39 (original), 29-39 (patched) > > > > > > No need for ifdef-ing here anymore. It's taken care of in a later commit. >

Re: Review Request 57973: Windows: Add `JobObjectManager` actor.

> On March 29, 2017, 9:36 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/include/process/windows/jobobject.hpp > > Lines 33 (patched) > > > > > > Can you move this comment down to the `extern` below? Whoops. > On

Re: Review Request 57975: Windows: Use Subprocess in default executor.

> On March 29, 2017, 2:40 p.m., Joseph Wu wrote: > > src/launcher/executor.hpp > > Lines 21-27 (original), 21 (patched) > > > > > > There's going to be a bunch of code movement... > > > > But now that the

Re: Review Request 57975: Windows: Use Subprocess in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57975/#review170485 --- src/launcher/CMakeLists.txt Lines 29-39 (original), 29-39

Re: Review Request 57973: Windows: Add `JobObjectManager` actor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57973/#review170482 --- 3rdparty/libprocess/include/process/windows/jobobject.hpp Lines

Re: Review Request 56367: Windows: Stout: Shim `os::killtree` to terminate job objects.

> On March 29, 2017, 9:09 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/windows/killtree.hpp > > Lines 41 (patched) > > > > > > A little note on Error conventions: > > > > We generally construct

Re: Review Request 56364: Windows: Stout: Rewrite job object wrappers.

> On March 29, 2017, 9 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/windows/os.hpp > > Lines 781 (patched) > > > > > > This comment is a tiny bit too long (> 80 characters). Ah I really need to get VS

Re: Review Request 56367: Windows: Stout: Shim `os::killtree` to terminate job objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56367/#review170449 --- 3rdparty/stout/include/stout/os/windows/killtree.hpp Lines 26-27

Re: Review Request 58044: Removed unused "using" statements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58044/#review170481 --- Patch looks great! Reviews applied: [58037, 58038, 58039, 58040,

Re: Review Request 56364: Windows: Stout: Rewrite job object wrappers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56364/#review170447 --- Ship it! Looks great! I can fix the one little thing below.

Re: Review Request 57911: Added UNKNOWN DiskInfo.Source type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57911/ --- (Updated March 29, 2017, 10:53 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 58038: Removed redundant call to `std::string::c_str()` in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58038/#review170479 --- Could you add `readability-redundant-string-cstr` to the default

Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

> On March 29, 2017, 12:30 p.m., Andrew Schwartzmeyer wrote: > > cmake/CompilationConfigure.cmake > > Lines 38 (patched) > > > > > > Are we going to enable verbose Cotire logging? It's useful. > > Andrew

Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

> On March 29, 2017, 7:30 p.m., Andrew Schwartzmeyer wrote: > > cmake/CompilationConfigure.cmake > > Lines 38 (patched) > > > > > > Are we going to enable verbose Cotire logging? It's useful. (Or note for users that

Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

> On March 29, 2017, 6:54 p.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Lines 39-40 (patched) > > > > > > I'll add a comment explaining unity builds: > > ``` > > # By default Cotire

Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

> On March 29, 2017, 11:54 a.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Lines 34-36 (patched) > > > > > > I think we can remove this check, as it would block people that want to > > fix the

Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58014/#review170448 --- src/CMakeLists.txt Lines 545 (patched)

Re: Review Request 58011: CMake: Add Cotire module (version 1.7.9).

> On March 29, 2017, 12:34 p.m., Andrew Schwartzmeyer wrote: > > Can we record what commit of upstream cotire this file got pulled from (or > > tag if we did indeed pull from a release)? I realize the module has a > > version in it, but I don't trust that it gurantees the file didn't come > >

Review Request 58042: Remove unused include in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58042/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Review Request 58044: Removed unused "using" statements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58044/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Review Request 58043: Cleanup usage of namespace-qualified identifiers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58043/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Review Request 58041: Don't mark a value parameter `const`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58041/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Review Request 58040: Avoid various redundant copies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58040/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Review Request 58039: Avoid redundant copies when using `std::get` on a tuple.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58039/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Review Request 58038: Removed redundant call to `std::string::c_str()` in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58038/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Review Request 58037: Removed redundant call to `std::string::c_str()` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58037/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

> On March 29, 2017, 6:54 p.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Lines 32 (patched) > > > > > > You need to surround `WIN32` with `${}`. Otherwise, this will default > > to `OFF` on

Re: Review Request 58015: Add name to contributors.yaml file for first contribution.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58015/#review170458 --- docs/contributors.yaml Lines 355 (patched)

Re: Review Request 58011: CMake: Add Cotire module (version 1.7.9).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58011/#review170457 --- Can we record what commit of upstream cotire this file got pulled

Re: Review Request 58012: Fix code issues to facilitate use of precompiled headers on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58012/#review170455 --- Ship it! Ship It! - Andrew Schwartzmeyer On March 29, 2017,

Re: Review Request 58013: WIN32: Add compile/link flags to improve incremental link times.

> On March 29, 2017, 6:53 p.m., Joseph Wu wrote: > > After double-checking what these flags actually do, I'm going to > > add some more information to the commit description: > > ``` > > The `/Zc:inline` flag tells the compiler to generate object files > > but exclude symbols that are either

Re: Review Request 58013: WIN32: Add compile/link flags to improve incremental link times.

> On March 29, 2017, 6:53 p.m., Joseph Wu wrote: > > After double-checking what these flags actually do, I'm going to > > add some more information to the commit description: > > ``` > > The `/Zc:inline` flag tells the compiler to generate object files > > but exclude symbols that are either

Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58014/#review170451 --- cmake/CompilationConfigure.cmake Lines 33 (patched)

Re: Review Request 58013: WIN32: Add compile/link flags to improve incremental link times.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58013/#review170443 --- Ship it! After double-checking what these flags actually do,

Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58014/#review170445 --- Fix it, then Ship it! Only minor issues, so I'll tweak them

Re: Review Request 58011: CMake: Add Cotire module (version 1.7.9).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58011/#review170439 --- Ship it! I'm going to tweak the commit description because I'm

Re: Review Request 58012: Fix code issues to facilitate use of precompiled headers on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58012/#review170444 --- Ship it! LGTM. - Joseph Wu On March 28, 2017, 5:54 p.m.,

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

> On March 28, 2017, 4:06 p.m., Michael Park wrote: > > src/master/quota_handler.cpp > > Lines 469-487 (original), 605-618 (patched) > > > > > > Couldn't this be just: > > > > ```cpp > > vector

Re: Review Request 58030: Added support for COMMAND checks to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58030/#review170441 --- Patch looks great! Reviews applied: [57644, 57648, 56288, 55901,

Re: Review Request 57898: Windows: Add deprecation warning for VS 2015.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57898/#review170428 --- This looks fine to me. I'll hold off upgrading until this is

Re: Review Request 57912: Enabled pause/resume for checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57912/ --- (Updated March 29, 2017, 4:40 p.m.) Review request for mesos, Alexander

Review Request 58030: Added support for COMMAND checks to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58030/ --- Review request for mesos, Alexander Rukletsov and Vinod Kone. Bugs: MESOS-7277

Re: Review Request 57912: Enabled pause/resume for checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57912/ --- (Updated March 29, 2017, 4:37 p.m.) Review request for mesos, Alexander

Re: Review Request 57854: Improved log/failure messages in the (health)checker libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57854/ --- (Updated March 29, 2017, 4:37 p.m.) Review request for mesos, Alexander

Re: Review Request 52379: Added agent flag '--oci_store_dir'.

> On Feb. 5, 2017, 12:18 p.m., Jie Yu wrote: > > src/slave/flags.cpp > > Lines 173 (patched) > > > > > > Let's make the default /tmp/mesos/store/oci, to be consistent with > > others. This was a suggestion of