Re: Review Request 59677: Added '--filter_gpu_resources' flag to the mesos master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59677/#review176419 --- Patch looks great! Reviews applied: [59677] Passed command:

Re: Review Request 59583: Added a test to verify executor driver message dropping behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59583/#review176418 --- Patch looks great! Reviews applied: [59460, 59461, 59463, 59545,

Review Request 59677: Added '--filter_gpu_resources' flag to the mesos master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59677/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7576

Re: Review Request 59320: Added test case for agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59320/#review176416 --- Patch looks great! Reviews applied: [59213, 59214, 59215, 59216,

Re: Review Request 59641: Follow symlinks when resolving paths specified in the various master/agent endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59641/#review176415 --- src/files/files.cpp Line 874 (original), 874 (patched)

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/#review176414 --- Ship it! LGTM. Would be great if one of @bmahler, @mpark or

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

> On May 23, 2017, 9:01 p.m., Vinod Kone wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Line 309 (original), 309 (patched) > > > > > > I don't quite follow why you need to have this variable here?

Re: Review Request 59641: Follow symlinks when resolving paths specified in the various master/agent endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59641/#review176410 --- Patch looks great! Reviews applied: [59641] Passed command:

Re: Review Request 59673: Combined an 'undef' workaround for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59673/#review176409 --- Patch looks great! Reviews applied: [59651, 59659, 59660, 59661,

Re: Review Request 59320: Added test case for agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59320/#review176399 --- src/master/master.cpp Lines 6018-6025 (original), 6018-6025

Re: Review Request 59583: Added a test to verify executor driver message dropping behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59583/#review176405 --- Ship it! Ship It! - Vinod Kone On May 30, 2017, 11:30 p.m.,

Re: Review Request 59545: Added a test to verify the agent flag 'executor_reregistration_timeout'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59545/#review176403 --- Ship it! Ship It! - Vinod Kone On May 30, 2017, 11:29 p.m.,

Re: Review Request 59463: Added test for agent ping timeout during agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59463/#review176402 --- Fix it, then Ship it! src/tests/slave_recovery_tests.cpp

Review Request 59673: Combined an 'undef' workaround for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59673/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Re: Review Request 59583: Added a test to verify executor driver message dropping behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59583/#review176401 --- Bad patch! Reviews applied: [59583, 59545, 59463, 59461, 59460]

Review Request 59672: Reordered gauge methods in `Slave` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59672/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Review Request 59671: Reordered `Slave` copy constructor and assignment operator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59671/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Review Request 59670: Removed an unnecessary declaration in slave.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59670/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Re: Review Request 59302: Simplified master logic for agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59302/#review176398 --- Ship it! Looking at this patch in isolation, it's hard to see

Re: Review Request 59583: Added a test to verify executor driver message dropping behavior.

> On May 30, 2017, 7:43 p.m., Mesos Reviewbot Windows wrote: > > Bad patch! > > > > Reviews applied: [59583, 59545, 59463, 59461, 59460] > > > > Failed command: python support/apply-reviews.py -n -r 59545 > > > > Error: > > error: patch failed: src/tests/slave_tests.cpp:7210 > > error:

Re: Review Request 59301: Marked a few deprecated proto fields with the "deprecated" option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59301/#review176396 --- Ship it! Ship It! - Benjamin Mahler On May 15, 2017, 11:18

Re: Review Request 59219: Removed logic for handling missing FrameworkID in ExecutorInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59219/#review176394 --- Ship it! src/master/master.cpp Line 7564 (original), 7564

Re: Review Request 59259: Cleaned up master code to check for PARTITION_AWARE capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59259/#review176395 --- Ship it! Ship It! - Benjamin Mahler On May 15, 2017, 11:16

Re: Review Request 59658: Windows: Updated Protobuf to 3.3.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59658/#review176393 --- 3rdparty/CMakeLists.txt Lines 296-302 (original), 296 (patched)

Re: Review Request 59658: Windows: Updated Protobuf to 3.3.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59658/#review176391 --- Ship it! Ship It! - Anand Mazumdar On May 30, 2017, 11:30

Re: Review Request 59658: Windows: Updated Protobuf to 3.3.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59658/#review176390 --- Ship it! Ship It! - Zhitao Li On May 30, 2017, 11:30 p.m.,

Re: Review Request 59583: Added a test to verify executor driver message dropping behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59583/ --- (Updated May 30, 2017, 11:30 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 59658: Windows: Updated Protobuf to 3.3.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59658/ --- (Updated May 30, 2017, 11:30 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 59658: Windows: Updated Protobuf to 3.3.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59658/ --- (Updated May 30, 2017, 11:30 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 59545: Added a test to verify the agent flag 'executor_reregistration_timeout'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59545/ --- (Updated May 30, 2017, 11:29 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 59463: Added test for agent ping timeout during agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59463/ --- (Updated May 30, 2017, 11:29 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 59581: Resolved a TODO that depended on a newer version of gtest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59581/#review176386 --- Ship it! Ship It! - Vinod Kone On May 25, 2017, 10:22 p.m.,

Re: Review Request 59504: Removed an instance of double logging in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59504/#review176385 --- Ship it! - Benjamin Mahler On May 23, 2017, 9:57 p.m., Anand

Review Request 59658: Windows: Updated Protobuf to 3.3.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59658/ --- Review request for mesos, Anand Mazumdar, Jeff Coffler, Joseph Wu, Li Li, and

Review Request 59668: Removed an unnecessary function declaration from slave.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59668/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Review Request 59669: Removed some unnecessary std:: prefix in slave.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59669/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Review Request 59667: Reordered the methods in `Framework` into logic units.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59667/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Review Request 59665: Reordered the streaming functions in slave.hpp|cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59665/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Review Request 59666: Moved Framework::addTask to the source file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59666/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Review Request 59663: Removed unnecessary friend declaration for an stream operator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59663/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Review Request 59664: Used `delete` for deleting copy constructor and assignment operator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59664/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Review Request 59662: Changed `Executor` and `Framework` to class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59662/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Review Request 59661: Fixed some style issues in slave.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59661/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Review Request 59660: Reordered some method definitions in `Slave` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59660/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Review Request 59659: Used `delete` for `Slave` copy constructor and assignment operator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59659/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review176382 --- Patch looks great! Reviews applied: [58720] Passed command:

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/#review176360 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp

Re: Review Request 59634: Updated 'config.py' in the new Mesos CLI to take settings as parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59634/#review176374 --- Bad patch! Reviews applied: [59634] Failed command: python

Re: Review Request 59641: Follow symlinks when resolving paths specified in the various master/agent endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59641/#review176365 --- Patch looks great! Reviews applied: [59641] Passed command:

Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review176357 --- Fix it, then Ship it! I am just waiting on two things before

Re: Review Request 59344: Make libprocess flags global.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59344/#review176356 --- Ship it! 3rdparty/libprocess/src/process.cpp Lines 562

Re: Review Request 59634: Updated 'config.py' in the new Mesos CLI to take settings as parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59634/ --- (Updated May 30, 2017, 9:13 p.m.) Review request for mesos and Armand Grillet.

Re: Review Request 58928: Update process tests to use a non-zero UPID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58928/#review176352 --- Ship it! Ship It! - Benjamin Mahler On May 10, 2017, 6:05

Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.

> On May 7, 2017, 8:13 p.m., Kevin Klues wrote: > > src/cli_new/lib/cli/tests/base.py > > Lines 384-401 (patched) > > > > > > This is fine for now, but I'm wondering if we can't find a more generic > > way of

Re: Review Request 59254: Used loop to implement allocator interval-based allocation.

> On May 30, 2017, 1:55 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 168 (patched) > > > > > > Can you use a PID rather than a UPID? Sure. FWIW I copied it from

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/#review176350 --- Patch looks great! Reviews applied: [59453, 58955, 58964, 59099,

Re: Review Request 59254: Used loop to implement allocator interval-based allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59254/#review176348 --- Ship it! src/master/allocator/mesos/hierarchical.cpp Lines

Re: Review Request 59453: Renamed RegisterAgent.agent to RegisterAgent.agents in acls.proto.

> On May 24, 2017, 10:26 a.m., Jiang Yan Xu wrote: > > Hmm, is this also violating the convention then? > > > > https://github.com/apache/mesos/blob/d225d4d4122e773e2416ba0d0eee653da8ced352/include/mesos/authorizer/acls.proto#L344 > > > > What if later we use uncountable nouns? > > > > FWIW

Re: Review Request 59343: Add a process ID for RemoteProcess in the libprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59343/#review176345 --- Ship it! Hm.. I'm not sure why you're saying this is needed to

Re: Review Request 59342: Improve listen address detection code comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59342/#review176344 --- Ship it! Ship It! - Benjamin Mahler On May 17, 2017, 5

Re: Review Request 59341: Fix gethostname() error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59341/#review176343 --- Ship it! Ship It! - Benjamin Mahler On May 17, 2017, 5:04

Re: Review Request 58977: Add local and peer address accessors to http::Connection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58977/#review176342 --- Ship it! Ship It! - Benjamin Mahler On May 17, 2017, 4:58

Re: Review Request 58950: Made persistent volume endpoints tests independent from allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58950/#review176341 --- Patch looks great! Reviews applied: [58950] Passed command:

Re: Review Request 59641: Follow symlinks when resolving paths specified in the various master/agent endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59641/ --- (Updated May 30, 2017, 8:14 p.m.) Review request for mesos, Andrew

Re: Review Request 59464: Add Fetcher total and success metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59464/#review176340 --- It looks like all of your patches are getting marked with

Re: Review Request 59583: Added a test to verify executor driver message dropping behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59583/#review176337 --- Bad patch! Reviews applied: [59583, 59545, 59463, 59461, 59460]

Re: Review Request 59634: Updated 'config.py' in the new Mesos CLI to take settings as parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59634/#review176338 --- Bad patch! Reviews applied: [59634] Failed command: python

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59294/#review176336 --- Patch looks great! Reviews applied: [59294] Passed command:

Re: Review Request 59605: Use glog for logging in executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59605/#review176332 --- Patch looks great! Reviews applied: [59605] Passed command:

Re: Review Request 59641: Follow symlinks when resolving paths specified in the various master/agent endpoints.

> On May 30, 2017, 6:31 p.m., Zhitao Li wrote: > > Is it possible to add an integration test in `src/tests/files_tests.cpp`? Sure, I can create a directory and a symlink pointing to it and make sure it passes. FWIW that test is currently disabled on Windows. > On May 30, 2017, 6:31 p.m.,

Re: Review Request 59641: Follow symlinks when resolving paths specified in the various master/agent endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59641/#review176325 --- Is it possible to add an integration test in

Re: Review Request 59578: Made MasterTest.MaxCompletedTasksPerFrameworkFlag less fragile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59578/#review176326 --- Patch looks great! Reviews applied: [59578] Passed command:

Re: Review Request 59254: Used loop to implement allocator interval-based allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59254/ --- (Updated May 30, 2017, 11:12 a.m.) Review request for mesos, Benjamin Mahler,

Review Request 59641: Follow symlinks when resolving paths specified in the various master/agent endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59641/ --- Review request for mesos, Andrew Schwartzmeyer, James Peach, Vinod Kone, and

Re: Review Request 59601: Removed an unused declaration in type_utils.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59601/#review176320 --- Patch looks great! Reviews applied: [59091, 59094, 59596, 59597,

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

> On May 26, 2017, 4:52 p.m., Zhitao Li wrote: > > 3rdparty/cmake/Versions.cmake > > Lines 30 (patched) > > > > > > Can you explain how is these hashes geneareted and used? > > > > I'm working on upgrading

Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.

> On May 7, 2017, 8:13 p.m., Kevin Klues wrote: > > src/cli_new/lib/cli/tests/base.py > > Lines 384-401 (patched) > > > > > > This is fine for now, but I'm wondering if we can't find a more generic > > way of

Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 30, 2017, 5:25 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 59616: Add `six` python package in install_require.

> On May 29, 2017, 9:41 p.m., Kevin Klues wrote: > > I agree with @benjamin. This is the improper fix for this problem. The > > underlying issue is that our build environment now requires `six` since > > protobuf-3.3.3 depends on it (the `mesos` package doesn't depend on it, > > just the

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/#review176304 --- Patch looks great! Reviews applied: [59453, 58955, 58964, 59099,

Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.

> On May 23, 2017, 3:59 p.m., Andrei Budnik wrote: > > src/cli_new/lib/cli/tests/base.py > > Lines 52 (patched) > > > > > > I would prefer os.linesep to '\n' here and everywhere to avoid extra > > constant. > >

Review Request 59622: Added a `net::inet::IP` and a `net::inet6::IP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59622/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Bugs: MESOS-7488

Re: Review Request 58950: Made persistent volume endpoints tests independent from allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58950/#review176299 --- Patch looks great! Reviews applied: [58950] Passed command:

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/ --- (Updated May 30, 2017, 1:41 p.m.) Review request for mesos, Adam B and Greg

Re: Review Request 58951: Made reservation endpoints tests independent from allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58951/ --- (Updated May 30, 2017, 12:22 p.m.) Review request for mesos, Alexander

Re: Review Request 58950: Made persistent volume endpoints tests independent from allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58950/ --- (Updated May 30, 2017, 12:22 p.m.) Review request for mesos, Alexander

Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 30, 2017, 10 a.m.) Review request for mesos and Kevin Klues.

Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review176295 --- Patch looks great! Reviews applied: [59628, 58720] Passed

Re: Review Request 59634: Updated 'config.py' in the new Mesos CLI to take settings as parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59634/#review176290 --- When using the command `mesos` after applying your patch on top

Re: Review Request 59634: Updated 'config.py' in the new Mesos CLI to take settings as parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59634/#review176289 --- Patch looks great! Reviews applied: [59634] Passed command: