Re: Review Request 60407: Avoided master crash on agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60407/#review178836 --- src/master/validation.cpp Line 370 (original), 370-372 (patched)

Re: Review Request 60406: Added sanity check to resource downgrade on agent registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60406/#review178835 --- Ship it! Ship It! - Adam B On June 23, 2017, 6:48 p.m.,

Re: Review Request 60405: Documented resource format in agent <-> master protocol.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60405/#review178834 --- Just a couple of clarifying questions before we commit these

Re: Review Request 60404: Documented the content of the `SlaveInfo.resources` field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60404/#review178833 --- Ship it! Ship It! - Adam B On June 23, 2017, 6:49 p.m.,

Re: Review Request 60407: Avoided master crash on agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60407/ --- (Updated June 24, 2017, 1:47 a.m.) Review request for mesos and Michael Park.

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

> On June 23, 2017, 11:21 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Line 6003 (original), 6007 (patched) > > > > > > Empty line above. > > Megha Sharma wrote: > This is not possible I guess, git

Re: Review Request 60404: Documented the content of the `SlaveInfo.resources` field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60404/ --- (Updated June 24, 2017, 12:32 a.m.) Review request for mesos and Michael Park.

Re: Review Request 60405: Documented resource format in agent <-> master protocol.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60405/ --- (Updated June 24, 2017, 12:31 a.m.) Review request for mesos and Michael Park.

Review Request 60407: Avoided master crash on agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60407/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 56895: Added tests to ensure slave recovery post reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/#review178816 --- src/tests/slave_recovery_tests.cpp Line 2575 (original), 2575

Re: Review Request 60397: Check perf version compatibility in tests with disabled coredumps.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60397/#review178826 --- Ship it! Great idea! What do you think about setting the core

Re: Review Request 60398: Split perf version test into 2 separate tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60398/#review178822 --- This drops the test that verifies we can actually parse perf

Review Request 60406: Added sanity check to resource downgrade on agent registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60406/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 60405: Documented resource format in agent <-> master protocol.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60405/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 60404: Documented the content of the `SlaveInfo.resources` field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60404/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 56895: Added tests to ensure slave recovery post reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/#review178820 --- Patch looks great! Reviews applied: [60103, 60104, 60105, 56895]

Re: Review Request 60400: (WIP) Skipped consulting registry if the agent is in the `slaves.recovered`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60400/#review178817 --- Patch looks great! Reviews applied: [60400] Passed command:

Re: Review Request 56895: Added tests to ensure slave recovery post reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/ --- (Updated June 23, 2017, 9:45 p.m.) Review request for mesos, Neil Conway,

Review Request 60400: (WIP) Skipped consulting registry if the agent is in the `slaves.recovered`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60400/ --- Review request for mesos and Neil Conway. Repository: mesos Description

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

> On June 23, 2017, 6:21 p.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Line 6003 (original), 6007 (patched) > > > > > > Empty line above. This is not possible I guess, git pre-commit hook complains:

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/ --- (Updated June 23, 2017, 9:30 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

> On June 23, 2017, 6:21 p.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Lines 5994-5999 (patched) > > > > > > I tweaked it a little bit: > > > > ``` > > // Fail the recovery unless the

Re: Review Request 60398: Split perf version test into 2 separate tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60398/#review178812 --- Patch looks great! Reviews applied: [60397, 60398] Passed

Review Request 60397: Check perf version compatibility in tests with disabled coredumps.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60397/ --- Review request for mesos, Benjamin Bannier, James Peach, and Neil Conway.

Review Request 60398: Split perf version test into 2 separate tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60398/ --- Review request for mesos, Benjamin Bannier and James Peach. Repository: mesos

Re: Review Request 56895: Added tests to ensure slave recovery post reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/#review178804 --- Patch looks great! Reviews applied: [60103, 60104, 60105, 56895]

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/#review178750 --- src/slave/slave.cpp Lines 5980-5981 (original), 5980-5981

Re: Review Request 56895: Added tests to ensure slave recovery post reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/ --- (Updated June 23, 2017, 6:01 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 60104: Added rebooted flag to State.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60104/ --- (Updated June 23, 2017, 5:20 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

> On June 21, 2017, 4:39 p.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Lines 5798-5867 (original), 5798-5867 (patched) > > > > > > So all of this work is only useful for recovering frameworks, it looks > >

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/ --- (Updated June 23, 2017, 5:19 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/#review178801 --- src/webui/master/static/agent.html Lines 176 (patched)

Re: Review Request 60203: Introduce HTB class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60203/#review178789 --- Looks solid to me. Comments below are mostly style issues.

Re: Review Request 60203: Introduce HTB class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60203/#review178786 --- src/linux/routing/queueing/htb.cpp Lines 144-145 (patched)

Re: Review Request 60104: Added rebooted flag to State.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60104/#review178782 --- Fix it, then Ship it! src/slave/slave.cpp Lines 5831