Re: Review Request 60900: Updated Python linter to work with multiple directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60900/ --- (Updated July 18, 2017, 5:31 a.m.) Review request for mesos, Eric Chung and

Re: Review Request 60847: Add test cases for /slaves, /slave/containers, /frameworks endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60847/#review180762 --- src/tests/master_tests.cpp Lines 2593 (patched)

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On July 18, 2017, 4:08 a.m., Benjamin Mahler wrote: > > Since these were pretty minor adjustments, I took care of these and committed your patch. I didn't add the `dataSizeMb` filter to clean some of the code up, so if you want to follow up with a patch for that, that would be much

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/#review180790 --- Fix it, then Ship it! src/webui/master/static/agent.html

Re: Review Request 60539: Added test for allocated resources per each role in the agent endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60539/#review180789 --- Ship it! Note that we're not adding a test anymore, so the

Review Request 60936: Removed stale FetcherProcess::setSpace declaration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60936/ --- Review request for mesos, Joseph Wu and Jiang Yan Xu. Bugs: MESOS-7782

Re: Review Request 60791: Add fetcher cache space usage metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60791/ --- (Updated July 18, 2017, 2:13 a.m.) Review request for mesos, Joseph Wu and

Re: Review Request 60915: Enabled filtering of reservations in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60915/#review180786 --- Can you have alexander rojas review this patch? - Benjamin

Re: Review Request 60400: Skipped consulting registry if the agent is in the `slaves.recovered`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60400/#review180779 --- Fix it, then Ship it! Ship It! src/master/master.cpp Lines

Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60369/#review180784 --- Ship it! Ship It! - Benjamin Mahler On July 17, 2017, 5:45

Re: Review Request 60907: Got rid of executor's `resources` variable in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60907/#review180777 --- Ship it! src/slave/slave.cpp Line 4626 (original), 4604

Re: Review Request 60902: Moved the libnl3 configure checks into a macro.

> On July 17, 2017, 3:20 a.m., Qian Zhang wrote: > > m4/libnl3.m4 > > Lines 33-37 (patched) > > > > > > Mind to elaborate a bit about why introducing a new .m4 file? What > > about just introducing a new configure

Re: Review Request 60902: Moved the libnl3 configure checks into a macro.

> On July 17, 2017, 11:20 a.m., Qian Zhang wrote: > > m4/libnl3.m4 > > Lines 33-37 (patched) > > > > > > Mind to elaborate a bit about why introducing a new .m4 file? What > > about just introducing a new configure

Re: Review Request 53479: Perform agent GC asynchronously.

> On July 17, 2017, 1:43 p.m., Jiang Yan Xu wrote: > > src/slave/gc.hpp > > Lines 114-117 (original), 115-118 (patched) > > > > > > I see that `promise == that.promise` here is required by the Multimap > > but does

Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/ --- Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, Vinod

Review Request 60934: Implemented blkio subsystem usage() for resource statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60934/ --- Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, Vinod

Review Request 60933: Added stats/control helpers for the Blkio cgroup subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60933/ --- Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, Vinod

Re: Review Request 60867: Added a method in the agent exposing an executor's allocated resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60867/#review180776 --- Ship it! Ship It! - Benjamin Mahler On July 17, 2017, 12:09

Re: Review Request 60917: Used a real UPID to send `LearnedMessage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60917/#review180773 --- Ship it! LGTM. src/log/network.hpp Line 247 (original),

Re: Review Request 60925: Updated CHANGELOG for changed semantic of recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60925/ --- (Updated July 17, 2017, 5:35 p.m.) Review request for mesos and Jiang Yan Xu.

Review Request 60931: Added test cases for framework events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60931/ --- Review request for mesos, Anand Mazumdar, Greg Mann, and Zhitao Li. Bugs:

Review Request 60930: Added 'FRAMEWORK_REMOVED' event for master streaming api.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60930/ --- Review request for mesos, Anand Mazumdar, Greg Mann, and Zhitao Li. Bugs:

Re: Review Request 53479: Perform agent GC asynchronously.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/ --- (Updated July 18, 2017, 12:23 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53479: Perform agent GC asynchronously.

> On July 17, 2017, 8:43 p.m., Jiang Yan Xu wrote: > > src/slave/gc.hpp > > Lines 114-117 (original), 115-118 (patched) > > > > > > I see that `promise == that.promise` here is required by the Multimap > > but does

Re: Review Request 53479: Perform agent GC asynchronously.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/ --- (Updated July 18, 2017, 12:22 a.m.) Review request for mesos, Benjamin Mahler

Review Request 60929: Added 'FRAMEWORK_UPDATED' event for master streaming event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60929/ --- Review request for mesos, Anand Mazumdar, Greg Mann, Vinod Kone, and Zhitao Li.

Re: Review Request 60890: WIP: Defined API for launching standalone containers.

> On July 17, 2017, 12:23 p.m., James DeFelice wrote: > > Some questions about this API: > > > > 1. If a launch request times out, how might someone query the state of the > > requested launch operation/container? > > 2. When a stand alone container terminates (either success or failure), who

Review Request 60928: Added 'FRAMEWORK_ADDED' event for master streaming event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60928/ --- Review request for mesos, Anand Mazumdar, Greg Mann, Vinod Kone, and Zhitao Li.

Re: Review Request 60236: Linted support/verify-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60236/#review180770 --- Ship it! LGTM. support/verify-reviews.py Lines 3-4

Re: Review Request 60925: Updated CHANGELOG for changed semantic of recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60925/ --- (Updated July 18, 2017, 12:02 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 60887: Decoupling `Docker::rm` from `Docker::stop` in agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60887/#review180769 --- Fix it, then Ship it! src/slave/containerizer/docker.cpp Line

Re: Review Request 60902: Moved the libnl3 configure checks into a macro.

> On July 17, 2017, 3:20 a.m., Qian Zhang wrote: > > m4/libnl3.m4 > > Lines 33-37 (patched) > > > > > > Mind to elaborate a bit about why introducing a new .m4 file? What > > about just introducing a new configure

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 18, 2017, 7:12 a.m., Avinash sridharan wrote: > > src/messages/flags.proto > > Lines 56 (patched) > > > > > > Had an internal discussion on this with Jie, and seems like having > > different DNS options

Re: Review Request 60235: Linted support/test-upgrade.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60235/#review180765 --- support/test-upgrade.py Lines 114-115 (original), 142-147

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review180764 --- src/messages/flags.proto Lines 56 (patched)

Re: Review Request 60925: Updated CHANGELOG for changed semantic of recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60925/#review180761 --- Patch looks great! Reviews applied: [60925] Passed command:

Re: Review Request 60822: Added filtering to /slaves, /slave/containers and /frameworks endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60822/#review180750 --- src/master/http.cpp Line 529 (original), 537-538 (patched)

Re: Review Request 60771: Implemented the 'SUBSCRIBE' call in the resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60771/#review180745 --- src/resource_provider/manager.cpp Lines 189 (patched)

Re: Review Request 60900: Updated Python linter to work with multiple directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60900/#review180752 --- support/mesos-style.py Lines 309-319 (original), 325-335

Re: Review Request 60900: Updated Python linter to work with multiple directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60900/#review180749 --- support/mesos-style.py Line 357 (original), 372 (patched)

Re: Review Request 60925: Updated CHANGELOG for changed semantic of recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60925/ --- (Updated July 17, 2017, 10:10 p.m.) Review request for mesos and Jiang Yan Xu.

Review Request 60925: Updated CHANGELOG for changed semantic of recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60925/ --- Review request for mesos. Repository: mesos Description --- Updated

Re: Review Request 60234: Linted support/push-commits.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60234/#review180723 --- Ship it! I'm a committer, but I have not used this script

Re: Review Request 60233: Linted support/post-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60233/#review180713 --- Ship it! Linting LGTM. support/post-reviews.py Lines 36-37

Re: Review Request 60899: Moved new Mesos CLI to src/python/.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60899/#review180746 --- Ship it! otherwise lgtm, ship it! - Eric Chung On July 16,

Re: Review Request 60771: Implemented the 'SUBSCRIBE' call in the resource provider manager.

> On July 17, 2017, 9:50 p.m., Jie Yu wrote: > > Sorry, I accidentally clicked "publish". I have more comments to come. - Jie --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 60771: Implemented the 'SUBSCRIBE' call in the resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60771/#review180219 --- src/resource_provider/manager.cpp Lines 109 (patched)

Re: Review Request 60888: WIP: Added recovery logic for standalone containers.

> On July 17, 2017, 10:12 a.m., Jie Yu wrote: > > src/slave/paths.hpp > > Lines 56-57 (patched) > > > > > > If we want to completely decouple containerizer from agent (the goal) > > in the future, i think the

Re: Review Request 60821: Introduced a "no sender" UPID.

> On July 12, 2017, 5:27 p.m., James Peach wrote: > > I think that a better approach is to define a static `UPID > > UPID::anonymous()` function that returns a well-defined anonymous UPID for > > the system. Remove all the sending functions that don't specify a `from` > > UPID and force them

Re: Review Request 53479: Perform agent GC asynchronously.

> On July 17, 2017, 1:43 p.m., Jiang Yan Xu wrote: > > src/slave/gc.hpp > > Lines 114-117 (original), 115-118 (patched) > > > > > > I see that `promise == that.promise` here is required by the Multimap > > but does

Re: Review Request 53479: Perform agent GC asynchronously.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/#review180730 --- src/slave/gc.hpp Lines 114-117 (original), 115-118 (patched)

Re: Review Request 60594: Added a`network/ports` isolator nested container test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60594/#review180731 --- Patch looks great! Reviews applied: [60491, 60493, 60494, 60764,

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review180728 --- src/messages/flags.proto Lines 56 (patched)

Re: Review Request 60917: Used a real UPID to send `LearnedMessage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60917/#review180726 --- Patch looks great! Reviews applied: [60917] Passed command:

Re: Review Request 60890: WIP: Defined API for launching standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60890/#review180722 --- Some questions about this API: 1. If a launch request times out,

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 14, 2017, 6:31 p.m., Jie Yu wrote: > > src/messages/flags.proto > > Lines 56 (patched) > > > > > > Any reason we seperate 'mesos' from 'docker'? Can we use the same? > > Qian Zhang wrote: > The reason

Review Request 60917: Used a real UPID to send `LearnedMessage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60917/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Re: Review Request 60888: WIP: Added recovery logic for standalone containers.

> On July 17, 2017, 5:12 p.m., Jie Yu wrote: > > src/slave/paths.hpp > > Lines 56-57 (patched) > > > > > > If we want to completely decouple containerizer from agent (the goal) > > in the future, i think the

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60719/#review180714 --- Patch looks great! Reviews applied: [60719] Passed command:

Re: Review Request 60482: Defined Git variables in CMake configure file.

> On July 17, 2017, 10:18 a.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Lines 347-348 (original), 367-368 (patched) > > > > > > This comment should be updated to reflect the doubling in output. +1

Re: Review Request 60899: Moved new Mesos CLI to src/python/.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60899/#review180708 --- missing bootstrap for mesos itself (config, make etc.) in the

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60719/ --- (Updated July 17, 2017, 5:59 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 60482: Defined Git variables in CMake configure file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60482/#review180706 --- Patch looks great! Reviews applied: [60482] Passed command:

Re: Review Request 60791: Add fetcher cache space usage metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60791/#review180702 --- docs/monitoring.md Lines 1258-1261 (patched)

Re: Review Request 50705: Changed master to allow partitioned slaves to reregister.

> On July 15, 2017, 4:31 p.m., David McLaughlin wrote: > > With the new code-path for mark unreachable after failover, this change > > introduced a non-backwards compatible change - namely that TASK_LOST > > messages for each task on the agent are no longer sent when the slaveLost > > message

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60719/ --- (Updated July 17, 2017, 5:50 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 60539: Added test for allocated resources per each role in the agent endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60539/ --- (Updated July 17, 2017, 5:47 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60369/ --- (Updated July 17, 2017, 5:45 p.m.) Review request for mesos, Benjamin Mahler

Review Request 60915: Enabled filtering of reservations in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60915/ --- Review request for mesos, Benjamin Mahler and haosdent huang. Bugs: MESOS-6441

Re: Review Request 60888: WIP: Added recovery logic for standalone containers.

> On July 17, 2017, 10:12 a.m., Jie Yu wrote: > > src/slave/paths.hpp > > Lines 56-57 (patched) > > > > > > If we want to completely decouple containerizer from agent (the goal) > > in the future, i think the

Re: Review Request 60482: Defined Git variables in CMake configure file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60482/#review180697 --- Ship it! Going to add some more comments and whitespace before

Re: Review Request 60888: WIP: Added recovery logic for standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60888/#review180694 --- src/slave/paths.hpp Lines 56-57 (patched)

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/#review180685 --- Patch looks great! Reviews applied: [60913] Passed command:

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/ --- (Updated July 17, 2017, 5:31 p.m.) Review request for mesos, Jie Yu and Till

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/ --- (Updated July 17, 2017, 5:31 p.m.) Review request for mesos, Jie Yu and Till

Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/ --- Review request for mesos, Jie Yu and Till Toenshoff. Bugs: MESOS-7792

Re: Review Request 60902: Moved the libnl3 configure checks into a macro.

> On July 17, 2017, 11:20 a.m., Qian Zhang wrote: > > m4/libnl3.m4 > > Lines 33-37 (patched) > > > > > > Mind to elaborate a bit about why introducing a new .m4 file? What > > about just introducing a new configure

Re: Review Request 60003: Reduced copying in defer, dispatch and Future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60003/#review180672 --- Patch looks great! Reviews applied: [60002, 60003] Passed

Re: Review Request 60867: Added a method in the agent exposing an executor's allocated resources.

> On July 14, 2017, 10:16 p.m., Benjamin Mahler wrote: > > src/slave/slave.hpp > > Lines 796-797 (original), 798-799 (patched) > > > > > > IIUC, this was supposed to represent the resources allocated the > >

Re: Review Request 60867: Added a method in the agent exposing an executor's allocated resources.

> On July 14, 2017, 10:35 p.m., Benjamin Mahler wrote: > > src/slave/slave.cpp > > Lines 7816-7818 (patched) > > > > > > Also, you don't want to include terminated tasks :) Fixed. - Andrei

Re: Review Request 60867: Added a method in the agent exposing an executor's allocated resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60867/ --- (Updated July 17, 2017, 12:09 p.m.) Review request for mesos, Benjamin Mahler

Review Request 60907: Got rid of executor's `resources` variable in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60907/ --- Review request for mesos, Benjamin Mahler and haosdent huang. Bugs: MESOS-6441

Re: Review Request 60003: Reduced copying in defer, dispatch and Future.

> On July 4, 2017, 10:55 a.m., Ilya Pronin wrote: > > 3rdparty/libprocess/include/process/deferred.hpp > > Line 77 (original), 79 (patched) > > > > > > This is more a question than an issue. Do we plan to forward

Re: Review Request 60003: Reduced copying in defer, dispatch and Future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60003/ --- (Updated July 17, 2017, 11:42 a.m.) Review request for mesos, Benjamin

Re: Review Request 60002: Added ENUM preprocessor macro.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60002/ --- (Updated July 17, 2017, 11:41 a.m.) Review request for mesos, Benjamin

Re: Review Request 60215: WIP: Logged offer ids of sent offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60215/#review180660 --- src/master/master.cpp Lines 7311 (patched)

Re: Review Request 60214: Logged when an offer is removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60214/#review180659 --- Ship it! Ship It! - Till Toenshoff On June 19, 2017, 10:42