Re: Review Request 63689: Used `Master::_apply` consistently for all offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63689/#review190554 --- PASS: Mesos patch 63689 was successfully built and tested.

Re: Review Request 63689: Used `Master::_apply` consistently for all offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63689/#review190552 --- Patch looks great! Reviews applied: [63689] Passed command:

Re: Review Request 63622: Provided handling for offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63622/#review190547 --- src/slave/slave.cpp Lines 6824-6851 (patched)

Re: Review Request 63655: Switched to `net::socketpair` in `ns::clone`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63655/#review190545 --- PASS: Mesos patch 63655 was successfully built and tested.

Re: Review Request 63652: Added d_type check in containerizer backend validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63652/#review190541 --- Patch looks great! Reviews applied: [63652] Passed command:

Re: Review Request 63682: Updated tests to toggle pipe inheritance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63682/#review190537 --- PASS: Mesos patch 63682 was successfully built and tested.

Re: Review Request 63682: Updated tests to toggle pipe inheritance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63682/#review190531 --- Patch looks great! Reviews applied: [63270, 63280, 63682]

Re: Review Request 62579: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_BlkioUsage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62579/ --- (Updated Nov. 9, 2017, 10:03 a.m.) Review request for mesos and Gilbert Song.

Re: Review Request 63674: Updated a comment about resubscribing completed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63674/#review190524 --- Ship it! Ship It! - Vinod Kone On Nov. 8, 2017, 5:31 p.m.,

Re: Review Request 62579: Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62579/#review190523 --- src/Makefile.am Lines 2469 (patched)

Re: Review Request 63276: Windows: Added `Cpu` and `Mem` isolators.

> On Nov. 8, 2017, 3:28 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/windows.hpp > > Lines 47 (patched) > > > > > > Can you move the implementation to a cpp file (instead of putting in > > the

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/#review190518 --- FAIL: Failed to apply the dependent review: 62145. Failed

Re: Review Request 63674: Updated a comment about resubscribing completed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63674/#review190515 --- PASS: Mesos patch 63674 was successfully built and tested.

Re: Review Request 63674: Updated a comment about resubscribing completed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63674/#review190513 --- Patch looks great! Reviews applied: [63662, 63672, 63673, 63674]

Review Request 63689: Used `Master::_apply` consistently for all offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63689/ --- Review request for mesos, Benjamin Bannier and Jan Schlicht. Bugs: MESOS-7235

Re: Review Request 63276: Windows: Added `Cpu` and `Mem` isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63276/#review190505 --- src/slave/containerizer/mesos/isolators/windows.hpp Lines 47

Re: Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63268/#review190504 --- Ship it! Ship It! - Jie Yu On Nov. 2, 2017, 8:39 p.m.,

Re: Review Request 63625: Added a test for resource conversion using a resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63625/#review190500 --- FAIL: Failed to apply the dependent review: 63622. Failed

Re: Review Request 63652: Added d_type check in containerizer backend validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63652/#review190499 --- PASS: Mesos patch 63652 was successfully built and tested.

Re: Review Request 63678: Improved the signal safety of `ns::clone`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63678/#review190498 --- PASS: Mesos patch 63678 was successfully built and tested.

Re: Review Request 63620: Updated offer operation handling to set resource versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63620/#review190496 --- Fix it, then Ship it! src/master/master.cpp Lines 5391

Re: Review Request 63625: Added a test for resource conversion using a resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63625/#review190495 --- Bad patch! Reviews applied: [63625, 63679, 63622, 63621, 63620,

Review Request 63682: Updated tests to toggle pipe inheritance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63682/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and Jie

Re: Review Request 63577: Fixed a task status update race in default executor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63577/#review190489 --- Fix it, then Ship it! src/tests/default_executor_tests.cpp

Re: Review Request 63678: Improved the signal safety of `ns::clone`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63678/#review190488 --- Patch looks great! Reviews applied: [63675, 63677, 63678]

Review Request 63680: Added a container daemon to monitor a long-running standalone container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/ --- Review request for mesos, Jie Yu and Joseph Wu. Bugs: MESOS-8183

Re: Review Request 63674: Updated a comment about resubscribing completed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63674/#review190486 --- Fix it, then Ship it! LGTM modulo Gaston's suggestion.

Re: Review Request 63400: Fix bad links.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63400/#review190485 --- PASS: Mesos patch 63400 was successfully built and tested.

Re: Review Request 63515: Updated xfs/disk, gpu, and cgroups isolators' prepare function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63515/#review190484 --- Can you update `network/port_mapping` isolator as well. There is

Re: Review Request 63514: Updated tests with Containerizer::launch interface change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63514/#review190482 --- Ship it! Ship It! - Jie Yu On Nov. 2, 2017, 4:04 p.m.,

Re: Review Request 63063: Modified Containerizer::launch interface to allow repeated launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63063/#review190481 --- Fix it, then Ship it! src/slave/containerizer/docker.cpp

Re: Review Request 63058: Changed failure response of LAUNCH containers API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63058/#review190478 --- Ship it! Ship It! - Jie Yu On Nov. 2, 2017, 4:01 p.m.,

Re: Review Request 63057: Moved and refactored some nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63057/#review190477 --- Ship it! Ship It! - Jie Yu On Nov. 2, 2017, 4 p.m., Joseph

Re: Review Request 63056: Parameterized test for nested container launch.

> On Nov. 8, 2017, 7:06 p.m., Jie Yu wrote: > > src/tests/agent_container_api_tests.cpp > > Lines 164 (patched) > > > > > > hum, i guess you cannot use `AWAIT_READY` because it's not in the test > > body. > >

Re: Review Request 63056: Parameterized test for nested container launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63056/#review190471 --- src/tests/agent_container_api_tests.cpp Lines 88 (patched)

Re: Review Request 63652: Added d_type check in containerizer backend validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63652/ --- (Updated Nov. 8, 2017, 10:46 a.m.) Review request for mesos and Gilbert Song.

Re: Review Request 63674: Updated a comment about resubscribing completed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63674/#review190468 --- Fix it, then Ship it! src/master/master.cpp Line 2672

Re: Review Request 63400: Fix bad links.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63400/#review190470 --- Patch looks great! Reviews applied: [63400] Passed command:

Re: Review Request 63054: Updated test filters to include value-parameterized tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63054/#review190469 --- Ship it! Ship It! - Jie Yu On Oct. 17, 2017, 12:05 a.m.,

Re: Review Request 62145: Implemented Standalone Container API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62145/#review190413 --- src/slave/http.cpp Line 2359 (original), 2420-2423 (patched)

Re: Review Request 63625: Added a test for resource conversion using a resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63625/ --- (Updated Nov. 8, 2017, 6:56 p.m.) Review request for mesos, Benjamin Bannier

Review Request 63679: Added test helpers for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63679/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Review Request 63678: Improved the signal safety of `ns::clone`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63678/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8159

Re: Review Request 60891: Added ACLs and AuthZ for standalone containers.

> On Oct. 18, 2017, 3:40 a.m., Jie Yu wrote: > > include/mesos/authorizer/acls.proto > > Lines 435-437 (patched) > > > > > > hum, i got confused. How do you get the user of a container? And it's > > not consistent

Review Request 63677: Changed `os:Stack` to allocate with `mmap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63677/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8159

Review Request 63675: Added a non-allocating variant of `os::clone`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63675/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8159

Review Request 63672: Added a two-parameter SendSubscribe action in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63672/ --- Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-6949

Review Request 63673: Allowed multiple master detections in MasterFailover test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63673/ --- Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-6949

Review Request 63674: Updated a comment about resubscribing completed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63674/ --- Review request for mesos, Anand Mazumdar, Greg Mann, and Vinod Kone.

Re: Review Request 63654: Added a `net::socketpair` helper to stout.

> On Nov. 8, 2017, 1:48 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/posix/socket.hpp > > Lines 137 (patched) > > > > > > Any reason we don't just let the message from `strerror` with the > >

Re: Review Request 63654: Added a `net::socketpair` helper to stout.

> On Nov. 8, 2017, 1:48 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/posix/socket.hpp > > Lines 89 (patched) > > > > > > Does it make sense to return a `Try>` here for > >

Re: Review Request 63400: Fix bad links.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63400/ --- (Updated Nov. 8, 2017, 5:06 p.m.) Review request for mesos, Andrew

Re: Review Request 63654: Added a `net::socketpair` helper to stout.

> On Nov. 8, 2017, 1:48 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/posix/socket.hpp > > Lines 74 (patched) > > > > > > I am not sure such a function is useful in general; maybe consider > >

Re: Review Request 63622: Provided handling for offer operation updates.

> On Nov. 7, 2017, 4:49 p.m., Benjamin Bannier wrote: > > src/resource_provider/message.hpp > > Lines 51 (patched) > > > > > > Since we seem to mirror `Call.UpdateOfferOperationStatus` pretty > > closely here, let's

Re: Review Request 60891: Added ACLs and AuthZ for standalone containers.

> On Oct. 17, 2017, 8:40 p.m., Jie Yu wrote: > > include/mesos/authorizer/acls.proto > > Lines 435-437 (patched) > > > > > > hum, i got confused. How do you get the user of a container? And it's > > not consistent

Re: Review Request 63622: Provided handling for offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63622/ --- (Updated Nov. 8, 2017, 5:12 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63621: Added a devolve function for 'OfferOperationStatus'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63621/ --- (Updated Nov. 8, 2017, 4:22 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63622: Provided handling for offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63622/ --- (Updated Nov. 8, 2017, 4:25 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63620: Updated offer operation handling to set resource versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63620/ --- (Updated Nov. 8, 2017, 4:23 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63662: Dropped scheduler call if a connection has been interrupted.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63662/#review190447 --- PASS: Mesos patch 63662 was successfully built and tested.

Re: Review Request 63662: Dropped scheduler call if a connection has been interrupted.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63662/#review190446 --- Patch looks great! Reviews applied: [63662] Passed command:

Re: Review Request 63654: Added a `net::socketpair` helper to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63654/#review190444 --- 3rdparty/stout/include/stout/os/posix/socket.hpp Lines 74

Re: Review Request 63622: Provided handling for offer operation updates.

> On Nov. 7, 2017, 8:45 p.m., Jie Yu wrote: > > src/slave/slave.cpp > > Lines 6823-6825 (patched) > > > > > > We still want to forward the status udpate for those operations, right? > > Just we don't need to

Re: Review Request 63661: Updated tests to use `createCallSubscribe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63661/#review190441 --- Patch looks great! Reviews applied: [63661] Passed command:

Re: Review Request 63661: Updated tests to use `createCallSubscribe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63661/#review190440 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Review Request 63662: Dropped scheduler call if a connection has been interrupted.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63662/ --- Review request for mesos, Greg Mann and Till Toenshoff. Bugs: MESOS-8179

Review Request 63661: Updated tests to use `createCallSubscribe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63661/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-8094

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63434/#review190437 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 3, 2017,

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

> On Nov. 7, 2017, 2:22 p.m., Qian Zhang wrote: > > I think you need to do the similar changes to the `CheckInfo` message. > > Avinash sridharan wrote: > `CheckInfo` is specific to the `default-executor` and hence UCR. We don't > support IPv6 for CNI and hence UCR at this point, so hence

Re: Review Request 63655: Switched to `net::socketpair` in `ns::clone`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63655/#review190421 --- Patch looks great! Reviews applied: [63654, 63655] Passed