Re: Review Request 63385: Added utility functions for CSI Plugin info and volume attributes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63385/#review191845 --- src/csi/utils.hpp Lines 36-43 (patched)

Re: Review Request 64067: Fixed a bug for starting local resource provider daemon multiple times.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64067/#review191844 --- Ship it! Ship It! - Jie Yu On Nov. 24, 2017, 6:32 p.m.,

Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/#review191843 --- src/exec/exec.cpp Lines 355 (patched)

Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/ --- (Updated Nov. 24, 2017, 8:14 p.m.) Review request for mesos, Andrei Budnik,

Review Request 64068: Increased executor log verbosity in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64068/ --- Review request for mesos, Andrei Budnik, Armand Grillet, and Vinod Kone.

Review Request 64070: Ensured executor adapter propagates error and shutdown messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64070/ --- Review request for mesos, Andrei Budnik, Armand Grillet, and Vinod Kone.

Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/ --- (Updated Nov. 24, 2017, 7:13 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 64032: Promoted log level to warning for disconnected events in exec.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64032/ --- (Updated Nov. 24, 2017, 7:12 p.m.) Review request for mesos, Andrei Budnik,

Review Request 64069: Ensured command executor always honors shutdown request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64069/ --- Review request for mesos, Andrei Budnik, Armand Grillet, and Vinod Kone.

Re: Review Request 63377: Added filesystem layout for CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63377/ --- (Updated Nov. 24, 2017, 6:48 p.m.) Review request for mesos, Jie Yu, Joseph

Review Request 64067: Fixed a bug for starting local resource provider daemon multiple times.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64067/ --- Review request for mesos, Alexander Rukletsov, Jie Yu, and Jan Schlicht.

Re: Review Request 64033: Terminated executors if kill task received before launch task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/ --- (Updated Nov. 24, 2017, 6:21 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 64033: Terminated executors if kill task received before launch task.

> On Nov. 22, 2017, 5:44 p.m., Vinod Kone wrote: > > can you write tests please? Writing a test here is not trivial. We don't have infrastructure in place to "hook" to our executors. All built-in executors are implemented in ".cpp" files, which does not allow to create an instance of executor

Re: Review Request 64033: Terminated executors if kill task received before launch task.

> On Nov. 24, 2017, 1:07 p.m., Andrei Budnik wrote: > > src/docker/executor.cpp > > Lines 386 (patched) > > > > > > Consider moving this check to [the > >

Re: Review Request 63842: Allowed removing non-terminal offer operations.

> On Nov. 21, 2017, 7:59 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 10925 (original), 10922 (patched) > > > > > > Especially now that we have code in this function which switches on > > operation

Re: Review Request 63842: Allowed removing non-terminal offer operations.

> On Nov. 21, 2017, 11:22 p.m., Jie Yu wrote: > > src/master/master.hpp > > Lines 2919 (patched) > > > > > > `removeOfferOperation` might be used for old operations too. This will > > throw a CHECK failure.

Re: Review Request 63842: Allowed removing non-terminal offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63842/ --- (Updated Nov. 24, 2017, 3:52 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 63732: Reconciled offer operations between agent and master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63732/ --- (Updated Nov. 24, 2017, 3:50 p.m.) Review request for mesos, Jie Yu and Jan

Review Request 64062: Added 6 nested container tests for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64062/ --- Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Bugs:

Re: Review Request 63730: Passed operations from resource provider to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63730/ --- (Updated Nov. 24, 2017, 3:10 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 63917: Renamed resource provider message UpdateTotalResources to UpdateState.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63917/ --- (Updated Nov. 24, 2017, 3:10 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 63843: Implemented a test of offer operation reconcilation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63843/ --- (Updated Nov. 24, 2017, 3:07 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/ --- (Updated Nov. 24, 2017, 3:08 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 64001: Made sure all true allocator agent updates return correct status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64001/ --- (Updated Nov. 24, 2017, 3:07 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 63997: Added a new allocator method to add resources to agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63997/ --- (Updated Nov. 24, 2017, 3:06 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 63842: Allowed removing non-terminal offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63842/ --- (Updated Nov. 24, 2017, 3:08 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 63918: Updated ResourceProviderMessage stringification with recent changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63918/ --- (Updated Nov. 24, 2017, 3:07 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 63732: Reconciled offer operations between agent and master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63732/ --- (Updated Nov. 24, 2017, 3:07 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 63844: Removed acknowledged offer operation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63844/ --- (Updated Nov. 24, 2017, 3:07 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 64056: Added a helper to extract consumed resources from offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64056/#review191836 --- Ship it! Ship It! - Jan Schlicht On Nov. 24, 2017, 10:31

Re: Review Request 64033: Terminated executors if kill task received before launch task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/#review191835 --- src/docker/executor.cpp Lines 386 (patched)

Re: Review Request 64054: Refactored offer operation handling for speculative operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64054/ --- (Updated Nov. 24, 2017, 12:24 p.m.) Review request for mesos, Benjamin Bannier

Review Request 64056: Added a helper to extract consumed resources from offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64056/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos