Re: Review Request 64969: Added an performance benchmark for master `getstate` v1 api.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64969/#review194923 --- - Can you measure with optimization turned on? - No need to

Re: Review Request 64969: Added an performance benchmark for master `getstate` v1 api.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64969/ --- (Updated Jan. 5, 2018, 5:40 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 64969: Added an performance benchmark for master `getstate` v1 api.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64969/#review194920 --- Can you link in the output in the 'Testing Done'? - Benjamin

Review Request 65000: Added an SLRP test for agent being registered with a new ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65000/ --- Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu. Repository:

Re: Review Request 64630: Narrowed task sandbox permissions from 0755 to 0750.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64630/#review194919 --- src/tests/api_tests.cpp Lines 2327 (patched)

Re: Review Request 64630: Narrowed task sandbox permissions from 0755 to 0750.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64630/#review194915 --- Looks good to me! Just some minor comments about naming and

Re: Review Request 64735: Fixed conversion warnings in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64735/#review194917 --- Fix it, then Ship it! Ship It!

Re: Review Request 64734: Fixed conversion warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64734/#review194916 --- Ship it! Ship It! - Joseph Wu On Jan. 5, 2018, 1:54 p.m.,

Review Request 64998: Added a SLRP test for CSI plugin restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64998/ --- Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu. Bugs:

Re: Review Request 64733: Fixed conversion warnings in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64733/#review194914 --- Ship it! Ship It! - Joseph Wu On Jan. 5, 2018, 1:54 p.m.,

Re: Review Request 64732: Fixed conversion warnings in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64732/#review194912 --- Ship it! Ship It! - Joseph Wu On Jan. 5, 2018, 1:53 p.m.,

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/ --- (Updated Jan. 5, 2018, 10:25 p.m.) Review request for mesos, Alexander

Re: Review Request 64731: Ended `IOSwitchboard::_prepare` with `UNREACHABLE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64731/#review194911 --- Fix it, then Ship it!

Re: Review Request 64730: Changed `Sorter::count()` to return `size_t` instead of `int`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64730/#review194910 --- Ship it! Ship It! - Joseph Wu On Jan. 5, 2018, 1:53 p.m.,

Re: Review Request 64729: Made `Duration::operator*` accept `int` and `size_t`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64729/#review194909 --- 3rdparty/stout/include/stout/duration.hpp Lines 173 (patched)

Review Request 64994: Renamed SLRP tests to describe them better.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64994/ --- Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu. Repository:

Review Request 64992: Added SLRP unit tests for profile updates and corner cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64992/ --- Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu. Bugs:

Re: Review Request 64962: Windows: Explicitly state source and destination path for extract.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64962/#review194908 --- Ship it! Ship It! - Jeff Coffler On Jan. 5, 2018, 9:50

Re: Review Request 64962: Windows: Explicitly state source and destination path for extract.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64962/#review194907 --- src/launcher/fetcher.cpp Line 101 (original), 103 (patched)

Review Request 64995: Improved image store manifest parsing errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64995/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8404

Review Request 64993: Made the `os::read` error less redundant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64993/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8404

Re: Review Request 64961: Windows: Fixed memory leak.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64961/#review194905 --- Ship it! Ship It! - Jeff Coffler On Jan. 5, 2018, 9:49

Re: Review Request 64735: Fixed conversion warnings in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64735/ --- (Updated Jan. 5, 2018, 1:54 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 64736: Fixed conversion warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64736/ --- (Updated Jan. 5, 2018, 1:55 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 64734: Fixed conversion warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64734/ --- (Updated Jan. 5, 2018, 1:54 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 64733: Fixed conversion warnings in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64733/ --- (Updated Jan. 5, 2018, 1:54 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 64730: Changed `Sorter::count()` to return `size_t` instead of `int`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64730/ --- (Updated Jan. 5, 2018, 1:53 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 64731: Ended `IOSwitchboard::_prepare` with `UNREACHABLE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64731/ --- (Updated Jan. 5, 2018, 1:53 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 64732: Fixed conversion warnings in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64732/ --- (Updated Jan. 5, 2018, 1:53 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 64729: Made `Duration::operator*` accept `int` and `size_t`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64729/ --- (Updated Jan. 5, 2018, 1:53 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Review Request 64962: Windows: Explicitly state source and destination path for extract.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64962/ --- Review request for mesos, Akash Gupta, Jeff Coffler, Joseph Wu, and Michael

Review Request 64961: Windows: Fixed memory leak.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64961/ --- Review request for mesos, Akash Gupta, Jeff Coffler, Joseph Wu, and Michael

Re: Review Request 64940: Prevented a crash when an agent with terminal tasks is lost.

> On Jan. 4, 2018, 2:09 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Lines 10061 (patched) > > > > > > Perhaps move all the logic around determining the unreachable task down > > here. > > > >

Re: Review Request 64940: Prevented a crash when an agent with terminal tasks is lost.

> On Jan. 5, 2018, 1:25 a.m., Vinod Kone wrote: > > src/master/master.cpp > > Lines 10037-10056 (original), 10039-10062 (patched) > > > > > > I think we shouldn't create a TASK_UNREACHABLE status update and call

Re: Review Request 64940: Prevented a crash when an agent with terminal tasks is lost.

> On Jan. 5, 2018, 1:25 a.m., Vinod Kone wrote: > > src/tests/master_tests.cpp > > Lines 7630 (patched) > > > > > > `the task`, which task? are both the tasks using the same executor? We need one task to finish

Re: Review Request 64940: Prevented a crash when an agent with terminal tasks is lost.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64940/ --- (Updated Jan. 5, 2018, 7:06 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 64940: Prevented a crash when an agent with terminal tasks is lost.

> On Jan. 4, 2018, 5:25 p.m., Vinod Kone wrote: > > src/master/master.cpp > > Lines 10037-10056 (original), 10039-10062 (patched) > > > > > > I think we shouldn't create a TASK_UNREACHABLE status update and call

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/#review194884 --- Fix it, then Ship it! src/docker/docker.cpp Line 741

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/ --- (Updated Jan. 5, 2018, 6:33 p.m.) Review request for mesos, Alexander

Re: Review Request 63861: Windows: Updated networking doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63861/ --- (Updated Jan. 5, 2018, 6:32 p.m.) Review request for mesos, Alexander

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/ --- (Updated Jan. 5, 2018, 6:31 p.m.) Review request for mesos, Alexander

Re: Review Request 64932: Added example framework converting disk resources.

> On Jan. 4, 2018, 12:49 p.m., Gaston Kleiman wrote: > > src/examples/test_csi_user_framework.cpp > > Lines 399 (patched) > > > > > > Why don't we make this a `string` instead of an `Option`? > > > > That

Re: Review Request 64973: Renamed VolumeProfileAdaptor to DiskProfileAdaptor (continued).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64973/#review194877 --- src/Makefile.am Line 1477 (original), 1477 (patched)

Re: Review Request 64973: Renamed VolumeProfileAdaptor to DiskProfileAdaptor (continued).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64973/#review194875 --- Fix it, then Ship it! src/Makefile.am Line 386 (original),

Re: Review Request 64980: Updated health check doc with 3xx redirects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64980/#review194870 --- Ship it! docs/health-checks.md Lines 389-390 (original),

Re: Review Request 64980: Updated health check doc with 3xx redirects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64980/ --- (Updated Jan. 5, 2018, 4 p.m.) Review request for mesos and Till Toenshoff.

Review Request 64980: Updated health check doc with 3xx redirects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64980/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Review Request 64978: WIP: Attached and detached executor volume directory for task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64978/ --- Review request for mesos. Bugs: MESOS-8279

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review194862 --- Some small issues to fix, there are also some typos in the commit

Re: Review Request 64932: Added example framework converting disk resources.

> On Jan. 4, 2018, 9:49 p.m., Gaston Kleiman wrote: > > Should we add this new framework to `src/tests/examples_tests.cpp`? I am not sure the framework would be useful in its current form for such a test; it e.g., has no clear termination criterion. - Benjamin

Re: Review Request 64970: Replace ad hoc venv under support/ with tox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review194853 --- I agree with Kevin, hhaving tox managing our virtualenvs rather

Re: Review Request 64932: Added example framework converting disk resources.

> On Jan. 4, 2018, 9:49 p.m., Gaston Kleiman wrote: > > src/examples/test_csi_user_framework.cpp > > Lines 278 (patched) > > > > > > I'd rephrase this: > > > > ``` > > Check whether the given resources

Re: Review Request 64932: Added example framework converting disk resources.

> On Jan. 5, 2018, 6:01 a.m., Greg Mann wrote: > > src/examples/test_csi_user_framework.cpp > > Lines 282 (patched) > > > > > > Is it not possible that a single resource provider can offer both > > reserved and

Re: Review Request 64932: Added example framework converting disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64932/ --- (Updated Jan. 5, 2018, 1:37 p.m.) Review request for mesos, Greg Mann and Jie

Re: Review Request 64805: Changed 'ConstantEndpointDetector' to have value semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64805/#review194850 --- Ship it! Ship It! - Jan Schlicht On Dec. 22, 2017, 2:36

Review Request 64973: Renamed VolumeProfileAdaptor to DiskProfileAdaptor (continued).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64973/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 64972: Renamed VolumeProfileAdaptor to DiskProfileAdaptor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64972/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 64970: Replace ad hoc venv under support/ with tox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review194848 --- Is the assumption that the user already have `tox` installed on

Re: Review Request 64953: Added error message in tests for orphaned containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64953/#review194845 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 4, 2018,

Review Request 64970: Replace ad hoc venv under support/ with tox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/ --- Review request for mesos, Armand Grillet and Kevin Klues. Repository: mesos