Re: Review Request 65182: Tested that agent resends unacknowledged op status updates on recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65182/#review195777 --- PASS: Mesos patch 65182 was successfully built and tested.

Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65039/#review195776 --- PASS: Mesos patch 65039 was successfully built and tested.

Re: Review Request 65231: Fixed detaching task volume directories of destroyed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65231/ --- (Updated Jan. 19, 2018, 2:46 a.m.) Review request for mesos, Michael Park,

Re: Review Request 65231: Fixed detaching task volume directories of destroyed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65231/#review195772 --- Ship it! Ship It! - Qian Zhang On Jan. 19, 2018, 10:30

Re: Review Request 65231: Fixed detaching task volume directories of destroyed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65231/#review195771 --- src/slave/slave.cpp Lines 1030-1031 (patched)

Re: Review Request 65231: Fixed detaching task volume directories of destroyed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65231/#review195770 --- PASS: Mesos patch 65231 was successfully built and tested.

Re: Review Request 65231: Fixed detaching task volume directories of destroyed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65231/ --- (Updated Jan. 19, 2018, 2:30 a.m.) Review request for mesos, Michael Park,

Re: Review Request 65231: Fixed detaching task volume directories of destroyed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65231/#review195769 --- PASS: Mesos patch 65231 was successfully built and tested.

Re: Review Request 65231: Fixed detaching task volume directories of destroyed frameworks.

> On Jan. 19, 2018, 1:36 a.m., Vinod Kone wrote: > > Can you or @qian write a unit test that triggered this bug? Let's do the unit test in another patch. Tracking with MESOS-8462. - Chun-Hung --- This is an automatically generated

Re: Review Request 65231: Fixed detaching task volume directories of destroyed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65231/ --- (Updated Jan. 19, 2018, 2:22 a.m.) Review request for mesos, Michael Park,

Re: Review Request 65231: Fixed detaching task volume directories of destroyed frameworks.

> On Jan. 19, 2018, 1:36 a.m., Vinod Kone wrote: > > src/slave/slave.cpp > > Lines 1029 (patched) > > > > > > Custom executors satisfy this check so it's not fool proof. Lets pass > > `ExecutorInfo` here and check

Re: Review Request 65057: Tested that op status updates dropped en route to master are resent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65057/ --- (Updated Jan. 18, 2018, 6:19 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 65231: Fixed detaching task volume directories of destroyed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65231/#review195764 --- Can you or @qian write a unit test that triggered this bug?

Re: Review Request 65231: Fixed detaching task volume directories of destroyed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65231/ --- (Updated Jan. 19, 2018, 1:25 a.m.) Review request for mesos, Michael Park,

Re: Review Request 65231: Fixed detaching task volume directories of destroyed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65231/#review195763 --- src/slave/slave.cpp Lines 5915-5919 (original), 5998-6002

Re: Review Request 65090: Mesos flags related to ZooKeeper use SecurePathOrValue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65090/#review195762 --- Fix it, then Ship it! src/master/flags.hpp Line 105

Re: Review Request 65226: Added SecurePathOrValue for file flags which need not to leak contents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65226/#review195761 --- Fix it, then Ship it! Awesome, thanks Alexander :)

Review Request 65227: Added specific flag loader for zookeeper urls preventing password leaks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65227/ --- Review request for mesos. Repository: mesos Description --- Adds the

Re: Review Request 65231: Fixed detaching task volume directories of destroyed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65231/ --- (Updated Jan. 19, 2018, 12:48 a.m.) Review request for mesos, Michael Park,

Re: Review Request 65232: Resumed the clock if necessary when destroying test agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65232/#review195760 --- Ship it! Ship It! - Gaston Kleiman On Jan. 18, 2018, 4:40

Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65039/ --- (Updated Jan. 19, 2018, 12:42 a.m.) Review request for mesos, Benjamin

Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent.

> On Jan. 17, 2018, 8:44 a.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 1797 (patched) > > > > > > This seems unneeded. > > Greg Mann wrote: > If the clock

Review Request 65232: Resumed the clock if necessary when destroying test agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65232/ --- Review request for mesos, Benjamin Bannier and Gaston Kleiman. Repository:

Review Request 65231: Fixed detaching task volume directories of destroyed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65231/ --- Review request for mesos, Michael Park and Vinod Kone. Bugs: MESOS-8460

Re: Review Request 64970: Use tox for linting and testing code living uder src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review195757 --- PASS: Mesos patch 64970 was successfully built and tested.

Re: Review Request 64970: Replace ad hoc venv under support/ with tox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/ --- (Updated Jan. 18, 2018, 11:46 p.m.) Review request for mesos, Armand Grillet

Re: Review Request 64970: Replace ad hoc venv under support/ with tox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/ --- (Updated Jan. 18, 2018, 11:20 p.m.) Review request for mesos, Armand Grillet

Re: Review Request 65229: Made `GetNodeID` call depend on `PUBLISH_UNPUBLISH_VOLUME` capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65229/#review195752 --- PASS: Mesos patch 65229 was successfully built and tested.

Re: Review Request 65229: Made `GetNodeID` call depend on `PUBLISH_UNPUBLISH_VOLUME` capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65229/ --- (Updated Jan. 18, 2018, 8:58 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 65229: Made `GetNodeID` call depend on `PUBLISH_UNPUBLISH_VOLUME` capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65229/#review195748 --- Ship it! Ship It! - Jie Yu On Jan. 18, 2018, 8:21 p.m.,

Review Request 65229: Made `GetNodeID` call depend on `PUBLISH_UNPUBLISH_VOLUME` capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65229/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 65090: Mesos flags related to ZooKeeper use SecurePathOrValue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65090/#review195747 --- PASS: Mesos patch 65090 was successfully built and tested.

Re: Review Request 65059: Speeded up SLRP unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65059/ --- (Updated Jan. 18, 2018, 7:30 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 65057: Tested that op status updates dropped en route to master are resent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65057/#review195745 --- src/tests/storage_local_resource_provider_tests.cpp Lines 2132

Re: Review Request 65090: Mesos flags related to ZooKeeper use SecurePathOrValue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65090/ --- (Updated Jan. 18, 2018, 8:01 p.m.) Review request for mesos and Greg Mann.

Review Request 65226: Added SecurePathOrValue for file flags which need not to leak contents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65226/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8413

Re: Review Request 65032: Added a SLRP unit test for agent reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65032/#review195643 --- src/tests/storage_local_resource_provider_tests.cpp Lines 1697

Re: Review Request 64574: Ensured trailing '/' in URL is insignificant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64574/#review195744 --- PASS: Mesos patch 64574 was successfully built and tested.

Re: Review Request 65223: Removed duplicated "/help" prefix in links in /help response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65223/#review195743 --- PASS: Mesos patch 65223 was successfully built and tested.

Re: Review Request 65212: Updated `mesos-tidy` docker build setup for benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65212/#review195742 --- Ship it! Ship It! - Michael Park On Jan. 18, 2018, 5:24

Review Request 65223: Removed duplicated "/help" prefix in links in /help response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65223/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8458

Re: Review Request 64574: Ensured trailing '/' in URL is insignificant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64574/ --- (Updated Jan. 18, 2018, 5:46 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 64992: Added SLRP unit tests for profile updates and corner cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64992/ --- (Updated Jan. 18, 2018, 5:30 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 61811: Flattened continuation chains in containerizer for readability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61811/#review195734 --- Ship it! Ship It! - Michael Park On Jan. 18, 2018, 5:11

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review195727 --- PASS: Mesos patch 65045 was successfully built and tested.

Re: Review Request 64574: Ensured trailing '/' in URL is insignificant.

> On Dec. 19, 2017, 1:08 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/process.cpp > > Lines 3530-3531 (patched) > > > > > > This approach doesn't seem quite right to me, since it prevents the > > user

Re: Review Request 65212: Updated `mesos-tidy` docker build setup for benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65212/#review195723 --- PASS: Mesos patch 65212 was successfully built and tested.

Re: Review Request 64211: Added configure/make options to build the new CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/#review195722 --- PASS: Mesos patch 64211 was successfully built and tested.

Re: Review Request 61811: Flattened continuation chains in containerizer for readability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61811/#review195721 --- PASS: Mesos patch 61811 was successfully built and tested.

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Jan. 17, 2018, 10:18 a.m., Benjamin Bannier wrote: > > src/tests/api_tests.cpp > > Line 181 (original), 181 (patched) > > > > > > Could you add something to the commit message explaining why this is > >

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/ --- (Updated Jan. 18, 2018, 3:11 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/ --- (Updated Jan. 18, 2018, 3:10 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review195718 --- src/python/lib/mesos/exceptions.py Lines 27-33 (patched)

Re: Review Request 65212: Updated `mesos-tidy` docker build setup for benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65212/ --- (Updated Jan. 18, 2018, 2:24 p.m.) Review request for mesos and Michael Park.

Re: Review Request 61811: Flattened continuation chains in containerizer for readability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61811/ --- (Updated Jan. 18, 2018, 1:11 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 61811: Flattened continuation chains in containerizer for readability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61811/ --- (Updated Jan. 18, 2018, 1:10 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 59746: Stopped accounting aborted container launches as failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59746/ --- (Updated Jan. 18, 2018, 1:09 p.m.) Review request for mesos, Greg Mann, Ian

Re: Review Request 65208: Prevented redundant descriptions when applying reviewboard reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65208/#review195715 --- PASS: Mesos patch 65208 was successfully built and tested.

Review Request 65208: Prevented redundant descriptions when applying reviewboard reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65208/ --- Review request for mesos, Armand Grillet and Till Toenshoff. Bugs: MESOS-7979

Re: Review Request 65197: Added some missing email addresses to the contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65197/#review195705 --- Ship it! Ship It! - Andrei Budnik On Jan. 18, 2018, 12:16

Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent.

> On Jan. 17, 2018, 9:44 a.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 1797 (patched) > > > > > > This seems unneeded. > > Greg Mann wrote: > If the clock

Re: Review Request 65197: Added some missing email addresses to the contributors list.

> On Jan. 18, 2018, 12:23 a.m., Joseph Wu wrote: > > docs/contributors.yaml > > Lines 118 (patched) > > > > > > Only one here too: > > ``` > > commit 30f7f3e1965885406d6d3e49348bee7e7d0df9d5 > > Author: