Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66644/ --- (Updated May 2, 2018, 5:18 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters.

> On May 1, 2018, 8:50 p.m., Jiang Yan Xu wrote: > > src/tests/partition_tests.cpp > > Lines 171 (patched) > > > > > > This seems to be exceeded the 80 character limit. For some reason the pre-commit hook didn't

Re: Review Request 66896: Updated `csi.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66896/#review202257 --- Patch looks great! Reviews applied: [66893, 66894, 66896]

Re: Review Request 66901: Add the ASF events link to the website.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66901/#review202254 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 66901: Add the ASF events link to the website.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66901/ --- Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/#review202253 --- How about adding tests to validate that resources with providers

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review202252 --- Ship it! Ship It! - Chun-Hung Hsiao On May 1, 2018, 10:44

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/#review202251 --- src/tests/master_validation_tests.cpp Lines 1497 (patched)

Re: Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66227/#review202237 --- Fix it, then Ship it! src/tests/api_tests.cpp Lines 3684

Re: Review Request 66900: Avoid copying of re-register framework messages in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66900/#review202248 --- PASS: Mesos patch 66900 was successfully built and tested.

Review Request 66900: Avoid copying of re-register framework messages in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66900/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 66860: Avoid copying of register framework messages in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66860/ --- (Updated May 1, 2018, 4:44 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/#review202245 --- FAIL: Failed to apply the dependent review: 66531. Failed

Re: Review Request 65784: Added validation of QuotaRequest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65784/#review202244 --- Fix it, then Ship it! src/master/quota.cpp Lines 199-200

Re: Review Request 66896: Updated `csi.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66896/#review202242 --- PASS: Mesos patch 66896 was successfully built and tested.

Re: Review Request 66892: Added `SubprocessTest.PipeLargeOutput`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66892/#review202243 --- PASS: Mesos patch 66892 was successfully built and tested.

Re: Review Request 65785: Added a test for QuotaRequest validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65785/#review202241 --- Ship it! Ship It! src/tests/master_validation_tests.cpp

Re: Review Request 66885: Removed unnecessary `get()` accessors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66885/#review202240 --- Patch looks great! Reviews applied: [66885] Passed command:

Re: Review Request 66834: Windows: Specialized `flags::parse`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66834/#review202239 --- Ship it! Ship It! - Joseph Wu On May 1, 2018, 3:43 p.m.,

Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66051/ --- (Updated May 1, 2018, 3:56 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66532/#review202238 --- src/tests/persistent_volume_tests.cpp Line 1212 (original), 1133

Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66532/ --- (Updated May 1, 2018, 3:55 p.m.) Review request for mesos, Chun-Hung Hsiao and

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/ --- (Updated May 1, 2018, 3:44 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66790/ --- (Updated May 1, 2018, 3:42 p.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66532/ --- (Updated May 1, 2018, 3:45 p.m.) Review request for mesos, Chun-Hung Hsiao and

Re: Review Request 66834: Windows: Specialized `flags::parse`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66834/ --- (Updated May 1, 2018, 3:43 p.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/ --- (Updated May 1, 2018, 3:37 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- (Updated May 1, 2018, 3:35 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66892: Added `SubprocessTest.PipeLargeOutput`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66892/#review202236 --- Ship it! Ship It! - Joseph Wu On May 1, 2018, 2:24 p.m.,

Re: Review Request 66881: Added benchmark test for master metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66881/#review202235 --- PASS: Mesos patch 66881 was successfully built and tested.

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

> On May 1, 2018, 2:39 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > > Lines 651-652 (original), 697-698 (patched) > > > > > > What's wrong with this test? (You might want to

Re: Review Request 66834: Windows: Specialized `flags::parse`.

> On May 1, 2018, 2:48 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/flags/parse.hpp > > Lines 197-200 (patched) > > > > > > There should be a check for exactly 2 tokens here. Instead of using > > the

Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66431/#review202232 --- Ship it! Ship It! - Joseph Wu On April 9, 2018, 3:53 p.m.,

Re: Review Request 66836: Fixed `mesos-tcp-connect` to use `net::socket`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66836/#review202230 --- Ship it! Ship It! - Joseph Wu On April 26, 2018, 9:22 p.m.,

Re: Review Request 66835: Replaced `int` and `HANDLE` types with `int_fd`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66835/#review202227 --- Ship it! Ship It! - Joseph Wu On April 26, 2018, 9:22 p.m.,

Re: Review Request 66834: Windows: Specialized `flags::parse`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66834/#review202226 --- 3rdparty/stout/include/stout/flags/parse.hpp Lines 197-200

Re: Review Request 66893: Documented the changes in gRPC and CSI supports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66893/ --- (Updated May 1, 2018, 9:47 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 66896: Updated `csi.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66896/ --- Review request for mesos, Benjamin Bannier, Greg Mann, and Jie Yu. Repository:

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66790/#review202220 --- Fix it, then Ship it!

Re: Review Request 66892: Added `SubprocessTest.PipeLargeOutput`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66892/#review202225 --- Ship it! Ship It! - radhika jandhyala On May 1, 2018, 9:24

Re: Review Request 66892: Added `SubprocessTest.PipeLargeOutput`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66892/#review202224 --- Ship it! Ship It! - John Kordich On May 1, 2018, 9:24 p.m.,

Review Request 66894: Fixed typos in `upgrades.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66894/ --- Review request for mesos, Benjamin Bannier, Greg Mann, and Jie Yu. Repository:

Re: Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66425/ --- (Updated May 1, 2018, 2:32 p.m.) Review request for mesos, Akash Gupta, Eric

Review Request 66893: Documented the changes in gRPC and CSI supports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66893/ --- Review request for mesos, Benjamin Bannier, Greg Mann, and Jie Yu. Repository:

Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`.

> On April 18, 2018, 11:55 a.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/windows/read.hpp > > Lines 39-44 (patched) > > > > > > So you're saying that `ReadFile` reads all the existing data on the > >

Review Request 66892: Added `SubprocessTest.PipeLargeOutput`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66892/ --- Review request for mesos, Akash Gupta, John Kordich, Joseph Wu, and radhika

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/ --- (Updated May 1, 2018, 2:23 p.m.) Review request for mesos, Akash Gupta, John

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

> On May 1, 2018, 12:16 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/permissions.hpp > > Lines 64 (patched) > > > > > > I have a feeling this will pollute the logs unless you demote it to > > `VLOG(2)`

Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`.

> On April 30, 2018, 9:05 p.m., Chun-Hung Hsiao wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 1256 (patched) > > > > > > Suggestion: Start the first framework with `DEFAULT_CREDENTIAL`, to be > >

Re: Review Request 66881: Added benchmark test for master metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66881/ --- (Updated May 1, 2018, 1:53 p.m.) Review request for Benjamin Mahler, Gaston

Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66644/#review202215 --- LGTM sans the unresolved issue from the previous revision!

Re: Review Request 66641: Added `FsTest.Open` to cover `os::open()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66641/#review202216 --- Ship it! Ship It! - Joseph Wu On April 16, 2018, 1:24 p.m.,

Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters.

> On April 25, 2018, 3:39 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Lines 10577-10584 (patched) > > > > > > This is the case we don't need to use `at()` as we are modifying the > > hashmap, we are

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/#review202212 --- Patch looks great! Reviews applied: [66258, 66591, 66259, 66260,

Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66051/#review202209 --- Fix it, then Ship it! src/master/http.cpp Lines 1557

Re: Review Request 66828: Introduced a push-based gauge metric.

> On May 1, 2018, 4:25 p.m., Zhitao Li wrote: > > 3rdparty/libprocess/include/process/metrics/push_gauge.hpp > > Lines 70-75 (patched) > > > > > > Hmm, is there a possible race condition here? > > > >

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/#review202206 --- Fix it, then Ship it!

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66437/#review202205 --- Ship it! Ship It! - Joseph Wu On April 26, 2018, 9:17 p.m.,

Re: Review Request 66885: Removed unnecessary `get()` accessors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66885/#review202204 --- PASS: Mesos patch 66885 was successfully built and tested.

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/#review202203 --- PASS: Mesos patch 66293 was successfully built and tested.

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66875/#review202200 --- Patch looks great! Reviews applied: [53105, 66875] Passed

Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`.

> On May 1, 2018, 4:05 a.m., Chun-Hung Hsiao wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 1464 (patched) > > > > > > No need to resume the clock here, as the fixture teardown will resume > > it.

Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`.

> On April 30, 2018, 9:05 p.m., Chun-Hung Hsiao wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 1464 (patched) > > > > > > No need to resume the clock here, as the fixture teardown will resume > > it.

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

> On April 30, 2018, 5:20 p.m., Chun-Hung Hsiao wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 459 (patched) > > > > > > Suggestion for the TODO: Make `MOUNT` a meaningful parameter value for > > this

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66875/#review202196 --- PASS: Mesos patch 66875 was successfully built and tested.

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/ --- (Updated May 1, 2018, 9:43 a.m.) Review request for mesos, Jason Lai and James

Re: Review Request 66284: Tested `max_completion_time` support in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66284/ --- (Updated May 1, 2018, 9:42 a.m.) Review request for mesos, Jason Lai and James

Re: Review Request 66291: Added support to `max_completion_time` in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66291/ --- (Updated May 1, 2018, 9:42 a.m.) Review request for mesos, Jason Lai and James

Re: Review Request 66283: Added support of `max_completion_time` in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66283/ --- (Updated May 1, 2018, 9:42 a.m.) Review request for mesos, Jason Lai and James

Re: Review Request 66259: Added `max_completion_time` support to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66259/ --- (Updated May 1, 2018, 9:41 a.m.) Review request for mesos, Jason Lai and James

Review Request 66885: Removed unnecessary `get()` accessors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66885/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 66828: Introduced a push-based gauge metric.

> On May 1, 2018, 9:25 a.m., Zhitao Li wrote: > > 3rdparty/libprocess/include/process/metrics/push_gauge.hpp > > Lines 70-75 (patched) > > > > > > Hmm, is there a possible race condition here? > > > >

Re: Review Request 66828: Introduced a push-based gauge metric.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66828/#review202194 --- 3rdparty/libprocess/include/process/metrics/push_gauge.hpp Lines

Re: Review Request 54986: Added pull gauges for slave message queue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54986/ --- (Updated May 1, 2018, 8:54 a.m.) Review request for mesos, Eric Chung, Jason

Re: Review Request 53267: Added a PullGauge to track active subscribers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53267/ --- (Updated May 1, 2018, 8:54 a.m.) Review request for mesos, Anand Mazumdar,