Re: Review Request 67830: Moved `executor::Call` validation to common validation library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67830/#review205780 --- Patch looks great! Reviews applied: [67830] Passed command: expo

Re: Review Request 67671: Prevented resource providers from changing their name or type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67671/#review205777 --- src/resource_provider/manager.cpp Lines 104 (patched)

Re: Review Request 67671: Prevented resource providers from changing their name or type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67671/#review205772 --- Fix it, then Ship it! src/resource_provider/registry.hpp Lines

Re: Review Request 67821: Added override specifiers to virtual methods of several isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67821/#review205776 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67820: Fixed recover() virtual method signature in several isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67820/#review205774 --- Ship it! Ship It! - Benjamin Mahler On July 5, 2018, 9:31 p.

Re: Review Request 67820: Fixed recover() virtual method signature in several isolators.

> On July 5, 2018, 8:33 p.m., Benjamin Mahler wrote: > > Also, is there a ticket? Did any releases ship with this broken? i.e. Do we > > need to backport this? > > Ilya Pronin wrote: > No, should I create one? AFAIK the commit mentioned in the description > was not included in any existing

Re: Review Request 67827: Added a helper `stripIncapableResources` in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67827/#review205771 --- Looks good, the second allocation loop is starting to look pretty

Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67693/#review205755 --- src/master/http.cpp Lines 3821 (patched)

Re: Review Request 67826: Made `Slave::getAvailable()` return all shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67826/#review205770 --- Can you add Yan Xu to this review? This looks interesting, can yo

Re: Review Request 67825: Added a resources utility `hasShared()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67825/#review205768 --- include/mesos/resources.hpp Lines 448-449 (patched)

Re: Review Request 67820: Fixed recover() virtual method signature in several isolators.

> On July 5, 2018, 1:33 p.m., Benjamin Mahler wrote: > > Also, is there a ticket? Did any releases ship with this broken? i.e. Do we > > need to backport this? No, should I create one? AFAIK the commit mentioned in the description was not included in any existing release. I checked branches `1

Re: Review Request 67777: Added a helper to match agent-framework capabilities in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/#review205766 --- Fix it, then Ship it! src/master/allocator/mesos/hierarchical.

Re: Review Request 67820: Fixed recover() virtual method signature in several isolators.

> On July 4, 2018, 3:42 a.m., James Peach wrote: > > In the commit message, I'd prefer to refer to the abbreviated git SHA1 > > instead of the review ID. I just think that makes the changes slightly > > easier to track back. > > > > Can you please also update the `port_mapping` and `ports` iso

Re: Review Request 67821: Added override specifiers to virtual methods of several isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67821/ --- (Updated July 5, 2018, 2:32 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 67820: Fixed recover() virtual method signature in several isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67820/ --- (Updated July 5, 2018, 2:31 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 67777: Added a helper to match agent-framework capabilities in the allocator.

> On July 2, 2018, 10:42 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Line 1756 (original), 1755 (patched) > > > > > > How about a member function of the framework struct? > >

Re: Review Request 67444: Persisted role consumed quota info in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67444/#review205762 --- Looks like a great cleanup! Persist tends to carry the connotatio

Re: Review Request 67820: Fixed XfsDiskIsolatorProcess::recover() signature.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67820/#review205760 --- Also, is there a ticket? Did any releases ship with this broken? i

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67791/#review205758 --- Ship it! Ship It! - Vinod Kone On July 3, 2018, 11:57 p.m.,

Re: Review Request 67722: Fixed unproperly guarded future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67722/#review205751 --- src/master/master.cpp Lines 9794-9806 (original), 9794-9809 (patc

Re: Review Request 67722: Fixed unproperly guarded future.

> On July 3, 2018, 2:28 a.m., Alexander Rojas wrote: > > src/master/master.cpp > > Lines 9667-9672 (patched) > > > > > > Honestly, I'm not even sure there should be a warning there unless > > there is an error now

Re: Review Request 67488: Updated CLI to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review205742 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67832: Changed docker subprocess calls to use exec form.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67832/#review205739 --- PASS: Mesos patch 67832 was successfully built and tested. Review

Re: Review Request 67832: Changed docker subprocess calls to use exec form.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67832/#review205738 --- PASS: Mesos patch 67832 was successfully built and tested. Review

Review Request 67832: Changed docker subprocess calls to use exec form.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67832/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Repository: mesos

Re: Review Request 67830: Moved `executor::Call` validation to common validation library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67830/#review205735 --- FAIL: Some of the unit tests failed. Please check the relevant log