Re: Review Request 67488: Updated CLI to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review205956 --- src/python/cli_new/lib/cli/http.py Line 74 (original), 74

Re: Review Request 67881: Fixed the error log in POSIX `os::rmdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67881/#review205955 --- Ship it! Ship It! - Jie Yu On July 10, 2018, 11:14 p.m.,

Re: Review Request 67881: Fixed the error log in POSIX `os::rmdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67881/#review205953 --- PASS: Mesos patch 67881 was successfully built and tested.

Re: Review Request 67877: Added a metrics scalability benchmark in libprocess.

> On July 10, 2018, 9:56 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['67877']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > >

Re: Review Request 66883: Added/updated tests to check per-framework metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66883/#review205951 --- PASS: Mesos patch 66883 was successfully built and tested.

Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67864/#review205950 --- PASS: Mesos patch 67864 was successfully built and tested.

Review Request 67881: Fixed the error log in POSIX `os::rmdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67881/ --- Review request for mesos, Jie Yu and Meng Zhu. Repository: mesos Description

Re: Review Request 66048: Added missing comment on a test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66048/#review205948 --- Fix it, then Ship it! src/tests/persistent_volume_tests.cpp

Re: Review Request 66048: Added missing comment on a test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66048/#review205947 --- Ship it! Ship It! - Chun-Hung Hsiao On March 13, 2018,

Re: Review Request 67849: Made some CSI-related utility headers public.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67849/#review205946 --- src/Makefile.am Lines 1533 (patched)

Re: Review Request 67848: Installed CSI bindings as part of Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67848/#review205945 --- src/Makefile.am Lines 1536 (patched)

Re: Review Request 67871: Optimized the generation of metrics snapshots.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67871/#review205942 --- Bad patch! Reviews applied: [67871, 67870, 67823, 67235, 67187,

Re: Review Request 67877: Added a metrics scalability benchmark in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67877/#review205941 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67869: Add use of `override` to the Mesos C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67869/#review205940 --- Patch looks great! Reviews applied: [67866, 67867, 67868, 67869]

Re: Review Request 67187: Tested per-framework task state metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/ --- (Updated July 10, 2018, 9:25 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 66883: Added/updated tests to check per-framework metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66883/ --- (Updated July 10, 2018, 9:25 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 67878: Added/updated tests to check per-framework metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67878/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.

Re: Review Request 67814: Added per-framework metrics for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67814/ --- (Updated July 10, 2018, 9:23 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67864/ --- (Updated July 10, 2018, 9:15 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67670: Added a unit test for disappeared profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67670/ --- (Updated July 10, 2018, 9:15 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 67876: Allowed resources to be removed in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67876/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Meng

Re: Review Request 67730: Made Git normalize all line endings automatically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67730/#review205939 --- Ship it! Ship It! - Till Toenshoff On July 10, 2018, 5:32

Review Request 67877: Added a metrics scalability benchmark in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67877/ --- Review request for mesos and Greg Mann. Bugs: MESOS-9068

Re: Review Request 67669: Allowed resources to be removed when updating the sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67669/ --- (Updated July 10, 2018, 8:31 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67669: Allow resources to be removed when updating the sorter.

> On July 10, 2018, 3:33 p.m., Benjamin Bannier wrote: > > docs/upgrades.md > > Lines 469 (patched) > > > > > > I don't think we do need to mention any operations. What about e.g., > > > > > The semantics

Re: Review Request 67663: Made `UriDiskProfileAdaptor` be able to handle disappeared profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67663/ --- (Updated July 10, 2018, 8:26 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67861: Updated json parsing to avoid copying between picojson and stout JSON.

> On July 10, 2018, 5:41 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/json.hpp > > Lines 343-347 (original), 352-377 (patched) > > > > > > While we're here, we could also replace these with the pointer

Re: Review Request 67669: Allow resources to be removed when updating the sorter.

> On July 10, 2018, 3:33 p.m., Benjamin Bannier wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 924-926 (original), 934-939 (patched) > > > > > > I believe we do not need the potentially expensive

Re: Review Request 67861: Updated json parsing to avoid copying between picojson and stout JSON.

> On July 10, 2018, 5:24 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/json.hpp > > Line 855 (original), 892 (patched) > > > > > > Perhaps leave a small comment + a pointer to > >

Re: Review Request 67870: Fixed an incorrect type in the master's metrics code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67870/#review205931 --- The commit message seems pretty ambiguous to me. Can you update

Re: Review Request 67871: Optimized the generation of metrics snapshots.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67871/#review205930 --- Forgot to mention this, can you include more information in the

Re: Review Request 67871: Optimized the generation of metrics snapshots.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67871/#review205929 --- Fix it, then Ship it! Thanks Greg! At some point we need a

Re: Review Request 67730: Made Git normalize all line endings automatically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67730/#review205928 --- PASS: Mesos patch 67730 was successfully built and tested.

Re: Review Request 67147: Included a missing header in the master metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67147/ --- (Updated July 10, 2018, 6:56 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67864/#review205926 --- Patch looks great! Reviews applied: [65974, 65594, 65995, 65975,

Re: Review Request 67663: Made `UriDiskProfileAdaptor` be able to handle disappeared profiles.

> On July 10, 2018, 4:02 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/uri_disk_profile_adaptor.cpp > > Line 303 (original), 303 (patched) > > > > > > We have already updated the profiles and can

Re: Review Request 67663: Made `UriDiskProfileAdaptor` be able to handle disappeared profiles.

> On July 10, 2018, 4:02 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/uri_disk_profile_adaptor.cpp > > Line 248 (original), 244 (patched) > > > > > > `foreachpair` would give us a way to give

Re: Review Request 67670: Added a unit test for disappeared profiles.

> On July 10, 2018, 3:37 p.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 1212-1217 (patched) > > > > > > Shouldn't we update before we poll? I advance the clock

Re: Review Request 67669: Allow resources to be removed when updating the sorter.

> On July 10, 2018, 3:33 p.m., Benjamin Bannier wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 887 (patched) > > > > > > Why are changes to the allocator in this file? Should they go somewhere > >

Re: Review Request 67669: Allow resources to be removed when updating the sorter.

> On July 10, 2018, 3:33 p.m., Benjamin Bannier wrote: > > src/tests/sorter_tests.cpp > > Lines 1317-1318 (patched) > > > > > > Not sure we really need two resource kinds here. For me it just seems > > to make

Re: Review Request 67669: Allow resources to be removed when updating the sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67669/ --- (Updated July 10, 2018, 5:58 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67730: Made Git normalize all line endings automatically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67730/ --- (Updated July 10, 2018, 10:32 a.m.) Review request for mesos, Benjamin

Re: Review Request 67730: Made Git normalize all line endings automatically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67730/#review205920 --- site/doap.rdf Line 58 (original), 58 (patched)

Re: Review Request 67730: Made Git normalize all line endings automatically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67730/#review205919 --- I created a new repo, set `git config core.autocrlf false`, added

Re: Review Request 67859: Updated apply-reviews.py messaging for submitted reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67859/#review205918 --- Ship it! Ship It! - Andrew Schwartzmeyer On July 9, 2018,

Re: Review Request 67855: Added virtualenv requirements watcher to Python 3 mesos-style.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67855/#review205916 --- Ship it! Can you clarify the commit message? It should

Re: Review Request 67856: Updated Python virtual environment dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67856/#review205917 --- Ship it! Ship It! - Benjamin Bannier On July 9, 2018, 12:38

Re: Review Request 67871: Optimized the generation of metrics snapshots.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67871/#review205915 --- Ship it! 3rdparty/libprocess/src/metrics/metrics.cpp Lines

Re: Review Request 67663: Made `UriDiskProfileAdaptor` be able to handle disappeared profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67663/#review205914 --- Fix it, then Ship it! Ship It!

Re: Review Request 67870: Fixed an incorrect type in the master's metrics code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67870/#review205913 --- Fix it, then Ship it! Do you think we should make the

Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/ --- (Updated July 10, 2018, 3:40 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 67875: Added `normalizeMetricKey()` and `getFrameworkMetricPrefix()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67875/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.

Re: Review Request 67670: Added a unit test for disappeared profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67670/#review205912 --- Fix it, then Ship it!

Re: Review Request 67669: Allow resources to be removed when updating the sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67669/#review205911 --- CHANGELOG Lines 28 (patched)

Re: Review Request 67859: Updated apply-reviews.py messaging for submitted reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67859/#review205910 --- Patch looks great! Reviews applied: [67859] Passed command:

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/#review205907 --- The commit message should be edited to finish with a period and

Re: Review Request 67504: Added helper for posting the result of a build

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67504/#review205906 --- The commit message should be edited to finish with a period and

Re: Review Request 67503: Added helper for fetching review id

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67503/#review205905 --- The commit message should be edited to finish with a period and

Re: Review Request 67502: Refactored API functionality into separate module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/#review205903 --- support/python3/common.py Lines 19 (patched)

Re: Review Request 67502: Refactored API functionality into separate module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/#review205901 --- Fix it, then Ship it! Only typos to fix, the commit message

Re: Review Request 67868: Apply the `override` keyword to Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67868/#review205900 --- This change seems a number of possible edits, I see e.g., the

Re: Review Request 67866: Apply the `override` keyword to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67866/#review205898 --- Running clang-tidy on this produced more changes for me

Re: Review Request 67867: Apply the `override` keyword to libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67867/#review205899 --- Running clang-tidy on this produced more changes for me

Review Request 67872: Added a stout helper to percent-encode strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67872/ --- Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Gastón Kleiman.

Re: Review Request 67813: Added per-framework metrics for task states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67813/ --- (Updated July 10, 2018, 6:29 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67871: Optimized the generation of metrics snapshots.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67871/#review205896 --- FAIL: Failed to apply the dependent review: 67813. Failed

Re: Review Request 67870: Fixed an incorrect type in the master's metrics code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67870/ --- (Updated July 10, 2018, 6:23 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67871: Optimized the generation of metrics snapshots.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67871/ --- (Updated July 10, 2018, 6:21 a.m.) Review request for mesos, Benjamin Mahler,

Review Request 67871: Optimized the generation of metrics snapshots.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67871/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.

Re: Review Request 67870: Fixed an incorrect type in the master's metrics code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67870/#review205895 --- FAIL: Failed to apply the dependent review: 67813. Failed

Review Request 67870: Fixed an incorrect type in the master's metrics code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67870/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.