Re: Review Request 68355: Added a CNI test for networking statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68355/#review207304 --- src/tests/containerizer/cni_isolator_tests.cpp Lines 203

Re: Review Request 68054: Added networking statistics to cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/#review207302 --- Ship it! Ship It! - Jie Yu On Aug. 15, 2018, 1:46 a.m.,

Re: Review Request 68146: Added actions and ACLs to authorize removal of resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68146/#review207301 --- include/mesos/authorizer/acls.proto Lines 512 (patched)

Re: Review Request 68347: Added a scheduler flag for max authentication timeout interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68347/#review207300 --- Patch looks great! Reviews applied: [68346, 68347] Passed

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68144/#review207287 --- src/resource_provider/message.hpp Lines 47 (patched)

Re: Review Request 68348: Fixed wrong `mnt` namespace detection for non-command executor tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68348/#review207294 --- Patch looks great! Reviews applied: [68256, 68257, 68348]

Review Request 68355: Added a CNI test for networking statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68355/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-5647

Re: Review Request 68054: Added networking statistics to cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/ --- (Updated Aug. 15, 2018, 1:46 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 68307: Added a test for master's handling of stale authentication requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68307/#review207288 --- PASS: Mesos patch 68307 was successfully built and tested.

Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/ --- Review request for mesos, Benjamin Mahler and Gastón Kleiman. Repository:

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/ --- (Updated Aug. 14, 2018, 5:47 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/ --- (Updated Aug. 14, 2018, 5:47 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68326: Introduced FUTURE_EXITED and DROP_EXITED in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68326/#review207280 --- Ship it! This looks good to me now! Disclaimer: I don't know

Re: Review Request 68145: Sent an event to resource providers when they are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68145/#review207279 --- I'm not sure if we want to have this. If we are to follow the

Re: Review Request 68327: Added tests for FUTURE_EXITED and DROP_EXITED.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68327/#review207278 --- Ship it! Ship It! - Gastón Kleiman On Aug. 13, 2018, 3:22

Re: Review Request 68147: Added agent support to remove local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/#review207277 --- include/mesos/agent/agent.proto Lines 100 (patched)

Re: Review Request 68143: Made resource provider manager emit an event when provider subscribed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68143/#review207266 --- Fix it, then Ship it! src/resource_provider/manager.cpp Lines

Re: Review Request 68307: Added a test for master's handling of stale authentication requests.

> On Aug. 14, 2018, 11:03 p.m., Gastón Kleiman wrote: > > src/tests/authentication_tests.cpp > > Lines 424 (patched) > > > > > > Nit: it would be more readable to use: > >

Re: Review Request 68305: Increased and added flag for the master's authentication timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68305/#review207272 --- src/master/flags.cpp Lines 237-243 (patched)

Re: Review Request 68305: Increased and added flag for the master's authentication timeout.

> On Aug. 13, 2018, 11:08 p.m., Benjamin Mahler wrote: > > src/master/flags.cpp > > Lines 237-243 (patched) > > > > > > Note to self: add this to configuration.md Also, added to authentication.md per Gaston's

Re: Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68222/#review207271 --- Ship it! Ship It! - Gilbert Song On Aug. 13, 2018, 11:29

Re: Review Request 68221: Updated `docker/volume` isolator to honor volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68221/#review207270 --- Ship it! Ship It! - Gilbert Song On Aug. 13, 2018, 11:29

Re: Review Request 68216: Updated `volume/image` isolator to honor volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68216/#review207269 --- Ship it! Ship It! - Gilbert Song On Aug. 13, 2018, 11:28

Re: Review Request 68325: Updated libprocess filtering to take the Process UPID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68325/#review207268 --- Ship it! Ship It! - Gastón Kleiman On Aug. 13, 2018, 3:22

Re: Review Request 68345: Fixed an expectation in the master tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68345/#review207267 --- Patch looks great! Reviews applied: [68345] Passed command:

Re: Review Request 68327: Added tests for FUTURE_EXITED and DROP_EXITED.

> On Aug. 14, 2018, 10:09 p.m., Gastón Kleiman wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp > > Lines 762-763 (patched) > > > > > > Can we add a description? > > > > Something like: > > >

Re: Review Request 68327: Added tests for FUTURE_EXITED and DROP_EXITED.

> On Aug. 14, 2018, 10:09 p.m., Gastón Kleiman wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp > > Lines 766-767 (patched) > > > > > > This might make the test easier to read: > > > > ``` > >

Re: Review Request 68327: Added tests for FUTURE_EXITED and DROP_EXITED.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68327/#review207264 --- 3rdparty/libprocess/src/tests/process_tests.cpp Lines 764

Re: Review Request 68350: Adjusted a test to conform to the new libprocess test filter interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68350/#review207263 --- Ship it! Ship It! - Gastón Kleiman On Aug. 14, 2018, 12:35

Re: Review Request 68306: Fixed an authentication request amplification issue in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68306/#review207261 --- Ship it! - Gastón Kleiman On Aug. 13, 2018, 3:22 p.m.,

Re: Review Request 68307: Added a test for master's handling of stale authentication requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68307/#review207260 --- Fix it, then Ship it! src/tests/authentication_tests.cpp

Re: Review Request 68305: Increased and added flag for the master's authentication timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68305/#review207258 --- Fix it, then Ship it! src/master/flags.cpp Lines 240-242

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/#review207255 --- Per offline conversation, seems like we could simplify this by

Re: Review Request 68327: Added tests for FUTURE_EXITED and DROP_EXITED.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68327/#review207257 --- 3rdparty/libprocess/src/tests/process_tests.cpp Lines 762-763

Re: Review Request 68326: Introduced FUTURE_EXITED and DROP_EXITED in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68326/#review207254 --- 3rdparty/libprocess/include/process/gmock.hpp Lines 711

Re: Review Request 68335: Added a CNI test to verify destroy while preparing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68335/#review207256 --- PASS: Mesos patch 68335 was successfully built and tested.

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/#review207251 --- Ship it! Ship It! - Andrew Schwartzmeyer On Aug. 7, 2018,

Re: Review Request 68347: Added a scheduler flag for max authentication timeout interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68347/#review207248 --- PASS: Mesos patch 68347 was successfully built and tested.

Re: Review Request 68348: Fixed wrong `mnt` namespace detection for non-command executor tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68348/#review207246 --- PASS: Mesos patch 68348 was successfully built and tested.

Review Request 68350: Adjusted a test to conform to the new libprocess test filter interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68350/ --- Review request for mesos, Gastón Kleiman and Meng Zhu. Repository: mesos

Re: Review Request 68306: Fixed an authentication request amplification issue in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68306/#review207244 --- Fix it, then Ship it! src/master/master.cpp Lines 9589-9591

Re: Review Request 68335: Added a CNI test to verify destroy while preparing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68335/ --- (Updated Aug. 14, 2018, 7:05 p.m.) Review request for mesos, Deepak Goel, Qian

Re: Review Request 67504: Added support script to post build results.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67504/#review207243 --- Ship it! Ship It! - Andrew Schwartzmeyer On Aug. 7, 2018,

Re: Review Request 67503: Added support helper for fetching review ids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67503/#review207242 --- Ship it! Ship It! - Andrew Schwartzmeyer On Aug. 7, 2018,

Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/#review207241 --- Fix it, then Ship it! support/python3/common.py Lines 153-154

Re: Review Request 68335: Added a CNI test to verify destroy while preparing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68335/#review207240 --- Patch looks great! Reviews applied: [68333, 68334, 68335]

Re: Review Request 68345: Fixed an expectation in the master tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68345/#review207239 --- PASS: Mesos patch 68345 was successfully built and tested.

Review Request 68348: Fixed wrong `mnt` namespace detection for non-command executor tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68348/ --- Review request for mesos, Alexander Rukletsov, Gilbert Song, Jie Yu, and Kevin

Re: Review Request 68257: Fixed incorrect `mnt` namespace detection of command executor's task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68257/ --- (Updated Aug. 14, 2018, 5:22 p.m.) Review request for mesos, Alexander

Review Request 68347: Added a scheduler flag for max authentication timeout interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68347/ --- Review request for mesos, Benjamin Mahler and Gastón Kleiman. Repository:

Review Request 68346: Fixed a backoff overflow bug in scheduler authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68346/ --- Review request for mesos, Benjamin Mahler and Gastón Kleiman. Bugs: MESOS-9147

Re: Review Request 68345: Fixed an expectation in the master tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68345/#review207237 --- Ship it! Ship It! - Gastón Kleiman On Aug. 14, 2018, 9:41

Re: Review Request 68334: Used state::checkpoint instead in CNI isolator.

> On Aug. 14, 2018, 7:30 a.m., Qian Zhang wrote: > > Ship It! > > Qian Zhang wrote: > BTW, what about the other files (i.e., hosts, hostname and resolv.conf) > that CNI isolator persists in the container dir? Should we change from > `os::write()` to `state::checkpoint()` for them too?

Review Request 68345: Fixed an expectation in the master tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68345/ --- Review request for mesos, Alexander Rukletsov and Gastón Kleiman. Bugs:

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/#review207234 --- Patch looks great! Reviews applied: [68304, 68324] Passed

Re: Review Request 68296: Added 'handler' field to batched requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68296/ --- (Updated Aug. 14, 2018, 2:20 p.m.) Review request for mesos, Alexander

Review Request 68343: Moved state serialization into separate function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68343/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Review Request 68342: Added const versions of slave-counting functions in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68342/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 68054: Added networking statistics to cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/#review207231 --- Patch looks great! Reviews applied: [68052, 68053, 68054]

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68224/ --- (Updated Aug. 14, 2018, 12:48 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 68225: Added 25th and 75th percentiles to `Statistics`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68225/ --- (Updated Aug. 14, 2018, 12:47 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 68331: Windows: Made `libwinio` the default option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68331/#review207229 --- Patch looks great! Reviews applied: [68331] Passed command:

Re: Review Request 67960: Added support for instrumenting HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67960/#review207228 --- I like the idea of having handling time statistics per endpoint.

Re: Review Request 67957: Refactored TemporaryDirectoryTest to be a mixin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67957/#review207227 --- 3rdparty/stout/include/stout/tests/utils.hpp Lines 46-48

Re: Review Request 68329: Windows: Made `libwinio` the default option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68329/#review207223 --- Patch looks great! Reviews applied: [68329] Passed command:

Re: Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68222/#review207222 --- PASS: Mesos patch 68222 was successfully built and tested.

Re: Review Request 68335: Added a CNI test to verify destroy while preparing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68335/#review207220 --- src/slave/containerizer/mesos/containerizer.hpp Lines 196-201

Re: Review Request 68333: Made CNI isolator cleanup more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68333/#review207214 --- Ship it! Ship It! - Qian Zhang On Aug. 14, 2018, 6:59 a.m.,

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/#review207212 --- PASS: Mesos patch 68324 was successfully built and tested.

Re: Review Request 68221: Updated `docker/volume` isolator to honor volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68221/ --- (Updated Aug. 14, 2018, 2:29 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68222/ --- (Updated Aug. 14, 2018, 2:29 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 68219: Updated `volume/secret` isolator to honor volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68219/ --- (Updated Aug. 14, 2018, 2:29 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 68216: Updated `volume/image` isolator to honor volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68216/ --- (Updated Aug. 14, 2018, 2:28 p.m.) Review request for mesos, Gilbert Song,