---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65721/#review198747
---
Ship it!
Ship It!
- Akash Gupta
On March 6, 2018, 8:05 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65719/#review198746
---
Ship it!
Ship It!
- Akash Gupta
On March 6, 2018, 8:04 p.m
Diff: https://reviews.apache.org/r/65840/diff/3/
Changes: https://reviews.apache.org/r/65840/diff/2-3/
Testing
---
Thanks,
Akash Gupta
.org/r/65891/
> ---
>
> (Updated March 2, 2018, 11:21 p.m.)
>
>
> Review request for mesos, Akash Gupta and Joseph Wu.
>
>
> Bugs: MESOS-8631
> https://issues.apache.org/jira/browse/MESOS-8631
>
>
> Repository: mesos
>
>
> Description
> ---
>
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65890/#review198573
---
Ship it!
Ship It!
- Akash Gupta
On March 2, 2018, 11:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65872/#review198489
---
Ship it!
Ship It!
- Akash Gupta
On March 1, 2018, 11:57 p.m
---
Thanks,
Akash Gupta
/checker_process.cpp cf9ec053946e620eb36e92d647ab864c4e88d506
Diff: https://reviews.apache.org/r/65862/diff/1/
Testing
---
Thanks,
Akash Gupta
://reviews.apache.org/r/65863/diff/1/
Testing
---
Thanks,
Akash Gupta
/
Changes: https://reviews.apache.org/r/65842/diff/1-2/
Testing
---
make check
Thanks,
Akash Gupta
/containerizer/perf_tests.cpp
d8aab08eb131f974821fb85662cbc6cc685d2f3e
Diff: https://reviews.apache.org/r/65864/diff/1/
Testing
---
Thanks,
Akash Gupta
b35e6b94ba6709254450be9429b6f48f2d276689
Diff: https://reviews.apache.org/r/65839/diff/2/
Changes: https://reviews.apache.org/r/65839/diff/1-2/
Testing
---
Thanks,
Akash Gupta
d8aab08eb131f974821fb85662cbc6cc685d2f3e
Diff: https://reviews.apache.org/r/65842/diff/1/
Testing
---
Thanks,
Akash Gupta
src/tests/containerizer/memory_pressure_tests.cpp
0c3e738ce05553a2ee5c38c6748d6d28a1eb93d3
src/tests/environment.cpp 1cba274e0e684b123ce1e4d9cd296f428022fcdc
Diff: https://reviews.apache.org/r/65841/diff/1/
Testing
---
Thanks,
Akash Gupta
(status))`
would end up aborting the agent or executor.
Diffs
-
3rdparty/stout/include/stout/windows.hpp
b35e6b94ba6709254450be9429b6f48f2d276689
Diff: https://reviews.apache.org/r/65840/diff/1/
Testing
---
Thanks,
Akash Gupta
cf9ec053946e620eb36e92d647ab864c4e88d506
Diff: https://reviews.apache.org/r/65839/diff/1/
Testing
---
Thanks,
Akash Gupta
checks tests because:
Running in another container's namespace is not supported on this version of
Windows.
Rest rests pass.
Linux:
make check passes
Thanks,
Akash Gupta
://reviews.apache.org/r/65728/diff/2/
Changes: https://reviews.apache.org/r/65728/diff/1-2/
Testing
---
Thanks,
Akash Gupta
for the mesos and docker executors.
Diffs (updated)
-
docs/health-checks.md 119d149f29f2f2d3178da6ef63a7ce97a4dbc952
Diff: https://reviews.apache.org/r/64604/diff/7/
Changes: https://reviews.apache.org/r/64604/diff/6-7/
Testing
---
Thanks,
Akash Gupta
because:
Running in another container's namespace is not supported on this version of
Windows.
Rest rests pass.
Linux:
make check passes
Thanks,
Akash Gupta
/diff/2-3/
Testing
---
Thanks,
Akash Gupta
/checks/checker_process.hpp 510f3b2e6e689faaf26595214ce377c2b5518f28
src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f
Diff: https://reviews.apache.org/r/65127/diff/11/
Changes: https://reviews.apache.org/r/65127/diff/10-11/
Testing
---
Thanks,
Akash Gupta
rocess.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f
Diff: https://reviews.apache.org/r/65419/diff/6/
Changes: https://reviews.apache.org/r/65419/diff/5-6/
Testing
---
make check
Thanks,
Akash Gupta
://reviews.apache.org/r/65395/diff/5-6/
Testing
---
make check
Thanks,
Akash Gupta
/diff/5-6/
Testing
---
make check
Thanks,
Akash Gupta
/
Testing
---
make check
Thanks,
Akash Gupta
/65393/diff/3-4/
Testing
---
ran mesos-tests --docker flag.
Thanks,
Akash Gupta
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65624/#review198054
---
Ship it!
Ship It!
- Akash Gupta
On Feb. 20, 2018, 7:40 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65574/#review197994
---
Ship it!
Ship It!
- Akash Gupta
On Feb. 21, 2018, 1:19 a.m
://github.com/apache/mesos/commit/a7714536fad1140fd0c07c47e32b40e9ed00a3c3#diff-9ed238cb3a33c53838909dd0ad5ae589
since that workaround only works on Linux.
- Akash Gupta
On Feb. 21, 2018, 2:19 p.m., Akash Gupta wrote
/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc
Diff: https://reviews.apache.org/r/65733/diff/1/
Testing
---
Thanks,
Akash Gupta
properly deals with quotes in the command health
check to ensure that MESOS-4812 is fixed.
Diffs
-
src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d
Diff: https://reviews.apache.org/r/65728/diff/1/
Testing
---
Thanks,
Akash Gupta
Setup()` function so that we only pull the image if
we pass the `*DOCKER*` filter. Otherwise, the test suite will fail if Docker
isn't installed since it will fail `SetupTestCase()`.
- Akash Gupta
On Feb. 21, 2018, 2:11 p.m
is actually run. This avoids failing the test suite
due to the pull failing when docker isn't installed.
Diffs (updated)
-
src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d
Diff: https://reviews.apache.org/r/65727/diff/1/
Testing
---
Thanks,
Akash Gupta
is in preparation of porting docker tests to Windows. There
were a few hardcoded values that were used throughout the codebase,
such as the `alpine` image, that are defined as a constant in a single
file.
Testing
---
Thanks,
Akash Gupta
/checks/checker_process.hpp 510f3b2e6e689faaf26595214ce377c2b5518f28
src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f
Diff: https://reviews.apache.org/r/65127/diff/10/
Changes: https://reviews.apache.org/r/65127/diff/9-10/
Testing
---
Thanks,
Akash Gupta
rocess.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f
Diff: https://reviews.apache.org/r/65419/diff/5/
Changes: https://reviews.apache.org/r/65419/diff/4-5/
Testing
---
make check
Thanks,
Akash Gupta
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65469/#review197833
---
Ship it!
Ship It!
- Akash Gupta
On Feb. 20, 2018, 7:40 p.m
indows/shell.hpp
Line 294 (original), 301 (patched)
<https://reviews.apache.org/r/65574/#comment278113>
Hm, I remember we discussed something like `CreateProcessW` does process
initialization async. Do we need to wait for the process to be initialized?
- Akash Gupta
On Feb. 20, 20
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65403/#review197825
---
Ship it!
Ship It!
- Akash Gupta
On Feb. 20, 2018, 7:39 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65467/#review197826
---
Ship it!
Ship It!
- Akash Gupta
On Feb. 20, 2018, 7:39 p.m
checks tests because:
Running in another container's namespace is not supported on this version of
Windows.
Rest rests pass.
Linux:
make check passes
Thanks,
Akash Gupta
for the mesos and docker executors.
Diffs (updated)
-
docs/health-checks.md 119d149f29f2f2d3178da6ef63a7ce97a4dbc952
Diff: https://reviews.apache.org/r/64604/diff/6/
Changes: https://reviews.apache.org/r/64604/diff/5-6/
Testing
---
Thanks,
Akash Gupta
/1-2/
Testing
---
Thanks,
Akash Gupta
iff: https://reviews.apache.org/r/65419/diff/4/
Changes: https://reviews.apache.org/r/65419/diff/3-4/
Testing
---
make check
Thanks,
Akash Gupta
/
Testing
---
make check
Thanks,
Akash Gupta
/65393/diff/2-3/
Testing
---
ran mesos-tests --docker flag.
Thanks,
Akash Gupta
tests because:
Running in another container's namespace is not supported on this version of
Windows.
Rest rests pass.
Linux:
make check passes
Thanks,
Akash Gupta
: https://reviews.apache.org/r/65615/diff/1/
Testing
---
Thanks,
Akash Gupta
)
-
src/checks/checker_process.hpp 510f3b2e6e689faaf26595214ce377c2b5518f28
src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f
Diff: https://reviews.apache.org/r/65127/diff/8/
Changes: https://reviews.apache.org/r/65127/diff/7-8/
Testing
---
Thanks,
Akash Gupta
/65393/diff/1-2/
Testing
---
ran mesos-tests --docker flag.
Thanks,
Akash Gupta
.
Diffs (updated)
-
src/checks/checks_runtime.hpp PRE-CREATION
src/checks/checks_types.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/65394/diff/4/
Changes: https://reviews.apache.org/r/65394/diff/3-4/
Testing
---
make check
Thanks,
Akash Gupta
ps://reviews.apache.org/r/65394/#review196986
-------
On Feb. 8, 2018, 7:44 p.m., Akash Gupta wrote:
>
> ---
> This is an automatically generated e-mail.
using these types.
Diffs (updated)
-
src/checks/checks_runtime.hpp PRE-CREATION
src/checks/checks_types.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/65394/diff/3/
Changes: https://reviews.apache.org/r/65394/diff/2-3/
Testing
---
make check
Thanks,
Akash Gupta
is unclear what this function
> > does. Is it a factory? Shall it be better be lambda rather than a free
> > function?
> >
> > Also, I see a similar function in `HealthCheck`. Is there any way you
> > can move duplicate code into the lower level `CheckerProcess`?
ache.org/r/65395/diff/2/?file=1950443#file1950443line658>
> >
> > Nit: Style-wise, can we brace-construct this whole struct? (Should we?
> > Could it become const-qualified if we did?)
yeah it can be const.
- Akash
---
- Akash
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65127/#review196735
---
On Feb. 8, 2018, 5:51 p.m., Akash Gupta wrot
,
Akash Gupta
ttps://github.com/mesosphere/marathon/issues/5136)
- Akash
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65419/#review196734
---
On Feb. 8, 2018,
/diff/2-3/
Testing
---
make check
Thanks,
Akash Gupta
ges: https://reviews.apache.org/r/65419/diff/1-2/
Testing
---
make check
Thanks,
Akash Gupta
apache.org/r/65396/#review196732
---
On Feb. 8, 2018, 5:50 p.m., Akash Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apa
://reviews.apache.org/r/65395/diff/2-3/
Testing
---
make check
Thanks,
Akash Gupta
think `create_process` is the only case
where you actually need inheritable handles.
- Akash Gupta
On Feb. 2, 2018, 8:12 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65408/#review197043
---
Ship it!
Ship It!
- Akash Gupta
On Feb. 2, 2018, 12:14 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65407/#review197040
---
Ship it!
Ship It!
- Akash Gupta
On Feb. 2, 2018, 12:03 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65406/#review197036
---
Ship it!
Ship It!
- Akash Gupta
On Jan. 29, 2018, 8:39 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65405/#review197033
---
Ship it!
Ship It!
- Akash Gupta
On Feb. 1, 2018, 11:30 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65403/#review197032
---
Ship it!
Ship It!
- Akash Gupta
On Feb. 1, 2018, 11:23 p.m
30 (original), 33 (patched)
<https://reviews.apache.org/r/65402/#comment277138>
It's not a change for this patch, but we should probably look to make
`os::dup` not inheritable by default and hunt down cases that we actually need
inheritance.
- Akash Gupta
On Feb. 7, 2018, 7:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65401/#review197029
---
Ship it!
Ship It!
- Akash Gupta
On Feb. 1, 2018, 11:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65400/#review197028
---
Ship it!
Ship It!
- Akash Gupta
On Jan. 29, 2018, 8:34 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65399/#review197027
---
Ship it!
Ship It!
- Akash Gupta
On Feb. 7, 2018, 7:20 p.m
to `CheckInfo`. That should avoid the code duplication too.
- Akash
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65395/#review196987
--------
cannot run any Docker health checks tests because:
Running in another container's namespace is not supported on this version of
Windows.
Rest rests pass.
Linux:
make check passes
Thanks,
Akash Gupta
mnd health check simply runs `docker exec` without any
wrapping.
Diffs
-
src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f
Diff: https://reviews.apache.org/r/65419/diff/1/
Testing
---
make check
Thanks,
Akash Gupta
/65127/diff/5-6/
Testing
---
Thanks,
Akash Gupta
://reviews.apache.org/r/65395/diff/1-2/
Testing
---
make check
Thanks,
Akash Gupta
cted. Considering that these arguments will be
> > joined a few lines down, how is the quoting maintained?
>
> Akash Gupta wrote:
> It's a bit weird. The implementation of `subprocess` for a shell command
> creates an argument list that looks like this: `{os::shell::arg0,
> os::shel
these types.
Diffs (updated)
-
src/checks/checks_runtime.hpp PRE-CREATION
src/checks/checks_types.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/65394/diff/2/
Changes: https://reviews.apache.org/r/65394/diff/1-2/
Testing
---
make check
Thanks,
Akash Gupta
tps://reviews.apache.org/r/65394/#comment276141>
Will fix the whitespace.
- Akash Gupta
On Jan. 29, 2018, 6:38 p.m., Akash Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
s an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65393/#review196464
-------
On Jan. 29, 2018, 6:20 p.m., Akash Gupta wrote:
>
> ---
> This i
container's namespace is not supported on this version of
Windows.
Rest rests pass.
Linux:
make check passes
Thanks,
Akash Gupta
----
On Jan. 17, 2018, 12:12 p.m., Akash Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64387/
>
ver with powershell instead. That will
make the image much smaller.
- Akash
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64387/#review195947
-
cted. Considering that these arguments will be
> > joined a few lines down, how is the quoting maintained?
>
> Akash Gupta wrote:
> It's a bit weird. The implementation of `subprocess` for a shell command
> creates an argument list that looks like this: `{os::shell::arg0,
> os::shel
to see that
this should have just been `MESOS` instead of the conditional.
- Akash
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64386/#review195894
---
/checks/checks_types.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/65394/diff/1/
Testing
---
make check
Thanks,
Akash Gupta
ddb197b8cc2c503fef5ae20af32f5881fff9833f
Diff: https://reviews.apache.org/r/65127/diff/5/
Testing
---
Thanks,
Akash Gupta
ddb197b8cc2c503fef5ae20af32f5881fff9833f
Diff: https://reviews.apache.org/r/65127/diff/5/
Changes: https://reviews.apache.org/r/65127/diff/4-5/
Testing
---
Thanks,
Akash Gupta
e4c53d558e414e50b1c429fba8e31e504c63744a
src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea
src/launcher/executor.cpp 050f5a057f360873e2b4738b126289bcd1bd0c7f
Diff: https://reviews.apache.org/r/65395/diff/1/
Testing
---
make check
Thanks,
Akash Gupta
/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f
src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a
Diff: https://reviews.apache.org/r/65396/diff/1/
Testing
---
make check
Thanks,
Akash Gupta
-
src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61
src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a
Diff: https://reviews.apache.org/r/65393/diff/1/
Testing
---
ran mesos-tests --docker flag.
Thanks,
Akash Gupta
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65319/#review196154
---
Ship it!
Ship It!
- Akash Gupta
On Jan. 24, 2018, 7:06 p.m
ps://reviews.apache.org/r/65127/#review195942
-------
On Jan. 17, 2018, 12:09 a.m., Akash Gupta wrote:
>
> ---
> This is an automatically generated e-mail.
de into a more general purpose
> location and reuse it. But we shouldn't do it until then, because otherwise
> we're just guessing at future technical needs.
>
> Akash Gupta wrote:
> This is specific to Docker and only for test code that checks the
> container exi
://reviews.apache.org/r/63862/ for test results.
Thanks,
Akash Gupta
is not supported on this version of
Windows.
Rest rests pass.
Linux:
make check passes
Thanks,
Akash Gupta
: https://reviews.apache.org/r/64386/diff/7-8/
Testing
---
See https://reviews.apache.org/r/64387/
Thanks,
Akash Gupta
ddb197b8cc2c503fef5ae20af32f5881fff9833f
Diff: https://reviews.apache.org/r/65127/diff/3/
Changes: https://reviews.apache.org/r/65127/diff/2-3/
Testing
---
Thanks,
Akash Gupta
101 - 200 of 319 matches
Mail list logo
