Re: Review Request 47842: Point slave flags at programmatic temp path.

://reviews.apache.org/r/47842/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47843: Agent: Added Windows support for launcher/fetcher.cpp.

/fetcher.cpp 0539b0182bd4a7178f1031ab4fee8fc79eda Diff: https://reviews.apache.org/r/47843/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47943: Stout: Implemented `shell.hpp` on Windows.

Diff: https://reviews.apache.org/r/47943/diff/ Testing --- Windows: buil/run Thanks, Alex Clemmer

Review Request 48000: Windows MVP.

/slave/cmake/SlaveConfigure.cmake 187b5cb9d281ea6f3f9c7f81ff2ea9280213b146 src/tests/cmake/ContainerizerTestsConfigure.cmake PRE-CREATION src/tests/containerizer/CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/48000/diff/ Testing --- Thanks, Alex Clemmer

Review Request 48002: Windows: Added new Windows.hpp defines.

Remoortere, and Michael Park. Repository: mesos Description --- Windows: Added new Windows.hpp defines. Diffs - 3rdparty/stout/include/stout/windows.hpp a71e2f4965c982331c2e8fe4be70027b373a6516 Diff: https://reviews.apache.org/r/48002/diff/ Testing --- Thanks, Alex Clemmer

Review Request 48003: Remove SASL dependency from agent tests.

629135f0dc59346f0fcddb2cbe65ca5770fad34e src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505 src/tests/script.cpp ec5f2c3016a6081031c1bd6c9bf35a2d6d953700 Diff: https://reviews.apache.org/r/48003/diff/ Testing --- osx: make check Thanks, Alex Clemmer

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

5977c30c0aacc569019f7b34bb0c6577823ec887 src/slave/containerizer/mesos/launcher.cpp a5c8c31b72773d0bd10b9d02675a01f1d641d41c Diff: https://reviews.apache.org/r/47576/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47469: Agent: Added `launch.cpp` to Windows build.

9eabd781763adba39b60526c1b4a7d99b3f1 src/slave/containerizer/mesos/launch.cpp e22106b014c871e2184a15c2ab154a0674874e47 Diff: https://reviews.apache.org/r/47469/diff/ Testing (updated) --- OSX: make check Windows: Build/run Thanks, Alex Clemmer

Re: Review Request 47470: Stout: Added `os::temp`.

/include/stout/windows/os.hpp 1363be1d4010028d4fc50242c80d91c0dd53e14c Diff: https://reviews.apache.org/r/47470/diff/ Testing (updated) --- osx: make check Thanks, Alex Clemmer

Re: Review Request 47602: Stout:[1/2] Added Windows support for folder `launcher/`.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47602/#review134665 ------- On May 19, 2016, 4:08 p.m., Alex Clemmer wrote: > > ---

Re: Review Request 47603: Agent:[2/2] Added Windows support for folder `launcher/`.

a2e6d86fd0b1f3d688d17296151db74bcb9b3418 src/launcher/executor.hpp PRE-CREATION src/launcher/executor.cpp fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 src/launcher/posix/executor.hpp PRE-CREATION src/launcher/windows/executor.hpp PRE-CREATION Diff: https://reviews.apache.org/r/47603/diff/ Testing --- Thanks, Alex

Re: Review Request 47468: Windows: Implemented IPC pipe.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47468/#review134655 --- On May 17, 2016, 4:01 p.m., Alex Clemmer wrote: > >

Re: Review Request 47469: Agent: Added `launch.cpp` to Windows build.

s side here? > > Is this just mapping the FDs into an abstraction, or are we actually > > creating a pipe? > > If so, why wasn't that done before? > > Alex Clemmer wrote: > The point of using a class was that I wanted to be able to thi

Re: Review Request 47469: Agent: Added `launch.cpp` to Windows build.

e0c538d9e6542fbe279bfbf6f20172e4c611c859 src/slave/containerizer/mesos/launch.cpp e22106b014c871e2184a15c2ab154a0674874e47 Diff: https://reviews.apache.org/r/47469/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47943: Stout: Implemented `shell.hpp` on Windows.

/ Testing (updated) --- Windows: buil/run Thanks, Alex Clemmer

Review Request 47943: Stout: Implemented `shell.hpp` on Windows.

Remoortere, and Michael Park. Repository: mesos Description --- Stout: Implemented `shell.hpp` on Windows. Diffs - 3rdparty/stout/include/stout/os/windows/shell.hpp ea6ae5ab981f422993085e63543d184a8e41524d Diff: https://reviews.apache.org/r/47943/diff/ Testing --- Thanks, Alex

Re: Review Request 47603: Agent:[2/2] Added Windows support for folder `launcher/`.

a2e6d86fd0b1f3d688d17296151db74bcb9b3418 src/launcher/executor.hpp PRE-CREATION src/launcher/executor.cpp fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 src/launcher/posix/executor.hpp PRE-CREATION src/launcher/windows/executor.hpp PRE-CREATION Diff: https://reviews.apache.org/r/47603/diff/ Testing --- Thanks, Alex

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

a5c8c31b72773d0bd10b9d02675a01f1d641d41c Diff: https://reviews.apache.org/r/47576/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47942: Windows: Added pipe support functions.

Diff: https://reviews.apache.org/r/47942/diff/ Testing --- OSX: make check Windows: build/run Thanks, Alex Clemmer

Re: Review Request 47842: Point slave flags at programmatic temp path.

--- Thanks, Alex Clemmer

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

a5c8c31b72773d0bd10b9d02675a01f1d641d41c Diff: https://reviews.apache.org/r/47576/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/#review134662 --- On May 19, 2016, 2:47 a.m., Alex Clemmer wrote: > >

Re: Review Request 47536: Agent: Added Windows isolators.

3b19682e67372b81484eacddbab78c2e5eda3c5b Diff: https://reviews.apache.org/r/47536/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47472: Windows: Added support for `fetcher.cpp`.

RATOR`? I rearranged the code somewhat so it's compatible. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47472/#review134659 -------

Re: Review Request 47472: Windows: Added support for `fetcher.cpp`.

176d8863d1becd8864218a0012ab45c614f0ad77 Diff: https://reviews.apache.org/r/47472/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47469: Agent: Added `launch.cpp` to Windows build.

cally generated e-mail. To reply, visit: https://reviews.apache.org/r/47469/#review134656 ------- On May 17, 2016, 4:02 p.m., Alex Clemmer wrote: > > --- >

Re: Review Request 47470: Stout: Added `os::temp`.

s://reviews.apache.org/r/47470/#review134657 ------- On May 26, 2016, 1:38 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47470/ > -

Re: Review Request 47470: Stout: Added `os::temp`.

0f71f66d3efed7513ce407dde5b56368747c8e70 3rdparty/stout/include/stout/windows/os.hpp 261768eace6ab09956f4a80e1ec5dba988d831e1 Diff: https://reviews.apache.org/r/47470/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47844: Agent: Added support for `slave/main.cpp`.

/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47843: Agent: Added Windows support for launcher/fetcher.cpp.

://reviews.apache.org/r/47843/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47842: Point slave flags at programmatic temp path.

, Alex Clemmer

Review Request 47821: Remove SASL dependency for Windows builds.

/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47409: Libprocess: Implemented `HANDLE` versions of file descriptor functions.

/process/io.hpp 2f1e626c0eec7c965ddb7acbc9cfe890a621afd3 3rdparty/libprocess/src/io.cpp 44dee23ec9fa958f8e047cf93b87a4031638ab5e Diff: https://reviews.apache.org/r/47409/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47389: Stout: Added support for correct path delimiters in Windows.

/include/stout/os/mkdir.hpp e86dbfd2416fc2835ef7c6c55a20f00429f7b4c6 3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f Diff: https://reviews.apache.org/r/47389/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47411: Agent: Changed the names of symbols that are ambiguous on MSVC.

feb9f291b4188aac1a63ab9cfae8349a048663b1 Diff: https://reviews.apache.org/r/47411/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47412: Windows: Use Winsock class in slave and containerizer.

fee46bafc88f8cdade868aab8c0fee79b8d2fb6d Diff: https://reviews.apache.org/r/47412/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47387: Stout: Implemented `fsync.hpp` for Windows.

9b39ce32c0269479066cf7991afaeed65d8ab547 3rdparty/stout/include/stout/os/fsync.hpp PRE-CREATION 3rdparty/stout/include/stout/os/posix/fsync.hpp PRE-CREATION 3rdparty/stout/include/stout/os/windows/fsync.hpp PRE-CREATION Diff: https://reviews.apache.org/r/47387/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47403: Stout: Set `_fmode` to binary in `protobuf.hpp`.

899 Diff: https://reviews.apache.org/r/47403/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47389: Stout: Added support for correct path delimiters in Windows.

/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f Diff: https://reviews.apache.org/r/47389/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47391: Stout: Removed warning in Windows implementation of `stat.hpp`.

://reviews.apache.org/r/47391/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47409: Libprocess: Implemented `HANDLE` versions of file descriptor functions.

/process/io.hpp 2f1e626c0eec7c965ddb7acbc9cfe890a621afd3 3rdparty/libprocess/src/io.cpp 44dee23ec9fa958f8e047cf93b87a4031638ab5e Diff: https://reviews.apache.org/r/47409/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47404: Stout: Implemented `HANDLE` versions of file descriptor functions.

/ Testing --- Thanks, Alex Clemmer

Review Request 47603: Agent:[2/2] Added Windows support for folder `launcher/`.

fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 src/launcher/posix/executor.hpp PRE-CREATION src/launcher/windows/executor.hpp PRE-CREATION Diff: https://reviews.apache.org/r/47603/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47602: Stout:[1/2] Added Windows support for folder `launcher/`.

, Alex Clemmer

Review Request 47577: Agent: Added minor changes to various .cpp files to support Windows.

, Alex Clemmer

Re: Review Request 47536: Agent: Added Windows isolators.

Diff: https://reviews.apache.org/r/47536/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47576: Agent: Add Windows support to the containerizer.

://reviews.apache.org/r/47576/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47536: Agent: Added Windows isolators.

-CREATION src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc src/usage/usage.hpp 2e1996a78c617c2559ef882ebede5c8aab6f899f src/usage/usage.cpp 3b19682e67372b81484eacddbab78c2e5eda3c5b Diff: https://reviews.apache.org/r/47536/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47470: Stout: Added `path::temp_path`.

/stout/posix/path.hpp PRE-CREATION 3rdparty/stout/include/stout/windows/path.hpp PRE-CREATION Diff: https://reviews.apache.org/r/47470/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47471: Introduced intialize() for Flags class.

fee46bafc88f8cdade868aab8c0fee79b8d2fb6d Diff: https://reviews.apache.org/r/47471/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47469: Agent: Added `launch.cpp` to Windows build.

e22106b014c871e2184a15c2ab154a0674874e47 Diff: https://reviews.apache.org/r/47469/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47472: Windows: Added support for `fetcher.cpp`.

://reviews.apache.org/r/47472/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47468: Windows: Implemented IPC pipe.

/process/pipe.hpp PRE-CREATION 3rdparty/libprocess/include/process/posix/pipe.hpp PRE-CREATION 3rdparty/libprocess/include/process/windows/pipe.hpp PRE-CREATION Diff: https://reviews.apache.org/r/47468/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47412: Windows: Use Winsock class in slave and containerizer.

://reviews.apache.org/r/47412/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47411: Agent: Changed the names of symbols that are ambiguous on MSVC.

://reviews.apache.org/r/47411/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47409: Libprocess: Implemented `HANDLE` versions of file descriptor functions.

2f1e626c0eec7c965ddb7acbc9cfe890a621afd3 3rdparty/libprocess/src/io.cpp 44dee23ec9fa958f8e047cf93b87a4031638ab5e Diff: https://reviews.apache.org/r/47409/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47410: CMake: Added build targets for Mesos executables.

--- Thanks, Alex Clemmer

Review Request 47404: Stout: Implemented `HANDLE` versions of file descriptor functions.

: https://reviews.apache.org/r/47404/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47403: Stout: Set `_fmode` to binary in `protobuf.hpp`.

47403/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47391: Stout: Removed warning in Windows implementation of `stat.hpp`.

--- Thanks, Alex Clemmer

Review Request 47390: Stout: Removed implicit conversions in `permissions.hpp` on Windows.

--- Thanks, Alex Clemmer

Review Request 47388: Stout: Included missing headers in some files.

b075d625541ed6c10192e3e98bf399b38b69cdc5 3rdparty/stout/include/stout/windows.hpp a7a59e78575e1456b4e14d18ac97f51dd23d794e Diff: https://reviews.apache.org/r/47388/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47387: Stout: Implemented `fsync.hpp` for Windows.

/stout/os/fsync.hpp PRE-CREATION 3rdparty/stout/include/stout/os/posix/fsync.hpp PRE-CREATION 3rdparty/stout/include/stout/os/windows/fsync.hpp PRE-CREATION Diff: https://reviews.apache.org/r/47387/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47386: Stout: Implemented `setHostname` on Windows.

/stout/net.hpp 1c99d893af34b834faf8c4e1bd5aee1b377af84f 3rdparty/stout/include/stout/posix/net.hpp PRE-CREATION 3rdparty/stout/include/stout/windows/net.hpp PRE-CREATION Diff: https://reviews.apache.org/r/47386/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47389: Stout: Added support for correct path delimiters in Windows.

ef538045a8b7a1e3d8962c869317d86a85e0259f Diff: https://reviews.apache.org/r/47389/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47162: Libprocess: Made some of the tests work on Windows.

To reply, visit: https://reviews.apache.org/r/47162/#review132487 ------- On May 13, 2016, 6:18 p.m., Alex Clemmer wrote: > > --- > This is an automatical

Re: Review Request 47162: Libprocess: Made some of the tests work on Windows.

/libprocess/src/tests/main.cpp c2ce9bc7830cd7bb0aa473f985106ec745207bf8 3rdparty/libprocess/src/tests/subprocess_tests.cpp 727e940f12643974de4ff2734fba431b285b5de3 Diff: https://reviews.apache.org/r/47162/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46392: Windows: Added stub implementations of `fcntl.hpp` functions.

25e93200cf8b95f57931771073f3b6e34fff061b 3rdparty/stout/include/stout/os/windows/fcntl.hpp 14734317d7fb40053ee808745ac3ba8c706a7669 Diff: https://reviews.apache.org/r/46392/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46392: Windows: Added stub implementations of `fcntl.hpp` functions.

25e93200cf8b95f57931771073f3b6e34fff061b 3rdparty/stout/include/stout/os/windows/fcntl.hpp 14734317d7fb40053ee808745ac3ba8c706a7669 Diff: https://reviews.apache.org/r/46392/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46392: Windows: Added stub implementations of `fcntl.hpp` functions.

/os.hpp 25e93200cf8b95f57931771073f3b6e34fff061b 3rdparty/stout/include/stout/os/windows/fcntl.hpp 14734317d7fb40053ee808745ac3ba8c706a7669 Diff: https://reviews.apache.org/r/46392/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47284: CMake:[1/2] Added support for new `3rdparty/` directory structure.

3rdparty/libprocess/cmake/macros/External.cmake e3901b67048f1c028216ae8323ee1c318a46f3cc Diff: https://reviews.apache.org/r/47284/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47285: CMake:[2/2] Added support for new `3rdparty/` directory structure.

CMakeLists.txt a5f7da7048e890894d11ad16ff96018b37643a16 src/slave/cmake/FindCurl.cmake df81fd538b06bf0c3e842a502bd5ef4083d897b5 Diff: https://reviews.apache.org/r/47285/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46424: Windows: Added libprocess to build.

/CMakeLists.txt 5633c395bcb3b3ce377193c1ca1d6d9810c97852 3rdparty/libprocess/src/tests/CMakeLists.txt 9558adf1e45043630b637fa6fb21dc92ec036bd4 Diff: https://reviews.apache.org/r/46424/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47162: Libprocess: Made some of the tests work on Windows.

/libprocess/src/tests/main.cpp c2ce9bc7830cd7bb0aa473f985106ec745207bf8 3rdparty/libprocess/src/tests/subprocess_tests.cpp 727e940f12643974de4ff2734fba431b285b5de3 Diff: https://reviews.apache.org/r/47162/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46392: Windows:[PLACEHOLDER] Implemented fcntl nonblock and other items.

14734317d7fb40053ee808745ac3ba8c706a7669 Diff: https://reviews.apache.org/r/46392/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47287: Fixed compilation error caused by prctl and recent subprocess change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47287/#review132820 --- Ship it! Ship It! - Alex Clemmer On May 12, 2016, 5:12 a.m

Review Request 47285: CMake:[2/2] Added support for new `3rdparty/` directory structure.

a5f7da7048e890894d11ad16ff96018b37643a16 src/slave/cmake/FindCurl.cmake df81fd538b06bf0c3e842a502bd5ef4083d897b5 Diff: https://reviews.apache.org/r/47285/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47284: CMake:[1/2] Added support for new `3rdparty/` directory structure.

/External.cmake e3901b67048f1c028216ae8323ee1c318a46f3cc Diff: https://reviews.apache.org/r/47284/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

/libprocess/src/subprocess_windows.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46608/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

how to handle this correctly, with minimum complexity -- our goal here is to _not_ reimplement the CLI parser. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/#review132623

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46423/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

onder how this happened. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46423/#review132625 --- On May 5, 20

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

/libprocess/src/subprocess_windows.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46608/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 47168: Windows: Implement `kill` and `killtree`.

> On May 10, 2016, 5:41 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/kill.hpp, line > > 30 > > <https://reviews.apache.org/r/47168/diff/1/?file=133#file133line30> > > > > If we don't mean to e

Re: Review Request 47168: Windows: Implement `kill` and `killtree`.

3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (lines 396 - 397) <https://reviews.apache.org/r/47168/#comment196714> I think these are semantically identical, so we might even just add theese as constants above, in the same way we do for other stuff like `S_IRUSR`. - Al

Re: Review Request 47054: Windows: Removed `Zookeeper's` NTDDI_VERSION.

I do ask we please add a comment before shipping. - Alex Clemmer On May 6, 2016, 4:17 a.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 47053: Windows: [2/2] Used `os::random` in `slave.cpp`.

agree with. - Alex Clemmer On May 6, 2016, 4:17 a.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 47052: Windows: [1/2] Added `os::random`.

h `UUID::random`? For my own education, can you please comment a bit on why this `#undef` is no longer necessary? - Alex Clemmer On May 6, 2016, 4:16 a.m., Daniel Pravat wrote: > > --- > This is an automatically g

Re: Review Request 47162: Libprocess: Made some of the tests work on Windows.

/tests/main.cpp 78858a2b84a439d8f8a60ec8bcb6ac3a308087a6 3rdparty/libprocess/src/tests/subprocess_tests.cpp 727e940f12643974de4ff2734fba431b285b5de3 Diff: https://reviews.apache.org/r/47162/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46422: Stout: Added Windows support for `stopwatch.hpp`.

/stout/include/stout/stopwatch.hpp 18d94afe8f337ae406c7af303ac593f4f712d225 Diff: https://reviews.apache.org/r/46422/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46928: Added safety fixes to and tests `os::close`.

/main.cpp 3f3f62769abdbe44b3e37e0ea9e5f59484b52db6 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 269079f316b51e19990d3058c1b9a34060e3559b Diff: https://reviews.apache.org/r/46928/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

this is best addressed post MVP. As I mention in the `TODO` mapping arguments to `subprocess` into a `CreateProcess` call is nontrivial, and will need to be thought about carefully. We should come back to it post-MVP. - Alex --- Th

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

/libprocess/src/subprocess_windows.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46608/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46424: Windows: Added libprocess to build.

/CMakeLists.txt 5633c395bcb3b3ce377193c1ca1d6d9810c97852 3rdparty/libprocess/src/tests/CMakeLists.txt 9558adf1e45043630b637fa6fb21dc92ec036bd4 Diff: https://reviews.apache.org/r/46424/diff/ Testing --- Thanks, Alex Clemmer

Review Request 47162: Libprocess: Made some of the tests work on Windows.

727e940f12643974de4ff2734fba431b285b5de3 Diff: https://reviews.apache.org/r/47162/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46422: Stout: Added Windows support for `stopwatch.hpp`.

18d94afe8f337ae406c7af303ac593f4f712d225 Diff: https://reviews.apache.org/r/46422/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

) - 3rdparty/libprocess/src/process.cpp 8727eb202e9699f0ac3c95788257cf1a22b0da7b Diff: https://reviews.apache.org/r/46395/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

;= 0` because we have `int` > > and `getOrElse(-1)`. Here we have `HANDLE` and > > `getOrElse(INVALID_HANDLE_VALUE)`. Is `>= 0` still the appropriate check? > > Alex Clemmer wrote: > Good catch. Though it's a no-op if we close an invalid handle, but technic

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

To reply, visit: https://reviews.apache.org/r/46608/#review131935 ------- On May 5, 2016, 3:12 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/#review131935 --- On May 5, 2016, 3:12 a.m., Alex Clemmer wrote: > > --

<    1   2   3   4   5   6   7   8   9   10   >