Review Request 44978: Windows: Fixed `fs::list` to be more compliant with POSIX version.

://reviews.apache.org/r/44978/diff/ Testing --- Thanks, Alex Clemmer

Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

ows/rm.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 Diff: https://reviews.apache.org/r/45022/diff/ Testing --- Thanks, Alex Clemmer

Review Request 45015: Windows: Fixed bug causing `os::exists` to report invalid paths exist.

ut/include/stout/os/windows/exists.hpp 9211851e4562e04045276421b359c3c78cdae7f1 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 Diff: https://reviews.apache.org/r/45015/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

Testing --- Thanks, Alex Clemmer

Re: Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.

) - 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp ee13d12fcffcd564c7ded2d2f541d7bbdf6633c1 Diff: https://reviews.apache.org/r/44078/diff/ Testing --- Thanks, Alex Clemmer

Review Request 44082: Stout: Un-commented out functions and marked them as deleted instead.

: https://reviews.apache.org/r/44082/diff/ Testing --- Thanks, Alex Clemmer

Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

/3rdparty/stout/include/stout/posix/os.hpp 9ee233b988c08d953e70345c55bcdd5c2f7c101b Diff: https://reviews.apache.org/r/44081/diff/ Testing --- Thanks, Alex Clemmer

Review Request 44808: Fixup POSIX build by removing headers from load.*.

dd44f9209ad283bfea95f16a8c1017e309757f23 Diff: https://reviews.apache.org/r/44808/diff/ Testing --- Thanks, Alex Clemmer

Review Request 44080: Windows:[1/2] Implemented `os::gmtime_r`.

9ee233b988c08d953e70345c55bcdd5c2f7c101b 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 6a391ff198ab724f689bcef79d4e2e05a786cbc2 Diff: https://reviews.apache.org/r/44080/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.

/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44748/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 44747: Stout: Added implementation of `write` that works on Windows.

3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/write.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/write.hpp 1715bf5e6c590e7d14f59d517b30a281346365be Diff: https://reviews.apache.org/r/44747/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.

/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44748/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 44747: Stout: Added implementation of `write` that works on Windows.

3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/write.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/write.hpp 1715bf5e6c590e7d14f59d517b30a281346365be Diff: https://reviews.apache.org/r/44747/diff/ Testing --- Thanks, Alex Clemmer

Review Request 44747: Stout: Added implementation of `write` that works on Windows.

1715bf5e6c590e7d14f59d517b30a281346365be Diff: https://reviews.apache.org/r/44747/diff/ Testing --- Thanks, Alex Clemmer

Review Request 44748: Stout: Added implementation of `read` that works on Windows.

, Alex Clemmer

Re: Review Request 42036: Windows: Added `slave/flags.cpp` to Windows build.

--- Thanks, Alex Clemmer

Re: Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.

) - 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp ee13d12fcffcd564c7ded2d2f541d7bbdf6633c1 Diff: https://reviews.apache.org/r/44078/diff/ Testing --- Thanks, Alex Clemmer

Review Request 44722: Libprocess: Add `SOL_TCP` flag for Windows.

--- Thanks, Alex Clemmer

Re: Review Request 44045: Style fixes to `stout/include/Makefile.am`.

c10c6d9d7c68a2d5b27d68736a49d212e70dcd05 Diff: https://reviews.apache.org/r/44045/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43708: Windows:[2/3] Added zlib compilation steps for Windows.

an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43708/#review123086 --- On Feb. 18, 2016, 5:25 a.m., Alex Clemmer wrote: > > --- > This is a

Re: Review Request 43708: Windows:[2/3] Added zlib compilation steps for Windows.

/libprocess/cmake/Process3rdpartyConfigure.cmake e42cf190bd0d0a768002ca8b28d53aa910543fb7 3rdparty/libprocess/cmake/ProcessConfigure.cmake 61edad985a74528bfb1f8935040670a802587061 Diff: https://reviews.apache.org/r/43708/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 44076: Windows: [2/3] Used `os::execlp` in launch.cpp.

/containerizer/mesos/launch.cpp 9fb55aa342559d2f982e7e6ccfef2f0e702bc214 Diff: https://reviews.apache.org/r/44076/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43709: Windows:[3/3] Enabled zlib compression tests.

--- Thanks, Alex Clemmer

Re: Review Request 41632: Windows: Forked signal handling in `signalhandler.hpp`.

4) <https://reviews.apache.org/r/41632/#comment183748> Can we get rid of the trailing whitespace here? - Alex Clemmer On March 3, 2016, 3 a.m., Daniel Pravat wrote: > > --- > This is an auto

Re: Review Request 43906: CMake: Added files to be built as part of libmesos.

0832f1e9a850cc0d2c1112a446f0daf0190f8d7f Diff: https://reviews.apache.org/r/43906/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

know almost nothing about the autotools build, so I'm not exactly qualified to vote on that. - Alex Clemmer On March 2, 2016, 6:15 a.m., Diana Arroyo wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp a2bc5c40167896a3df2cfb5b1f3cf58c20ea1422 Diff: https://reviews.apache.org/r/43908/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

bc420c9c10d93ddd619a9eb2c5f4db67f31d722f Diff: https://reviews.apache.org/r/43907/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

rge of two commits, unfortunately. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43908/#review121532 --- On Feb. 25, 20

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

s.cpp` and `os_tests.cpp`. So I've removed them from `os.hpp`. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43908/#review121532 ---------

Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

valid path, you don't get an error. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43907/#review121530 ------- On Feb. 25, 2016, 7:41 p.m., Alex Clemmer wrote: > > ---

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

g/r/43889/#comment183301> Oh wait. Sorry, I marked this as ship it, but you forgot to update the Makefile.am (my build just failed as a result). As soon as you update that and test the build, you should push this up, and then I think it's ready to go. - Alex Clemmer On March 2

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/#review121560 --- Ship it! - Alex Clemmer On March 2, 2016, 12:52 a.m., Diana

Re: Review Request 43905: Windows: Removed `user` launcher flag, preventing `su`.

/43905/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds.

ically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43889/ > --- > > (Updated Feb. 25, 2016, 7:42 p.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, Joseph Wu, and Till Toensho

Re: Review Request 42036: Windows: Added `slave/flags.cpp` to Windows build.

> On March 1, 2016, 10:10 a.m., Alex Clemmer wrote: > > Ship It! Ah, oops, sorry folks. :( Meant to click this for a different review. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apa

Re: Review Request 42036: Windows: Added `slave/flags.cpp` to Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42036/#review121412 --- Ship it! Ship It! - Alex Clemmer On Jan. 7, 2016, 9:47 p.m

Re: Review Request 43694: Windows:[3/4] Transitioned to static-everything builds on Windows.

://reviews.apache.org/r/43694/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43692: CMake:[1/4] Transitioned to 64-bit build of ZK on Windows.

/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a Diff: https://reviews.apache.org/r/43692/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43694: Windows:[3/4] Transitioned to static-everything builds on Windows.

://reviews.apache.org/r/43694/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43698: CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.

://reviews.apache.org/r/43698/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43698: CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.

Ood catch, thanks Yi. :) - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43698/#review119659 --- On Feb. 29, 20

Re: Review Request 44001: CMake: Add MasterConfigure for master executable build.

paths in a bunch of places now, and this is bad. Every time we add a directory, we'll need to add it to two places. Why not just add it to the libmesos configuration once, and have both other things consume that configuration instead? Thoughts? - Alex Clemmer On Feb. 25, 2016, 8:

Re: Review Request 41092: CMake: Added CMake file for agent executable build.

txt (line 37) <https://reviews.apache.org/r/41092/#comment182588> See comment above and comment in the master review for my recommendations here -- thinking it woudl be better to just put this into a single variable in `SlaveConfigure.cmake`. - Alex Clemmer On Feb. 13, 2016, 4:23 a.m.,

Re: Review Request 44003: CMake: Add CMakeLists for master executable build.

eed! src/master/CMakeLists.txt (line 33) <https://reviews.apache.org/r/44003/#comment182581> Same comment as the dependencies -- we should make this something like the following, much like we did with the agent. ``` target_link_libraries(${MASTER_TARGET} ${MASTER_LIBS}) ```

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

> On Feb. 25, 2016, 12:22 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp, line 52 > > <https://reviews.apache.org/r/43416/diff/2/?file=1253414#file1253414line52> > > > > Why is the cast to `size_t` nee

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

88b355e09f76f0412c74ad69556572f0079deb8f Diff: https://reviews.apache.org/r/43416/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

88b355e09f76f0412c74ad69556572f0079deb8f Diff: https://reviews.apache.org/r/43416/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 44005: CMake: StoutTestsConfigure-removed FindApr & FindSvn, moved to master.

, which I think should address the problems you are having here? :) let me know. https://reviews.apache.org/r/43697/ https://reviews.apache.org/r/43698/ https://reviews.apache.org/r/43699/ - Alex Clemmer On Feb. 25, 2016, 3:28 p.m., Diana Arroyo wrote

Re: Review Request 43997: CMake: Move FindApr and FindSvn to master.

/ https://reviews.apache.org/r/43698/ https://reviews.apache.org/r/43699/ Do you think this addresses the problem you have? Let me know if you have any other concerns or things I can help with. - Alex Clemmer On Feb. 25, 2016, 8:41 a.m., Diana Arroyo wrote

Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.

/windows.hpp d3ba0b4ff5d2d125252389a0f8f618c78aa6d948 Diff: https://reviews.apache.org/r/44078/diff/ Testing --- Thanks, Alex Clemmer

Review Request 44077: Windows:[3/3] Transitioned Windows `system` to use `os::execlp`.

/os/windows/shell.hpp 42e2ee1d5cc3bfe4a8fe121d591ad04213a6730b Diff: https://reviews.apache.org/r/44077/diff/ Testing --- Thanks, Alex Clemmer

Review Request 44076: Windows: [2/3] Used `os::execlp` in launch.cpp.

6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9 Diff: https://reviews.apache.org/r/44076/diff/ Testing --- Thanks, Alex Clemmer

Review Request 44075: Windows: [1/3] Add platform-dependent `os::execlp`.

e0039fdab20ba547dc2bb78c544549c30c535294 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp 42e2ee1d5cc3bfe4a8fe121d591ad04213a6730b Diff: https://reviews.apache.org/r/44075/diff/ Testing --- Thanks, Alex Clemmer

Review Request 44046: Windows: Used `evutil_socket_t` typedef for sockets.

/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43407: CMake: Force GMock and libevent to build and link statically.

d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 Diff: https://reviews.apache.org/r/43407/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

> On Feb. 25, 2016, 12:22 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp, line 52 > > <https://reviews.apache.org/r/43416/diff/2/?file=1253414#file1253414line52> > > > > Why is the cast to `size_t` nee

Review Request 44045: Style fixes to `stout/include/Makefile.am`.

/diff/ Testing --- Thanks, Alex Clemmer

Review Request 44042: Windows: Fixed `UUID::random` and added utime/touch to stout/os.hpp.

Diff: https://reviews.apache.org/r/44042/diff/ Testing --- Thanks, Alex Clemmer

Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

://reviews.apache.org/r/43907/diff/ Testing --- Thanks, Alex Clemmer

Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

/os_tests.cpp a2bc5c40167896a3df2cfb5b1f3cf58c20ea1422 Diff: https://reviews.apache.org/r/43908/diff/ Testing --- Thanks, Alex Clemmer

Review Request 43906: CMake: Added files to be built as part of libmesos.

, Alex Clemmer

Review Request 43905: Windows: Removed `user` launcher flag, preventing `su`.

/containerizer/mesos/launch.hpp 7e29ca2b8bec1c20aef122472cff60f6003603ad src/slave/containerizer/mesos/launch.cpp 6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9 Diff: https://reviews.apache.org/r/43905/diff/ Testing --- Thanks, Alex Clemmer

Review Request 43904: Windows: Removed `rootfs` launcher flag, preventing `chroot`.

/launch.hpp 7e29ca2b8bec1c20aef122472cff60f6003603ad src/slave/containerizer/mesos/launch.cpp 6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9 Diff: https://reviews.apache.org/r/43904/diff/ Testing --- Thanks, Alex Clemmer

Review Request 43903: Stout: Add `WindowsError` constructor to `Result`.

/r/43903/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43410: Windows: Added support for dynamic library loading.

/libprocess/3rdparty/stout/include/stout/windows/dynamiclibrary.hpp PRE-CREATION Diff: https://reviews.apache.org/r/43410/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

/libprocess/3rdparty/stout/tests/CMakeLists.txt 3c65d0422dc6e198180d53d1c9e6cb2839137434 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 27626ae28db090f1a002239ff5c674b82e8fc9a8 Diff: https://reviews.apache.org/r/43411/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

ed e-mail. To reply, visit: https://reviews.apache.org/r/43416/#review120623 --- On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

ps://reviews.apache.org/r/43411/#review120616 ------- On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 43410: Windows: Added support for dynamic library loading.

----- On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43410/ >

Re: Review Request 43407: CMake: Force GMock and libevent to build and link statically.

d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 Diff: https://reviews.apache.org/r/43407/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43407: CMake: Force GMock and libevent to build and link statically.

.apache.org/r/43407/#review118923 --- On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43407/ > -

Re: Review Request 43697: CMake:[1/3] Move Stout configuration to its own file.

/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake a27cb98fa45cbd135ebfeca65e215fb3ff054739 Diff: https://reviews.apache.org/r/43697/diff/ Testing --- Thanks, Alex Clemmer

Review Request 43707: Windows:[1/3] Added zlib definitions for Windows.

Diff: https://reviews.apache.org/r/43707/diff/ Testing --- Thanks, Alex Clemmer

Review Request 43709: Windows:[3/3] Enabled zlib compression tests.

/CMakeLists.txt 3c65d0422dc6e198180d53d1c9e6cb2839137434 Diff: https://reviews.apache.org/r/43709/diff/ Testing --- Thanks, Alex Clemmer

Review Request 43708: Windows:[2/3] Added zlib compilation steps for Windows.

d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 3rdparty/libprocess/cmake/ProcessConfigure.cmake 2a37fdb6501aaf7baac2ada0a714bbe67e7c5aca Diff: https://reviews.apache.org/r/43708/diff/ Testing --- Thanks, Alex Clemmer

Review Request 43698: CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.

--- Thanks, Alex Clemmer

Review Request 43699: CMake:[3/3] Used Stout config script in agent build.

/slave/cmake/SlaveConfigure.cmake a8270a9ac6ceee4f370e185bee82126c309ec134 Diff: https://reviews.apache.org/r/43699/diff/ Testing --- Thanks, Alex Clemmer

Review Request 43697: CMake:[1/3] Move Stout configuration to its own file.

PRE-CREATION 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake a27cb98fa45cbd135ebfeca65e215fb3ff054739 Diff: https://reviews.apache.org/r/43697/diff/ Testing --- Thanks, Alex Clemmer

Review Request 43700: CMake: Fixed Find* scripts to not explode if invoked twice.

/3rdparty/stout/cmake/FindSvn.cmake c975a16975e76b38f028d7575775abd31c9090f5 Diff: https://reviews.apache.org/r/43700/diff/ Testing --- Thanks, Alex Clemmer

Review Request 43689: CMake: Begin to require 64-bit builds.

ab503b23f054ebc9a3877a3eca27b1b4190aa51b Diff: https://reviews.apache.org/r/43689/diff/ Testing --- Thanks, Alex Clemmer

Review Request 43695: Windows:[4/4] Included Socket library for 64-bit builds.

/StoutTestsConfigure.cmake a27cb98fa45cbd135ebfeca65e215fb3ff054739 Diff: https://reviews.apache.org/r/43695/diff/ Testing --- Thanks, Alex Clemmer

Review Request 43694: Windows:[3/4] Transitioned to static-everything builds on Windows.

3a2e0999722007475c023ade75719093e35cfc80 3rdparty/libprocess/src/CMakeLists.txt 12dfaf61b801372b6ec70c535080fde350866fb8 Diff: https://reviews.apache.org/r/43694/diff/ Testing --- Thanks, Alex Clemmer

Review Request 43693: CMake:[2/4] Transitioned ZK build to be 64-bit and static.

--- Thanks, Alex Clemmer

Re: Review Request 43692: CMake:[1/4] Transitioned to 64-bit build of ZK on Windows.

/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609 Diff: https://reviews.apache.org/r/43692/diff/ Testing --- Thanks, Alex Clemmer

Review Request 43691: CMake:[2/2] Fixed http-parser library directory for Windows builds.

://reviews.apache.org/r/43691/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43415: CMake: Moved Windows build to version of glog that builds with CMake.

9b61376ea6aad304607c20c9823d9ef19013eca0 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 Diff: https://reviews.apache.org/r/43415/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43418: Windows: Added slave/status_update_manager.cpp and other files.

://reviews.apache.org/r/43418/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43413: CMake:[1/2] Allow downloading third-party dependencies from mirror.

CMakeLists.txt 7f83dc84997d3b824d1f63012894bd9fc5284053 Diff: https://reviews.apache.org/r/43413/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43417: Windows: Marked functions in headers `inline` to avoid linker errors.

/dirent.hpp 046388189823c0c41ce6cc135d5d3838e9131087 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 9a592c4ec9f45fdd8ae8c724c3cab67876de72f5 Diff: https://reviews.apache.org/r/43417/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43410: Windows: Added support for dynamic library loading.

/libprocess/3rdparty/stout/include/stout/windows/dynamiclibrary.hpp PRE-CREATION Diff: https://reviews.apache.org/r/43410/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

88b355e09f76f0412c74ad69556572f0079deb8f Diff: https://reviews.apache.org/r/43416/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43414: CMake:[2/2] Canonicalize location of third-party dependencies.

9b61376ea6aad304607c20c9823d9ef19013eca0 Diff: https://reviews.apache.org/r/43414/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43409: Windows: Added `src/resource_estimator.cpp` to build.

Remoortere and Michael Park. Repository: mesos Description --- Windows: Added `src/resource_estimator.cpp` to build. Diffs (updated) - src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609 Diff: https://reviews.apache.org/r/43409/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

/libprocess/3rdparty/stout/tests/CMakeLists.txt 3c65d0422dc6e198180d53d1c9e6cb2839137434 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 27626ae28db090f1a002239ff5c674b82e8fc9a8 Diff: https://reviews.apache.org/r/43411/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43407: CMake: Force GMock and libevent to build and link statically.

d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 Diff: https://reviews.apache.org/r/43407/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

he.org/job/mesos-reviewbot/11361/console Ah, sorry, this patch is extremely old, and hhas been resurrected. I'll fix it. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 43410: Windows: Added support for dynamic library loading.

/libprocess/3rdparty/stout/include/stout/windows/dynamiclibrary.hpp PRE-CREATION Diff: https://reviews.apache.org/r/43410/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43407: CMake: Force GMock and libevent to build and link statically.

9b61376ea6aad304607c20c9823d9ef19013eca0 Diff: https://reviews.apache.org/r/43407/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 43407: CMake: Force GMock and libevent to build and link statically.

--- Thanks, Alex Clemmer

<    2   3   4   5   6   7   8   9   10   11   >