src/slave/slave.cpp e6c7e686f287fb4448a0074d4e99298665fc866d
Diff: https://reviews.apache.org/r/67022/diff/3/
Changes: https://reviews.apache.org/r/67022/diff/2-3/
Testing
---
Thanks,
Zhitao Li
med that in our agent log, but we can also create a new unit test to
cover that case. wdyt?
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67022/#review208520
---------
://reviews.apache.org/r/68300/diff/1/
Testing
---
Thanks,
Zhitao Li
Description
---
Documented new `--cgroups_destroy_timeout` agent option.
Diffs
-
docs/configuration/agent.md 83b5fed5a8bf287700688507eaa584f37e8ba2b7
Diff: https://reviews.apache.org/r/68299/diff/1/
Testing
---
Thanks,
Zhitao Li
eeb9708f9ec76d83b6719541f4a012544c7c0cbe
src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478
Diff: https://reviews.apache.org/r/68088/diff/3/
Changes: https://reviews.apache.org/r/68088/diff/2-3/
Testing
---
`make` and `./bin/mesos-slave.sh --help`
Thanks,
Zhitao Li
eeb9708f9ec76d83b6719541f4a012544c7c0cbe
src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478
Diff: https://reviews.apache.org/r/68088/diff/2/
Changes: https://reviews.apache.org/r/68088/diff/1-2/
Testing
---
`make` and `./bin/mesos-slave.sh --help`
Thanks,
Zhitao Li
8fba6f9d335cc43a7cd0fcb51ed047ba0e7027ed
src/slave/containerizer/mesos/linux_launcher.cpp
3bddcece7028745cec6623ac33dbfcaced629629
Diff: https://reviews.apache.org/r/68088/diff/1/
Testing
---
`make` and `./bin/mesos-slave.sh --help`
Thanks,
Zhitao Li
://reviews.apache.org/r/68087/diff/1/
Testing
---
`make` and run `./bin/mesos-slave.sh --help`.
Thanks,
Zhitao Li
: https://reviews.apache.org/r/67822/diff/1-2/
Testing
---
```make```
Thanks,
Zhitao Li
directories. This patch makes sure we do not call unmount
anymore after a success.
Diffs
-
src/slave/gc.cpp 407f6b23f87cf2e2bdaf873c8adcda57f5d559b3
Diff: https://reviews.apache.org/r/67822/diff/1/
Testing
---
```make```
Thanks,
Zhitao Li
age_pull_ms/p99": 8829.27057408,
"containerizer/docker/image_pull_ms/p999": 8849.274551808,
"containerizer/docker/image_pull_ms/p": 8851.2749495808,
```
Thanks,
Zhitao Li
/zhitaoli/mesos/blob/public/zhitao/time_containerizer_pulls/docs/monitoring.md#containerizers
Thanks,
Zhitao Li
image_pull_ms/p999":
4208.072888064,
"containerizer/mesos/provisioner/docker_store/image_pull_ms/p":
4208.6031032064,
```
Thanks,
Zhitao Li
ot;: 8629.2307968,
"containerizer/docker/image_pull_ms/p95": 8740.3640064,
"containerizer/docker/image_pull_ms/p99": 8829.27057408,
"containerizer/docker/image_pull_ms/p999": 8849.274551808,
"containerizer/docker/image_pull_ms/p": 8851.2749495808,
```
Thanks,
Zhitao Li
y generated e-mail. To reply, visit:
https://reviews.apache.org/r/53105/#review205049
-------
On May 21, 2018, 10:16 a.m., Zhitao Li wrote:
>
> ---
> Th
latest state of the task according to the agent,
// which can be more recent...
```
- Zhitao Li
On June 15, 2018, 5:45 a.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
s (updated)
-
src/slave/gc.cpp 390b35e6d17d6614a73c9548decbf10739560106
Diff: https://reviews.apache.org/r/67423/diff/3/
Changes: https://reviews.apache.org/r/67423/diff/2-3/
Testing
---
Thanks,
Zhitao Li
/4-5/
Testing
---
Thanks,
Zhitao Li
'/home/zhitao/mesos-workdir/volumes/roles/role/id1'
inside garbage collected path
'/home/zhitao/mesos-workdir/slaves/b3eb3aff-d19d-45ff-8113-f0316462d3fa-S0'
```
Thanks,
Zhitao Li
'
```
Thanks,
Zhitao Li
/slaves/b3eb3aff-d19d-45ff-8113-f0316462d3fa-S0'
```
Thanks,
Zhitao Li
/gc_tests.cpp 619ed22edd9b3909ea24cdcbf62c354420a8d031
Diff: https://reviews.apache.org/r/67421/diff/3/
Changes: https://reviews.apache.org/r/67421/diff/2-3/
Testing
---
Thanks,
Zhitao Li
'/home/zhitao/mesos-workdir/slaves/b3eb3aff-d19d-45ff-8113-f0316462d3fa-S0'
```
Thanks,
Zhitao Li
/tests/gc_tests.cpp 619ed22edd9b3909ea24cdcbf62c354420a8d031
Diff: https://reviews.apache.org/r/67421/diff/2/
Changes: https://reviews.apache.org/r/67421/diff/1-2/
Testing
---
Thanks,
Zhitao Li
7d6614a73c9548decbf10739560106
Diff: https://reviews.apache.org/r/67423/diff/1/
Testing
---
Thanks,
Zhitao Li
/1/
Testing
---
Thanks,
Zhitao Li
volume '/home/zhitao/mesos-workdir/volumes/roles/role/id1'
inside garbage collected path
'/home/zhitao/mesos-workdir/slaves/b3eb3aff-d19d-45ff-8113-f0316462d3fa-S0'
```
Thanks,
Zhitao Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67320/#review204023
---
Ship it!
Ship It!
- Zhitao Li
On May 28, 2018, 4:25 a.m
tps://reviews.apache.org/r/67320/#comment286238>
We typically do not do `this->`.
`Try<Owned> master = StartMaster();`
- Zhitao Li
On May 25, 2018, 6:52 a.m., Alexander Rukletsov wrote:
>
> ---
> This is an automa
/volume'
of persistent volume '/home/zhitao/mesos-workdir/volumes/roles/role/id1'
inside garbage collected path
'/home/zhitao/mesos-workdir/slaves/b3eb3aff-d19d-45ff-8113-f0316462d3fa-S0'
```
Thanks,
Zhitao Li
-45ff-8113-f0316462d3fa-/executors/test_id/runs/1cd3bd06-2632-4541-a708-80c7cd51c74b/volume'
of persistent volume '/home/zhitao/mesos-workdir/volumes/roles/role/id1'
inside garbage collected path
'/home/zhitao/mesos-workdir/slaves/b3eb3aff-d19d-45ff-8113-f0316462d3fa-S0'
```
Thanks,
Zhitao
` itself can be failed?
- Zhitao Li
On May 16, 2018, 12:20 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
://reviews.apache.org/r/67022/diff/2/
Changes: https://reviews.apache.org/r/67022/diff/1-2/
Testing
---
Thanks,
Zhitao Li
: mesos
Description
---
Refreshed checkpointed SlaveInfo if `--reconfiguration_policy==any`.
Diffs
-
src/slave/slave.cpp c6d9152d9de4184f9107bb8242b41d468d76e018
Diff: https://reviews.apache.org/r/67022/diff/1/
Testing
---
Thanks,
Zhitao Li
wonder
whether we should augment the behavior for `any` to also flush out changed
`AgentInfo` using `state::checkpoint()`.
Thoughts?
- Zhitao Li
On Dec. 6, 2017, 8:22 a.m., Benno Evers wrote:
>
> ---
> This is an automatica
/r/66993/diff/1-2/
Testing
---
GTEST_FILTER="DockerContainerizerTest.ROOT_DOCKER_MaxCompletionTime"
./bin/mesos-tests.sh --gtest_repeat=100 --verbose
Thanks,
Zhitao Li
="DockerContainerizerTest.ROOT_DOCKER_MaxCompletionTime"
./bin/mesos-tests.sh --gtest_repeat=100 --verbose
Thanks,
Zhitao Li
-volume.md
https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/operator-http-api.md
https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/authorization.md
Thanks,
Zhitao Li
fer making tests as
> > deterministic as possible.
I think I prefer keeping it for now.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66532/#review202300
-------
` will be
dropped...
```
- Zhitao Li
On May 2, 2018, 9:54 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
/api_tests.cpp dd8e221d8fd1b2a241505345337897e4ee4a6347
Diff: https://reviews.apache.org/r/66227/diff/9/
Changes: https://reviews.apache.org/r/66227/diff/8-9/
Testing
---
Thanks,
Zhitao Li
://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/authorization.md
Thanks,
Zhitao Li
Diff: https://reviews.apache.org/r/66858/diff/6/
Changes: https://reviews.apache.org/r/66858/diff/5-6/
Testing
---
Thanks,
Zhitao Li
Diff: https://reviews.apache.org/r/66858/diff/5/
Changes: https://reviews.apache.org/r/66858/diff/4-5/
Testing
---
Thanks,
Zhitao Li
/master_validation_tests.cpp
a5229610a81dfac9d358597135b63ee51de86659
Diff: https://reviews.apache.org/r/66858/diff/4/
Changes: https://reviews.apache.org/r/66858/diff/3-4/
Testing
---
Thanks,
Zhitao Li
dd8e221d8fd1b2a241505345337897e4ee4a6347
Diff: https://reviews.apache.org/r/66227/diff/7/
Changes: https://reviews.apache.org/r/66227/diff/6-7/
Testing
---
Thanks,
Zhitao Li
, visit:
https://reviews.apache.org/r/66858/#review202251
-------
On May 2, 2018, 10:24 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically gener
/master_validation_tests.cpp
a5229610a81dfac9d358597135b63ee51de86659
Diff: https://reviews.apache.org/r/66858/diff/3/
Changes: https://reviews.apache.org/r/66858/diff/2-3/
Testing
---
Thanks,
Zhitao Li
://reviews.apache.org/r/66051/diff/15-16/
Testing
---
Thanks,
Zhitao Li
(patched)
<https://reviews.apache.org/r/66532/#comment283990>
For my self: consistency.
- Zhitao Li
On May 1, 2018, 3:45 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
a76ad18a54ec232e6d6c92ec6a45b445a83f174c
src/tests/persistent_volume_tests.cpp
4edf781711d9efdb994114aeb6289b6af750b87a
Diff: https://reviews.apache.org/r/66532/diff/8/
Changes: https://reviews.apache.org/r/66532/diff/7-8/
Testing
---
Thanks,
Zhitao Li
/persistent_volume_tests.cpp
4edf781711d9efdb994114aeb6289b6af750b87a
Diff: https://reviews.apache.org/r/66220/diff/10/
Changes: https://reviews.apache.org/r/66220/diff/9-10/
Testing
---
Thanks,
Zhitao Li
a76ad18a54ec232e6d6c92ec6a45b445a83f174c
src/tests/persistent_volume_tests.cpp
4edf781711d9efdb994114aeb6289b6af750b87a
Diff: https://reviews.apache.org/r/66532/diff/7/
Changes: https://reviews.apache.org/r/66532/diff/6-7/
Testing
---
Thanks,
Zhitao Li
/persistent_volume_tests.cpp
4edf781711d9efdb994114aeb6289b6af750b87a
Diff: https://reviews.apache.org/r/66220/diff/9/
Changes: https://reviews.apache.org/r/66220/diff/8-9/
Testing
---
Thanks,
Zhitao Li
c723a291ed8d219ced4492bc905ac6b52683ae47
src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf
src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d
Diff: https://reviews.apache.org/r/66050/diff/15/
Changes: https://reviews.apache.org/r/66050/diff/14-15/
Testing
---
Thanks,
Zhitao
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/66532/#review202170
-----------
On April 27, 2018, 1:08 p.m., Zhitao Li wrote:
>
> ---
> This is an au
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66532/#review202170
-------
On April 27, 2018, 1:08 p.m., Zhitao Li wrote:
>
> -
}` so we
> > don't need the subsequent `acceptOffers`?
I like this suggestion. will try it out.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66220/#review
bf849c4b636e81ec267112bff9621579998941f5
Diff: https://reviews.apache.org/r/66293/diff/6/
Changes: https://reviews.apache.org/r/66293/diff/5-6/
Testing
---
Thanks,
Zhitao Li
5e3dfdb537f52a85a82c6e8195e70a389b76aadf
Diff: https://reviews.apache.org/r/66284/diff/5/
Changes: https://reviews.apache.org/r/66284/diff/4-5/
Testing
---
Thanks,
Zhitao Li
will be killed without above reason.
Diffs (updated)
-
src/launcher/default_executor.cpp ea0d425bb60e970f209f411632e1d486c279259b
Diff: https://reviews.apache.org/r/66291/diff/4/
Changes: https://reviews.apache.org/r/66291/diff/3-4/
Testing
---
Thanks,
Zhitao Li
://reviews.apache.org/r/66283/diff/4-5/
Testing
---
Thanks,
Zhitao Li
/diff/5-6/
Testing
---
Thanks,
Zhitao Li
> On May 1, 2018, 9:25 a.m., Zhitao Li wrote:
> > 3rdparty/libprocess/include/process/metrics/push_gauge.hpp
> > Lines 70-75 (patched)
> > <https://reviews.apache.org/r/66828/diff/1/?file=2013207#file2013207line70>
> >
> > Hmm,
T2: `fetch_add(3)`, `prev` in T2 == 2;
T2: `push(2 + 3)`, metric value is 5;
T1: `push(0 + 2)`, metric value is 2.
Metric value and cached value in gauge would be out of sync due to the race
condition?
- Zhitao Li
On April 26, 2018, 2:54 p.m., Benjamin Mahler
ae82438a4f2f79820fe6d476e25b4915aa5f212c
Diff: https://reviews.apache.org/r/54986/diff/3/
Changes: https://reviews.apache.org/r/54986/diff/2-3/
Testing
---
make check.
Thanks,
Zhitao Li
e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/53267/diff/4/
Changes: https://reviews.apache.org/r/53267/diff/3-4/
Testing
---
Ran this on master with a client keeps subscribing and disconnecting. Observes
that gauge gets updated and new log line is printed.
Thanks,
Zhitao Li
ontainerizer/mesos/docker_store/pull_ms/p999": 4083.694998528,
"containerizer/mesos/docker_store/pull_ms/p": 4084.1982870528,
```
Thanks,
Zhitao Li
://reviews.apache.org/r/66292/diff/1/
Testing
---
Thanks,
Zhitao Li
/containerizer/mesos/provisioner/docker/store.cpp
8b3f07f5027cb90d4b4ed401960494709d3eda5f
Diff: https://reviews.apache.org/r/66875/diff/1/
Testing
---
Thanks,
Zhitao Li
://reviews.apache.org/r/66875/diff/1/
Testing
---
Thanks,
Zhitao Li
pull_ms/p99": 25739.0929664,
"containerizer/docker/pull_ms": 26261.613824,
"containerizer/docker/pull_ms/count": 3
```
Thanks,
Zhitao Li
: 12520.426776832,
"containerizer/mesos/docker_store/pull_ms/min": 3167.337984,
"containerizer/mesos/docker_store/pull_ms/p95": 12091.4106496,
"containerizer/mesos/docker_store/pull_ms/p99": 12441.62789632,
"containerizer/mesos/docker_store/layers": 47,
```
Thanks,
Zhitao Li
c20b99eb32a50830ea6f66b5bdbfcabe45fc6ecb
Diff: https://reviews.apache.org/r/54987/diff/2/
Changes: https://reviews.apache.org/r/54987/diff/1-2/
Testing
---
Thanks,
Zhitao Li
/
Testing
---
make check.
Thanks,
Zhitao Li
0eb2b59ed67e14e73b29d7592c239441df0008d5
src/slave/slave.hpp be72ba93d4c6ca3e69e3f76f87aa7ddebdbf9cad
src/tests/slave_tests.cpp fc6b56c074c71b827a9ee522cd715c0d15ecc7e3
Diff: https://reviews.apache.org/r/54986/diff/1/
Testing
---
make check.
Thanks,
Zhitao Li
---
https://github.com/zhitaoli/mesos/blob/zhitao/public/active_subscribers/docs/monitoring.md#http-api
Thanks,
Zhitao Li
/r/53267/diff/2-3/
Testing
---
Ran this on master with a client keeps subscribing and disconnecting. Observes
that gauge gets updated and new log line is printed.
Thanks,
Zhitao Li
t:
https://reviews.apache.org/r/66050/#review201887
-------
On April 27, 2018, 12:24 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e
/1/
Testing
---
Thanks,
Zhitao Li
will not allow to
grow/shrink volumes.
Also created unit test in next patch.
Thanks,
Zhitao Li
/
Changes: https://reviews.apache.org/r/66051/diff/14-15/
Testing
---
Thanks,
Zhitao Li
a76ad18a54ec232e6d6c92ec6a45b445a83f174c
src/tests/persistent_volume_tests.cpp
4edf781711d9efdb994114aeb6289b6af750b87a
Diff: https://reviews.apache.org/r/66532/diff/6/
Changes: https://reviews.apache.org/r/66532/diff/5-6/
Testing
---
Thanks,
Zhitao Li
his?
They don't. I've rewrittent the comment.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66220/#review201843
-----------
On April 27, 2018, 1:04 p.m., Zhitao Li wrote:
>
> ---
don't need it.
New test dropped this.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66220/#review201969
---
On A
on code? Can we check for
> > expected behavior when a GROW/SHRINK operation is submitted for a MOUNT
> > volume, rather than simply returning?
>
> Zhitao Li wrote:
> I added validation in r/66050 so we drop shrink volume operation on
> MOUNT. There is no logical path f
; allocator communication for
`allocator::updateAllocation()` has happened.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66220/#review201843
-------
On April 27, 2018, 1:04 p.m., Zhitao Li wrote:
>
4edf781711d9efdb994114aeb6289b6af750b87a
Diff: https://reviews.apache.org/r/66220/diff/8/
Changes: https://reviews.apache.org/r/66220/diff/7-8/
Testing
---
Thanks,
Zhitao Li
-14/
Testing
---
Thanks,
Zhitao Li
/reservation_tests.cpp 5570df2e0b208512d0a0a3079a180e1acfe08f3d
Diff: https://reviews.apache.org/r/66049/diff/12/
Changes: https://reviews.apache.org/r/66049/diff/11-12/
Testing
---
Thanks,
Zhitao Li
5e3dfdb537f52a85a82c6e8195e70a389b76aadf
Diff: https://reviews.apache.org/r/66284/diff/4/
Changes: https://reviews.apache.org/r/66284/diff/3-4/
Testing
---
Thanks,
Zhitao Li
belongs in the validation
> > function for the ACCEPT call? Since this is something that we can easily
> > confirm synchronously in the top-level scheduler API handler and return
> > 400, rather than calling into the accept handlers.
>
> Zhitao Li wrote:
>
belongs in the validation
> > function for the ACCEPT call? Since this is something that we can easily
> > confirm synchronously in the top-level scheduler API handler and return
> > 400, rather than calling into the accept handlers.
>
> Zhitao Li wrote:
>
add an end-to-end test of authorization for these
> > operations?
>
> Zhitao Li wrote:
> Sure. Do you have an example or existing test to add this?
>
> Greg Mann wrote:
> There are some similar tests in both 'persistent_volume_tests.cpp' as
> well as 'master_authorizat
/authorization_tests.cpp a76ad18a54ec232e6d6c92ec6a45b445a83f174c
src/tests/persistent_volume_tests.cpp
4edf781711d9efdb994114aeb6289b6af750b87a
Diff: https://reviews.apache.org/r/66532/diff/5/
Changes: https://reviews.apache.org/r/66532/diff/4-5/
Testing
---
Thanks,
Zhitao Li
belongs in the validation
> > function for the ACCEPT call? Since this is something that we can easily
> > confirm synchronously in the top-level scheduler API handler and return
> > 400, rather than calling into the accept handlers.
>
> Zhitao Li wrote:
>
c723a291ed8d219ced4492bc905ac6b52683ae47
src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf
src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d
Diff: https://reviews.apache.org/r/66050/diff/13/
Changes: https://reviews.apache.org/r/66050/diff/12-13/
Testing
---
Thanks,
Zhitao Li
Diff: https://reviews.apache.org/r/66733/diff/2/
Changes: https://reviews.apache.org/r/66733/diff/1-2/
Testing
---
Thanks,
Zhitao Li
://reviews.apache.org/r/66291/diff/2-3/
Testing
---
Thanks,
Zhitao Li
belongs in the validation
> > function for the ACCEPT call? Since this is something that we can easily
> > confirm synchronously in the top-level scheduler API handler and return
> > 400, rather than calling into the accept handlers.
>
> Zhitao Li wrote:
>
1 - 100 of 907 matches
Mail list logo
