org/r/55334/diff/8/
Changes: https://reviews.apache.org/r/55334/diff/7-8/
Testing
---
Thanks,
Zhitao Li
---
Thanks,
Zhitao Li
slave/slave.cpp 6d1516a5d5b5db684f79385e60d892ff75fd00fd
Diff: https://reviews.apache.org/r/62047/diff/4/
Changes: https://reviews.apache.org/r/62047/diff/3-4/
Testing (updated)
---
Created new unit test in https://reviews.apache.org/r/62263/
Thanks,
Zhitao Li
tests/slave_tests.cpp 1bdadce4c50cbff958f2be2a4261e130b414acfd
Diff: https://reviews.apache.org/r/62047/diff/3/
Testing (updated)
---
Created new unit test to browse and read file through virtual sandbox path.
Thanks,
Zhitao Li
e the virtual path.
Thanks,
Zhitao Li
,
Zhitao Li
y with the two different calls?
rebase error
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62047/#review184737
---
On Sep
Diff: https://reviews.apache.org/r/62047/diff/2/
Changes: https://reviews.apache.org/r/62047/diff/1-2/
Testing
---
Ran a master/agent pair, launch a task with `mesos-execute` and use
`files/browse` endpoint to browse the virtual path.
Thanks,
Zhitao Li
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62040/#review184732
-------
On Sept. 7, 2017, 9:16 p.m., Zhitao Li wrote:
>
> ---
&g
b03279ee0b23b3a33383c6d3e0c31faa97dab8eb
Diff: https://reviews.apache.org/r/62174/diff/1/
Testing
---
Thanks,
Zhitao Li
/2/
Changes: https://reviews.apache.org/r/62040/diff/1-2/
Testing
---
Thanks,
Zhitao Li
iff/1/
Testing
---
Ran a master/agent pair, launch a task with `mesos-execute` and use
`files/browse` endpoint to browse the virtual path.
Thanks,
Zhitao Li
/slave.cpp df920ec07cd59c7ba6baccfc1c20ed3809f187d6
Diff: https://reviews.apache.org/r/62040/diff/1/
Testing
---
Thanks,
Zhitao Li
---
Thanks,
Zhitao Li
/
Testing
---
Thanks,
Zhitao Li
://reviews.apache.org/r/53993/diff/6/
Testing (updated)
---
https://github.com/zhitaoli/mesos/blob/public/quota_update/docs/quota.md
Thanks,
Zhitao Li
://reviews.apache.org/r/53993/diff/6/
Changes: https://reviews.apache.org/r/53993/diff/5-6/
Testing (updated)
---
https://github.com/zhitaoli/mesos/tree/public/quota_update
Thanks,
Zhitao Li
://reviews.apache.org/r/52103/diff/5-6/
Testing
---
Thanks,
Zhitao Li
ithTask`
Diffs (updated)
-
src/tests/master_quota_tests.cpp 9d52f767c112abd55ab3f49d172eb6e3caea511b
Diff: https://reviews.apache.org/r/53691/diff/4/
Changes: https://reviews.apache.org/r/53691/diff/3-4/
Testing
---
Thanks,
Zhitao Li
/quota.cpp 79e4ad8ae5cdada8ac98d663b50645ae0e792f72
src/tests/master_quota_tests.cpp 9d52f767c112abd55ab3f49d172eb6e3caea511b
Diff: https://reviews.apache.org/r/52284/diff/7/
Changes: https://reviews.apache.org/r/52284/diff/6-7/
Testing
---
Thanks,
Zhitao Li
://reviews.apache.org/r/55335/diff/4/
Changes: https://reviews.apache.org/r/55335/diff/3-4/
Testing
---
GTEST_FILTER="MesosContainerizer*" make check
Thanks,
Zhitao Li
://reviews.apache.org/r/55334/diff/6-7/
Testing
---
Thanks,
Zhitao Li
8058dcb31b9de59fa8d3638b553632235542
src/tests/containerizer/provisioner_docker_tests.cpp
920be77b16178a4458d72145020c015130799ec4
Diff: https://reviews.apache.org/r/60511/diff/1/
Testing
---
Thanks,
Zhitao Li
affected.
Thanks,
Zhitao Li
85c43cacf1361d269c28a7fe8bd1da8615949ec8
src/tests/api_tests.cpp cdaa72462eac1687185115771265539d8c2b09a9
Diff: https://reviews.apache.org/r/56722/diff/3/
Changes: https://reviews.apache.org/r/56722/diff/2-3/
Testing (updated)
---
New unit test to trigger the new call.
Thanks,
Zhitao Li
/provisioner_docker_tests.cpp
920be77b16178a4458d72145020c015130799ec4
Diff: https://reviews.apache.org/r/60471/diff/1/
Testing
---
Thanks,
Zhitao Li
e64 encoding?
- Zhitao Li
On June 12, 2017, 2:06 a.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59989/
> ---
`.proto` change
the only real code change? If so, should we write some c++ test code to use the
map based fields and json parsing of map?
Also, explaining which files are generated in summary will help reviewers to
know what changes we can safekly skip reading?
- Zhitao Li
On June 12, 2017, 2
above said, I am still happy to see this happening.
- Zhitao Li
On June 6, 2017, 9:16 p.m., James Peach wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
/containerizer/provisioner_docker_tests.cpp
1decc721c58f3168e100bb4b137dd8df26602095
Diff: https://reviews.apache.org/r/59705/diff/1/
Testing
---
make check
Thanks,
Zhitao Li
://reviews.apache.org/r/55727/diff/4/
Changes: https://reviews.apache.org/r/55727/diff/3-4/
Testing
---
Thanks,
Zhitao Li
/tests/containerizer.cpp 1d2b6391cf7a7545fa44206c59d05764f3e8cdfb
src/tests/containerizer/mock_containerizer.hpp
0adcb01e6c12d6cc4abed1f14fa2df833ffc6569
Diff: https://reviews.apache.org/r/56721/diff/3/
Changes: https://reviews.apache.org/r/56721/diff/2-3/
Testing
---
Thanks,
Zhitao Li
8058dcb31b9de59fa8d3638b553632235542
Diff: https://reviews.apache.org/r/55727/diff/3/
Changes: https://reviews.apache.org/r/55727/diff/2-3/
Testing
---
Thanks,
Zhitao Li
/diff/1/
Testing
---
Thanks,
Zhitao Li
/pull_ms/max": 26261.613824,
"containerizer/docker/pull_ms/p95": 23649.009536,
"containerizer/docker/pull_ms/min": 103.215872,
"containerizer/docker/pull_ms/p99": 25739.0929664,
"containerizer/docker/pull_ms": 26261.613824,
"containerizer/docker/pull_ms/count": 3
```
Thanks,
Zhitao Li
://reviews.apache.org/r/55335/diff/3/
Changes: https://reviews.apache.org/r/55335/diff/2-3/
Testing
---
GTEST_FILTER="MesosContainerizer*" make check
Thanks,
Zhitao Li
://reviews.apache.org/r/55334/diff/4-5/
Testing
---
Thanks,
Zhitao Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59658/#review176390
---
Ship it!
Ship It!
- Zhitao Li
On May 30, 2017, 11:30 p.m
ent249723>
It seems like this `path` variable shadows input argument? I'm not sure
whether that's a good idea but I generally found that hard to understand.
Consider rename this local variable to something like `resolvedPath`?
- Zhitao Li
On May 30, 2017, 6:10
y generated e-mail. To reply, visit:
https://reviews.apache.org/r/59616/#review176274
-------
On May 27, 2017, 1:10 a.m., Zhitao Li wrote:
>
> ---
> Th
---
After protobuf 3.3.0 upgrade, reviewboard CI breaks complaining failed
`import six` python.
Diffs
-
src/python/setup.py.in 991ac31409c566e8a59d47f8296317e245925d4e
Diff: https://reviews.apache.org/r/59616/diff/1/
Testing
---
Thanks,
Zhitao Li
(updated)
-
3rdparty/cmake/Versions.cmake a7a13402d9b8d9795634dc99f488b9c9e6f5d5a8
3rdparty/versions.am 55e170a496761c8b9aadb79d03c56d22549e167c
Diff: https://reviews.apache.org/r/58515/diff/6/
Changes: https://reviews.apache.org/r/58515/diff/5-6/
Testing
---
Thanks,
Zhitao Li
tps://reviews.apache.org/r/59536/#comment249555>
Can you explain how is these hashes geneareted and used?
I'm working on upgrading protobuf library to 3.3.0 so this hash would
change, but I don't know how I can generate a correct value from here...
- Zhitao Li
On May 24
728f88fe57aef4dd7be1d40c7c0227ad2db5015e
3rdparty/versions.am b8144702adca9dd41199f69cb6fb0c0c4b490dbd
Diff: https://reviews.apache.org/r/58515/diff/5/
Changes: https://reviews.apache.org/r/58515/diff/4-5/
Testing
---
Thanks,
Zhitao Li
/1/
Testing
---
Ran this on a master and able to get result on `/metrics/cached` endpoint.
Thanks,
Zhitao Li
-
3rdparty/CMakeLists.txt cb118f6c454c3bb36990e292a31703e4a3f99483
3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e
3rdparty/protobuf-2.6.1.patch bfd3bb2c600383ef05bdb4ea9df0188b4a560315
Diff: https://reviews.apache.org/r/58513/diff/4/
Testing
---
Thanks,
Zhitao Li
.
Diffs (updated)
-
LICENSE 512b089c5dd2540f9f83afb559e5d0998d97ea22
Diff: https://reviews.apache.org/r/58361/diff/9/
Changes: https://reviews.apache.org/r/58361/diff/8-9/
Testing
---
Thanks,
Zhitao Li
.
Diffs (updated)
-
src/tests/protobuf_utils_tests.cpp 5239182812835b93a28e85146b2df2b20ae77328
Diff: https://reviews.apache.org/r/58360/diff/6/
Changes: https://reviews.apache.org/r/58360/diff/5-6/
Testing
---
Thanks,
Zhitao Li
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58359/#review172363
---
On May 19, 2017, 5:55 p.m., Zhitao Li wrote:
>
> --
---
Thanks,
Zhitao Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58515/#review175319
-------
On May 19, 2017, 5:54 p.m., Zhitao Li wrote:
>
> ---
---
Thanks,
Zhitao Li
18870cde806c7bcb0a204de2a40555739adf777b
3rdparty/stout/tests/protobuf_tests.pb.cc
b2458f0edcf679b2390f87ec8c4bee2b16e71d70
Diff: https://reviews.apache.org/r/58514/diff/3/
Changes: https://reviews.apache.org/r/58514/diff/2-3/
Testing
---
Thanks,
Zhitao Li
://reviews.apache.org/r/58513/diff/4/
Changes: https://reviews.apache.org/r/58513/diff/3-4/
Testing
---
Thanks,
Zhitao Li
. build this branch in Apache Aurora's vagrant based box, and verifies that
Aurora scheduler (using java) and executor (using python) still works with
`libmesos.so` built from this branch.
Thanks,
Zhitao Li
version of protobuf.
Diffs (updated)
-
src/tests/protobuf_utils_tests.cpp 5239182812835b93a28e85146b2df2b20ae77328
Diff: https://reviews.apache.org/r/58360/diff/4/
Changes: https://reviews.apache.org/r/58360/diff/3-4/
Testing
---
Thanks,
Zhitao Li
3rdparty/versions.am b8144702adca9dd41199f69cb6fb0c0c4b490dbd
Diff: https://reviews.apache.org/r/58515/diff/3/
Changes: https://reviews.apache.org/r/58515/diff/2-3/
Testing
---
Thanks,
Zhitao Li
---
Thanks,
Zhitao Li
---
Thanks,
Zhitao Li
based box, and verifies that
Aurora scheduler (using java) and executor (using python) still works with
`libmesos.so` built from this branch.
Thanks,
Zhitao Li
nt use case.
Do you have any concern about a hard dependency to protobuf 3.x?
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58360/#review172365
-------
> On April 19, 2017, 6:28 p.m., Zhitao Li wrote:
> > src/java/mesos.pom.in
> > Line 86 (original), 86 (patched)
> > <https://reviews.apache.org/r/58359/diff/2/?file=1693769#file1693769line86>
> >
> > This is simply done by a sweeping grep and repla
s between 3.2 and 3.3 is not critical to us?
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58358/#review175168
---
On Apr
: https://reviews.apache.org/r/59279/diff/2/
Changes: https://reviews.apache.org/r/59279/diff/1-2/
Testing
---
Ran through all tests.
Thanks,
Zhitao Li
directory created
for each test case, so they do not affect each other.
Diffs
-
src/tests/mesos.cpp a79ec62d6b8354a97a50533dc66e04c1afc4bef6
Diff: https://reviews.apache.org/r/59279/diff/1/
Testing
---
Ran through all tests.
Thanks,
Zhitao Li
84df21dd6e63653e1a18e700ef904aa3a04b2b45
Diff: https://reviews.apache.org/r/58357/diff/5/
Changes: https://reviews.apache.org/r/58357/diff/4-5/
Testing
---
Ran this on all three languages options for cpp, java and python.
Thanks,
Zhitao Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58810/#review173245
---
Ship it!
- Zhitao Li
On April 27, 2017, 7 p.m., Greg Mann
84df21dd6e63653e1a18e700ef904aa3a04b2b45
Diff: https://reviews.apache.org/r/58357/diff/4/
Changes: https://reviews.apache.org/r/58357/diff/3-4/
Testing
---
Ran this on all three languages options for cpp, java and python.
Thanks,
Zhitao Li
. build this branch in Apache Aurora's vagrant based box, and verifies that
Aurora scheduler (using java) and executor (using python) still works with
`libmesos.so` built from this branch.
Thanks,
Zhitao Li
available at
https://github.com/apache/mesos/pull/208
Diffs
-
3rdparty/protobuf-2.6.1.tar.gz e1c2d541c1eb806e837ff5d1e9d3fdb678b40e06
3rdparty/protobuf-3.2.0.tar.gz PRE-CREATION
Diff: https://reviews.apache.org/r/58358/diff/4/
Testing
---
Thanks,
Zhitao Li
it hard to read the logging output since there are no
> > newlines between the end of each framework run.
Will do.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review1
b8144702adca9dd41199f69cb6fb0c0c4b490dbd
Diff: https://reviews.apache.org/r/58515/diff/2/
Changes: https://reviews.apache.org/r/58515/diff/1-2/
Testing
---
Thanks,
Zhitao Li
on released libraries?
src/python/interface/setup.py.in
Line 29 (original), 29 (patched)
<https://reviews.apache.org/r/58359/#comment245487>
Similar to the comment above on java.
- Zhitao Li
On April 18, 2017, 6:25 p.m., Zhitao Li wrote:
>
>
sting
---
Ran this on all three languages options for cpp, java and python.
Thanks,
Zhitao Li
://reviews.apache.org/r/58361/diff/7/
Changes: https://reviews.apache.org/r/58361/diff/6-7/
Testing
---
Thanks,
Zhitao Li
.
Diffs (updated)
-
src/tests/protobuf_utils_tests.cpp 5239182812835b93a28e85146b2df2b20ae77328
Diff: https://reviews.apache.org/r/58360/diff/3/
Changes: https://reviews.apache.org/r/58360/diff/2-3/
Testing
---
Thanks,
Zhitao Li
/v3.2.0rc2.tar.gz;
- Run `./autogen.sh`;
- Recompress and tar by `tar -czvf`.
Diffs
-
3rdparty/protobuf-2.6.1.tar.gz e1c2d541c1eb806e837ff5d1e9d3fdb678b40e06
3rdparty/protobuf-3.2.0.tar.gz PRE-CREATION
Diff: https://reviews.apache.org/r/58358/diff/4/
Testing
---
Thanks,
Zhitao
512b089c5dd2540f9f83afb559e5d0998d97ea22
Diff: https://reviews.apache.org/r/58361/diff/6/
Changes: https://reviews.apache.org/r/58361/diff/5-6/
Testing
---
Thanks,
Zhitao Li
/58513/diff/1-2/
Testing
---
Thanks,
Zhitao Li
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review172226
-------
On April 12, 2017, 12:02 a.m., Zhitao Li wrote:
>
>
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review172226
-------
On April 12, 2017, 12:02 a.m., Zhitao Li wrote:
>
> --
/entrypoint.sh 5dbaa6086621934a7313dfa5c8008b6a6f5496f1
Diff: https://reviews.apache.org/r/58359/diff/2/
Changes: https://reviews.apache.org/r/58359/diff/1-2/
Testing
---
Thanks,
Zhitao Li
512b089c5dd2540f9f83afb559e5d0998d97ea22
Diff: https://reviews.apache.org/r/58361/diff/5/
Changes: https://reviews.apache.org/r/58361/diff/4-5/
Testing
---
Thanks,
Zhitao Li
version of protobuf.
Diffs (updated)
-
src/tests/protobuf_utils_tests.cpp 5239182812835b93a28e85146b2df2b20ae77328
Diff: https://reviews.apache.org/r/58360/diff/2/
Changes: https://reviews.apache.org/r/58360/diff/1-2/
Testing
---
Thanks,
Zhitao Li
3rdparty/versions.am b8144702adca9dd41199f69cb6fb0c0c4b490dbd
Diff: https://reviews.apache.org/r/58515/diff/1/
Testing
---
Thanks,
Zhitao Li
18870cde806c7bcb0a204de2a40555739adf777b
3rdparty/stout/tests/protobuf_tests.pb.cc
b2458f0edcf679b2390f87ec8c4bee2b16e71d70
Diff: https://reviews.apache.org/r/58514/diff/1/
Testing
---
Thanks,
Zhitao Li
://reviews.apache.org/r/58513/diff/1/
Testing
---
Thanks,
Zhitao Li
e1c2d541c1eb806e837ff5d1e9d3fdb678b40e06
3rdparty/protobuf-3.2.0.tar.gz PRE-CREATION
Diff: https://reviews.apache.org/r/58358/diff/4/
Changes: https://reviews.apache.org/r/58358/diff/3-4/
Testing
---
Thanks,
Zhitao Li
512b089c5dd2540f9f83afb559e5d0998d97ea22
Diff: https://reviews.apache.org/r/58361/diff/4/
Changes: https://reviews.apache.org/r/58361/diff/3-4/
Testing
---
Thanks,
Zhitao Li
: https://reviews.apache.org/r/58358/diff/2-3/
Testing
---
Thanks,
Zhitao Li
e1c2d541c1eb806e837ff5d1e9d3fdb678b40e06
3rdparty/protobuf-3.2.0.tar.gz PRE-CREATION
Diff: https://reviews.apache.org/r/58511/diff/1/
Testing
---
Thanks,
Zhitao Li
512b089c5dd2540f9f83afb559e5d0998d97ea22
Diff: https://reviews.apache.org/r/58361/diff/3/
Changes: https://reviews.apache.org/r/58361/diff/2-3/
Testing
---
Thanks,
Zhitao Li
Diff: https://reviews.apache.org/r/58358/diff/2/
Changes: https://reviews.apache.org/r/58358/diff/1-2/
Testing
---
Thanks,
Zhitao Li
tests.pb.h
18870cde806c7bcb0a204de2a40555739adf777b
3rdparty/stout/tests/protobuf_tests.pb.cc
b2458f0edcf679b2390f87ec8c4bee2b16e71d70
3rdparty/versions.am b8144702adca9dd41199f69cb6fb0c0c4b490dbd
Diff: https://reviews.apache.org/r/58358/diff/1/
Testing
---
Thanks,
Zhitao Li
512b089c5dd2540f9f83afb559e5d0998d97ea22
Diff: https://reviews.apache.org/r/58361/diff/2/
Changes: https://reviews.apache.org/r/58361/diff/1-2/
Testing
---
Thanks,
Zhitao Li
,
Zhitao Li
://reviews.apache.org/r/56722/diff/2/
Changes: https://reviews.apache.org/r/56722/diff/1-2/
Testing
---
Thanks,
Zhitao Li
/tests/containerizer.cpp 548da3a8757c9ad3ab115c6b91f8a1f2f5e37144
src/tests/containerizer/mock_containerizer.hpp
ca0ae053b1eed01d6c04f581cd08485beec0c5fb
Diff: https://reviews.apache.org/r/56721/diff/2/
Changes: https://reviews.apache.org/r/56721/diff/1-2/
Testing
---
Thanks,
Zhitao Li
.182208,
"containerizer/mesos/docker_store/pull_ms/p999": 12520.426776832,
"containerizer/mesos/docker_store/pull_ms/min": 3167.337984,
"containerizer/mesos/docker_store/pull_ms/p95": 12091.4106496,
"containerizer/mesos/docker_store/pull_ms/p99": 12441.62789632,
"containerizer/mesos/docker_store/layers": 47,
```
Thanks,
Zhitao Li
://reviews.apache.org/r/55334/diff/3-4/
Testing
---
Thanks,
Zhitao Li
401 - 500 of 929 matches
Mail list logo
